GNU bug report logs - #46145
[PATCH v2] gnu: jekyll: Update to 4.2.0

Previous Next

Full log

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches--- via <guix-patches <at> gnu.org>
Cc: 46145 <at> debbugs.gnu.org, EuAndreh <eu <at> euandre.org>
Subject: Re: [bug#46145] [PATCH v2] gnu: jekyll: Update to 4.2.0
Date: Fri, 05 Feb 2021 21:50:19 +0100

Hello,

guix-patches--- via <guix-patches <at> gnu.org> writes:

> * gnu/packages/ruby.scm (ruby-sassc): Update to 2.4.0.
> * gnu/packages/ruby.scm (ruby-jekyll-sass-converter): Update to 2.1.0.
> * gnu/packages/ruby.scm (ruby-mercenary): Update to 0.4.0.
> * gnu/packages/ruby.scm (ruby-terminal-table): New variable.
> * gnu/packages/ruby.scm (ruby-rouge-2): Remove variable.
> * gnu/packages/ruby.scm (jekyll): Update to 4.2.0.
> [propagated-inputs]: Use newer version or ruby-rouge, add ruby-sassc
> and ruby-terminal-table.
> ---
> I forgot to add the copyright line. This new patch only differs in this
> aspect, all the rest is the same.

Thank you.

Could you split it into independent patches that I can apply sequentially?

> +(define-public ruby-terminal-table
> +  (package
> +    (name "ruby-terminal-table")
> +    (version "2.0.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "terminal-table" version))
> +       (sha256
> +        (base32
> +         "18rbrh464ysqbdv53iwj0r8frshn65566kyj044cp3x9c2754jwh"))))
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'remove-gemfile-lock
> +           (lambda _
> +             (delete-file "Gemfile.lock")))
> +         (add-before 'check 'remove-unnecessary-dependencies
> +           (lambda _
> +             (substitute* "terminal-table.gemspec"
> +               (("s.add_runtime_dependency.*") "\n")
> +               (("s.add_development_dependency.*") "\n"))
> +             (substitute* "Gemfile"
> +               ((".*tins.*") "\n"))))
> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (invoke "rspec")))))))
> +    (build-system ruby-build-system)
> +    (propagated-inputs
> +     `(("ruby-unicode-display-width" ,ruby-unicode-display-width)))
> +    (native-inputs
> +     `(("ruby-rspec" ,ruby-rspec)))
> +    (synopsis
> +     "Simple, feature rich ASCII table generation library")

Nitpick: This string could be moved on the same line as `synopsis'.

> +    (description
> +     "Terminal Table is a fast and simple, yet feature rich
> +table generator written in Ruby. It supports ASCII and
> +Unicode formatted tables.")

You need to add two spaces after a full stop.

> +    (home-page
> +     "https://github.com/tj/terminal-table")

Nitpick: This could be moved above synopsis.

Otherwise, LGTM!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.