From unknown Sat Jun 21 10:42:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#46139 <46139@debbugs.gnu.org> To: bug#46139 <46139@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add tpm2-tss. Reply-To: bug#46139 <46139@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:42:54 +0000 retitle 46139 [PATCH] gnu: Add tpm2-tss. reassign 46139 guix-patches submitter 46139 L=C3=A9o Le Bouter severity 46139 normal tag 46139 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 13:42:51 2021 Received: (at submit) by debbugs.gnu.org; 27 Jan 2021 18:42:51 +0000 Received: from localhost ([127.0.0.1]:46118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4pmF-000684-BH for submit@debbugs.gnu.org; Wed, 27 Jan 2021 13:42:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:36140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4pmD-00067w-LS for submit@debbugs.gnu.org; Wed, 27 Jan 2021 13:42:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4pmB-0004JP-VU for guix-patches@gnu.org; Wed, 27 Jan 2021 13:42:49 -0500 Received: from mail.zaclys.net ([178.33.93.72]:60559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4pm8-0007oD-Tx for guix-patches@gnu.org; Wed, 27 Jan 2021 13:42:47 -0500 Received: from localhost.localdomain (lam21-1_migr-78-196-200-185.fbx.proxad.net [78.196.200.185] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 10RIgVNW055541 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 27 Jan 2021 19:42:39 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 10RIgVNW055541 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1611772959; bh=9mc7Z35Rqhp7LIyLZf9Ybp6gKv5z8CK8b9YdneXn1N0=; h=From:To:Cc:Subject:Date:From; b=cLYUWY92QlAG1AqAypG64Qp5k2em0NpPE9Mh4O4pTqAv0qNkBIt8hks905RrHWfn5 tI38mM2a4Bmk9sAil3hnGm2jqK/rC7GBlq8TStmcUyqD8AHoWNmC5LoroJk8nQamNG QyONB7LRFciBmd+ZRBUirwLPTvUhpgfDBkvcb6V8= From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= To: guix-patches@gnu.org Subject: [PATCH] gnu: Add tpm2-tss. Date: Wed, 27 Jan 2021 19:42:27 +0100 Message-Id: <20210127184227.29258-1-lle-bout@zaclys.net> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.33.93.72; envelope-from=lle-bout@zaclys.net; helo=mail.zaclys.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/hardware.scm (tpm2-tss): New variable. --- gnu/packages/hardware.scm | 68 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/gnu/packages/hardware.scm b/gnu/packages/hardware.scm index 3da6759472..778453a395 100644 --- a/gnu/packages/hardware.scm +++ b/gnu/packages/hardware.scm @@ -498,3 +498,71 @@ screens. It displays various patterns and allows you to estimate the quality of your CRT/LCD monitor.") (home-page "https://github.com/TobiX/screentest") (license license:gpl2))) + +(define-public tpm2-tss + (package + (name "tpm2-tss") + (version "3.0.3") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/tpm2-software/" name + "/releases/download/" version "/" name "-" version + ".tar.gz")) + (sha256 + (base32 "05xynpwq851fp8f5fy7ac0blvz8mr5m5cbqj3gslgbwv63kjnfbq")))) + (build-system gnu-build-system) + (inputs + `(("pkg-config" ,pkg-config) + ("openssl" ,openssl) + ("json-c" ,json-c) + ("curl" ,curl))) + (synopsis "OSS implementation of the TCG TPM2 Software Stack (TSS2)") + (description "This package provides the Trusted Computing Group's (TCG) +TPM2 Software Stack (TSS). This stack consists of the following layers from +top to bottom: + +@enumerate +@item Feature API (FAPI) as described in the TCG Feature API (FAPI) +Specification along with TCG TSS 2.0 JSON Data Types and Policy Language +Specification This API is designed to be very high-level API, intended to make +programming with the TPM as simple as possible. The API functions are exposed +through a single library: libtss2-fapi. +@item Enhanced System API (ESAPI) as described in the TCG TSS 2.0 Enhanced +System API (ESAPI) Specification This API is a 1-to-1 mapping of the TPM2 +commands documented in Part 3 of the TPM2 specification. Additionally there +are asynchronous versions of each command. In addition to SAPI, the ESAPI +performs tracking of meta data for TPM object and automatic calculation of +session based authorization and encryption values. Both the synchronous and +asynchronous API are exposed through a single library: libtss2-esys. +@item System API (SAPI) as described in the TCG TSS 2.0 System Level API +(SAPI) Specification This API is a 1-to-1 mapping of the TPM2 commands +documented in Part 3 of the TPM2 specification. Additionally there are +asynchronous versions of each command. These asynchronous variants may be +useful for integration into event-driven programming environments. Both the +synchronous and asynchronous API are exposed through a single library: +libtss2-sys. +@item Marshaling/Unmarshaling (MU) as described in the TCG TSS 2.0 +Marshaling/Unmarshaling API Specification This API provides a set of +marshaling and unmarshaling functions for all data types define by the TPM +library specification. The Marshaling/Unmarshaling API is exposed through a +library called libtss2-mu. +@item TPM Command Transmission Interface (TCTI) as described in the TCG TSS +2.0 TPM Command Transmission Interface (TCTI) API Specification. This API +provides a standard interface to transmit / receive TPM command / response +buffers. It is expected that any number of libraries implementing the TCTI API +will be implemented as a way to abstract various platform specific IPC +mechanisms. Currently this repository provides several TCTI implementations: +libtss2-tcti-device, libtss2-tcti-tbs (for Windows), libtss2-tcti-swtpm and +libtss2-tcti-mssim. The former should be used for direct access to the TPM +through the Linux kernel driver. The latter implements the protocol exposed by +the Microsoft software TPM2 simulator. +@item The TCG TSS 2.0 Overview and Common Structures Specification forms the +basis for all implementations in this project. NOTE: We deviate from this +specification by increasing the value of TPM2_NUM_PCR_BANKS from 3 to 16 to +ensure compatibility with TPM2 implementations that have enabled a larger than +typical number of PCR banks. This larger value for TPM2_NUM_PCR_BANKS is +expected to be included in a future revision of the specification. +@end enumerate") + (home-page "https://tpm2-software.github.io/") + (license license:bsd-2))) -- 2.30.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 15:44:36 2021 Received: (at submit) by debbugs.gnu.org; 27 Jan 2021 20:44:36 +0000 Received: from localhost ([127.0.0.1]:46250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rg4-0002lT-B3 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 15:44:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:42742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rg2-0002lM-MY for submit@debbugs.gnu.org; Wed, 27 Jan 2021 15:44:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4rg1-0000zR-Kg for guix-patches@gnu.org; Wed, 27 Jan 2021 15:44:34 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:57521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4rfw-0004VU-RI for guix-patches@gnu.org; Wed, 27 Jan 2021 15:44:33 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B40A224000C; Wed, 27 Jan 2021 20:44:22 +0000 (UTC) From: Nicolas Goaziou To: guix-patches--- via Subject: Re: [bug#46139] [PATCH] gnu: Add tpm2-tss. References: <20210127184227.29258-1-lle-bout@zaclys.net> Date: Wed, 27 Jan 2021 21:44:21 +0100 In-Reply-To: <20210127184227.29258-1-lle-bout@zaclys.net> (guix-patches@gnu.org's message of "Wed, 27 Jan 2021 19:42:27 +0100") Message-ID: <87y2geqfdm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: =?utf-8?Q?L=C3=A9o?= Le Bouter , 46139@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, guix-patches--- via writes: > * gnu/packages/hardware.scm (tpm2-tss): New variable. Thank you. Some comments follow. > + (inputs > + `(("pkg-config" ,pkg-config) > + ("openssl" ,openssl) > + ("json-c" ,json-c) > + ("curl" ,curl))) pkg-config should be a native-input. Don't you need libgcrypt as an input, too? > + (synopsis "OSS implementation of the TCG TPM2 Software Stack (TSS2)") > + (description "This package provides the Trusted Computing Group's (TCG) > +TPM2 Software Stack (TSS). This stack consists of the following layers from > +top to bottom: > + > +@enumerate > +@item Feature API (FAPI) as described in the TCG Feature API (FAPI) > +Specification along with TCG TSS 2.0 JSON Data Types and Policy Language > +Specification This API is designed to be very high-level API, intended to make > +programming with the TPM as simple as possible. The API functions are exposed > +through a single library: libtss2-fapi. > +@item Enhanced System API (ESAPI) as described in the TCG TSS 2.0 Enhanced > +System API (ESAPI) Specification This API is a 1-to-1 mapping of the TPM2 > +commands documented in Part 3 of the TPM2 specification. Additionally there > +are asynchronous versions of each command. In addition to SAPI, the ESAPI > +performs tracking of meta data for TPM object and automatic calculation of > +session based authorization and encryption values. Both the synchronous and > +asynchronous API are exposed through a single library: libtss2-esys. > +@item System API (SAPI) as described in the TCG TSS 2.0 System Level API > +(SAPI) Specification This API is a 1-to-1 mapping of the TPM2 commands > +documented in Part 3 of the TPM2 specification. Additionally there are > +asynchronous versions of each command. These asynchronous variants may be > +useful for integration into event-driven programming environments. Both the > +synchronous and asynchronous API are exposed through a single library: > +libtss2-sys. > +@item Marshaling/Unmarshaling (MU) as described in the TCG TSS 2.0 > +Marshaling/Unmarshaling API Specification This API provides a set of > +marshaling and unmarshaling functions for all data types define by the TPM > +library specification. The Marshaling/Unmarshaling API is exposed through a > +library called libtss2-mu. > +@item TPM Command Transmission Interface (TCTI) as described in the TCG TSS > +2.0 TPM Command Transmission Interface (TCTI) API Specification. This API > +provides a standard interface to transmit / receive TPM command / response > +buffers. It is expected that any number of libraries implementing the TCTI API > +will be implemented as a way to abstract various platform specific IPC > +mechanisms. Currently this repository provides several TCTI implementations: > +libtss2-tcti-device, libtss2-tcti-tbs (for Windows), libtss2-tcti-swtpm and > +libtss2-tcti-mssim. The former should be used for direct access to the TPM > +through the Linux kernel driver. The latter implements the protocol exposed by > +the Microsoft software TPM2 simulator. > +@item The TCG TSS 2.0 Overview and Common Structures Specification forms the > +basis for all implementations in this project. NOTE: We deviate from this > +specification by increasing the value of TPM2_NUM_PCR_BANKS from 3 to 16 to > +ensure compatibility with TPM2 implementations that have enabled a larger than > +typical number of PCR banks. This larger value for TPM2_NUM_PCR_BANKS is > +expected to be included in a future revision of the specification. > +@end enumerate") This description is waaaaay too long. Could you trim it down a bit? IIRC, the manual suggests description of about 5 lines. Of course, this is not a hard rule. Also you need to add two spaces after sentences. > + (home-page "https://tpm2-software.github.io/") Could you move it above synopsis? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 16:15:11 2021 Received: (at 46139) by debbugs.gnu.org; 27 Jan 2021 21:15:11 +0000 Received: from localhost ([127.0.0.1]:46265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4s9e-0003UL-V4 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 16:15:11 -0500 Received: from mail.zaclys.net ([178.33.93.72]:60655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4s9d-0003Ts-Bi for 46139@debbugs.gnu.org; Wed, 27 Jan 2021 16:15:10 -0500 Received: from localhost.localdomain (lam21-1_migr-78-196-200-185.fbx.proxad.net [78.196.200.185] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 10RLEggk019159 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 27 Jan 2021 22:15:02 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 10RLEggk019159 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1611782102; bh=jzBO2pieNnmw4A00HXAsSeMEOymKTWHx9r4NyyOGugY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=snZYQn8TdNcZWUCwrYvAjyBB+N2TlBmfcIYfFaL4DhcFavczKaS8bFvB1CAjA4Ynv aO/gvIiaYWgE1IS6KRB2Bz3fCD4V915YSs8Y1ul6qGKF6I4s8+yMz6yUURXx+xT8OV gkJMJ45aQ45C7Dg3hIsbP6LNoQkUnxwH8hxIqK2U= From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= To: 46139@debbugs.gnu.org Subject: [PATCH v2 0/1] gnu: Add tpm2-tss. Date: Wed, 27 Jan 2021 22:14:18 +0100 Message-Id: <20210127211418.21758-1-lle-bout@zaclys.net> X-Mailer: git-send-email 2.30.0 In-Reply-To: <87y2geqfdm.fsf@nicolasgoaziou.fr> References: <87y2geqfdm.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46139 Cc: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! Sorry, I made a mistake forgetting to `$ git add` before amending my commit thus not sending some of the changes you just requested which I had already done. Here now with shortened description, home-page above synopsis, pkg-config in native-inputs and required modules imported appropriately. Thank you. Léo Le Bouter (1): gnu: Add tpm2-tss. gnu/packages/hardware.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) -- 2.30.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 16:15:11 2021 Received: (at 46139) by debbugs.gnu.org; 27 Jan 2021 21:15:11 +0000 Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4s9f-0003UN-89 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 16:15:11 -0500 Received: from mail.zaclys.net ([178.33.93.72]:53389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4s9d-0003Tx-E8 for 46139@debbugs.gnu.org; Wed, 27 Jan 2021 16:15:10 -0500 Received: from localhost.localdomain (lam21-1_migr-78-196-200-185.fbx.proxad.net [78.196.200.185] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 10RLEggl019159 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 27 Jan 2021 22:15:02 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 10RLEggl019159 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1611782102; bh=Wgq9NvJbFuK7OLkjiCAZsJM0MjytqMaqXSQF/jEVAMs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OgnDa9lv6e9BBMUnjMVeYKuWZVl+tra8Pu/01jdzB1PM7jL89ZxYI2bNT6VwOydCU DhPdHqLoagHEENiYJAmR7Fpd7jukKOOFdXs+ODoL7rOp4QjKM3Foxuh8vO5sDDHmqf 16hNEqQjDPVIwPs2NVsJxIvLbkPsTUwGaDoENMbQ= From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= To: 46139@debbugs.gnu.org Subject: [PATCH v2 1/1] gnu: Add tpm2-tss. Date: Wed, 27 Jan 2021 22:14:19 +0100 Message-Id: <20210127211418.21758-2-lle-bout@zaclys.net> X-Mailer: git-send-email 2.30.0 In-Reply-To: <87y2geqfdm.fsf@nicolasgoaziou.fr> References: <87y2geqfdm.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46139 Cc: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/hardware.scm (tpm2-tss): New variable. --- gnu/packages/hardware.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/hardware.scm b/gnu/packages/hardware.scm index 59f36a8135..6479db66cd 100644 --- a/gnu/packages/hardware.scm +++ b/gnu/packages/hardware.scm @@ -28,6 +28,7 @@ #:use-module (gnu packages check) #:use-module (gnu packages cpp) #:use-module (gnu packages crypto) + #:use-module (gnu packages curl) #:use-module (gnu packages documentation) #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) @@ -42,6 +43,8 @@ #:use-module (gnu packages polkit) #:use-module (gnu packages protobuf) #:use-module (gnu packages python) + #:use-module (gnu packages tls) + #:use-module (gnu packages web) #:use-module (gnu packages xdisorg) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) @@ -543,3 +546,30 @@ screens. It displays various patterns and allows you to estimate the quality of your CRT/LCD monitor.") (home-page "https://github.com/TobiX/screentest") (license license:gpl2))) + +(define-public tpm2-tss + (package + (name "tpm2-tss") + (version "3.0.3") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/tpm2-software/" name + "/releases/download/" version "/" name "-" version + ".tar.gz")) + (sha256 + (base32 "05xynpwq851fp8f5fy7ac0blvz8mr5m5cbqj3gslgbwv63kjnfbq")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("openssl" ,openssl) + ("json-c" ,json-c) + ("curl" ,curl))) + (home-page "https://tpm2-software.github.io/") + (synopsis "OSS implementation of the TCG TPM2 Software Stack (TSS2)") + (description "This package provides the Trusted Computing Group's (TCG) +TPM2 Software Stack (TSS). The stack contains libtss2-fapi, libtss2-esys, +libtss2-sys, libtss2-mu, libtss2-tcti-device, libtss2-tcti-tbs (for Windows), +libtss2-tcti-swtpm and libtss2-tcti-mssim.") + (license license:bsd-2))) -- 2.30.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 16:20:41 2021 Received: (at submit) by debbugs.gnu.org; 27 Jan 2021 21:20:41 +0000 Received: from localhost ([127.0.0.1]:46276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4sEz-0003cc-C6 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 16:20:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:41732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4sEx-0003cV-W2 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 16:20:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4sEx-0005vK-QC for guix-patches@gnu.org; Wed, 27 Jan 2021 16:20:39 -0500 Received: from mail.zaclys.net ([178.33.93.72]:48141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4sEv-0000Hu-Pd for guix-patches@gnu.org; Wed, 27 Jan 2021 16:20:39 -0500 Received: from [192.168.1.44] (lam21-1_migr-78-196-200-185.fbx.proxad.net [78.196.200.185] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 10RLJmLo019928 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 27 Jan 2021 22:20:29 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 10RLJmLo019928 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1611782429; bh=EKvkBOrItinf1wbXaaEkToTvoLydyGs++eDdY/VrGi8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=KD58GUwBThVBNxfBAiTizg7+aDsITDLCm856xISp+V/5TnmqYWrVTGtFrvlayM+lF exwcDSNaTiRPsMk7DK4JTnyhCVKz4Eal1ANpsvAtWwqn1rbNsErsw/vxdHhKr7dlHG Xgju7VnCSPt/ojspZWc2AbCxMrqyzAAqkuRz452w= Message-ID: <56beddec19886a04a3d7af73a0fcbf7735b52f0a.camel@zaclys.net> Subject: Re: [bug#46139] [PATCH] gnu: Add tpm2-tss. From: Leo Le Bouter To: Nicolas Goaziou , guix-patches--- via Date: Wed, 27 Jan 2021 22:19:42 +0100 In-Reply-To: <87y2geqfdm.fsf@nicolasgoaziou.fr> References: <20210127184227.29258-1-lle-bout@zaclys.net> <87y2geqfdm.fsf@nicolasgoaziou.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-KTxDGo+Q+TfQtN/zz6dI" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Received-SPF: pass client-ip=178.33.93.72; envelope-from=lle-bout@zaclys.net; helo=mail.zaclys.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 46139@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-KTxDGo+Q+TfQtN/zz6dI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2021-01-27 at 21:44 +0100, Nicolas Goaziou wrote: > Don't you need libgcrypt as an input, too? Apparently no, see: < https://github.com/tpm2-software/tpm2-tss/blob/master/INSTALL.md#gnulinux >. Everything compiles fine as-is. --=-KTxDGo+Q+TfQtN/zz6dI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmAR2O4ACgkQRaix6GvN EKbmjBAAkWt+5L08PUR8qC2vE9qlPOxR3wIlaAEJXkO3AYtbbAzIkwRI7nlQ76tx ekbnbAdgYXH81IkiYgSVkhY3FpmakmOLxlZABlokhnuwf46G310OBxCwlCH/sXrR UUylwAhGWwIHqPjaBq3tP4thn5alkUNPldM1dHa3kUVUD7QY4ghxNeOPZ4IgUf/3 a+Ezv/XAxloOLKgvyIrGf8JL6ImamdyVm894J31qZ0WJ8fdWFB9UPpc4XQ5pdoZx eeQoLXR1WXDDkMq/YyLUD9ogcaY43jLAgr0GhTzcB87lQ1rJXG5DIJ/HqlDQmvy2 UdXHP5XQRvtf930aYmSCFwfLnylsihKZeyxf7Hxdv+MeAVxs85xGjP9sld7brDTh e1K6+3097UHXmtzu6JQc/LHKhhKEAle6b0o4f9DHIMglkLVt24zj1jWXMvwZUc3S uY+v2szJ+Xzipmv3P0RKNLTDGMxUhCQzuUNjl6EJLQHWs+itGWO+jNEl0xUspq3F AJYDhYQhuvjY9GY41smo93tD01vXSkeJ3Yzx0V1fi7JBEf3y/tETIpsa7zx1WjnC tL8WqFgfkQo38QNfcQoGW/jGsFlShz3sBBekVBfl2Grr5mdYP/eKOUemXCgZ8bH+ jqvmjaoaZC9WhHOfoT542LNEZd0CICy48iMpTIDP+3p33x5G5IE= =Agvb -----END PGP SIGNATURE----- --=-KTxDGo+Q+TfQtN/zz6dI-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 17:26:17 2021 Received: (at 46139) by debbugs.gnu.org; 27 Jan 2021 22:26:17 +0000 Received: from localhost ([127.0.0.1]:46366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4tGP-0007Ju-Q6 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 17:26:17 -0500 Received: from tobias.gr ([80.241.217.52]:36306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4tGL-0007Jk-UH for 46139@debbugs.gnu.org; Wed, 27 Jan 2021 17:26:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=lkWRqytwbRlruH1sFB3snxuXF6h7NO/kQIhcNaXyuZQ=; h=date:in-reply-to: references:subject:to:from; b=U6bzf2kv96197lUFOevAF1eo1uYl6PBD4rRKe5zU UD8lE6mrkTbmElx5QNOv8m4FzANVDQ5OjkiL0XYruYcRyiD4O3yEdnzEdN5SH0Q6cHVZHD tI/Y1suCE0PkeeHUcXZunPdpGncy32NR8CWFfqNx9T3f+l72rJwrQCJs/bJTwvcoEuQYNr kbK9U9e1weBZ6/n2SzjkxN/7Sf5aBcOXN7roKUNuOdMJnJi5pcqgi4+ts66v/lIiHPtaDD ZPI43eWLOnmHVtYEBlJADt4U5eQ5VD9nbJUfYSnnbNbUOtm1g/3Ngy0w8qvRw4EK9ytGI3 aYY+mXMB6oYuUHWSPb0KcQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ee9dcc4c (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for <46139@debbugs.gnu.org>; Wed, 27 Jan 2021 22:26:47 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: 46139@debbugs.gnu.org Subject: Re: [bug#46139] [PATCH] gnu: Add tpm2-tss. References: <20210127184227.29258-1-lle-bout@zaclys.net> <87y2geqfdm.fsf@nicolasgoaziou.fr> In-reply-to: <87y2geqfdm.fsf@nicolasgoaziou.fr> Date: Wed, 27 Jan 2021 23:26:11 +0100 Message-ID: <87czxqyq2k.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46139 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Leo, Thanks! > (uri (string-append ... name ...)) Nitpick: there is no point in parameterising NAME here. Unlike=20 VERSION, it's more likely to cause future work than to save any.=20 Just hard-code it. > (inputs ...) Did you forget `(use-modules (gnu packages tls))'? > (synopsis "OSS implementation of the TCG TPM2 Software Stack=20 > (TSS2)") s/OSS i/I/ Likewise, Windows support is irrelevant, so we don't mention it.=20 Don't know enough about the =E2=80=98Microsoft software TPM2 simulator=E2= =80=99 to=20 know if it is. > IIRC, the manual suggests description of about 5 lines. At minimum, IMO :-) Between 5 and 10, depending on how much there=20 is to say about the package. Reducing each @item to ~1 sentence would strike a good balance.=20 Be sure to keep any keywords that could help people =E2=80=98guix search=E2= =80=99=20 for this package. Drop the boring spec minutia. > Trusted Computing Group's (TCG) You can mark these up as @acronym{TCG, Trusted Computing Group}. When finished, don't forget to run =E2=80=98guix lint tpm2-tss=E2=80=99. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYBHogw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15NHsBAP6OC67mK9MIAjP2ERpSg5HGG5C/vJE/nlVF3MJT 0fDzAQDWw26JHIgBGlnUu0k/eQ0SWPbocsH1U5HxlfsZIC9vDw== =z3Ig -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 08:26:53 2021 Received: (at 46139) by debbugs.gnu.org; 28 Jan 2021 13:26:53 +0000 Received: from localhost ([127.0.0.1]:47585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57K0-0006po-Qw for submit@debbugs.gnu.org; Thu, 28 Jan 2021 08:26:53 -0500 Received: from mail.zaclys.net ([178.33.93.72]:47713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57Jy-0006pT-RM for 46139@debbugs.gnu.org; Thu, 28 Jan 2021 08:26:52 -0500 Received: from localhost.localdomain (lam21-1_migr-78-196-200-185.fbx.proxad.net [78.196.200.185] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 10SDQTYv049317 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 28 Jan 2021 14:26:44 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 10SDQTYv049317 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1611840404; bh=o+QJfn8jsTWqmeqBu8VeBtIF8ewkg/4FrySf8kJE+HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GOBV0OHZM4h9ehw30WZTX+rfybkTfbxs1gXrmeIvbKQJDUIAyRfvPW/9WUMAPnQD0 RRIZkXhINggsQdpPdjnigB6O5Yb/C9fnsWY1nrtd7IKodPxv2xAsPq5rmItlhQ54Sc a73SEdfTpvV+14urQFLiPamnjjVhZAe7Qzzb4CTU= From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= To: 46139@debbugs.gnu.org Subject: [PATCH v3 0/1] gnu: Add tpm2-tss. Date: Thu, 28 Jan 2021 14:26:27 +0100 Message-Id: <20210128132628.24609-1-lle-bout@zaclys.net> X-Mailer: git-send-email 2.30.0 In-Reply-To: <87czxqyq2k.fsf@nckx> References: <87czxqyq2k.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46139 Cc: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the review. Final patch, if any additional nitpicks, please co-author my patch. I run `guix lint` before submitting any patch to GNU Guix upstream now, I used to forget few times before. It would help me if things like putting home-page above synopsis were checked by the linter, I'm not at ease with Scheme so if anyone knows how to add that, please do. Thanks. Léo Le Bouter (1): gnu: Add tpm2-tss. gnu/packages/hardware.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) -- 2.30.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 08:26:53 2021 Received: (at 46139) by debbugs.gnu.org; 28 Jan 2021 13:26:53 +0000 Received: from localhost ([127.0.0.1]:47587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57K1-0006pq-37 for submit@debbugs.gnu.org; Thu, 28 Jan 2021 08:26:53 -0500 Received: from mail.zaclys.net ([178.33.93.72]:57997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57Jy-0006pU-RB for 46139@debbugs.gnu.org; Thu, 28 Jan 2021 08:26:52 -0500 Received: from localhost.localdomain (lam21-1_migr-78-196-200-185.fbx.proxad.net [78.196.200.185] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 10SDQTYw049317 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 28 Jan 2021 14:26:44 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 10SDQTYw049317 Authentication-Results: mail.zaclys.net; dmarc=fail (p=reject dis=none) header.from=zaclys.net Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1611840404; bh=IvmRoXE3GPyY5Ku/x6ycrpVoVmK2DcE4sdfD6ZfSDZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MPAAL/6CqAG75Db+VUOVloA0wodjWIaKwmHRxvTacr0fMfqeHuGaq1g0PIp2+tCjS uwPkhI8Qey4d8dRFrpIFKRt57W/Kq74TAXhIWAl/UM0OQMZXilkuz9vBncnoSeG0ZS KQvm0dq4rf6ugg//MY4qULocP4+oCqcXMHc63zkY= From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= To: 46139@debbugs.gnu.org Subject: [PATCH v3 1/1] gnu: Add tpm2-tss. Date: Thu, 28 Jan 2021 14:26:28 +0100 Message-Id: <20210128132628.24609-2-lle-bout@zaclys.net> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210128132628.24609-1-lle-bout@zaclys.net> References: <87czxqyq2k.fsf@nckx> <20210128132628.24609-1-lle-bout@zaclys.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46139 Cc: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/hardware.scm (tpm2-tss): New variable. --- gnu/packages/hardware.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/hardware.scm b/gnu/packages/hardware.scm index 59f36a8135..bef0947827 100644 --- a/gnu/packages/hardware.scm +++ b/gnu/packages/hardware.scm @@ -28,6 +28,7 @@ #:use-module (gnu packages check) #:use-module (gnu packages cpp) #:use-module (gnu packages crypto) + #:use-module (gnu packages curl) #:use-module (gnu packages documentation) #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) @@ -42,6 +43,8 @@ #:use-module (gnu packages polkit) #:use-module (gnu packages protobuf) #:use-module (gnu packages python) + #:use-module (gnu packages tls) + #:use-module (gnu packages web) #:use-module (gnu packages xdisorg) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) @@ -543,3 +546,30 @@ screens. It displays various patterns and allows you to estimate the quality of your CRT/LCD monitor.") (home-page "https://github.com/TobiX/screentest") (license license:gpl2))) + +(define-public tpm2-tss + (package + (name "tpm2-tss") + (version "3.0.3") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/tpm2-software/tpm2-tss" + "/releases/download/" version "/tpm2-tss-" version + ".tar.gz")) + (sha256 + (base32 "05xynpwq851fp8f5fy7ac0blvz8mr5m5cbqj3gslgbwv63kjnfbq")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("openssl" ,openssl) + ("json-c" ,json-c) + ("curl" ,curl))) + (home-page "https://tpm2-software.github.io/") + (synopsis "OSS Implementation of the TCG TPM2 Software Stack (TSS2)") + (description "This package provides the +@acronym{TCG, Trusted Computing Group} @acronym{TSS2, TPM2 Software Stack}. +The stack contains libtss2-fapi, libtss2-esys, libtss2-sys, libtss2-mu, +libtss2-tcti-device, libtss2-tcti-swtpm and libtss2-tcti-mssim.") + (license license:bsd-2))) -- 2.30.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 12:47:49 2021 Received: (at submit) by debbugs.gnu.org; 28 Jan 2021 17:47:49 +0000 Received: from localhost ([127.0.0.1]:49978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5BOW-0005pW-Pk for submit@debbugs.gnu.org; Thu, 28 Jan 2021 12:47:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:34074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5BOU-0005pH-Up for submit@debbugs.gnu.org; Thu, 28 Jan 2021 12:47:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5BOU-0003yM-GM for guix-patches@gnu.org; Thu, 28 Jan 2021 12:47:46 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5BOR-0001Tk-Va for guix-patches@gnu.org; Thu, 28 Jan 2021 12:47:46 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E8A5AE0006; Thu, 28 Jan 2021 17:47:39 +0000 (UTC) From: Nicolas Goaziou To: guix-patches--- via Subject: Re: [bug#46139] [PATCH v3 0/1] gnu: Add tpm2-tss. References: <87czxqyq2k.fsf@nckx> <20210128132628.24609-1-lle-bout@zaclys.net> Date: Thu, 28 Jan 2021 18:47:37 +0100 In-Reply-To: <20210128132628.24609-1-lle-bout@zaclys.net> (guix-patches@gnu.org's message of "Thu, 28 Jan 2021 14:26:27 +0100") Message-ID: <87sg6lhs1y.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: =?utf-8?Q?L=C3=A9o?= Le Bouter , 46139-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, guix-patches--- via writes: > Final patch, if any additional nitpicks, please co-author my patch. Hmm... I re-ordered alphabetically the inputs and applied your patch. > I run `guix lint` before submitting any patch to GNU Guix upstream now, > I used to forget few times before. It would help me if things like > putting home-page above synopsis were checked by the linter Putting home-page after synopsis is not a show stopper and wouldn't prevent a patch from being applied. There is no written convention about it. It's more of an habit. Thank you! Regards, -- Nicolas Goaziou From unknown Sat Jun 21 10:42:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 Feb 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator