From gg@zip.com.au Thu Oct 1 17:10:50 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 2 Oct 2009 00:10:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.9 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n920AnZn027457 for ; Thu, 1 Oct 2009 17:10:50 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtVjU-00072Z-Ne for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2009 20:10:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtVjQ-0006td-ET for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2009 20:10:48 -0400 Received: from [199.232.76.173] (port=43969 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtVjQ-0006tP-BL for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2009 20:10:44 -0400 Received: from mailout1-1.pacific.net.au ([61.8.2.208]:48533 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtVjM-0005Sw-QE for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2009 20:10:41 -0400 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id 5325D50720C for ; Fri, 2 Oct 2009 10:10:33 +1000 (EST) Received: from blah.blah (ppp24D8.dyn.pacific.net.au [61.8.36.216]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 5FB5A8C18 for ; Fri, 2 Oct 2009 10:10:32 +1000 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1MtVin-0006Px-8z for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2009 10:10:05 +1000 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; checkdoc insert ";;; Code" before autoload cookie Date: Fri, 02 Oct 2009 10:10:04 +1000 Message-ID: <87ljju7j1f.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= On foo.el below M-x checkdoc inserts ";;; Code" as ;;;###autoload ;;; Code: (defun foo () where I hoped it would be before the cookie like say ;;; Code: ;;;###autoload (defun foo () generate-file-autoloads etc is happy with either, but the latter reads better for humans. I struck this in one of my own .el files which had an autoload cookie on the first func. Incidentally, I see the `cont' loop puts ";;; Code" after any initial `require' forms. Is that actually usual, or usual any more? I think I've only ever seen `require's after ";;; Code". 2009-10-01 Kevin Ryde * emacs-lisp/checkdoc.el (checkdoc-file-comments-engine): When inserting ";;; Code" put it before any ";;;###autoload" cookie on the first form. And insert a blank line after ";;; Code" since that's usual style. --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline; filename=foo.el Content-Transfer-Encoding: quoted-printable ;;; foo.el --- do something ;;; Commentary: ;;=20 ;;; History: ;;=20 ;;;###autoload (defun foo () "This is foo." (message "foo")) (provide 'foo) ;;; foo.el ends here --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=checkdoc.el.code-autoload.diff --- checkdoc.el.~1.74.~ 2009-09-18 08:22:27.000000000 +1000 +++ checkdoc.el 2009-09-25 18:22:29.000000000 +1000 @@ -2304,15 +2304,18 @@ (or ;; * Code section (if (not (lm-code-mark)) - (let ((cont t)) + (let ((cont t) + pos) (goto-char (point-min)) - (while (and cont (re-search-forward "^(" nil t)) - (setq cont (looking-at "require\\s-+"))) + ;; matching ";;;###" to keep autoload cookie with the form + (while (and cont (re-search-forward "^\\(;;;###.*\n\\)?(" nil t)) + (setq pos (match-beginning 0) + cont (looking-at "require\\s-+"))) (if (and (not cont) (checkdoc-y-or-n-p "There is no ;;; Code: marker. Insert one? ")) - (progn (beginning-of-line) - (insert ";;; Code:\n") + (progn (goto-char pos) + (insert ";;; Code:\n\n") nil) (checkdoc-create-error "You should have a section marked \";;; Code:\"" --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_AU value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default-enable-multibyte-characters: t --=-=-=-- From lekktu@gmail.com Mon Oct 5 17:28:16 2009 Received: (at control) by emacsbugs.donarmstrong.com; 6 Oct 2009 00:28:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.3 required=4.0 tests=AWL,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n960SETc008330 for ; Mon, 5 Oct 2009 17:28:16 -0700 Received: by fxm3 with SMTP id 3so3113141fxm.44 for ; Mon, 05 Oct 2009 17:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=J/UHU7hBzBtUHDJKVKy/f6a464PlVCRVDtM7Ue0iwcE=; b=B6bnSJOQMTrOyFaGDMELlOOXoCne2njE1HiIHNYX19+zmqsossMsmCVvnii58LMRIT gzKW+GYVOHXQSj7X52VlusP1xvFy8J9kFiS3zIm4D1VBe4vQN5Z2hna5SQ6vg6W2g6Ea xWkef7ksNoMFiqcBxdwyjRixmndEM8fzMoQPU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Vswlg+dCjmpGK222c6K8gUD233GDUJqSyvVx6pHfheWbGWt2N2sXbuM/zQ3D7RTYdW MkLGFvBtilKCZvWmWCYiT9j+1G+yhtE3nmElv0GTMpDPX5f8Jb72gO9GPyYvtcWYjD/9 nPlDixV8Dp8GMKXFzlLX2ndsWwuJwDp7Dwff4= MIME-Version: 1.0 Received: by 10.239.139.158 with SMTP id t30mr69439hbt.94.1254788889134; Mon, 05 Oct 2009 17:28:09 -0700 (PDT) From: Juanma Barranquero Date: Tue, 6 Oct 2009 02:27:49 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 reassign 4641 spam tags 4612 + patch severity 4612 minor quit From gg@zip.com.au Wed Oct 21 15:11:25 2009 Received: (at 4612-done) by emacsbugs.donarmstrong.com; 21 Oct 2009 22:11:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mailout1.pacific.net.au (mailout1-1.pacific.net.au [61.8.2.208]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9LMBORJ004368 for <4612-done@emacsbugs.donarmstrong.com>; Wed, 21 Oct 2009 15:11:25 -0700 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id F2B31506E42; Thu, 22 Oct 2009 09:11:22 +1100 (EST) Received: from blah.blah (ppp2067.dyn.pacific.net.au [61.8.32.103]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 8B74F8C0F; Thu, 22 Oct 2009 09:11:16 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1N0jO1-00013S-79; Thu, 22 Oct 2009 09:10:29 +1100 From: Kevin Ryde To: 4612-done@debbugs.gnu.org Cc: Stefan Monnier Subject: Re: bug#4612: 23.1; checkdoc insert ";;; Code" before autoload cookie References: <87ljju7j1f.fsf@blah.blah> Date: Thu, 22 Oct 2009 09:10:29 +1100 In-Reply-To: (Stefan Monnier's message of "Sun, 18 Oct 2009 23:28:39 -0400") Message-ID: <8763a8mm96.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier writes: > > Please install it. Beaut, done. I used generate-autoload-cookie too, for gratuitous generality :-). I've still got doubts about putting the ";; Code:" after `require's, but I'll leave that alone failing a reason for or against it being that way. From unknown Mon Aug 18 19:27:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Nov 2009 15:24:15 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator