From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 04:06:06 2021 Received: (at submit) by debbugs.gnu.org; 26 Jan 2021 09:06:06 +0000 Received: from localhost ([127.0.0.1]:40726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4KIU-0001oG-DA for submit@debbugs.gnu.org; Tue, 26 Jan 2021 04:06:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:39558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4HzH-0004Y1-Nc for submit@debbugs.gnu.org; Tue, 26 Jan 2021 01:38:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4HzH-0003OG-GG for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:38:03 -0500 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:52044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4HzF-0005ib-En for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:38:03 -0500 Received: by mail-pj1-x1031.google.com with SMTP id a20so1448782pjs.1 for ; Mon, 25 Jan 2021 22:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enzu-ru.20150623.gappssmtp.com; s=20150623; h=date:message-id:from:to:subject:user-agent; bh=AdUAxxgLc9HDBs73bhRxbp4dLCsBC9CcwPHGSk5d/C0=; b=OBZmyuwFQoei0Xt+wwkOCPpb3Ne/AS8aBoBBrQSfn9ssdkKTJDJJt8WjxrOraxSc2r a068gO1X1hUCWIBmCIlvthQwOcgRSEmtdEQbJZR3JGjtFZc0nNp/4NITozFMgvLR1SmK uig1F9bg5lnBVGrUeRbZBpuxysgKd/Hc9qgYXEbuzYhDged+eTRPlePJ84F2LO0ALVtH 3T+nk79lvRs45E6dteOVJPoRgcBdlji+3Zm2GSqfNXFxcjcuEYREe36ceX0CApCSlZ8r Uj7JysC0xQkvmZx37Kolx0p09jUKVJtKQnn9RFDKiXvaDH0clLEUdILnwYxfmaSE7v8h eq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:subject:user-agent; bh=AdUAxxgLc9HDBs73bhRxbp4dLCsBC9CcwPHGSk5d/C0=; b=sLivptDVrHfylEiunnfUFyVYo5AFsin68m5pSV2xzVUaln02/Ijej1SLhFA259KoTs kZ+Ub+SnAXyNfS82HE0/wqNnh9r5BMpFFF5ccKRmApUh8YC7f/3i21iHCF1/ZAWi9Jbb TifJTQewNMpgA2C3t17D8WtXZUfDJg3XRm5VeiIYvkBcrP3ZHAdV96QsNfN1sLkfFXSH qPP1me7nfAHCl4MAhuMyWsrr/vDbLo8gEdnx7ztmiG2ES9SV8MfJ1tcEzqF9iUrQRWFI pYM3rbW9W6ubeHGKhd1yPOo0Gm54DvT7EVLZTZke4tjKDg/pGjKBlYb1/VhktQOus7OU 0Jbg== X-Gm-Message-State: AOAM533khCTt0f23mFgeC/Px0J2IQmwK6yhAyFdXtdgvEDTOWpvnYU6d xHyEcdVmeHkkTQY2NzspAsiygNQl3pAfoH9y X-Google-Smtp-Source: ABdhPJw/q3jk9yWBVQZuPdRulYzZBaM4mRgzXJJXn2kXCWMpngGoJp+vX5e7i8840ps0odAcDwGIbg== X-Received: by 2002:a17:90b:46cf:: with SMTP id jx15mr4464090pjb.61.1611643079019; Mon, 25 Jan 2021 22:37:59 -0800 (PST) Received: from ultra.enzu.ru.enzu.ru (cpe-45-48-14-47.socal.res.rr.com. [45.48.14.47]) by smtp.gmail.com with ESMTPSA id t206sm18271059pgb.84.2021.01.25.22.37.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 22:37:58 -0800 (PST) Date: Mon, 25 Jan 2021 22:37:53 -0800 Message-ID: <87sg6oyzi6.wl-me@enzu.ru> From: Ahmed Khanzada To: bug-gnu-emacs@gnu.org Subject: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (sparc64-unknown-openbsd) MULE/6.0 (HANACHIRUSATO) Received-SPF: none client-ip=2607:f8b0:4864:20::1031; envelope-from=me@enzu.ru; helo=mail-pj1-x1031.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 26 Jan 2021 04:06:01 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I'm not an expert on C, OpenBSD, or SPARC64, but I did notice emacs-current was not compiling. During a gmake, bootstrap-emacs would get a SIGBUS and fail. Running gdb led me to the hash_string function where it seemed to be failing. Reverting the hash_string function to a previous version seems to have fixed the issue. If I had to guess, it may have something to do with SPARC64 alignment. I don't have an updated AMD64 OpenBSD box running at the moment, but if you would like me to test there, I could find a way. I understand that reverting this function might not be the best way forward, but wrote a patch just in case that reverts hash_string to an earlier version that compiles on OpenBSD/SPARC64. I am already signed all my GNU contributor docs. --[[text/plain; type=patch; name="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" Content-Disposition: attachment; filename="0001-Reverting-hasattach filh_string-function-due-to-problem-on-Ope.patch"][base64]] RnJvbSBkOTM4NzQ1Y2U1NjA1OGJlMjQwNzhlYzUyZDk3Mzk4Njk3ZGI0Yjc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBaG1lZCBLaGFuemFkYSA8bWVAZW56dS5ydT4KRGF0ZTogTW9u LCAyNSBKYW4gMjAyMSAyMToxNjo0OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydGluZyBo YXNoX3N0cmluZyBmdW5jdGlvbiBkdWUgdG8gcHJvYmxlbSBvbgogT3BlbkJTRC9TUEFSQzY0Cgot LS0KIHNyYy9mbnMuYyB8IDMyICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggN2FiMmU4ZjFhMC4uMDEyN2ZlM2Y0OCAxMDA2 NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDU5OSwzNCArNDU5OSwxNiBA QCAjZGVmaW5lIFNYSEFTSF9NQVhfTEVOICAgNwogRU1BQ1NfVUlOVAogaGFzaF9zdHJpbmcgKGNo YXIgY29uc3QgKnB0ciwgcHRyZGlmZl90IGxlbikKIHsKLSAgRU1BQ1NfVUlOVCBjb25zdCAqcCAg ID0gKEVNQUNTX1VJTlQgY29uc3QgKikgcHRyOwotICBFTUFDU19VSU5UIGNvbnN0ICplbmQgPSAo RU1BQ1NfVUlOVCBjb25zdCAqKSAocHRyICsgbGVuKTsKLSAgRU1BQ1NfVUlOVCBoYXNoID0gbGVu OwotICAvKiBBdCBtb3N0IDggc3RlcHMuICBXZSBjb3VsZCByZXVzZSBTWEhBU0hfTUFYX0xFTiwg b2YgY291cnNlLAotICAgKiBidXQgZGl2aWRpbmcgYnkgOCBpcyBjaGVhcGVyLiAgKi8KLSAgcHRy ZGlmZl90IHN0ZXAgPSAxICsgKChlbmQgLSBwKSA+PiAzKTsKLQotICAvKiBCZXdhcmU6IGBlbmRg IG1pZ2h0IGJlIHVuYWxpZ25lZCwgc28gYHAgPCBlbmRgIGlzIG5vdCBhbHdheXMgdGhlIHNhbWUK LSAgICogYXMgYHAgPD0gZW5kIC0gMWAuICAqLwotICB3aGlsZSAocCA8PSBlbmQgLSAxKQorICBj aGFyIGNvbnN0ICpwID0gcHRyOworICBjaGFyIGNvbnN0ICplbmQgPSBwICsgbGVuOworICB1bnNp Z25lZCBjaGFyIGM7CisgIEVNQUNTX1VJTlQgaGFzaCA9IDA7CisKKyAgd2hpbGUgKHAgIT0gZW5k KQogICAgIHsKLSAgICAgIEVNQUNTX1VJTlQgYyA9ICpwOwotICAgICAgcCArPSBzdGVwOworICAg ICAgYyA9ICpwKys7CiAgICAgICBoYXNoID0gc3hoYXNoX2NvbWJpbmUgKGhhc2gsIGMpOwogICAg IH0KLSAgaWYgKHAgPCBlbmQpCi0gICAgeyAvKiBBIGZldyBsYXN0IGJ5dGVzIHJlbWFpbiAoc21h bGxlciB0aGFuIGFuIEVNQUNTX1VJTlQpLiAgKi8KLSAgICAgIC8qIEZJWE1FOiBXZSBjb3VsZCBk byB0aGlzIHdpdGhvdXQgYSBsb29wLCBidXQgaXQnZCByZXF1aXJlCi0gICAgICAgICBlbmRpYW4t ZGVwZW5kZW50IGNvZGUgOi0oICAqLwotICAgICAgY2hhciBjb25zdCAqcDEgPSAoY2hhciBjb25z dCAqKXA7Ci0gICAgICBjaGFyIGNvbnN0ICplbmQxID0gKGNoYXIgY29uc3QgKillbmQ7Ci0gICAg ICBkbwotICAgICAgICB7Ci0gICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gKnAxKys7Ci0gICAg ICAgICAgaGFzaCA9IHN4aGFzaF9jb21iaW5lIChoYXNoLCBjKTsKLSAgICAgICAgfQotICAgICAg d2hpbGUgKHAxIDwgZW5kMSk7Ci0gICAgfQogCiAgIHJldHVybiBoYXNoOwogfQotLSAKMi4yOC4w Cgo= From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 04:24:50 2021 Received: (at submit) by debbugs.gnu.org; 26 Jan 2021 09:24:50 +0000 Received: from localhost ([127.0.0.1]:40744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Kaf-0002GX-P8 for submit@debbugs.gnu.org; Tue, 26 Jan 2021 04:24:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:44082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4IIB-0004zq-Fc for submit@debbugs.gnu.org; Tue, 26 Jan 2021 01:57:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4IIA-0006LS-BQ for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:57:35 -0500 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:34417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4II8-0003sP-0K for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:57:33 -0500 Received: by mail-ot1-x332.google.com with SMTP id a109so15353305otc.1 for ; Mon, 25 Jan 2021 22:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enzu-ru.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LOOUlt0J0iDlM6a1uOn4WkBpOYkHcGKcWsRKRDsk9lU=; b=QV0ll3Zz/oax7xnhGNcJo+szTcP7xe718IMGW1wEsWVAq7hSjHkBJ6SuZ7SI5yi4Ya OX0WLiX9CdXQni8bK4kJuX1jH8DIzrKIR0XLFAxXb6Fk/nQ8SI4Kbh7lzJ9w94ci5djm vG6W3ktdr+WVfICA5hnMCcLdunlXbIPwSLr8pgdJTdrwxkfhyeYdkjsNGfK52xTeEgwT qEXo2GC2/h8X3LqglOLxYKbMC6RaOdVpcSA3Gx9ezKQ3RPb7SuRCYDIiDG2sQq5rlVM5 DTBshlU+Ho/KVfPMIGaAPrTsV5EhL6HxmBFIoFAa+DV7+m9uG2se4F04ip0OiaRf4IWh vehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LOOUlt0J0iDlM6a1uOn4WkBpOYkHcGKcWsRKRDsk9lU=; b=XWrYcGjhaMlN5hOFuxGDRYT+YoDVYigDfpPnP0QXY/A/zDXuWenENretm36bzBtPkE TSCNATjBD3CTzQbSR3fGN4S5ZQIsv5Vz0vbrIyaWDEG53eleIi9jKGk62GAhVAwD4fnM DHEnaNPePwSwjvB6lkpHhLCC4VwCy0gpl6Cn6Kf84ymLcBEv9gihmaFZcDNx1IqKB+vG CHz+VASjCJATfY11aJE7BQ/10j1KvntZgC6W5tc5lvohL+/jGzvkGQJW75Dy7Qnf0+eZ qu3EbBvvvNG87lFPTskLWteoxM2kVEQLj2ftYjsdpGp7ATCgnyHewW0/9oAwcQZwZtNy Ly2g== X-Gm-Message-State: AOAM530+jSbmdaAIbNr7d1MDZWm7k4vd8yHtcTpUwNld5UbMw5ku8vj1 ZFPiS2KKtdAG6SYaJaff45eTDpRKYfylGlDChn1Ro5PYrgg= X-Google-Smtp-Source: ABdhPJzXPhANG0JWL3D0VXlyYDRlbdQR8wjBevzBLzqWgBWFt6otOvQVCSDO1iJLtXvvglhkRSBnzEvj4pwbCylVQD8= X-Received: by 2002:a9d:7a4a:: with SMTP id z10mr3137110otm.206.1611644249927; Mon, 25 Jan 2021 22:57:29 -0800 (PST) MIME-Version: 1.0 References: <87sg6oyzi6.wl-me@enzu.ru> In-Reply-To: <87sg6oyzi6.wl-me@enzu.ru> From: Ahmed Khanzada Date: Mon, 25 Jan 2021 22:57:18 -0800 Message-ID: Subject: Re: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking To: bug-gnu-emacs@gnu.org, Ahmed Khanzada Content-Type: multipart/mixed; boundary="000000000000059e5b05b9c82bfd" Received-SPF: none client-ip=2607:f8b0:4864:20::332; envelope-from=me@enzu.ru; helo=mail-ot1-x332.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 26 Jan 2021 04:24:48 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --000000000000059e5b05b9c82bfd Content-Type: text/plain; charset="UTF-8" Not sure if the patch attached correctly. Trying again. On Mon, Jan 25, 2021 at 10:37 PM Ahmed Khanzada wrote: > > I'm not an expert on C, OpenBSD, or SPARC64, but I did notice > emacs-current was not compiling. > > During a gmake, bootstrap-emacs would get a SIGBUS and fail. Running > gdb led me to the hash_string function where it seemed to be failing. > > Reverting the hash_string function to a previous version seems to have > fixed the issue. > > If I had to guess, it may have something to do with SPARC64 alignment. > > I don't have an updated AMD64 OpenBSD box running at the moment, but if you > would like me to test there, I could find a way. > > I understand that reverting this function might not be the best way > forward, but wrote a patch just in case that reverts hash_string to an > earlier version that compiles on OpenBSD/SPARC64. > > I am already signed all my GNU contributor docs. > > --[[text/plain; type=patch; name="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" > Content-Disposition: attachment; filename="0001-Reverting-hasattach filh_string-function-due-to-problem-on-Ope.patch"][base64]] > RnJvbSBkOTM4NzQ1Y2U1NjA1OGJlMjQwNzhlYzUyZDk3Mzk4Njk3ZGI0Yjc2IE1vbiBTZXAgMTcg > MDA6MDA6MDAgMjAwMQpGcm9tOiBBaG1lZCBLaGFuemFkYSA8bWVAZW56dS5ydT4KRGF0ZTogTW9u > LCAyNSBKYW4gMjAyMSAyMToxNjo0OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydGluZyBo > YXNoX3N0cmluZyBmdW5jdGlvbiBkdWUgdG8gcHJvYmxlbSBvbgogT3BlbkJTRC9TUEFSQzY0Cgot > LS0KIHNyYy9mbnMuYyB8IDMyICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp > bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg > YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggN2FiMmU4ZjFhMC4uMDEyN2ZlM2Y0OCAxMDA2 > NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDU5OSwzNCArNDU5OSwxNiBA > QCAjZGVmaW5lIFNYSEFTSF9NQVhfTEVOICAgNwogRU1BQ1NfVUlOVAogaGFzaF9zdHJpbmcgKGNo > YXIgY29uc3QgKnB0ciwgcHRyZGlmZl90IGxlbikKIHsKLSAgRU1BQ1NfVUlOVCBjb25zdCAqcCAg > ID0gKEVNQUNTX1VJTlQgY29uc3QgKikgcHRyOwotICBFTUFDU19VSU5UIGNvbnN0ICplbmQgPSAo > RU1BQ1NfVUlOVCBjb25zdCAqKSAocHRyICsgbGVuKTsKLSAgRU1BQ1NfVUlOVCBoYXNoID0gbGVu > OwotICAvKiBBdCBtb3N0IDggc3RlcHMuICBXZSBjb3VsZCByZXVzZSBTWEhBU0hfTUFYX0xFTiwg > b2YgY291cnNlLAotICAgKiBidXQgZGl2aWRpbmcgYnkgOCBpcyBjaGVhcGVyLiAgKi8KLSAgcHRy > ZGlmZl90IHN0ZXAgPSAxICsgKChlbmQgLSBwKSA+PiAzKTsKLQotICAvKiBCZXdhcmU6IGBlbmRg > IG1pZ2h0IGJlIHVuYWxpZ25lZCwgc28gYHAgPCBlbmRgIGlzIG5vdCBhbHdheXMgdGhlIHNhbWUK > LSAgICogYXMgYHAgPD0gZW5kIC0gMWAuICAqLwotICB3aGlsZSAocCA8PSBlbmQgLSAxKQorICBj > aGFyIGNvbnN0ICpwID0gcHRyOworICBjaGFyIGNvbnN0ICplbmQgPSBwICsgbGVuOworICB1bnNp > Z25lZCBjaGFyIGM7CisgIEVNQUNTX1VJTlQgaGFzaCA9IDA7CisKKyAgd2hpbGUgKHAgIT0gZW5k > KQogICAgIHsKLSAgICAgIEVNQUNTX1VJTlQgYyA9ICpwOwotICAgICAgcCArPSBzdGVwOworICAg > ICAgYyA9ICpwKys7CiAgICAgICBoYXNoID0gc3hoYXNoX2NvbWJpbmUgKGhhc2gsIGMpOwogICAg > IH0KLSAgaWYgKHAgPCBlbmQpCi0gICAgeyAvKiBBIGZldyBsYXN0IGJ5dGVzIHJlbWFpbiAoc21h > bGxlciB0aGFuIGFuIEVNQUNTX1VJTlQpLiAgKi8KLSAgICAgIC8qIEZJWE1FOiBXZSBjb3VsZCBk > byB0aGlzIHdpdGhvdXQgYSBsb29wLCBidXQgaXQnZCByZXF1aXJlCi0gICAgICAgICBlbmRpYW4t > ZGVwZW5kZW50IGNvZGUgOi0oICAqLwotICAgICAgY2hhciBjb25zdCAqcDEgPSAoY2hhciBjb25z > dCAqKXA7Ci0gICAgICBjaGFyIGNvbnN0ICplbmQxID0gKGNoYXIgY29uc3QgKillbmQ7Ci0gICAg > ICBkbwotICAgICAgICB7Ci0gICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gKnAxKys7Ci0gICAg > ICAgICAgaGFzaCA9IHN4aGFzaF9jb21iaW5lIChoYXNoLCBjKTsKLSAgICAgICAgfQotICAgICAg > d2hpbGUgKHAxIDwgZW5kMSk7Ci0gICAgfQogCiAgIHJldHVybiBoYXNoOwogfQotLSAKMi4yOC4w > Cgo= --000000000000059e5b05b9c82bfd Content-Type: application/octet-stream; name="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" Content-Disposition: attachment; filename="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkdnchls0 RnJvbSBkOTM4NzQ1Y2U1NjA1OGJlMjQwNzhlYzUyZDk3Mzk4Njk3ZGI0Yjc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBaG1lZCBLaGFuemFkYSA8bWVAZW56dS5ydT4KRGF0ZTogTW9u LCAyNSBKYW4gMjAyMSAyMToxNjo0OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydGluZyBo YXNoX3N0cmluZyBmdW5jdGlvbiBkdWUgdG8gcHJvYmxlbSBvbgogT3BlbkJTRC9TUEFSQzY0Cgot LS0KIHNyYy9mbnMuYyB8IDMyICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggN2FiMmU4ZjFhMC4uMDEyN2ZlM2Y0OCAxMDA2 NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDU5OSwzNCArNDU5OSwxNiBA QCAjZGVmaW5lIFNYSEFTSF9NQVhfTEVOICAgNwogRU1BQ1NfVUlOVAogaGFzaF9zdHJpbmcgKGNo YXIgY29uc3QgKnB0ciwgcHRyZGlmZl90IGxlbikKIHsKLSAgRU1BQ1NfVUlOVCBjb25zdCAqcCAg ID0gKEVNQUNTX1VJTlQgY29uc3QgKikgcHRyOwotICBFTUFDU19VSU5UIGNvbnN0ICplbmQgPSAo RU1BQ1NfVUlOVCBjb25zdCAqKSAocHRyICsgbGVuKTsKLSAgRU1BQ1NfVUlOVCBoYXNoID0gbGVu OwotICAvKiBBdCBtb3N0IDggc3RlcHMuICBXZSBjb3VsZCByZXVzZSBTWEhBU0hfTUFYX0xFTiwg b2YgY291cnNlLAotICAgKiBidXQgZGl2aWRpbmcgYnkgOCBpcyBjaGVhcGVyLiAgKi8KLSAgcHRy ZGlmZl90IHN0ZXAgPSAxICsgKChlbmQgLSBwKSA+PiAzKTsKLQotICAvKiBCZXdhcmU6IGBlbmRg IG1pZ2h0IGJlIHVuYWxpZ25lZCwgc28gYHAgPCBlbmRgIGlzIG5vdCBhbHdheXMgdGhlIHNhbWUK LSAgICogYXMgYHAgPD0gZW5kIC0gMWAuICAqLwotICB3aGlsZSAocCA8PSBlbmQgLSAxKQorICBj aGFyIGNvbnN0ICpwID0gcHRyOworICBjaGFyIGNvbnN0ICplbmQgPSBwICsgbGVuOworICB1bnNp Z25lZCBjaGFyIGM7CisgIEVNQUNTX1VJTlQgaGFzaCA9IDA7CisKKyAgd2hpbGUgKHAgIT0gZW5k KQogICAgIHsKLSAgICAgIEVNQUNTX1VJTlQgYyA9ICpwOwotICAgICAgcCArPSBzdGVwOworICAg ICAgYyA9ICpwKys7CiAgICAgICBoYXNoID0gc3hoYXNoX2NvbWJpbmUgKGhhc2gsIGMpOwogICAg IH0KLSAgaWYgKHAgPCBlbmQpCi0gICAgeyAvKiBBIGZldyBsYXN0IGJ5dGVzIHJlbWFpbiAoc21h bGxlciB0aGFuIGFuIEVNQUNTX1VJTlQpLiAgKi8KLSAgICAgIC8qIEZJWE1FOiBXZSBjb3VsZCBk byB0aGlzIHdpdGhvdXQgYSBsb29wLCBidXQgaXQnZCByZXF1aXJlCi0gICAgICAgICBlbmRpYW4t ZGVwZW5kZW50IGNvZGUgOi0oICAqLwotICAgICAgY2hhciBjb25zdCAqcDEgPSAoY2hhciBjb25z dCAqKXA7Ci0gICAgICBjaGFyIGNvbnN0ICplbmQxID0gKGNoYXIgY29uc3QgKillbmQ7Ci0gICAg ICBkbwotICAgICAgICB7Ci0gICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gKnAxKys7Ci0gICAg ICAgICAgaGFzaCA9IHN4aGFzaF9jb21iaW5lIChoYXNoLCBjKTsKLSAgICAgICAgfQotICAgICAg d2hpbGUgKHAxIDwgZW5kMSk7Ci0gICAgfQogCiAgIHJldHVybiBoYXNoOwogfQotLSAKMi4yOC4w Cgo= --000000000000059e5b05b9c82bfd-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 04:36:43 2021 Received: (at 46111) by debbugs.gnu.org; 26 Jan 2021 09:36:43 +0000 Received: from localhost ([127.0.0.1]:40757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4KmB-0002Yg-JG for submit@debbugs.gnu.org; Tue, 26 Jan 2021 04:36:43 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:44582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4KmA-0002YS-3f for 46111@debbugs.gnu.org; Tue, 26 Jan 2021 04:36:42 -0500 Received: by mail-ot1-f41.google.com with SMTP id e70so15588850ote.11 for <46111@debbugs.gnu.org>; Tue, 26 Jan 2021 01:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xRnHS4PSWCsy7ZIsjCRr+1NU3WvB1bnn8sgXhJ3KG4E=; b=ZJ+N89XFiarRFavoLHmfV5vLhjJNJG9z0vpy7rTftJAEnQdAYfws2N1+I7MOmxMRn4 Z1KDEPaBLbJmfzk4Ec21cMsZa0TJtoy+RYibX1PDUVDFEX2SE+VM2FdcMXHJ1RKOsuEF QYYWMYslEXPvEMStsKj2tFFA1kHg3x2gmoT9i775UlfHXGQB3Re01g+bvqKNmXlUNGlI SAtgZPcH5oDvhk6nXWkvO2oguhtdjuxBYGcSRnD20kyCU8QhYldfjeOTJQ3y5c1kP0Tg DJGG2OKN9Qxy7Dq59LEMH+xeZPFiQjdLeI/c/jRkRWA+K5S57Eaj3areBl1W+1lXQjHs uwSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xRnHS4PSWCsy7ZIsjCRr+1NU3WvB1bnn8sgXhJ3KG4E=; b=DpGnOPvSPF1Kr53zFng8jfcFdv7PBQhmEUSPneVYW0Uwz6qDyMbjkaoiRI8CPJ2x8f HUfFbY/Sr2NZ6V1zaek3m1D2fG8dfzpjaqffJePvg1mTLptH3uLvMLhrUYrEdaCkyeU+ pnfQYkOtjJF2mgvVPGkOtayuhEOoEGztw3q29IY0BqhHTKw41DB+urHJH+oVvH89u+Qs XeDXZgYKn8r/6AChiOT9mKkz0RXZyoQ/+23H5rG8RqlGTW5SFE5tuCtfaNKoqxBQSLZU +VfyFX/Svox/74zzdIIsXo9RvFflrbWOsJQxJZDcR7Oc93eKXwie/eix+/XkxQpnjse3 YjmQ== X-Gm-Message-State: AOAM532SMBiMM9At+hjbPLixN9B8EVEUh4DbwX5Enkp98KnVtl0zlfel U6hUsQmlbGiNdrVgvErnQPVlHp1LsIXh7LHHModTJ7bgDB/JIQ== X-Google-Smtp-Source: ABdhPJx+8QFW+jQfYnvORwHupiv9T0e0FQWulvlEaSEUlHUF/+AjrejEVRoVU+147iUDBpFpejMFXIEXUCbUzmsRzo0= X-Received: by 2002:a9d:4e8d:: with SMTP id v13mr3491305otk.12.1611653796110; Tue, 26 Jan 2021 01:36:36 -0800 (PST) MIME-Version: 1.0 References: <87sg6oyzi6.wl-me@enzu.ru> In-Reply-To: <87sg6oyzi6.wl-me@enzu.ru> From: Philipp Stephani Date: Tue, 26 Jan 2021 10:36:25 +0100 Message-ID: Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking To: Ahmed Khanzada Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Di., 26. Jan. 2021 um 10:07 Uhr schrieb Ahmed Khanzada : > > I'm not an expert on C, OpenBSD, or SPARC64, but I did notice > emacs-current was not compiling. > > During a gmake, bootstrap-emacs would get a SIGBUS and fail. Running > gdb led me to the hash_string function where it seemed to be failing. The culprit might be commit be0f2de179235980b5409d5e77577207b93a4f12. I don't think that something like EMACS_UINT const *p = (EMACS_UINT const *) ptr; is legal on any platform; it just happens to work on forgiving platforms such as x86-64. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 06:12:23 2021 Received: (at submit) by debbugs.gnu.org; 26 Jan 2021 11:12:23 +0000 Received: from localhost ([127.0.0.1]:40861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MGl-0004vW-DG for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:12:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:59154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MGj-0004vP-R6 for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:12:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4MGj-0000Mf-Mk for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 06:12:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45804) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4MGj-0006TN-3Y; Tue, 26 Jan 2021 06:12:21 -0500 Received: from [2001:4df7:1:dcaf::1] (port=46138) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1l4MGi-0007ct-7C; Tue, 26 Jan 2021 06:12:20 -0500 Date: Tue, 26 Jan 2021 13:12:16 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: <87sg6oyzi6.wl-me@enzu.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking To: bug-gnu-emacs@gnu.org, Philipp Stephani , Ahmed Khanzada From: Eli Zaretskii Message-ID: <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On January 26, 2021 11:36:25 AM GMT+02:00, Philipp Stephani wrote: > Am Di=2E, 26=2E Jan=2E 2021 um 10:07 Uhr schrieb Ahmed Khanzada > : > > > > I'm not an expert on C, OpenBSD, or SPARC64, but I did notice > > emacs-current was not compiling=2E > > > > During a gmake, bootstrap-emacs would get a SIGBUS and fail=2E Running > > gdb led me to the hash_string function where it seemed to be > failing=2E >=20 >=20 > The culprit might be commit be0f2de179235980b5409d5e77577207b93a4f12=2E > I don't think that something like > EMACS_UINT const *p =3D (EMACS_UINT const *) ptr; > is legal on any platform; it just happens to work on forgiving > platforms such as x86-64=2E It's definitely legal, as it doesn't violate any laws=2E=2E=2E From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 06:15:46 2021 Received: (at submit) by debbugs.gnu.org; 26 Jan 2021 11:15:46 +0000 Received: from localhost ([127.0.0.1]:40873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MK2-00051M-F1 for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:15:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:60220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MK0-00051E-M4 for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:15:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4MK0-00011e-Dc for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 06:15:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45877) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4MK0-0007gj-6B; Tue, 26 Jan 2021 06:15:44 -0500 Received: from [2001:4df7:1:dcaf::1] (port=46146) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1l4MJy-0007zc-9v; Tue, 26 Jan 2021 06:15:43 -0500 Date: Tue, 26 Jan 2021 13:15:38 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: <87sg6oyzi6.wl-me@enzu.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking To: bug-gnu-emacs@gnu.org, Ahmed Khanzada , 46111@debbugs.gnu.org, me@enzu.ru From: Eli Zaretskii Message-ID: <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On January 26, 2021 8:57:18 AM GMT+02:00, Ahmed Khanzada wro= te: > Not sure if the patch attached correctly=2E Trying again=2E Thanks=2E However, could you please show the C-level backtrace from the S= IGBUS crash, as displayed by GDB? I think we'd like to know which string h= as its data unaligned to cause this=2E From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 06:17:12 2021 Received: (at 46111) by debbugs.gnu.org; 26 Jan 2021 11:17:12 +0000 Received: from localhost ([127.0.0.1]:40881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MLQ-00054L-4r for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:17:12 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:51584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MLN-00054B-JG for 46111@debbugs.gnu.org; Tue, 26 Jan 2021 06:17:10 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DQ42D1SFwz1rxM2; Tue, 26 Jan 2021 12:17:07 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DQ42C60nQz1sP6K; Tue, 26 Jan 2021 12:17:07 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NvhCmQJTKos8; Tue, 26 Jan 2021 12:17:07 +0100 (CET) X-Auth-Info: qxxToeK84vcCTVTy3PBhw/X0YE4RycqkieAzD2xJZNquBlAoID20p7FdaGqXF4Ou Received: from igel.home (ppp-46-244-165-188.dynamic.mnet-online.de [46.244.165.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 26 Jan 2021 12:17:07 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id B33532C32FB; Tue, 26 Jan 2021 12:17:06 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> X-Yow: Not SENSUOUS... only ``FROLICSOME''... and in need of DENTAL WORK... in PAIN!!! Date: Tue, 26 Jan 2021 12:17:06 +0100 In-Reply-To: <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jan 2021 13:12:16 +0200") Message-ID: <87sg6o54nh.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 26 2021, Eli Zaretskii wrote: > It's definitely legal, as it doesn't violate any laws... It violates the laws of C. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 06:44:02 2021 Received: (at 46111) by debbugs.gnu.org; 26 Jan 2021 11:44:02 +0000 Received: from localhost ([127.0.0.1]:40910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MlN-0005sB-Np for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:44:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4MlL-0005rV-K2 for 46111@debbugs.gnu.org; Tue, 26 Jan 2021 06:43:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46352) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4MlF-0000L5-FG; Tue, 26 Jan 2021 06:43:53 -0500 Received: from [2001:4df7:1:dcaf::1] (port=46234) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1l4MlC-000548-OK; Tue, 26 Jan 2021 06:43:52 -0500 Date: Tue, 26 Jan 2021 13:43:47 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <87sg6o54nh.fsf@igel.home> References: <87sg6oyzi6.wl-me@enzu.ru> <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> <87sg6o54nh.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking To: Andreas Schwab From: Eli Zaretskii Message-ID: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On January 26, 2021 1:17:06 PM GMT+02:00, Andreas Schwab wrote: > On Jan 26 2021, Eli Zaretskii wrote: >=20 > > It's definitely legal, as it doesn't violate any laws=2E=2E=2E >=20 > It violates the laws of C=2E We call that "invalid" not "illegal"=2E From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 06:49:49 2021 Received: (at 46111) by debbugs.gnu.org; 26 Jan 2021 11:49:49 +0000 Received: from localhost ([127.0.0.1]:40924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Mqz-00061I-2R for submit@debbugs.gnu.org; Tue, 26 Jan 2021 06:49:49 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:35347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Mqx-00061A-DI for 46111@debbugs.gnu.org; Tue, 26 Jan 2021 06:49:48 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DQ4lt25skz1qsZn; Tue, 26 Jan 2021 12:49:46 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DQ4lt0NNBz1sP6Q; Tue, 26 Jan 2021 12:49:46 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id IguCZRS9Aong; Tue, 26 Jan 2021 12:49:45 +0100 (CET) X-Auth-Info: B5esb45wzPfXqypLesnhynZzA93bAK/qS8Hqa/anraCgkO2mtD2JY+sUNCcXJmhb Received: from igel.home (ppp-46-244-165-188.dynamic.mnet-online.de [46.244.165.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 26 Jan 2021 12:49:45 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id DDFA22C3323; Tue, 26 Jan 2021 12:49:44 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> <87sg6o54nh.fsf@igel.home> X-Yow: If a person is FAMOUS in this country, they have to go on the ROAD for MONTHS at a time and have their name misspelled on the SIDE of a GREYHOUND SCENICRUISER!! Date: Tue, 26 Jan 2021 12:49:44 +0100 In-Reply-To: (Eli Zaretskii's message of "Tue, 26 Jan 2021 13:43:47 +0200") Message-ID: <87o8hb6hpj.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 26 2021, Eli Zaretskii wrote: > On January 26, 2021 1:17:06 PM GMT+02:00, Andreas Schwab wrote: >> On Jan 26 2021, Eli Zaretskii wrote: >> >> > It's definitely legal, as it doesn't violate any laws... >> >> It violates the laws of C. > > We call that "invalid" not "illegal". It's still a bug. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 10:36:41 2021 Received: (at 46111) by debbugs.gnu.org; 26 Jan 2021 15:36:41 +0000 Received: from localhost ([127.0.0.1]:42447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4QOX-0001Db-E8 for submit@debbugs.gnu.org; Tue, 26 Jan 2021 10:36:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4QOV-0001DO-O2 for 46111@debbugs.gnu.org; Tue, 26 Jan 2021 10:36:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53024) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4QOO-00072M-IH; Tue, 26 Jan 2021 10:36:33 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4665 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l4QOB-0006rG-TH; Tue, 26 Jan 2021 10:36:28 -0500 Date: Tue, 26 Jan 2021 17:36:30 +0200 Message-Id: <83bldb1zi9.fsf@gnu.org> From: Eli Zaretskii To: Andreas Schwab In-Reply-To: <87o8hb6hpj.fsf@igel.home> (message from Andreas Schwab on Tue, 26 Jan 2021 12:49:44 +0100) Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> <87sg6o54nh.fsf@igel.home> <87o8hb6hpj.fsf@igel.home> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andreas Schwab > Cc: 46111@debbugs.gnu.org, p.stephani2@gmail.com, me@enzu.ru > Date: Tue, 26 Jan 2021 12:49:44 +0100 > > On Jan 26 2021, Eli Zaretskii wrote: > > > On January 26, 2021 1:17:06 PM GMT+02:00, Andreas Schwab wrote: > >> On Jan 26 2021, Eli Zaretskii wrote: > >> > >> > It's definitely legal, as it doesn't violate any laws... > >> > >> It violates the laws of C. > > > > We call that "invalid" not "illegal". > > It's still a bug. That goes without saying: a crash is always a bug. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 02:42:25 2021 Received: (at 46111) by debbugs.gnu.org; 27 Jan 2021 07:42:25 +0000 Received: from localhost ([127.0.0.1]:43657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4fT6-00064Q-FD for submit@debbugs.gnu.org; Wed, 27 Jan 2021 02:42:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4fT4-000644-Vn for 46111@debbugs.gnu.org; Wed, 27 Jan 2021 02:42:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43004) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4fSz-0004wU-9L; Wed, 27 Jan 2021 02:42:17 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1l4fSw-0000gB-Re; Wed, 27 Jan 2021 02:42:15 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Andreas Schwab In-Reply-To: <87sg6o54nh.fsf@igel.home> (message from Andreas Schwab on Tue, 26 Jan 2021 12:17:06 +0100) Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> <87sg6o54nh.fsf@igel.home> Message-Id: Date: Wed, 27 Jan 2021 02:42:14 -0500 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: p.stephani2@gmail.com, eliz@gnu.org, me@enzu.ru, 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > It violates the laws of C. C is not a government, and neither is the ISO C Committee. Breaking the rules of C is not illegal. Indeed, GNU C goes against the standard in some simple ways unless you specify options such as --pedantic. -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 03:24:48 2021 Received: (at 46111) by debbugs.gnu.org; 27 Jan 2021 08:24:48 +0000 Received: from localhost ([127.0.0.1]:43697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4g87-00075x-NA for submit@debbugs.gnu.org; Wed, 27 Jan 2021 03:24:48 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:45432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4g83-00075Y-Dy for 46111@debbugs.gnu.org; Wed, 27 Jan 2021 03:24:43 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DQc8p2Vjgz1qskN; Wed, 27 Jan 2021 09:24:42 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DQc8p0Y0bz1sP6w; Wed, 27 Jan 2021 09:24:42 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id P8QIBLc25zxP; Wed, 27 Jan 2021 09:24:41 +0100 (CET) X-Auth-Info: 0slVZG/qKATR03j5uMaKrHA3fm1FPZYSU4Ua0TU5ag9kdG1Humayx19qB8d7hpoN Received: from igel.home (ppp-46-244-175-231.dynamic.mnet-online.de [46.244.175.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 27 Jan 2021 09:24:41 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 020E12C3288; Wed, 27 Jan 2021 09:24:40 +0100 (CET) From: Andreas Schwab To: Richard Stallman Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <9020EC26-6AC7-4316-B5FB-11A27AB61481@gnu.org> <87sg6o54nh.fsf@igel.home> X-Yow: I'm having BEAUTIFUL THOUGHTS about the INSIPID WIVES of smug and wealthy CORPORATE LAWYERS.. Date: Wed, 27 Jan 2021 09:24:40 +0100 In-Reply-To: (Richard Stallman's message of "Wed, 27 Jan 2021 02:42:14 -0500") Message-ID: <871re6lrcn.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 46111 Cc: p.stephani2@gmail.com, eliz@gnu.org, me@enzu.ru, 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 27 2021, Richard Stallman wrote: > Breaking the rules of C is not illegal. If it breaks, you get to keep both pieces. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 23:06:18 2021 Received: (at submit) by debbugs.gnu.org; 28 Jan 2021 04:06:18 +0000 Received: from localhost ([127.0.0.1]:46723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4yZW-0000wl-0z for submit@debbugs.gnu.org; Wed, 27 Jan 2021 23:06:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:53960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4yZR-0000wV-4D for submit@debbugs.gnu.org; Wed, 27 Jan 2021 23:06:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4yZQ-0005LQ-4m for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2021 23:06:12 -0500 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:34697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4yZN-0002Jz-WA for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2021 23:06:11 -0500 Received: by mail-pj1-x102a.google.com with SMTP id my11so4086338pjb.1 for ; Wed, 27 Jan 2021 20:06:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enzu-ru.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=dpDxE+PvzrRbU9rSsI4Tu5A1zNL5zoSd1OwmHD1706M=; b=Xo4qVT27QsSvXXzm90ndKc9IewlpjjnIqq++UBKgHFVjBB/Fh89cOP1T69KHI+JJGb GrmybGcf4033Rg6/BzbrPEr7ZlMobHENdf0FSlmQPu6paP86FEX5gQgIqlGIkDpdaQr8 u39qWrmlsPj5DO8JApbpY5mMo9TO/fStItzG2nyeaDfjVJSKxLibcM+7sJ3gvqPz8hxT BiOoms8QH17sgekHqR0BSU8PxyQQtQA86Nfo/nEcU5poabdIYSQGcBo5sWjFJvAsIHfs sNOl+GyRjFrqeNIecsFUV4fAcP+liXgb0slxu+y2UcwplNGPIG6J9tfk+bYQOzKu2Q/n 7vXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=dpDxE+PvzrRbU9rSsI4Tu5A1zNL5zoSd1OwmHD1706M=; b=RgpRFrns2NOAYHIJ0fSPG2w3fFXapqfRk3/B6WtGpgoU2yy59BsMjGh+TyPAPcNUat Yytq4t2Qv8jMkOHkgCjLSyYB4arNesnYjVDWl6l1d/jaQgAN0QrqBBb+KjzjTH60h3GW 4oYMvPUwiXXj28UxHVfgveiAwBJYFA79Mr0r3aI/Hv29ZWm0zINM9BHDbxZetkvhQDCn n5vKxHVvwliUex2xo79snIuFVarjVaq2ZLQ9aty3DwrzMbRMdqhRT61yKNetHFTUwMC9 LzV29/Kavsbb/P714FrW9Fo5eAKXwh5jX6/IOKgD6PBg4UpBfL+85IlHJ3868LI2a2SA OMKA== X-Gm-Message-State: AOAM533qSXGhJ6wcWXLFJa98kltzHdoAIOXCurBJrh7sj322zbnABk7R Bdx48KhmpDI0rMus253fapbE17lsKyCaQQ== X-Google-Smtp-Source: ABdhPJz1m9SIBW1RMUYHYsXLRLyhYZSE1cZzkIlDMb35YQbOsCfUD17PIQLsRy6ldmbif7uv1W68JQ== X-Received: by 2002:a17:902:74cb:b029:df:f561:c06c with SMTP id f11-20020a17090274cbb02900dff561c06cmr14616063plt.81.1611806765877; Wed, 27 Jan 2021 20:06:05 -0800 (PST) Received: from ultra.enzu.ru (cpe-45-48-14-47.socal.res.rr.com. [45.48.14.47]) by smtp.gmail.com with ESMTPSA id u26sm3829815pfm.61.2021.01.27.20.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 20:06:05 -0800 (PST) From: Ahmed Khanzada To: Eli Zaretskii , bug-gnu-emacs@gnu.org, 46111@debbugs.gnu.org Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking In-Reply-To: <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> Date: Wed, 27 Jan 2021 20:06:01 -0800 Message-ID: <871re5vh7a.fsf@ultra.enzu.ru> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=2607:f8b0:4864:20::102a; envelope-from=me@enzu.ru; helo=mail-pj1-x102a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > On January 26, 2021 8:57:18 AM GMT+02:00, Ahmed Khanzada wrote: >> Not sure if the patch attached correctly. Trying again. > > > Thanks. However, could you please show the C-level backtrace from the SIGBUS crash, as displayed by GDB? I think we'd like to know which string has its data unaligned to cause this. Is the log below the information that you are looking for? Starting program: /home/enzuru/src/emacs/src/bootstrap-emacs Breakpoint 1, hash_string (ptr=0x47fa34d596 "DndProtocol", len=11) at fns.c:4602 4602 EMACS_UINT const *p = (EMACS_UINT const *) ptr; (gdb) info args ptr = 0x47fa34d596 "DndProtocol" len = 11 (gdb) next 4603 EMACS_UINT const *end = (EMACS_UINT const *) (ptr + len); (gdb) next 4604 EMACS_UINT hash = len; (gdb) next 4607 ptrdiff_t step = 1 + ((end - p) >> 3); (gdb) next 4611 while (p <= end - 1) (gdb) next 4613 EMACS_UINT c = *p; (gdb) next Program received signal SIGBUS, Bus error. 0x000000455fe1dc6c in hash_string (ptr=0x47fa34d596 "DndProtocol", len=11) at fns.c:4613 4613 EMACS_UINT c = *p; (gdb) backtrace #0 0x000000455fe1dc6c in hash_string (ptr=0x47fa34d596 "DndProtocol", len=11) at fns.c:4613 #1 0x000000455fe1dd48 in sxhash_string (ptr=0x47fa34d596 "DndProtocol", len=11) at fns.c:4640 #2 0x000000455fe1e36c in sxhash_obj (obj=0x47fa02f0bc, depth=0) at fns.c:4759 #3 0x000000455fe1e270 in sxhash (obj=0x47fa02f0bc) at fns.c:4741 #4 0x000000455fe1c52c in hashfn_equal (key=0x47fa02f0bc, h=0x47fa02eff0) at fns.c:4096 #5 0x000000455fe1cf44 in hash_table_rehash (hash=0x47fa02eff5) at fns.c:4342 #6 0x000000455fdc5264 in hash_table_thaw (hash=0x47fa02eff5) at pdumper.c:2652 #7 0x000000455fdcd184 in thaw_hash_tables () at pdumper.c:5477 #8 0x000000455fdcccf0 in pdumper_load (dump_filename=0x4832495d00 "/home/enzuru/src/emacs/src/bootstrap-emacs.pdmp") at pdumper.c:5405 #9 0x000000455fcea4ac in load_pdump (argc=1, argv=0xffffffffffff2968) at emacs.c:859 #10 0x000000455fceabec in main (argc=1, argv=0xffffffffffff2968) at emacs.c:1067 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 08:58:08 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 13:58:08 +0000 Received: from localhost ([127.0.0.1]:47621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57oG-0007gb-Kn for submit@debbugs.gnu.org; Thu, 28 Jan 2021 08:58:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57oE-0007g1-Od for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 08:58:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42217) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57o9-0000bY-0e; Thu, 28 Jan 2021 08:58:01 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l57o4-00050K-RL; Thu, 28 Jan 2021 08:57:58 -0500 Date: Thu, 28 Jan 2021 15:58:09 +0200 Message-Id: <837dnxyxhq.fsf@gnu.org> From: Eli Zaretskii To: Ahmed Khanzada , Stefan Monnier In-Reply-To: <871re5vh7a.fsf@ultra.enzu.ru> (message from Ahmed Khanzada on Wed, 27 Jan 2021 20:06:01 -0800) Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ahmed Khanzada > Cc: > Date: Wed, 27 Jan 2021 20:06:01 -0800 > > Eli Zaretskii writes: > > > Thanks. However, could you please show the C-level backtrace from the SIGBUS crash, as displayed by GDB? I think we'd like to know which string has its data unaligned to cause this. > > Is the log below the information that you are looking for? Yes, thanks. > 4613 EMACS_UINT c = *p; > (gdb) next > > Program received signal SIGBUS, Bus error. > 0x000000455fe1dc6c in hash_string (ptr=0x47fa34d596 "DndProtocol", > len=11) at fns.c:4613 > 4613 EMACS_UINT c = *p; > (gdb) backtrace > #0 0x000000455fe1dc6c in hash_string (ptr=0x47fa34d596 "DndProtocol", > len=11) at fns.c:4613 > #1 0x000000455fe1dd48 in sxhash_string (ptr=0x47fa34d596 "DndProtocol", > len=11) at fns.c:4640 > #2 0x000000455fe1e36c in sxhash_obj (obj=0x47fa02f0bc, depth=0) at > fns.c:4759 > #3 0x000000455fe1e270 in sxhash (obj=0x47fa02f0bc) at fns.c:4741 > #4 0x000000455fe1c52c in hashfn_equal (key=0x47fa02f0bc, > h=0x47fa02eff0) at fns.c:4096 > #5 0x000000455fe1cf44 in hash_table_rehash (hash=0x47fa02eff5) at > fns.c:4342 > #6 0x000000455fdc5264 in hash_table_thaw (hash=0x47fa02eff5) at > pdumper.c:2652 > #7 0x000000455fdcd184 in thaw_hash_tables () at pdumper.c:5477 Stefan, any ideas? One possibility is to use memcpy instead of dereferencing a pointer. We could do that either unconditionally or when the original pointer is not aligned on 4/8-byte boundary. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 10:09:31 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 15:09:31 +0000 Received: from localhost ([127.0.0.1]:49365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l58vL-0001Rv-9Y for submit@debbugs.gnu.org; Thu, 28 Jan 2021 10:09:31 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l58vJ-0001Rh-3z for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 10:09:29 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D47CC4403AE; Thu, 28 Jan 2021 10:09:23 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8AFDB440536; Thu, 28 Jan 2021 10:09:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611846562; bh=qqSijwYZi8CeySEJnjCYMxyA7g5dLBM5juoClqP0XYQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IsWtIfMG9BqBavRQ6za62w2c4uD464Hig5BBiOGUpQGfmTZZnPvFPlQ03UiUlYvjm w51nySp2k8Pios1C1FZyBIpHQjXrFzUjA8cJJmTbjJRweEOStC9wZveXYx4bOBILIi jaP0XlbKOPms2vljeV40E3BFlmyhIeE4834pXNlvfXHQ/y+ZTUrBSWBR3Ngc2c7JcZ lv9ribRb7M8Oe3OYz57nYsomSG3nC6JT/GPCNxoHLGOJAiX/CK5MuXMG8xaLDCQN6K Gq8ZkUP3BeBxNNJeBQ+h1TPklRyhuhvWCXcfaocAic9bK9gFeUwCsXGu8IB4pnYIj7 BxiKlmbkqVjmQ== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1A9231201A9; Thu, 28 Jan 2021 10:09:22 -0500 (EST) From: Stefan Monnier To: Ahmed Khanzada Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> Date: Thu, 28 Jan 2021 10:09:21 -0500 In-Reply-To: <871re5vh7a.fsf@ultra.enzu.ru> (Ahmed Khanzada's message of "Wed, 27 Jan 2021 20:06:01 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.103 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: eliz@gnu.org, 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Starting program: /home/enzuru/src/emacs/src/bootstrap-emacs > > Breakpoint 1, hash_string (ptr=0x47fa34d596 "DndProtocol", len=11) at > fns.c:4602 > 4602 EMACS_UINT const *p = (EMACS_UINT const *) ptr; > (gdb) info args > ptr = 0x47fa34d596 "DndProtocol" > len = 11 > (gdb) next > 4603 EMACS_UINT const *end = (EMACS_UINT const *) (ptr + len); > (gdb) next > 4604 EMACS_UINT hash = len; > (gdb) next > 4607 ptrdiff_t step = 1 + ((end - p) >> 3); > (gdb) next > 4611 while (p <= end - 1) > (gdb) next > 4613 EMACS_UINT c = *p; > (gdb) next > > Program received signal SIGBUS, Bus error. Hmm... so it's doing a dereference at address 0x47fa34d596 and getting a bus error? I have two questions here: - I'd guess that the bus error is due to alignment restrictions. What hardware is this running on? Last I checked, the computer architecture community had agreed (many years ago already) that (except for very small CPUs maybe, those not able to run Emacs) it's better to have the hardware support unaligned memory accesses (it took more time to get there than the consensus on branch delay slots, admittedly), so I'd be curious if there is still moderately recent hardware that insists on signaling an error. - AFAICT from the backtrace, `ptr` points to a plain normal ELisp string's content, yet these are supposed to be aligned, so what's going on here (this question is not directed at you ;-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 10:19:55 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 15:19:55 +0000 Received: from localhost ([127.0.0.1]:49397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l595P-0001jT-9w for submit@debbugs.gnu.org; Thu, 28 Jan 2021 10:19:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l595L-0001jA-EN for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 10:19:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44009) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l595F-0004CO-DU; Thu, 28 Jan 2021 10:19:45 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2478 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l595E-0004Nw-2E; Thu, 28 Jan 2021 10:19:44 -0500 Date: Thu, 28 Jan 2021 17:19:56 +0200 Message-Id: <8335ylytpf.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 28 Jan 2021 10:09:21 -0500) Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: eliz@gnu.org, 46111@debbugs.gnu.org > Date: Thu, 28 Jan 2021 10:09:21 -0500 > > Hmm... so it's doing a dereference at address 0x47fa34d596 and getting > a bus error? Yes. > I have two questions here: > > - I'd guess that the bus error is due to alignment restrictions. > What hardware is this running on? See the Subject: it's SPARC64. > - AFAICT from the backtrace, `ptr` points to a plain normal ELisp > string's content, yet these are supposed to be aligned, so what's > going on here I wondered that myself. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 10:44:19 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 15:44:19 +0000 Received: from localhost ([127.0.0.1]:49501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59T1-0002Rr-CH for submit@debbugs.gnu.org; Thu, 28 Jan 2021 10:44:19 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59T0-0002Re-1Y for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 10:44:18 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8493A8084A; Thu, 28 Jan 2021 10:44:12 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CBB6D80712; Thu, 28 Jan 2021 10:44:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611848650; bh=1L9glPaQnqOI4meWw4nl45rZzGWJ21DxplyiuWdhR9A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nQQ1sT/qAG1vIcAyYUeEieXWgHJNh23SUOol1hOHBFKBOZkf+wisCNqUjKUWq/gbc h9BDGqKbLOoGb3s1Kow3t7BFO8T5ZKNCKL7lniL+lTCfWpeBlVMCFzxiEbQj1Fd/jN qdHU6WREEabsjgxEGm+RTLCbWY2h2eLrf/K+7rNeWE7Ye15BeSDCMRRs7Prp1liRiI F9Izhzxts7M2Oim6V1cSOBSmTRPkJvAFWI1wMyUtPQMsu6CvdrzkPZNQDarzt75PFG s+ZZVjPmfjVO/e5zOADPXRzPw2M6JMwbab/wa8QA6UorP67CKKpIA7QlF7BrKS7zFF WpvJsuMPVVQJA== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 95922120213; Thu, 28 Jan 2021 10:44:10 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> Date: Thu, 28 Jan 2021 10:44:09 -0500 In-Reply-To: <8335ylytpf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jan 2021 17:19:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - I'd guess that the bus error is due to alignment restrictions. >> What hardware is this running on? > See the Subject: it's SPARC64. I mean the actual hardware, not the architecture. [ I know most RISC processors started with a restriction that they only allowed aligned memory accesses, but AFAIK they've changed stance since (IIUC the extra hardware can be very little, sometimes even less than the hardware that would be needed to implement the ad-hoc "support instructions" used to do the unaligned access as a sequence of instructions). It's one of the RISC simplifications that just didn't pan out. ] >> - AFAICT from the backtrace, `ptr` points to a plain normal ELisp >> string's content, yet these are supposed to be aligned, so what's >> going on here > I wondered that myself. And what did you conclude? ;-) Stef From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 10:52:41 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 15:52:41 +0000 Received: from localhost ([127.0.0.1]:49526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59b7-0002fj-II for submit@debbugs.gnu.org; Thu, 28 Jan 2021 10:52:41 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59b6-0002fV-BG for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 10:52:40 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C120B44073C; Thu, 28 Jan 2021 10:52:34 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 934814403AE; Thu, 28 Jan 2021 10:52:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611849153; bh=PTo2It7qgPANq5Xt+AmoismwxYh9iqGjFHHnqLM7HZM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Q896zFSIT5npF3/qVTKkbyqZPDpNLVSrbBuN1wcsYgeuZnUZC5KBz/IRkCkugEL8+ uGLj2lfuTFOZ2REVfpxAK5PX9auGT8W1LBeydKtYrZUu/ED6OYLyNDVFyXTdDEmIUi WrnZLQAQAEA4eytQfokCgiNpndi5Rix4k2SYx87QZtYdCK8i+MFuh03H72zAb5Eowa EdylPFdaklwY9CuPGDDySQ7MYa6HxR/BtkH8rpTyAWRU88FAAOD0LbbZvrHg2WVDmP GR2CtTuGkcpeiKKyLjZ9HRnX+QTVZJm1RYw+C1LwSuS1jPKXWQP21mWrPYgQY6XXwP 7GbYe+Ll0kfVg== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DD37F120263; Thu, 28 Jan 2021 10:52:32 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> Date: Thu, 28 Jan 2021 10:52:31 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Jan 2021 10:44:09 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> - AFAICT from the backtrace, `ptr` points to a plain normal ELisp >>> string's content, yet these are supposed to be aligned, so what's >>> going on here >> I wondered that myself. > And what did you conclude? ;-) Hmm... now that I think about it, I think `make_pure_string` may get us there, because the string's content is allocated from the end without any alignment! And the backtrace shows we're hashing the string `DndProtocol` which comes from `lisp/x-dnd.el` which is indeed preloaded, so I think that's what's going on. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 11:04:26 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 16:04:27 +0000 Received: from localhost ([127.0.0.1]:49606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59mU-00033F-I6 for submit@debbugs.gnu.org; Thu, 28 Jan 2021 11:04:26 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:51851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59mR-000332-8K for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 11:04:24 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DRQJj0lTwz1qsjl; Thu, 28 Jan 2021 17:04:20 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DRQJh6B5Yz1t6p4; Thu, 28 Jan 2021 17:04:20 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id BugzcnfeOqEh; Thu, 28 Jan 2021 17:04:20 +0100 (CET) X-Auth-Info: 1q9xtYLRn1yFdKH6Uyn9vSqE0u3GpJlv67rbHs47AKyybj0B5YaaC4OP5laRE9om Received: from igel.home (ppp-46-244-185-149.dynamic.mnet-online.de [46.244.185.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 28 Jan 2021 17:04:20 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 529EC2C3656; Thu, 28 Jan 2021 17:04:19 +0100 (CET) From: Andreas Schwab To: Stefan Monnier Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> X-Yow: I feel like I am sharing a ``CORN-DOG'' with NIKITA KHRUSCHEV.. Date: Thu, 28 Jan 2021 17:04:19 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Jan 2021 10:44:09 -0500") Message-ID: <87zh0t59q4.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 46111 Cc: Eli Zaretskii , me@enzu.ru, 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 28 2021, Stefan Monnier wrote: >>> - I'd guess that the bus error is due to alignment restrictions. >>> What hardware is this running on? >> See the Subject: it's SPARC64. > > I mean the actual hardware, not the architecture. Strict alignment is a property of the architecture, not the hardware. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 11:14:58 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 16:14:58 +0000 Received: from localhost ([127.0.0.1]:49621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59wg-0003JQ-0i for submit@debbugs.gnu.org; Thu, 28 Jan 2021 11:14:58 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59wd-0003JB-Q9 for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 11:14:56 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 180AD100250; Thu, 28 Jan 2021 11:14:50 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B8CAC100062; Thu, 28 Jan 2021 11:14:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611850488; bh=sPVO9FypDupMhZNSMegfR8inH4aK1JiqsnnnkyhWAO0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RZJU7rtw4dgjjHsIyOFWiQJUqlvllpRx2ROgavYajCrCmq+zCgmBUOMFWVZDdCyyB ReC9XSWUt2P2/JU4P7S6CaOP8KtiyFiftOBawhDgeWFW2u/Q8BuYt8t3xX5ALCNz4j jKFsYVFQwT31r/fxdh9lFhbZdgMUF5GGwsZYq4zCU+vwbbVBaIkYoWmB6bKgukwuQQ +WPq/fmYCh5vYjA4XR1JCaoPpMtZcHh6ugIkDvbQ+ab/UgrvSxhIrBXs7vxzBBHxUj 1T+j2rkip61Cifwe14qCnDXALZCXQlkIluT6fFsUYo0+9PVaNtHuKaG/5z8LFcQibP nQz5TG6Zay1SQ== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4683C12047A; Thu, 28 Jan 2021 11:14:48 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> <87zh0t59q4.fsf@igel.home> Date: Thu, 28 Jan 2021 11:14:47 -0500 In-Reply-To: <87zh0t59q4.fsf@igel.home> (Andreas Schwab's message of "Thu, 28 Jan 2021 17:04:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: Eli Zaretskii , me@enzu.ru, 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Andreas Schwab [2021-01-28 17:04:19] wrote: > On Jan 28 2021, Stefan Monnier wrote: > >>>> - I'd guess that the bus error is due to alignment restrictions. >>>> What hardware is this running on? >>> See the Subject: it's SPARC64. >> >> I mean the actual hardware, not the architecture. > > Strict alignment is a property of the architecture, not the hardware. IIRC some RISC architectures *allowed* errors on unaligned memory accesses without requiring it, making it a property of the hardware. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 11:17:48 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 16:17:48 +0000 Received: from localhost ([127.0.0.1]:49629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59zQ-0003OE-Gh for submit@debbugs.gnu.org; Thu, 28 Jan 2021 11:17:48 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59zL-0003Nz-RR for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 11:17:47 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ACCE48079A; Thu, 28 Jan 2021 11:17:38 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0C15680712; Thu, 28 Jan 2021 11:17:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611850653; bh=wko4MXo9PLCefHwARh+6S3NLZW8G9ff+xIg00XjDW9o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fu9gFfQO21EzPMY0wUXkxbCsBskSPClI4fjx7a+tzq+7xw/8UsDHGRFf/3vQQs67p DsSAGFbbAzfXktoVj8jnUkoZX4/vjc6gH4QuKImmIwfgWXHRnVlX4VoLMunWkT9fXS tNCtER6zXLyUhVkbzaZlPJIUwX1DHXhe6P4HbN84JRYiBh2RiA86l9J3jTCmrHA8YW fRQyp7PJB9m7ZNms/PuIXnJg9npfNkDslZ8pXe6wlJ31MVeCuIxprOoHuE5xTG+zQQ Zn2sZUnXuuryV/KvIjZzKAYA8a578ETDBARZ/48o/n8MN95tZYv1QgS1sFe2i77lrI yC5seBJatM+Qg== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D353B12045A; Thu, 28 Jan 2021 11:17:32 -0500 (EST) From: Stefan Monnier To: Ahmed Khanzada Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> Date: Thu, 28 Jan 2021 11:17:31 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Jan 2021 10:52:31 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > And the backtrace shows we're hashing the string `DndProtocol` which > comes from `lisp/x-dnd.el` which is indeed preloaded, so I think that's > what's going on. Could you try the patch below? Stefan diff --git a/src/fns.c b/src/fns.c index 7ab2e8f1a0..0c6bb770ef 100644 --- a/src/fns.c +++ b/src/fns.c @@ -4610,7 +4610,20 @@ hash_string (char const *ptr, ptrdiff_t len) * as `p <= end - 1`. */ while (p <= end - 1) { + /* Here `p` is *almost* always be properly aligned, so we want to + optimize for the aligned case, but we still need to support the + non-aligned case. */ + /* FIXME: Could we just always use `memcpy` and rely on GCC optimizing + it to a single word-sized memory access on all-but-sparc64? */ +#ifdef __sparc64__ /* Arch that still insists on aligned memory accesses. */ + EMACS_UINT c; + if (!((unsigned long)p) % sizeof (c)) + c = *p; + else + memcpy (&c, (char const *)p, sizeof (c)); /* `p` is unaligned! */ +#else EMACS_UINT c = *p; +#fi p += step; hash = sxhash_combine (hash, c); } From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 11:22:33 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 16:22:33 +0000 Received: from localhost ([127.0.0.1]:49638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5A41-0003Vf-Ec for submit@debbugs.gnu.org; Thu, 28 Jan 2021 11:22:33 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:44859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5A3z-0003VW-Nx for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 11:22:32 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DRQjf3tDXz1rxMG; Thu, 28 Jan 2021 17:22:30 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DRQjf1PVNz1t6p1; Thu, 28 Jan 2021 17:22:30 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id PdaSjMtr71Yq; Thu, 28 Jan 2021 17:22:29 +0100 (CET) X-Auth-Info: L1mH7wE9CBCg9n2C5I3q//Gj82ctRDX57z+oatstcQgsdPbPnYPvi/BgQDuG3BIC Received: from igel.home (ppp-46-244-185-149.dynamic.mnet-online.de [46.244.185.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 28 Jan 2021 17:22:29 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 23E752C3656; Thu, 28 Jan 2021 17:22:29 +0100 (CET) From: Andreas Schwab To: Stefan Monnier Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> X-Yow: I feel real SOPHISTICATED being in FRANCE! Date: Thu, 28 Jan 2021 17:22:29 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Jan 2021 11:17:31 -0500") Message-ID: <87sg6l58vu.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, Ahmed Khanzada X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 28 2021, Stefan Monnier wrote: > +#ifdef __sparc64__ /* Arch that still insists on aligned memory accesses. */ $ git grep -E '#define +STRICT_ALIGNMENT +1' -- gcc/config | wc -l 35 Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 12:22:42 2021 Received: (at 46111) by debbugs.gnu.org; 28 Jan 2021 17:22:42 +0000 Received: from localhost ([127.0.0.1]:49870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5B0E-00059N-1I for submit@debbugs.gnu.org; Thu, 28 Jan 2021 12:22:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5B0B-000599-DI for 46111@debbugs.gnu.org; Thu, 28 Jan 2021 12:22:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47624) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5B05-0000x8-US; Thu, 28 Jan 2021 12:22:33 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2005 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l5B04-0005s8-Ud; Thu, 28 Jan 2021 12:22:33 -0500 Date: Thu, 28 Jan 2021 19:22:47 +0200 Message-Id: <83zh0tx9g8.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 28 Jan 2021 11:17:31 -0500) Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111 Cc: 46111@debbugs.gnu.org, me@enzu.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Date: Thu, 28 Jan 2021 11:17:31 -0500 > Cc: 46111@debbugs.gnu.org > > + /* Here `p` is *almost* always be properly aligned, so we want to > + optimize for the aligned case, but we still need to support the > + non-aligned case. */ > + /* FIXME: Could we just always use `memcpy` and rely on GCC optimizing > + it to a single word-sized memory access on all-but-sparc64? */ > +#ifdef __sparc64__ /* Arch that still insists on aligned memory accesses. */ > + EMACS_UINT c; > + if (!((unsigned long)p) % sizeof (c)) > + c = *p; > + else > + memcpy (&c, (char const *)p, sizeof (c)); /* `p` is unaligned! */ > +#else > EMACS_UINT c = *p; > +#fi AFAIK, memcpy itself optimizes: once it gets to aligned address, it starts copying words instead of bytes. So I'm not sure we need either #ifdef or the run-time condition. I suggest to time both variants on x86 architecture, to see whether there's any performance hit due to use of memcpy, and if not, use memcpy always -- it will let us have the cake and eat it, too. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 12:30:33 2021 Received: (at 46111-done) by debbugs.gnu.org; 28 Jan 2021 17:30:33 +0000 Received: from localhost ([127.0.0.1]:49924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5B7o-0005OG-RH for submit@debbugs.gnu.org; Thu, 28 Jan 2021 12:30:33 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5B7m-0005Ny-LD for 46111-done@debbugs.gnu.org; Thu, 28 Jan 2021 12:30:31 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E4D1A809A7; Thu, 28 Jan 2021 12:30:24 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9056180602; Thu, 28 Jan 2021 12:30:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611855023; bh=31J2qBOK5vHroV7KWfLc4YlCeO7Muisg0pheJjrS5+4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dsvQB+aRTeIcUMeKNeFD7vGnwMQLjyzyupJqULwiKOQeMfnok+klQ3/m/qs4ZNAsC ta6Xxy7ig6BHkXtPZ1EodxFteBRe1+KXSKkYGGHNdGiDdrOM9dhVSikQhIL7V3Cpkf KoNQKCGdyaukPe0Yt7qIrgRBBHljX3LJRUF7V91pj7KRJmcIdQw0Eo+zyzmPNqn9J/ QWRkYuJ13VaHEaG6T2KlD/5DM1Ond3guHiUtLuVs90oKSRqM8DcOKyfBrjft4y8FsZ 4c9xD8WLADDAmXlj3LygLsKjwnEIEujTNki7WPmcF2ArvyzFe461k8+7JETZa0TgOl +SCQj1geKhvUg== Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5FF351201E0; Thu, 28 Jan 2021 12:30:23 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> <6915951F-2A53-4B08-A48A-6683B99AA14A@gnu.org> <871re5vh7a.fsf@ultra.enzu.ru> <8335ylytpf.fsf@gnu.org> <83zh0tx9g8.fsf@gnu.org> Date: Thu, 28 Jan 2021 12:30:22 -0500 In-Reply-To: <83zh0tx9g8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jan 2021 19:22:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46111-done Cc: 46111-done@debbugs.gnu.org, me@enzu.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > AFAIK, memcpy itself optimizes: once it gets to aligned address, it > starts copying words instead of bytes. I don't know what this `memcpy` code expands to on sparc64, but since it turns into a plain `mov` on x86, I simplified the code to always use `memcpy`. Stefan From unknown Mon Jun 23 06:01:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 Feb 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator