Subject: [bug#46107] [PATCH 1/6] gnu: Add spglib.

From: Kei <[email-masked]>
Date: Mon, 25 Jan 2021 22:20:19 -0500

On Mon, 2021-01-25 at 17:17 -0500, Leo Famulari wrote:
> On Mon, Jan 25, 2021 at 04:20:42PM -0500, Kei Kebreau wrote:
> > * gnu/packages/chemistry.scm (spglib): New variable.
> 
> Thanks! LGTM
> 
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (replace 'bootstrap
> > +           (lambda _
> > +             ;; These files are required by the Makefile, but not provided
> > by
> > +             ;; the developers.
> > +             (for-each (lambda (file) (invoke "touch" file))
> > +                       '("NEWS" "README" "AUTHORS"))
> > +             (invoke "autoreconf" "-vi"))))))
> 
> Can you file a bug upstream about this?

On closer inspection, it seems that the developer is moving to make CMake the
main build system.  Using the CMake build system, I ran into a known [0]
inconsistency [1] between the GNU and CMake build systems used by spglib.  I've
patched spglib to deal with this for now, with links added in the comments.

[0]: https://github.com/spglib/spglib/issues/75
[1]: https://github.com/OpenChemistry/avogadroapp/issues/97