GNU bug report logs - #46056
hardcoded ~/.emacs.d in elpa package excorporate

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Gunnar Horrigmo <gnunar <at> stoffe-pro.net>
Cc: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>, 46056 <at> debbugs.gnu.org
Subject: bug#46056: hardcoded ~/.emacs.d in elpa package excorporate
Date: Sat, 23 Jan 2021 22:31:13 +0000

Gunnar Horrigmo <gnunar <at> stoffe-pro.net> writes:

> The `excorporate' package hardcodes its diary files to
> ~/.emacs.d/excorporate, instead of honoring user-emacs-directory.

Right.  CCing Thomas, the package's maintainer.

> I've included a small fix:
>
> === begin diff ===
>
> diff --git a/excorporate-diary.el b/excorporate-diary.el
> index 833df3017c..b147bed42d 100644
> --- a/excorporate-diary.el
> +++ b/excorporate-diary.el
> @@ -76,13 +76,17 @@ respectively."
>               #'exco-diary-icalendar--add-diary-entry-around))
>  
>  (defvar excorporate-diary-today-file
> -  "~/.emacs.d/excorporate/diary-excorporate-today"
> +  (concat
> +   (file-name-as-directory user-emacs-directory)
> +   "excorporate/diary-excorporate-today")

Rather than concatenating file names as strings, better to use
locate-user-emacs-file in this case (or expand-file-name in general).
See (info "(elisp) Standard File Names").

[...]

> Am I submitting this the right way?

Ideally the patch would include a ChangeLog-style commit message
referencing this bug number; see the guidelines in the CONTRIBUTE
file[1] at the top of the Emacs source tree.  Otherwise looks fine :).

[1]: https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.