GNU bug report logs - #46056
hardcoded ~/.emacs.d in elpa package excorporate

Previous Next

Full log

Message #18 received at 46056-done <at> debbugs.gnu.org (full text, mbox):

From: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>
To: Gunnar Horrigmo <horrigmo <at> runbox.no>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 46056-done <at> debbugs.gnu.org
Subject: Re: bug#46056: hardcoded ~/.emacs.d in elpa package excorporate
Date: Sat, 23 Jan 2021 22:16:20 -0500

[Message part 1 (text/plain, inline)]

Hi Gunnar,

Gunnar Horrigmo <horrigmo <at> runbox.no> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Right.  CCing Thomas, the package's maintainer.

Thanks Basil, I might not have seen this otherwise (see postscript).

> Thank you.
>
>> Rather than concatenating file names as strings, better to use
>> locate-user-emacs-file in this case (or expand-file-name in general).
>> See (info "(elisp) Standard File Names").
>
> Good advice! 
>
>> Ideally the patch would include a ChangeLog-style commit message
>> referencing this bug number; see the guidelines in the CONTRIBUTE
>> file[1] at the top of the Emacs source tree.  Otherwise looks fine :).
>>
>> [1]: https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE
>
> Not that Thomas needs my help, but just for my own excercise, is this
> what you prefer?

Thanks for the fix.  I wrote up the ChangeLog and pushed the change, see
attached.  It will be released when Excorporate 0.9.2 hits GNU ELPA
tomorrow or the day after.

Thomas

P.S. The results of the following steps don't include this bug report; I
wonder why:

M-x debbugs-gnu-search RET
Enter search phrase: excorporate RET
Enter attribute: RET

[0001-Do-not-hard-code-diary-directory.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.