From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 14:02:14 2021 Received: (at submit) by debbugs.gnu.org; 23 Jan 2021 19:02:14 +0000 Received: from localhost ([127.0.0.1]:35292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3OAo-0004a6-5Z for submit@debbugs.gnu.org; Sat, 23 Jan 2021 14:02:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:45444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3OAl-0004Zy-V5 for submit@debbugs.gnu.org; Sat, 23 Jan 2021 14:02:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3OAk-0000Au-90 for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 14:02:11 -0500 Received: from 17.mo5.mail-out.ovh.net ([46.105.56.132]:52408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3OAi-0005BF-2t for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 14:02:09 -0500 Received: from player755.ha.ovh.net (unknown [10.108.54.52]) by mo5.mail-out.ovh.net (Postfix) with ESMTP id 1982D2A8514 for ; Sat, 23 Jan 2021 20:01:57 +0100 (CET) Received: from parouby.fr (91-175-17-70.subs.proxad.net [91.175.17.70]) (Authenticated sender: contact@parouby.fr) by player755.ha.ovh.net (Postfix) with ESMTPSA id 88AAA1A68A688; Sat, 23 Jan 2021 19:01:56 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-105G0066ad67cc1-f7c3-447d-90f6-fc8a3c7bac32, C852A40F96BA1AB9599DE0135A45900F0AB8A045) smtp.auth=contact@parouby.fr X-OVh-ClientIp: 91.175.17.70 From: Pierre-Antoine Rouby To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add rust lang to etags Date: Sat, 23 Jan 2021 20:01:43 +0100 Message-Id: <20210123190143.29246-1-contact@parouby.fr> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 8261009092924945419 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrudekgdduvdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomheprfhivghrrhgvqdetnhhtohhinhgvucftohhusgihuceotghonhhtrggtthesphgrrhhouhgshidrfhhrqeenucggtffrrghtthgvrhhnpeffteffgeekveekgeetudfghfdttdeigfeffffhhfdvveektdefvdeljeffudetudenucfkpheptddrtddrtddrtddpledurddujeehrddujedrjedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeehhedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtohhnthgrtghtsehprghrohhusgihrdhfrhdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg Received-SPF: pass client-ip=46.105.56.132; envelope-from=contact@parouby.fr; helo=17.mo5.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Pierre-Antoine Rouby X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * lib-src/etags.c (Rust_functions): New function to make tags for rust files. (Rust_help, Rust_suffixes): New constant. --- lib-src/etags.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/lib-src/etags.c b/lib-src/etags.c index b5c18e0e01..8243861c69 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c @@ -366,6 +366,7 @@ #define xrnew(op, n, m) ((op) = xnrealloc (op, n, (m) * sizeof *(op))) static void Prolog_functions (FILE *); static void Python_functions (FILE *); static void Ruby_functions (FILE *); +static void Rust_functions (FILE *); static void Scheme_functions (FILE *); static void TeX_commands (FILE *); static void Texinfo_nodes (FILE *); @@ -752,6 +753,12 @@ #define STDIN 0x1001 /* returned by getopt_long on --parse-stdin */ static const char *Ruby_interpreters [] = { "ruby", NULL }; +static const char *Rust_suffixes [] = + { "rs", NULL }; +static const char Rust_help [] = + "In Rust code, tags anything defined with 'fn', 'enum', \n\ +'struct' or 'macro_rules!'."; + /* Can't do the `SCM' or `scm' prefix with a version number. */ static const char *Scheme_suffixes [] = { "oak", "sch", "scheme", "SCM", "scm", "SM", "sm", "ss", "t", NULL }; @@ -836,6 +843,7 @@ #define STDIN 0x1001 /* returned by getopt_long on --parse-stdin */ NULL, Python_interpreters }, { "ruby", Ruby_help, Ruby_functions, Ruby_suffixes, Ruby_filenames, Ruby_interpreters }, + { "rust", Rust_help, Rust_functions, Rust_suffixes }, { "scheme", Scheme_help, Scheme_functions, Scheme_suffixes }, { "tex", TeX_help, TeX_commands, TeX_suffixes }, { "texinfo", Texinfo_help, Texinfo_nodes, Texinfo_suffixes }, @@ -5019,6 +5027,47 @@ Ruby_functions (FILE *inf) } } + +/* + * Rust support + * Look for: + * - fn: Function + * - struct: Structure + * - enum: Enumeration + * - macro_rules!: Macro + */ +static void +Rust_functions (FILE *inf) +{ + char *cp, *name; + + LOOP_ON_INPUT_LINES(inf, lb, cp) + { + cp = skip_spaces(cp); + name = cp; + + // Skip 'pub' keyworld + (void)LOOKING_AT (cp, "pub"); + + // Look for define + if (LOOKING_AT (cp, "fn") + || LOOKING_AT (cp, "enum") + || LOOKING_AT (cp, "struct") + || LOOKING_AT (cp, "macro_rules!")) + { + cp = skip_spaces (cp); + name = cp; + + while (!notinname (*cp)) + cp++; + + make_tag (name, cp - name, true, + lb.buffer, cp - lb.buffer + 1, + lineno, linecharno); + } + } +} + /* * PHP support -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 15:00:26 2021 Received: (at 46055) by debbugs.gnu.org; 23 Jan 2021 20:00:26 +0000 Received: from localhost ([127.0.0.1]:35365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3P4t-00088W-8k for submit@debbugs.gnu.org; Sat, 23 Jan 2021 15:00:26 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3P4q-00087C-Tr for 46055@debbugs.gnu.org; Sat, 23 Jan 2021 15:00:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j8tW/KEpSfuMxV28KQ9lhxeOa5Q0aEG9SCzOG8ZE2ro=; b=g2/Yj9FCSTxEKNo9BvWhngW+08 +8dCuRim/R08jEJwJrYNJoxnUx+e0101vMbmQaOlanWfaOH+mD3cWX1YOF2DtKj9eLzNanKRDqAZh BcqG2xaAGL88xqU0JhIuNIKJnwoA8aE04AgDM6BRqmcBVUyEOPjR2nh8pN0OpI0yk7D4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3P4g-0004fa-83; Sat, 23 Jan 2021 21:00:02 +0100 From: Lars Ingebrigtsen To: Pierre-Antoine Rouby Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210123190143.29246-1-contact@parouby.fr> X-Now-Playing: The Style Council's _The Complete Adventures (5)_: "Promised Land (Longer Version)" Date: Sat, 23 Jan 2021 20:59:56 +0100 In-Reply-To: <20210123190143.29246-1-contact@parouby.fr> (Pierre-Antoine Rouby's message of "Sat, 23 Jan 2021 20:01:43 +0100") Message-ID: <87im7ntoeb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pierre-Antoine Rouby writes: > * lib-src/etags.c (Rust_functions): New function to make tags for rust > files. > (Rust_help, Rust_suffixes): New constant. Thanks; looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pierre-Antoine Rouby writes: > * lib-src/etags.c (Rust_functions): New function to make tags for rust > files. > (Rust_help, Rust_suffixes): New constant. Thanks; looks good to me. This patch is too big to apply without an FSF copyright assignment, though. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 15:23:55 2021 Received: (at 46055) by debbugs.gnu.org; 23 Jan 2021 20:23:55 +0000 Received: from localhost ([127.0.0.1]:35382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3PRq-0000HT-ST for submit@debbugs.gnu.org; Sat, 23 Jan 2021 15:23:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3PRp-0000HE-B8 for 46055@debbugs.gnu.org; Sat, 23 Jan 2021 15:23:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48334) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3PRj-00009i-8N; Sat, 23 Jan 2021 15:23:47 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l3PRi-0006ko-HH; Sat, 23 Jan 2021 15:23:47 -0500 Date: Sat, 23 Jan 2021 22:23:48 +0200 Message-Id: <83im7n4d2j.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87im7ntoeb.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 23 Jan 2021 20:59:56 +0100) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210123190143.29246-1-contact@parouby.fr> <87im7ntoeb.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46055 Cc: contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Sat, 23 Jan 2021 20:59:56 +0100 > Cc: 46055@debbugs.gnu.org > > Pierre-Antoine Rouby writes: > > > * lib-src/etags.c (Rust_functions): New function to make tags for rust > > files. > > (Rust_help, Rust_suffixes): New constant. > > Thanks; looks good to me. > > This patch is too big to apply without an FSF copyright assignment, > though. Would you be willing to sign such paperwork? Please don't forget to update etags.1 as well. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 05:08:47 2021 Received: (at 46055) by debbugs.gnu.org; 25 Jan 2021 10:08:48 +0000 Received: from localhost ([127.0.0.1]:37942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3ynf-000259-Mz for submit@debbugs.gnu.org; Mon, 25 Jan 2021 05:08:47 -0500 Received: from 3.mo178.mail-out.ovh.net ([46.105.44.197]:40865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3ynd-000250-Tn for 46055@debbugs.gnu.org; Mon, 25 Jan 2021 05:08:47 -0500 Received: from player737.ha.ovh.net (unknown [10.108.16.142]) by mo178.mail-out.ovh.net (Postfix) with ESMTP id 6076BC1A20 for <46055@debbugs.gnu.org>; Mon, 25 Jan 2021 11:08:44 +0100 (CET) Received: from parouby.fr (58.ip-213-32-91.eu [213.32.91.58]) (Authenticated sender: contact@parouby.fr) by player737.ha.ovh.net (Postfix) with ESMTPSA id 10E9910E3AA76; Mon, 25 Jan 2021 10:08:40 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-97G002747cf18f-644d-4800-b09d-08914beaf3c2, 8854E7433D5AD1D10FBE0073606383D2091F8FEE) smtp.auth=contact@parouby.fr X-OVh-ClientIp: 213.32.91.58 Subject: Re: bug#46055: [PATCH] Add rust lang to etags To: Eli Zaretskii , Lars Ingebrigtsen References: <20210123190143.29246-1-contact@parouby.fr> <87im7ntoeb.fsf@gnus.org> <83im7n4d2j.fsf@gnu.org> From: parouby Message-ID: Date: Mon, 25 Jan 2021 11:08:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <83im7n4d2j.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 11000886516773500142 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgddutdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpehprghrohhusgihuceotghonhhtrggtthesphgrrhhouhgshidrfhhrqeenucggtffrrghtthgvrhhnpeeghedvgeffueevheekkeffkeffkeeuffegffdttdelueduhfduhfevieeuffelffenucfkpheptddrtddrtddrtddpvddufedrfedvrdeluddrheeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeefjedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtohhnthgrtghtsehprghrohhusgihrdhfrhdprhgtphhtthhopeegiedtheehseguvggssghughhsrdhgnhhurdhorhhg X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thanks for review. On 23/01/2021 21:23, Eli Zaretskii wrote: >> From: Lars Ingebrigtsen >> Date: Sat, 23 Jan 2021 20:59:56 +0100 >> Cc: 46055@debbugs.gnu.org >> >> Pierre-Antoine Rouby writes: >> >>> * lib-src/etags.c (Rust_functions): New function to make tags for rust >>> files. >>> (Rust_help, Rust_suffixes): New constant. >> >> Thanks; looks good to me. >> >> This patch is too big to apply without an FSF copyright assignment, >> though. Would you be willing to sign such paperwork? Yes, no problem, who can I sign it ? > Please don't forget to update etags.1 as well. Ok, I have update 'etags.1' and 'maintaining.texi'. Updated patch coming soon. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 05:09:50 2021 Received: (at 46055) by debbugs.gnu.org; 25 Jan 2021 10:09:50 +0000 Received: from localhost ([127.0.0.1]:37946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3yog-000270-0p for submit@debbugs.gnu.org; Mon, 25 Jan 2021 05:09:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3yod-00026j-O9 for 46055@debbugs.gnu.org; Mon, 25 Jan 2021 05:09:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gAM5Omlke2tGxz5Jrtvm8ikBvqutN1/EwSALgO2dQNQ=; b=qJK3Ion94Jt0Ou9xeEBlRAZugC 0702tSbDY3TZ6InTlmLxbsyBAJaD9oQixkVe8nRCJP7G6HEiV82Y8a5Q98vXPjepKbQXNyBVPym9v E1ZhIPybAunweuv2G7GFzcAJ/hiZMJ9Qwxu8sE+PnzZZqFF/o8NJZ7HBAUlMEIumnQiw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3yoS-00036s-Hq; Mon, 25 Jan 2021 11:09:41 +0100 From: Lars Ingebrigtsen To: parouby Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210123190143.29246-1-contact@parouby.fr> <87im7ntoeb.fsf@gnus.org> <83im7n4d2j.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEX57dL99t3++OKc pJF7lYqhjmejclPWhjXTrIp4i3VlTjPWlV3QUC/Gz7v////TbqgbAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UBGQoJDE/PY4AAAAGFSURBVDjLpZPBSsNAEIbTR9h5g5lX2ETac9UXiFvrWSKl5mpz8Fgs gfRW9A1aoZ6VQnptKfgMvouzTZrMmgiC/yGQ/fjnH2Z3vI76IWKhUh4DQizOEBCpEHqOA4haATIB AVAAVC0OziQEaAIkqBzkOKiKcAGIrhhAnY0kgWiKLdhWqpqIA3SpBvAvonNtrvoinI4hfpAYk4R9 xwFHEPZ14JSCAmh9GWrtlrLF/GD6sgycUjwGvilfT3uLrnAUVwkQBO93kQnD2mG/nHFmcpa5rR12 cDyWwYNhx/W9CzjjaRsNs8HnsAZoI0jpeJSm813XCedz1YtH4+VsH8pSyob78Wi9+tgvJIASvE1m EqhjtyqI89dJvgtlRnEf22S9Sj7rcO6Wh4hKzy04aOkAfsyQzpPxMjm47dr3lBWOzR8BK8vz8SrN GwCzx007MMbcPBsTyXaP+ipVbZR4x1JYhZf/vwH6F4BqvdEF5Zbxu1PS7bWvTRPIVet46rQ9cAJI XiULvJMB6BuICr/mzuKZKQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wMS0yNVQxMDowOToxMisw MDowMFgcFLAAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDEtMjVUMTA6MDk6MTIrMDA6MDApQawM AAAAAElFTkSuQmCC X-Now-Playing: Not Glass's _Forma Hoos_: "Forma Bonum Fragile Est" Date: Mon, 25 Jan 2021 11:09:35 +0100 In-Reply-To: (parouby's message of "Mon, 25 Jan 2021 11:08:39 +0100") Message-ID: <878s8hpbts.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: parouby writes: >>> This patch is too big to apply without an FSF copyright assignment, >>> though. Would you be willing to sign such paperwork? > > Yes, no problem, who can I sign it ? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: Eli Zaretskii , 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) parouby writes: >>> This patch is too big to apply without an FSF copyright assignment, >>> though. Would you be willing to sign such paperwork? > > Yes, no problem, who can I sign it ? Great; here's the form to get started: Please email the following information to assign@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full legal name (in ASCII characters) as the subject line of the message. ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written so far?] From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 05:18:48 2021 Received: (at 46055) by debbugs.gnu.org; 25 Jan 2021 10:18:48 +0000 Received: from localhost ([127.0.0.1]:37964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3yxL-0002MZ-TO for submit@debbugs.gnu.org; Mon, 25 Jan 2021 05:18:48 -0500 Received: from 10.mo5.mail-out.ovh.net ([46.105.52.148]:50030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3yxJ-0002MQ-ET for 46055@debbugs.gnu.org; Mon, 25 Jan 2021 05:18:46 -0500 Received: from player791.ha.ovh.net (unknown [10.110.171.96]) by mo5.mail-out.ovh.net (Postfix) with ESMTP id 0D1BC2AD657 for <46055@debbugs.gnu.org>; Mon, 25 Jan 2021 11:18:43 +0100 (CET) Received: from parouby.fr (91-175-17-70.subs.proxad.net [91.175.17.70]) (Authenticated sender: contact@parouby.fr) by player791.ha.ovh.net (Postfix) with ESMTPSA id 38D891A4BBBFE; Mon, 25 Jan 2021 10:18:42 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-99G003027077ef-d99a-4097-a97b-bb496c3f479a, 8854E7433D5AD1D10FBE0073606383D2091F8FEE) smtp.auth=contact@parouby.fr X-OVh-ClientIp: 91.175.17.70 From: Pierre-Antoine Rouby To: 46055@debbugs.gnu.org Subject: [PATCH] Add rust lang to etags Date: Mon, 25 Jan 2021 11:15:46 +0100 Message-Id: <20210125101546.6929-1-contact@parouby.fr> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 11169771503595304174 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgdduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefrihgvrhhrvgdqtehnthhoihhnvgcutfhouhgshicuoegtohhnthgrtghtsehprghrohhusgihrdhfrheqnecuggftrfgrthhtvghrnhepheelkedukeffgfehkefgvdeiiedtkeeifedvudeiueekhfehkeeiudetjedtiefhnecukfhppedtrddtrddtrddtpdeluddrudejhedrudejrdejtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejledurdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghonhhtrggtthesphgrrhhouhgshidrfhhrpdhrtghpthhtohepgeeitdehheesuggvsggsuhhgshdrghhnuhdrohhrgh X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: Pierre-Antoine Rouby X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * lib-src/etags.c (Rust_functions): New function to make tags for rust files. (Rust_help, Rust_suffixes): New constant. * doc/emacs/maintaining.texi (Tag Syntax): Add Rust item. * doc/man/etags.1: Add Rust. --- doc/emacs/maintaining.texi | 4 ++++ doc/man/etags.1 | 2 +- lib-src/etags.c | 49 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index 415815473e..0f96dc65d1 100644 --- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -2639,6 +2639,10 @@ Tag Syntax @item In Ruby code, @code{def} or @code{class} or @code{module} at the beginning of a line generate a tag. Constants also generate tags. + +@item +In Rust code, tags anything defined with @code{fn}, @code{enum}, +@code{struct} or @code{macro_rules!}. @end itemize You can also generate tags based on regexp matching (@pxref{Etags diff --git a/doc/man/etags.1 b/doc/man/etags.1 index c5c15fb182..354f6ca88b 100644 --- a/doc/man/etags.1 +++ b/doc/man/etags.1 @@ -51,7 +51,7 @@ format understood by \&. Both forms of the program understand the syntax of C, Objective C, C++, Java, Fortran, Ada, Cobol, Erlang, Forth, Go, HTML, LaTeX, Emacs Lisp/Common Lisp, Lua, Makefile, Pascal, Perl, -Ruby, PHP, PostScript, Python, Prolog, Scheme and +Ruby, Rust, PHP, PostScript, Python, Prolog, Scheme and most assembler\-like syntaxes. Both forms read the files specified on the command line, and write a tag table (defaults: \fBTAGS\fP for \fBetags\fP, \fBtags\fP for diff --git a/lib-src/etags.c b/lib-src/etags.c index b5c18e0e01..8243861c69 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c @@ -366,6 +366,7 @@ #define xrnew(op, n, m) ((op) = xnrealloc (op, n, (m) * sizeof *(op))) static void Prolog_functions (FILE *); static void Python_functions (FILE *); static void Ruby_functions (FILE *); +static void Rust_functions (FILE *); static void Scheme_functions (FILE *); static void TeX_commands (FILE *); static void Texinfo_nodes (FILE *); @@ -752,6 +753,12 @@ #define STDIN 0x1001 /* returned by getopt_long on --parse-stdin */ static const char *Ruby_interpreters [] = { "ruby", NULL }; +static const char *Rust_suffixes [] = + { "rs", NULL }; +static const char Rust_help [] = + "In Rust code, tags anything defined with 'fn', 'enum', \n\ +'struct' or 'macro_rules!'."; + /* Can't do the `SCM' or `scm' prefix with a version number. */ static const char *Scheme_suffixes [] = { "oak", "sch", "scheme", "SCM", "scm", "SM", "sm", "ss", "t", NULL }; @@ -836,6 +843,7 @@ #define STDIN 0x1001 /* returned by getopt_long on --parse-stdin */ NULL, Python_interpreters }, { "ruby", Ruby_help, Ruby_functions, Ruby_suffixes, Ruby_filenames, Ruby_interpreters }, + { "rust", Rust_help, Rust_functions, Rust_suffixes }, { "scheme", Scheme_help, Scheme_functions, Scheme_suffixes }, { "tex", TeX_help, TeX_commands, TeX_suffixes }, { "texinfo", Texinfo_help, Texinfo_nodes, Texinfo_suffixes }, @@ -5019,6 +5027,47 @@ Ruby_functions (FILE *inf) } } + +/* + * Rust support + * Look for: + * - fn: Function + * - struct: Structure + * - enum: Enumeration + * - macro_rules!: Macro + */ +static void +Rust_functions (FILE *inf) +{ + char *cp, *name; + + LOOP_ON_INPUT_LINES(inf, lb, cp) + { + cp = skip_spaces(cp); + name = cp; + + // Skip 'pub' keyworld + (void)LOOKING_AT (cp, "pub"); + + // Look for define + if (LOOKING_AT (cp, "fn") + || LOOKING_AT (cp, "enum") + || LOOKING_AT (cp, "struct") + || LOOKING_AT (cp, "macro_rules!")) + { + cp = skip_spaces (cp); + name = cp; + + while (!notinname (*cp)) + cp++; + + make_tag (name, cp - name, true, + lb.buffer, cp - lb.buffer + 1, + lineno, linecharno); + } + } +} + /* * PHP support -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 09:34:57 2021 Received: (at 46055) by debbugs.gnu.org; 25 Jan 2021 14:34:57 +0000 Received: from localhost ([127.0.0.1]:38351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l42xF-0005Yu-5w for submit@debbugs.gnu.org; Mon, 25 Jan 2021 09:34:57 -0500 Received: from 1.mo2.mail-out.ovh.net ([46.105.63.121]:37123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l42xC-0005Yk-2B for 46055@debbugs.gnu.org; Mon, 25 Jan 2021 09:34:55 -0500 Received: from player755.ha.ovh.net (unknown [10.109.138.183]) by mo2.mail-out.ovh.net (Postfix) with ESMTP id 63A4B1F93B5 for <46055@debbugs.gnu.org>; Mon, 25 Jan 2021 15:34:52 +0100 (CET) Received: from parouby.fr (91-175-17-70.subs.proxad.net [91.175.17.70]) (Authenticated sender: contact@parouby.fr) by player755.ha.ovh.net (Postfix) with ESMTPSA id B2BF61A73F521; Mon, 25 Jan 2021 14:34:45 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-99G003ae519c25-9193-45c9-a6a6-9a5e7db89e24, 8854E7433D5AD1D10FBE0073606383D2091F8FEE) smtp.auth=contact@parouby.fr X-OVh-ClientIp: 91.175.17.70 From: Pierre-Antoine Rouby To: 46055@debbugs.gnu.org Subject: [PATCH] Add rust lang to etags Date: Mon, 25 Jan 2021 15:33:44 +0100 Message-Id: <20210125143344.21837-1-contact@parouby.fr> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 15495478943056803054 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgdeigecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefrihgvrhhrvgdqtehnthhoihhnvgcutfhouhgshicuoegtohhnthgrtghtsehprghrohhusgihrdhfrheqnecuggftrfgrthhtvghrnhepheelkedukeffgfehkefgvdeiiedtkeeifedvudeiueekhfehkeeiudetjedtiefhnecukfhppedtrddtrddtrddtpdeluddrudejhedrudejrdejtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejheehrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghonhhtrggtthesphgrrhhouhgshidrfhhrpdhrtghpthhtohepgeeitdehheesuggvsggsuhhgshdrghhnuhdrohhrgh X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: eliz@gnu.org, larsi@gnus.org, Pierre-Antoine Rouby X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * lib-src/etags.c (Rust_functions): New function to make tags for rust files. (Rust_help, Rust_suffixes): New constant. * doc/emacs/maintaining.texi (Tag Syntax): Add Rust item. * doc/man/etags.1: Add Rust. --- doc/emacs/maintaining.texi | 4 +++ doc/man/etags.1 | 2 +- lib-src/etags.c | 51 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+), 1 deletion(-) diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index 415815473e..0f96dc65d1 100644 --- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -2639,6 +2639,10 @@ Tag Syntax @item In Ruby code, @code{def} or @code{class} or @code{module} at the beginning of a line generate a tag. Constants also generate tags. + +@item +In Rust code, tags anything defined with @code{fn}, @code{enum}, +@code{struct} or @code{macro_rules!}. @end itemize You can also generate tags based on regexp matching (@pxref{Etags diff --git a/doc/man/etags.1 b/doc/man/etags.1 index c5c15fb182..354f6ca88b 100644 --- a/doc/man/etags.1 +++ b/doc/man/etags.1 @@ -51,7 +51,7 @@ format understood by \&. Both forms of the program understand the syntax of C, Objective C, C++, Java, Fortran, Ada, Cobol, Erlang, Forth, Go, HTML, LaTeX, Emacs Lisp/Common Lisp, Lua, Makefile, Pascal, Perl, -Ruby, PHP, PostScript, Python, Prolog, Scheme and +Ruby, Rust, PHP, PostScript, Python, Prolog, Scheme and most assembler\-like syntaxes. Both forms read the files specified on the command line, and write a tag table (defaults: \fBTAGS\fP for \fBetags\fP, \fBtags\fP for diff --git a/lib-src/etags.c b/lib-src/etags.c index b5c18e0e01..d703183cef 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c @@ -366,6 +366,7 @@ #define xrnew(op, n, m) ((op) = xnrealloc (op, n, (m) * sizeof *(op))) static void Prolog_functions (FILE *); static void Python_functions (FILE *); static void Ruby_functions (FILE *); +static void Rust_entries (FILE *); static void Scheme_functions (FILE *); static void TeX_commands (FILE *); static void Texinfo_nodes (FILE *); @@ -752,6 +753,12 @@ #define STDIN 0x1001 /* returned by getopt_long on --parse-stdin */ static const char *Ruby_interpreters [] = { "ruby", NULL }; +static const char *Rust_suffixes [] = + { "rs", NULL }; +static const char Rust_help [] = + "In Rust code, tags anything defined with 'fn', 'enum', \n\ +'struct' or 'macro_rules!'."; + /* Can't do the `SCM' or `scm' prefix with a version number. */ static const char *Scheme_suffixes [] = { "oak", "sch", "scheme", "SCM", "scm", "SM", "sm", "ss", "t", NULL }; @@ -836,6 +843,7 @@ #define STDIN 0x1001 /* returned by getopt_long on --parse-stdin */ NULL, Python_interpreters }, { "ruby", Ruby_help, Ruby_functions, Ruby_suffixes, Ruby_filenames, Ruby_interpreters }, + { "rust", Rust_help, Rust_entries, Rust_suffixes }, { "scheme", Scheme_help, Scheme_functions, Scheme_suffixes }, { "tex", TeX_help, TeX_commands, TeX_suffixes }, { "texinfo", Texinfo_help, Texinfo_nodes, Texinfo_suffixes }, @@ -5019,6 +5027,49 @@ Ruby_functions (FILE *inf) } } + +/* + * Rust support + * Look for: + * - fn: Function + * - struct: Structure + * - enum: Enumeration + * - macro_rules!: Macro + */ +static void +Rust_entries (FILE *inf) +{ + char *cp, *name; + bool is_func = false; + + LOOP_ON_INPUT_LINES(inf, lb, cp) + { + cp = skip_spaces(cp); + name = cp; + + // Skip 'pub' keyworld + (void)LOOKING_AT (cp, "pub"); + + // Look for define + if ((is_func = LOOKING_AT (cp, "fn")) + || LOOKING_AT (cp, "enum") + || LOOKING_AT (cp, "struct") + || (is_func = LOOKING_AT (cp, "macro_rules!"))) + { + cp = skip_spaces (cp); + name = cp; + + while (!notinname (*cp)) + cp++; + + make_tag (name, cp - name, is_func, + lb.buffer, cp - lb.buffer + 1, + lineno, linecharno); + is_func = false; + } + } +} + /* * PHP support -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 23:20:00 2021 Received: (at 46055) by debbugs.gnu.org; 21 Apr 2021 03:20:00 +0000 Received: from localhost ([127.0.0.1]:56597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ3PD-0005oc-Q8 for submit@debbugs.gnu.org; Tue, 20 Apr 2021 23:19:59 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:39728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ3PC-0005oN-5L for 46055@debbugs.gnu.org; Tue, 20 Apr 2021 23:19:58 -0400 Received: by mail-pg1-f172.google.com with SMTP id s22so7312436pgk.6 for <46055@debbugs.gnu.org>; Tue, 20 Apr 2021 20:19:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=LvOEU7pUQEaWSCguQPQuSOYWVvRLplDifyhG7lRABv8=; b=mEuMe9tGMTncgndr7L6PiYbbMxytalMjPP0Vmbh+yt2Yj8DDw1oGocC6QC8ZkynSG7 OQ1azaEyZU7m9GdAr//u6YWJhCR1/aOUg+zozS4TLTwMYIWRJ5ExN86MT8IYL4QRBlo+ 1qAKWcFzBsoEBUQ87/jb+r4tZnU++w8mNtJMhLKHO8QKsMeIBKzrNUi/evoKxJdVx0GV KJ5DvCtEH9m6LG1QtRGWinVm65o7y1+pN/Fr0ZXGaVPp3PFEnOAp6Az3Y9+XF9WY6QHq cAk6ged7jbsmACRxcRzBm94HxzZuZpSJrRSWLQbB238f1SFpQjRZoCBr1uJa4C9zrlXF B+Yw== X-Gm-Message-State: AOAM530L3fAJytGXDMabxsEw2nZiwYEkXJhG+UX1klx9IdoV2jWDNswJ NN+C63YmJvUisjrL5NpavCAb9X0d9/gQ2PVu8Lc= X-Google-Smtp-Source: ABdhPJxbZGio2cb3AbNRrXoLsrRwsol6Pw/ZXXN83mOx/xtLEOfr7RjIPAky7FM+8h2ybUssth9UdnW3bLAm+JXfPJE= X-Received: by 2002:a17:90b:19ca:: with SMTP id nm10mr8617432pjb.175.1618975192600; Tue, 20 Apr 2021 20:19:52 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Apr 2021 22:19:52 -0500 From: Stefan Kangas In-Reply-To: <878s8hpbts.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 25 Jan 2021 11:09:35 +0100") References: <20210123190143.29246-1-contact@parouby.fr> <87im7ntoeb.fsf@gnus.org> <83im7n4d2j.fsf@gnu.org> <878s8hpbts.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 20 Apr 2021 22:19:52 -0500 Message-ID: Subject: Re: bug#46055: [PATCH] Add rust lang to etags To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 46055 Cc: Eli Zaretskii , parouby , 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > parouby writes: > >>>> This patch is too big to apply without an FSF copyright assignment, >>>> though. Would you be willing to sign such paperwork? >> >> Yes, no problem, who can I sign it ? > > Great; here's the form to get started: That was 12 weeks ago. Is this copyright assignment all processed and finished now? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 04:54:59 2021 Received: (at 46055) by debbugs.gnu.org; 21 Apr 2021 08:54:59 +0000 Received: from localhost ([127.0.0.1]:56955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ8dP-00069W-DH for submit@debbugs.gnu.org; Wed, 21 Apr 2021 04:54:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ8dO-00069D-Cd for 46055@debbugs.gnu.org; Wed, 21 Apr 2021 04:54:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52644) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZ8dI-0006Zt-7L; Wed, 21 Apr 2021 04:54:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1241 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lZ8dH-0004Nt-Fu; Wed, 21 Apr 2021 04:54:52 -0400 Date: Wed, 21 Apr 2021 11:54:40 +0300 Message-Id: <83im4gqapb.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 20 Apr 2021 22:19:52 -0500) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210123190143.29246-1-contact@parouby.fr> <87im7ntoeb.fsf@gnus.org> <83im7n4d2j.fsf@gnu.org> <878s8hpbts.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46055 Cc: larsi@gnus.org, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 20 Apr 2021 22:19:52 -0500 > Cc: parouby , Eli Zaretskii , 46055@debbugs.gnu.org > > >>>> This patch is too big to apply without an FSF copyright assignment, > >>>> though. Would you be willing to sign such paperwork? > >> > >> Yes, no problem, who can I sign it ? > > > > Great; here's the form to get started: > > That was 12 weeks ago. Is this copyright assignment all processed and > finished now? Yes, the assignment is on file now. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 08:39:51 2021 Received: (at 46055) by debbugs.gnu.org; 21 Apr 2021 12:39:51 +0000 Received: from localhost ([127.0.0.1]:57147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZC90-00061k-N7 for submit@debbugs.gnu.org; Wed, 21 Apr 2021 08:39:51 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:33385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZC8y-00061X-Ul for 46055@debbugs.gnu.org; Wed, 21 Apr 2021 08:39:49 -0400 Received: by mail-pl1-f169.google.com with SMTP id n10so10423651plc.0 for <46055@debbugs.gnu.org>; Wed, 21 Apr 2021 05:39:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=9nB9scLbDhki4Ry97VDBVMuENM8g/HfU+LZsQc6sLFI=; b=GCbiOrk1ujhuDyFPOrYyDoS+YvU/O/oYv5A7/jnSN2EmLR6dkGRuL2y7Wd64a1goVu NvvA3J1xM2mU/fOerd7p37wzHo7ke3ie5QITp5AQF7EXQ/5/6ZcHYuFSKXlWZvAeT286 hxOUVqRTXCzRDBYx/ZLRO/xvra4ts7xZZUGq+9jslagDeqlRj5EbS3oryrXlRMAtH2/s hV5hdn0hvtoGcLo5CF+ZaKshBJMwVIOYnbVfMc55hZgRIygF0EwLnpDj9GyEvD054qCR t4Tn9fwsf0b16UGKV/C/VcS9oQ2nTkqpXXyo241CmujYjOLPVcW1OnjXfwrQDrefe9qz E0zQ== X-Gm-Message-State: AOAM532UMqbmBsVC34UliycyuFujRuCA8lG7cPUhoP/ZOqlFk7C1a37Q O9G3gH/3IxEyVyOh3iw45MsCYxdZ8gQDQ7vW9h4= X-Google-Smtp-Source: ABdhPJzzEZ1z1s6pE0WInovbI/H5FwYwOaN/9BcBCW6Hg/MLS2KMw4s/rWcs6xPOibxnFqD9ytlcxbFRvWb5liqonL4= X-Received: by 2002:a17:902:e9c4:b029:eb:4626:feba with SMTP id 4-20020a170902e9c4b02900eb4626febamr34791580plk.39.1619008783110; Wed, 21 Apr 2021 05:39:43 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 21 Apr 2021 07:39:42 -0500 From: Stefan Kangas In-Reply-To: <20210125143344.21837-1-contact@parouby.fr> (Pierre-Antoine Rouby's message of "Mon, 25 Jan 2021 15:33:44 +0100") References: <20210125143344.21837-1-contact@parouby.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 21 Apr 2021 07:39:42 -0500 Message-ID: Subject: Re: bug#46055: [PATCH] Add rust lang to etags To: Pierre-Antoine Rouby Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 46055 Cc: eliz@gnu.org, larsi@gnus.org, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Your patch looks good to me, but I didn't test it. I have one question, though. In "test/manual/etags", we have manual tests for etags including source code examples and which tags they should generate. Should we add a manual test also for Rust? Pierre-Antoine Rouby writes: > * lib-src/etags.c (Rust_functions): New function to make tags for rust > files. > (Rust_help, Rust_suffixes): New constant. > * doc/emacs/maintaining.texi (Tag Syntax): Add Rust item. > * doc/man/etags.1: Add Rust. > --- > doc/emacs/maintaining.texi | 4 +++ > doc/man/etags.1 | 2 +- > lib-src/etags.c | 51 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+), 1 deletion(-) > > diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi > index 415815473e..0f96dc65d1 100644 > --- a/doc/emacs/maintaining.texi > +++ b/doc/emacs/maintaining.texi > @@ -2639,6 +2639,10 @@ Tag Syntax > @item > In Ruby code, @code{def} or @code{class} or @code{module} at the > beginning of a line generate a tag. Constants also generate tags. > + > +@item > +In Rust code, tags anything defined with @code{fn}, @code{enum}, > +@code{struct} or @code{macro_rules!}. > @end itemize > > You can also generate tags based on regexp matching (@pxref{Etags > diff --git a/doc/man/etags.1 b/doc/man/etags.1 > index c5c15fb182..354f6ca88b 100644 > --- a/doc/man/etags.1 > +++ b/doc/man/etags.1 > @@ -51,7 +51,7 @@ format understood by > \&. Both forms of the program understand > the syntax of C, Objective C, C++, Java, Fortran, Ada, Cobol, Erlang, > Forth, Go, HTML, LaTeX, Emacs Lisp/Common Lisp, Lua, Makefile, Pascal, P= erl, > -Ruby, PHP, PostScript, Python, Prolog, Scheme and > +Ruby, Rust, PHP, PostScript, Python, Prolog, Scheme and > most assembler\-like syntaxes. > Both forms read the files specified on the command line, and write a tag > table (defaults: \fBTAGS\fP for \fBetags\fP, \fBtags\fP for > diff --git a/lib-src/etags.c b/lib-src/etags.c > index b5c18e0e01..d703183cef 100644 > --- a/lib-src/etags.c > +++ b/lib-src/etags.c > @@ -366,6 +366,7 @@ #define xrnew(op, n, m) ((op) =3D xnrealloc (op, n, (= m) * sizeof *(op))) > static void Prolog_functions (FILE *); > static void Python_functions (FILE *); > static void Ruby_functions (FILE *); > +static void Rust_entries (FILE *); > static void Scheme_functions (FILE *); > static void TeX_commands (FILE *); > static void Texinfo_nodes (FILE *); > @@ -752,6 +753,12 @@ #define STDIN 0x1001 /* returned by getopt_long on = --parse-stdin */ > static const char *Ruby_interpreters [] =3D > { "ruby", NULL }; > > +static const char *Rust_suffixes [] =3D > + { "rs", NULL }; > +static const char Rust_help [] =3D > + "In Rust code, tags anything defined with 'fn', 'enum', \n\ > +'struct' or 'macro_rules!'."; > + > /* Can't do the `SCM' or `scm' prefix with a version number. */ > static const char *Scheme_suffixes [] =3D > { "oak", "sch", "scheme", "SCM", "scm", "SM", "sm", "ss", "t", NULL }; > @@ -836,6 +843,7 @@ #define STDIN 0x1001 /* returned by getopt_long on -= -parse-stdin */ > NULL, Python_interpreters }, > { "ruby", Ruby_help, Ruby_functions, Ruby_suffixes, > Ruby_filenames, Ruby_interpreters }, > + { "rust", Rust_help, Rust_entries, Rust_suffixes }= , > { "scheme", Scheme_help, Scheme_functions, Scheme_suffixes }= , > { "tex", TeX_help, TeX_commands, TeX_suffixes }= , > { "texinfo", Texinfo_help, Texinfo_nodes, Texinfo_suffixes }= , > @@ -5019,6 +5027,49 @@ Ruby_functions (FILE *inf) > } > } > > +=0C > +/* > + * Rust support > + * Look for: > + * - fn: Function > + * - struct: Structure > + * - enum: Enumeration > + * - macro_rules!: Macro > + */ > +static void > +Rust_entries (FILE *inf) > +{ > + char *cp, *name; > + bool is_func =3D false; > + > + LOOP_ON_INPUT_LINES(inf, lb, cp) > + { > + cp =3D skip_spaces(cp); > + name =3D cp; > + > + // Skip 'pub' keyworld > + (void)LOOKING_AT (cp, "pub"); > + > + // Look for define > + if ((is_func =3D LOOKING_AT (cp, "fn")) > + || LOOKING_AT (cp, "enum") > + || LOOKING_AT (cp, "struct") > + || (is_func =3D LOOKING_AT (cp, "macro_rules!"))) > + { > + cp =3D skip_spaces (cp); > + name =3D cp; > + > + while (!notinname (*cp)) > + cp++; > + > + make_tag (name, cp - name, is_func, > + lb.buffer, cp - lb.buffer + 1, > + lineno, linecharno); > + is_func =3D false; > + } > + } > +} > + > =0C > /* > * PHP support From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 11:02:30 2021 Received: (at 46055) by debbugs.gnu.org; 21 Apr 2021 15:02:30 +0000 Received: from localhost ([127.0.0.1]:59397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZEN0-0003l8-73 for submit@debbugs.gnu.org; Wed, 21 Apr 2021 11:02:30 -0400 Received: from plesklin7.if2.ehiweb.it ([79.98.45.17]:59605 helo=plesklin7.if1.ehiweb.it) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZEMu-0003ku-GW for 46055@debbugs.gnu.org; Wed, 21 Apr 2021 11:02:24 -0400 Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by plesklin7.if1.ehiweb.it (Postfix) with ESMTPSA id 20D6710832D; Wed, 21 Apr 2021 17:02:18 +0200 (CEST) Message-Id: <87im4fvfye.fsf@tucano.isti.cnr.it> From: =?utf-8?Q?Francesco_Potort=C3=AC?= Date: Wed, 21 Apr 2021 17:02:17 +0200 To: Stefan Kangas In-Reply-To: (stefan@marxist.se) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> Organization: The GNU project X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-PPP-Message-ID: <20210421150218.1256.42066@plesklin7.if1.ehiweb.it> X-PPP-Vhost: potorti.it X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >I have one question, though. In "test/manual/etags", we have manual >tests for etags including source code examples and which tags they >should generate. Should we add a manual test also for Rust? I'd say definitely yes. Ideally, the regression tests should be updated every time a new feature is added or a bug is corrected. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [79.98.45.17 listed in wl.mailspike.net] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 46055 Cc: larsi@gnus.org, Pierre-Antoine Rouby , 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >I have one question, though. In "test/manual/etags", we have manual >tests for etags including source code examples and which tags they >should generate. Should we add a manual test also for Rust? I'd say definitely yes. Ideally, the regression tests should be updated every time a new feature is added or a bug is corrected. From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 11:21:52 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 15:21:52 +0000 Received: from localhost ([127.0.0.1]:53535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif42-0002in-31 for submit@debbugs.gnu.org; Mon, 17 May 2021 11:21:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif3w-0002iO-3E for 46055@debbugs.gnu.org; Mon, 17 May 2021 11:21:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Wx9nOHKhQqGEtdboL1bwlkudLXeUTVHpwSub8Q09bs=; b=bMfTEwtkh/6CG46yk0MSvo/fxS MfRujpXnmlqASxxDZCOHEEaF1pzifQgMEUskBVqi0YuFozFm3+2XdGWM2LUUxoZ3UkCzfJNZEzR2w x+B9/zlbQiuz54enmKbdmvRm1bZ0tVo839DRsIhWCsNI34AEVhoWJ8uVLN2YmBtTSnJo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lif3n-0000rJ-7J; Mon, 17 May 2021 17:21:37 +0200 From: Lars Ingebrigtsen To: Pierre-Antoine Rouby Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> X-Now-Playing: d'Eon's _LP_: "Transparency Pt. IV" Date: Mon, 17 May 2021 17:21:31 +0200 In-Reply-To: <20210125143344.21837-1-contact@parouby.fr> (Pierre-Antoine Rouby's message of "Mon, 25 Jan 2021 15:33:44 +0100") Message-ID: <87wnrxidxg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pierre-Antoine Rouby writes: > * lib-src/etags.c (Rust_functions): New function to make tags for rust > files. > (Rust_help, Rust_suffixes): New constant. > * doc/emacs/maintaining.texi (Tag Syntax): Add Rust item. > * doc/man/et [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: eliz@gnu.org, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pierre-Antoine Rouby writes: > * lib-src/etags.c (Rust_functions): New function to make tags for rust > files. > (Rust_help, Rust_suffixes): New constant. > * doc/emacs/maintaining.texi (Tag Syntax): Add Rust item. > * doc/man/etags.1: Add Rust. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 11:24:01 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 15:24:01 +0000 Received: from localhost ([127.0.0.1]:53541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif65-0002mO-Jr for submit@debbugs.gnu.org; Mon, 17 May 2021 11:24:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif60-0002m5-Rh for 46055@debbugs.gnu.org; Mon, 17 May 2021 11:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f2VhUz+t6XTtspNLZKf7VdbC71HMculFR0gI2zc3uGA=; b=qvPq1cblAknRjSNp9bjHiD1BFD dax4Q+ja/cZCQI9NdvK0RMSGU2pdQNUjKcLR7g/3cKSpydxWH5iGyqmHnHblMyW4OThK1bJW29nPR 2IX3golI08rNLvEMsqulss+OUHCnwtVOdtSwbwe3/hz30Mg9Xnv/SiMeRYsL+Nf2NozQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lif5s-0000rn-It; Mon, 17 May 2021 17:23:46 +0200 From: Lars Ingebrigtsen To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> X-Now-Playing: d'Eon's _LP_: "Transparency Pt. IV" Date: Mon, 17 May 2021 17:23:44 +0200 In-Reply-To: <87im4fvfye.fsf@tucano.isti.cnr.it> ("Francesco =?utf-8?Q?Pot?= =?utf-8?Q?ort=C3=AC=22's?= message of "Wed, 21 Apr 2021 17:02:17 +0200") Message-ID: <87sg2lidtr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Francesco Potortì writes: >>I have one question, though. In "test/manual/etags", we have manual >>tests for etags including source code examples and which tags they >>should generate. Should we add a manual test also for Rust? [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: Stefan Kangas , Pierre-Antoine Rouby , 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Francesco Potort=C3=AC writes: >>I have one question, though. In "test/manual/etags", we have manual >>tests for etags including source code examples and which tags they >>should generate. Should we add a manual test also for Rust? > > I'd say definitely yes. Ideally, the regression tests should be updated > every time a new feature is added or a bug is corrected. I looked into adding a Rust test there... but it's unclear how, or what it's checking. A "make check" in that directory fails. I looked in admin/* for an explanation of what's supposed to be done in test/manual/etags, but found nothing. Perhaps a README should be added to that directory to explain how to use it? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 11:24:01 2021 Received: (at control) by debbugs.gnu.org; 17 May 2021 15:24:01 +0000 Received: from localhost ([127.0.0.1]:53544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif69-0002ma-5M for submit@debbugs.gnu.org; Mon, 17 May 2021 11:24:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif67-0002mE-El for control@debbugs.gnu.org; Mon, 17 May 2021 11:24:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ft9Y77t359oTLgfXgGTRVlxwWe0xDz/rbpERnCTQo0E=; b=KFBmfKt4vs3hWRI3es/ussoEEw CCWfmB0KKPOLbYGyWWJV117YYyoB0pgvM0w025yv30kKlLRQnZmp73F+oEV9MFU1eOofLNU/WHZdD H35z+LeXTg8dchC8ZgXvEke/2XmIZPabFh8f14ekEgvdPmwdDhteTqXzMHCRVLJCUJOg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lif60-0000ru-2U for control@debbugs.gnu.org; Mon, 17 May 2021 17:23:53 +0200 Date: Mon, 17 May 2021 17:23:51 +0200 Message-Id: <87r1i5idtk.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46055 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 46055 - patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46055 - patch quit From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 11:52:05 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 15:52:05 +0000 Received: from localhost ([127.0.0.1]:53595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifXJ-0007tZ-J5 for submit@debbugs.gnu.org; Mon, 17 May 2021 11:52:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifXH-0007sx-8H for 46055@debbugs.gnu.org; Mon, 17 May 2021 11:52:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48468) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lifX9-0003Zd-Ci; Mon, 17 May 2021 11:51:57 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1890 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lifX6-0000Ey-Rj; Mon, 17 May 2021 11:51:54 -0400 Date: Mon, 17 May 2021 18:51:55 +0300 Message-Id: <834kf1tl2c.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87sg2lidtr.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 17:23:44 +0200) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Mon, 17 May 2021 17:23:44 +0200 > Cc: Stefan Kangas , > Pierre-Antoine Rouby , 46055@debbugs.gnu.org > > Francesco Potortì writes: > > >>I have one question, though. In "test/manual/etags", we have manual > >>tests for etags including source code examples and which tags they > >>should generate. Should we add a manual test also for Rust? > > > > I'd say definitely yes. Ideally, the regression tests should be updated > > every time a new feature is added or a bug is corrected. > > I looked into adding a Rust test there... but it's unclear how, or what > it's checking. A "make check" in that directory fails. I looked in > admin/* for an explanation of what's supposed to be done in > test/manual/etags, but found nothing. > > Perhaps a README should be added to that directory to explain how to use > it? Just say "make" in that directory, it should finish with no errors. From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 12:08:19 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 16:08:19 +0000 Received: from localhost ([127.0.0.1]:53651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifn1-0008Pl-Jw for submit@debbugs.gnu.org; Mon, 17 May 2021 12:08:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifn0-0008PY-1r for 46055@debbugs.gnu.org; Mon, 17 May 2021 12:08:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/FiWl4l3D5hPmeKbyUv1EU2SDf7AxVi0+SZGTKvC3jU=; b=PwIRnruWJAvj2hShXVGbRyUVoQ IQxOxgrtWBi5K1MosnS/Xyfr9NSBryAdcnA53YFNxronphjKRJsL1dqt49K13YWjMDRnbWgdVJwoF Bb4Ilb4i/uu5HKt91Bau11l0Mul+cf5GgFEkTL9pLj62hu+6lMbM/5EpD19LDhowZsUI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lifmr-0001nW-Na; Mon, 17 May 2021 18:08:12 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUdGRmAfX/v6uql n6BdWlz///99uy98AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UFERAHGZ0UAmwAAAFsSURBVDjLdZML koMwCIZxywE2mgNsQw/QBA+gDfc/05JgoraV0RnI1/DzsDCEarTAQLPIAs02MOtJ9rKyfwNRXfQi KZA/3yi+iBPHZOluBmqAwhybjN2g6uPK7bIGFTzMz2QFVhsPYOJ+G7CCvw2kEmz1TsV/mh4XcN+A 7CBX8AsHdQNr0Xj0oezAKeB9XJxjrGNAp+25tYMMi0jN5KYZMnWASxmG1hS98wsIHE2yNuG8eCc2 tHYuThXUxJJm02QNncN+rD+s4BWi1zWodgPYgO5aweAbELfYeBXMuWy2xKhg2kCU2lX/RvpCZi2q glMLOvcOetM150TeqhBB04C2Ty9bvycAa9zKfJPQDGLZ0STw+QEs/mlLxwY2GwkO5ABS2H086OL+ nZxtoPT8Cm7+CsgFWJcrAON3gNfglegrgTReAL6VDvnTAidmCBcGofxRQ0qpvKQWkgFqoBAN7pRI UeqpUn3IvHKDLzT+AfKNWZq+bhFkAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTE3VDE2OjA3 OjI0KzAwOjAwNj26AgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xN1QxNjowNzoyNCswMDow MEdgAr4AAAAASUVORK5CYII= X-Now-Playing: Tied + Tickled Trio's _Aelita_: "Aelita 1" Date: Mon, 17 May 2021 18:08:09 +0200 In-Reply-To: <834kf1tl2c.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 18:51:55 +0300") Message-ID: <87y2cdgx7a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Just say "make" in that directory, it should finish with no errors. If I do that, I get an enormous diff in the terminal, and it then finishes with: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Just say "make" in that directory, it should finish with no errors. If I do that, I get an enormous diff in the terminal, and it then finishes with: y-src/parse.c,520 #define YYBISON 4,64 make[1]: *** [Makefile:63: ediff_1] Error 1 make[1]: Leaving directory '/home/larsi/src/emacs/trunk/test/manual/etags' make: *** [Makefile:54: check] Error 2 -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 12:14:41 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 16:14:41 +0000 Received: from localhost ([127.0.0.1]:53669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liftB-00007y-2y for submit@debbugs.gnu.org; Mon, 17 May 2021 12:14:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lift9-00007j-6h for 46055@debbugs.gnu.org; Mon, 17 May 2021 12:14:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50068) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lift3-00007a-4L; Mon, 17 May 2021 12:14:33 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lift2-00065m-Ek; Mon, 17 May 2021 12:14:32 -0400 Date: Mon, 17 May 2021 19:14:34 +0300 Message-Id: <831ra5tk0l.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87y2cdgx7a.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 18:08:09 +0200) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, > 46055@debbugs.gnu.org > Date: Mon, 17 May 2021 18:08:09 +0200 > > Eli Zaretskii writes: > > > Just say "make" in that directory, it should finish with no errors. > > If I do that, I get an enormous diff in the terminal, and it then > finishes with: > > y-src/parse.c,520 > #define YYBISON 4,64 > make[1]: *** [Makefile:63: ediff_1] Error 1 > make[1]: Leaving directory '/home/larsi/src/emacs/trunk/test/manual/etags' > make: *** [Makefile:54: check] Error 2 Try again, I just fixed this. The problem is that people make mechanic changes to all our sources, and forget that files in this particular directory shall NOT be changed, or else if they are, the '*good*' files with expected results should be updated at that very moment. Examples of such changes include: yearly update of copyright years, removal of obsolete variables across the board, spelling fixes, etc. Just do git log test/manual/etags/c-src/abbrev.c and you will see what I mean. Each such change breaks this test suite, and requires manual inspection of the diffs to convince ourselves that the new results are correct and not bugs. From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 12:27:57 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 16:27:57 +0000 Received: from localhost ([127.0.0.1]:53695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lig61-0002dK-7T for submit@debbugs.gnu.org; Mon, 17 May 2021 12:27:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lig5t-0002cl-33 for 46055@debbugs.gnu.org; Mon, 17 May 2021 12:27:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J0LrYB7b482SAJL8I8Tf1DXA2toPIcUmA5+riOCgKME=; b=FDeyX8mZQaBDwSrjyvNhyuYUlw PTmprFjzZNNI3LCyOrLdaMDcH3+FMjbohgD6BSQoL1J0zFxANb2StmS757ztTxFrbXMpwktwHsZVj WAsYNX1OWNBBV+kOxbNQnYXu39g/4Xe67uoF714LfC9hVLWB6IrF40E4zbaItKAfi52M=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lig5j-00029I-SQ; Mon, 17 May 2021 18:27:42 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> <831ra5tk0l.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUdGRmAfX/v6uql n6BdWlz///99uy98AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UFERAHGZ0UAmwAAAFsSURBVDjLdZML koMwCIZxywE2mgNsQw/QBA+gDfc/05JgoraV0RnI1/DzsDCEarTAQLPIAs02MOtJ9rKyfwNRXfQi KZA/3yi+iBPHZOluBmqAwhybjN2g6uPK7bIGFTzMz2QFVhsPYOJ+G7CCvw2kEmz1TsV/mh4XcN+A 7CBX8AsHdQNr0Xj0oezAKeB9XJxjrGNAp+25tYMMi0jN5KYZMnWASxmG1hS98wsIHE2yNuG8eCc2 tHYuThXUxJJm02QNncN+rD+s4BWi1zWodgPYgO5aweAbELfYeBXMuWy2xKhg2kCU2lX/RvpCZi2q glMLOvcOetM150TeqhBB04C2Ty9bvycAa9zKfJPQDGLZ0STw+QEs/mlLxwY2GwkO5ABS2H086OL+ nZxtoPT8Cm7+CsgFWJcrAON3gNfglegrgTReAL6VDvnTAidmCBcGofxRQ0qpvKQWkgFqoBAN7pRI UeqpUn3IvHKDLzT+AfKNWZq+bhFkAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTE3VDE2OjA3 OjI0KzAwOjAwNj26AgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xN1QxNjowNzoyNCswMDow MEdgAr4AAAAASUVORK5CYII= X-Now-Playing: Tied + Tickled Trio's _Aelita_: "Aelita 2" Date: Mon, 17 May 2021 18:27:39 +0200 In-Reply-To: <831ra5tk0l.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 19:14:34 +0300") Message-ID: <87tun1gwas.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > The problem is that people make mechanic changes to all our sources, > and forget that files in this particular directory shall NOT be > changed, or else if they are, the '*good*' files with expecte [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > The problem is that people make mechanic changes to all our sources, > and forget that files in this particular directory shall NOT be > changed, or else if they are, the '*good*' files with expected results > should be updated at that very moment. Examples of such changes > include: yearly update of copyright years, removal of obsolete > variables across the board, spelling fixes, etc. Just do > > git log test/manual/etags/c-src/abbrev.c > > and you will see what I mean. Yes, I was most puzzled when trying to find out just what was going on in that directory. I wondered whether the test cases were somehow... copying files from the main Emacs source directories (since many of them have the same names and are updated in this way). > Each such change breaks this test suite, and requires manual > inspection of the diffs to convince ourselves that the new results are > correct and not bugs. Yup. So I think a README to explain what's going on in that directory would be helpful. :-) I've now added a test case for Rust. (Note: I don't know Rust at all.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 12:27:57 2021 Received: (at control) by debbugs.gnu.org; 17 May 2021 16:27:57 +0000 Received: from localhost ([127.0.0.1]:53697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lig61-0002dO-JP for submit@debbugs.gnu.org; Mon, 17 May 2021 12:27:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lig5z-0002cw-QT for control@debbugs.gnu.org; Mon, 17 May 2021 12:27:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KvrUZ+6SL4o6EVMEvooY9qNB/oFRTJi/WjNXcROoGP8=; b=M4sjJ8pxMVD7B+qnh9GRK8LFIg 4AGn0EvgW7V2r90LWEqDfh5Pi4VhPWw9xQo3EA6Fm1ucS8iFR1CMll/mIMlIKHoSMTq8mhJalnN+R gCKRfzwDORR7+lbeDlQo8Wcg14zAonu0La/B3Uo3M9+uBEAuwqR1QXgjLXFLio4RYynk=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lig5s-00029T-Dq for control@debbugs.gnu.org; Mon, 17 May 2021 18:27:50 +0200 Date: Mon, 17 May 2021 18:27:47 +0200 Message-Id: <87sg2lgwak.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46055 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 46055 fixed close 46055 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46055 fixed close 46055 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 12:32:04 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 16:32:04 +0000 Received: from localhost ([127.0.0.1]:53710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ligA0-0004SY-F5 for submit@debbugs.gnu.org; Mon, 17 May 2021 12:32:04 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lig9y-0004MY-EI for 46055@debbugs.gnu.org; Mon, 17 May 2021 12:32:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PRqlCCPp9AQn89yvFxCGLuBF+n1T5A6Ks8naIse7BNY=; b=Yu48P+9W3rVq1bWDu+CoVelPhr xp9NoDfxlDbj9UUDAEGRGHjJccIjTbQymXb9BiltHHG8/pUrZzapiilT7USP75CBweBwmhnb14I8B 4sBtYo+XVQM9MccUVIakZ2GAgaO9dnMUrA1BND20jMJnyG95v//kpcoPzN2NydxjiFIE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lig9q-0002Bk-8M; Mon, 17 May 2021 18:31:56 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> <831ra5tk0l.fsf@gnu.org> <87tun1gwas.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUdGRmAfX/v6uql n6BdWlz///99uy98AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UFERAHGZ0UAmwAAAFsSURBVDjLdZML koMwCIZxywE2mgNsQw/QBA+gDfc/05JgoraV0RnI1/DzsDCEarTAQLPIAs02MOtJ9rKyfwNRXfQi KZA/3yi+iBPHZOluBmqAwhybjN2g6uPK7bIGFTzMz2QFVhsPYOJ+G7CCvw2kEmz1TsV/mh4XcN+A 7CBX8AsHdQNr0Xj0oezAKeB9XJxjrGNAp+25tYMMi0jN5KYZMnWASxmG1hS98wsIHE2yNuG8eCc2 tHYuThXUxJJm02QNncN+rD+s4BWi1zWodgPYgO5aweAbELfYeBXMuWy2xKhg2kCU2lX/RvpCZi2q glMLOvcOetM150TeqhBB04C2Ty9bvycAa9zKfJPQDGLZ0STw+QEs/mlLxwY2GwkO5ABS2H086OL+ nZxtoPT8Cm7+CsgFWJcrAON3gNfglegrgTReAL6VDvnTAidmCBcGofxRQ0qpvKQWkgFqoBAN7pRI UeqpUn3IvHKDLzT+AfKNWZq+bhFkAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTE3VDE2OjA3 OjI0KzAwOjAwNj26AgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xN1QxNjowNzoyNCswMDow MEdgAr4AAAAASUVORK5CYII= X-Now-Playing: Tied + Tickled Trio's _Aelita_: "A Rocket Debris Cloud Drifts" Date: Mon, 17 May 2021 18:31:53 +0200 In-Reply-To: <87tun1gwas.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 17 May 2021 18:27:39 +0200") Message-ID: <87o8d9gw3q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I've now added a test case for Rust. I spoke too soon -- I guessed that ETAGS.good_1 was to be copied over from ETAGS after saying "make", but I have no idea what the other good_* files are supposed to be, so now "make" complains again. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I've now added a test case for Rust. I spoke too soon -- I guessed that ETAGS.good_1 was to be copied over from ETAGS after saying "make", but I have no idea what the other good_* files are supposed to be, so now "make" complains again. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 12:41:02 2021 Received: (at 46055) by debbugs.gnu.org; 17 May 2021 16:41:02 +0000 Received: from localhost ([127.0.0.1]:53718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ligIg-0005Bf-IV for submit@debbugs.gnu.org; Mon, 17 May 2021 12:41:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ligIe-0005B4-Gu for 46055@debbugs.gnu.org; Mon, 17 May 2021 12:41:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51188) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ligIX-0001g5-1g; Mon, 17 May 2021 12:40:54 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1036 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ligIS-0002wl-0K; Mon, 17 May 2021 12:40:49 -0400 Date: Mon, 17 May 2021 19:40:50 +0300 Message-Id: <83zgwts48d.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87o8d9gw3q.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 18:31:53 +0200) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> <831ra5tk0l.fsf@gnu.org> <87tun1gwas.fsf@gnus.org> <87o8d9gw3q.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, > 46055@debbugs.gnu.org > Date: Mon, 17 May 2021 18:31:53 +0200 > > Lars Ingebrigtsen writes: > > > I've now added a test case for Rust. > > I spoke too soon -- I guessed that ETAGS.good_1 was to be copied over > from ETAGS after saying "make", but I have no idea what the other good_* > files are supposed to be, so now "make" complains again. The test suite uses the same source files for 7 different runs, each time invoking etags with different command-line switches. So whenever you add a new source file, you need to run make, and each time it fails, copy the left-over ETAGS file into ETAGS.good_1, ETAGS.good_2, etc., one by one. Which I just did. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 09:45:05 2021 Received: (at 46055) by debbugs.gnu.org; 18 May 2021 13:45:05 +0000 Received: from localhost ([127.0.0.1]:54713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj01x-0001dx-BW for submit@debbugs.gnu.org; Tue, 18 May 2021 09:45:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj01v-0001a9-QJ for 46055@debbugs.gnu.org; Tue, 18 May 2021 09:45:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dTOJM2Sum/Dz4EM6llVtSeHPMON5wxWu96B4czXBc0o=; b=Z7p/l5ipDr2uuoQXRcyLluOC4A PwlVhdegwXKbvmBUi8tpe3Y6ExLeJoaE3Pb1nIWUoBErGTMWkvq4QBr4/OXFmyGyQRromivUTFEaz TQEAVOgGQxUD7fmtFFDRE0mnlksjThFqCUu4l8l35cIe2E7FMn5zXplzVdKCxAGhtsVM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj01n-0005jf-1z; Tue, 18 May 2021 15:44:57 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> <831ra5tk0l.fsf@gnu.org> <87tun1gwas.fsf@gnus.org> <87o8d9gw3q.fsf@gnus.org> <83zgwts48d.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX6+vrPz9GenZ9+ foE6OTn///+yF5QpAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UFEg0sBfkuPIcAAAGWSURBVDjLfZOB seMwCERR0oCRXUCEUkAsKODO0H9Nhyw7X5b/HJPJZPy0sKwVgLMiJeTMK4QJLhUookihGF9X4BIS +7NQnEbAbPY3xjAqMDvQkCANAGYWNUyANyDmkhRviqfVKnQD8K6AqYy2IOwA6RXy4KwOYY7E8rmC pQJV2cYlg0vENn7dpszu1xJ7lHCXuIJvxtD2+cbDcHioE3U29JqFt1gVWvr+eVoMFcUd5x48yxQ8 +Zq9G+j7+Kki1qqf8WCMZU9LlPuEn0w1XtXsgLvZRJj9OXE2fVt3F+Y1UDa/Kb6JdADzBJ43t/H6 0+mxBSQ+XXVgKa9nyXdANqusHrtbuoC8xbeVaqu1a089fdlwqa+v3tOq8ebJP+jR0X6yfq2+KARW SJ7FObXu4OsYoOfJKWQ6SRItVYFZa/6aTuBvyUUGKR/v8turFSTes6H13SZ8wR7156Er6lWR93Ox NW7/gwbmr83zR3PuGZH9VrC32O+GXXzB0WI7gXyBWZ2v+dbKNjkiOoTnHpdz+h9wDIEy+jzAP/Dc p2cJ7hFvAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTE4VDEzOjQ0OjA1KzAwOjAwGkSqYwAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xOFQxMzo0NDowNSswMDowMGsZEt8AAAAASUVORK5C YII= X-Now-Playing: MoE & Pinquins's _Vi som elsket kaos_: =?utf-8?Q?=22Bj?= =?utf-8?Q?=C3=B8rnenes?= inntogsmarsj" Date: Tue, 18 May 2021 15:44:50 +0200 In-Reply-To: <83zgwts48d.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 19:40:50 +0300") Message-ID: <87im3gf965.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > The test suite uses the same source files for 7 different runs, each > time invoking etags with different command-line switches. So whenever > you add a new source file, you need to run make, and ea [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > The test suite uses the same source files for 7 different runs, each > time invoking etags with different command-line switches. So whenever > you add a new source file, you need to run make, and each time it > fails, copy the left-over ETAGS file into ETAGS.good_1, ETAGS.good_2, > etc., one by one. Ah, I see. Putting this info in a README in that directory would be helpful for the next person who wonders how it works, though. > Which I just did. Thanks. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 20 06:04:01 2021 Received: (at 46055) by debbugs.gnu.org; 20 May 2021 10:04:01 +0000 Received: from localhost ([127.0.0.1]:33166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljfX7-0006Pd-0i for submit@debbugs.gnu.org; Thu, 20 May 2021 06:04:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljfX5-0006PO-6D for 46055@debbugs.gnu.org; Thu, 20 May 2021 06:04:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53926) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljfWy-0006jN-3T; Thu, 20 May 2021 06:03:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2707 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljfWv-0002wf-S4; Thu, 20 May 2021 06:03:50 -0400 Date: Thu, 20 May 2021 13:03:58 +0300 Message-Id: <83y2c9oh69.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87im3gf965.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 18 May 2021 15:44:50 +0200) Subject: Re: bug#46055: [PATCH] Add rust lang to etags References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> <831ra5tk0l.fsf@gnu.org> <87tun1gwas.fsf@gnus.org> <87o8d9gw3q.fsf@gnus.org> <83zgwts48d.fsf@gnu.org> <87im3gf965.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46055 Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, > 46055@debbugs.gnu.org > Date: Tue, 18 May 2021 15:44:50 +0200 > > Eli Zaretskii writes: > > > The test suite uses the same source files for 7 different runs, each > > time invoking etags with different command-line switches. So whenever > > you add a new source file, you need to run make, and each time it > > fails, copy the left-over ETAGS file into ETAGS.good_1, ETAGS.good_2, > > etc., one by one. > > Ah, I see. Putting this info in a README in that directory would be > helpful for the next person who wonders how it works, though. Done. From unknown Thu Jun 19 16:24:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Jun 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator