GNU bug report logs - #46044
[PATCH] Improvements to handling po files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Subject: bug#46044: closed (Re: bug#46044: [PATCH] Improvements to
 handling po files)
Date: Thu, 28 Jan 2021 16:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#46044: [PATCH] Improvements to handling po files

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 46044 <at> debbugs.gnu.org.

-- 
46044: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46044
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46044-done <at> debbugs.gnu.org
Subject: Re: bug#46044: [PATCH] Improvements to handling po files
Date: Thu, 28 Jan 2021 17:23:22 +0100

Pushed as c891e7c828d21530f110c04dabe70515447c7d67 and
b91165460e71f427c30f22ace02a5d775ecea23d, thank you!

[Message part 3 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Improvements to handling po files
Date: Fri, 22 Jan 2021 21:34:02 +0100

[Message part 4 (text/plain, inline)]

Hi Guix,

here are two patches to improve our handling of po files. Yesterday I
pushed again new po files that were broken, and I didn't notice. The
first patch ensure po files are normalized. The TP automatically
normalized po, but weblate doesn't, using the indent method instead.
This creates huge patches like yesterday. Instead, normalizing ensures
we only see relevant changes.

The second patch adds a check-po target to the Makefile that runs
msgfmt on every po file we have, to make sure they are at least
correct. That's not enough for manual translations, but that can be
spotted easily when running "make". This would have spotted the issues
I introduced yesterday.

[0001-Makefile.am-Normalize-downloaded-po-files.patch (text/x-patch, attachment)]

[0002-Makefile.am-Add-check-po-rule.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.