GNU bug report logs - #46036
fails do build on macos 10.7

Previous Next

Package: emacs;

Reported by: Riccardo Mottola <riccardo.mottola <at> libero.it>

Date: Fri, 22 Jan 2021 14:58:01 UTC

Severity: normal

Done: Alan Third <alan <at> idiocy.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Third <alan <at> idiocy.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46036: closed (fails do build on macos 10.7)
Date: Sat, 30 Jan 2021 22:17:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 30 Jan 2021 22:15:57 +0000
with message-id <YBXancf8dpCPxxYM <at> breton.holly.idiocy.org>
and subject line Re: bug#46036: fails do build on macos 10.7
has caused the debbugs.gnu.org bug report #46036,
regarding fails do build on macos 10.7
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46036: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46036
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Riccardo Mottola <riccardo.mottola <at> libero.it>
To: bug-gnu-emacs <at> gnu.org
Subject: fails do build on macos 10.7
Date: Fri, 22 Jan 2021 15:57:18 +0100
Compilation of 27.1 yields:
nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
  NSNumber *isUbiquitousItem = @YES;
                                ^
/usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
#define YES             (BOOL)1
                         ^

this code is guarded with MacOS 10.7, but the compiler doesn't like it.

It is as easy to write it old-style:
  NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];

and emacs 27.1 happily running on Lion again.

Thanks



[Message part 3 (message/rfc822, inline)]
From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 46036-done <at> debbugs.gnu.org, Riccardo Mottola <riccardo.mottola <at> libero.it>
Subject: Re: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 22:15:57 +0000
On Sat, Jan 30, 2021 at 08:34:00PM +0200, Eli Zaretskii wrote:
> > Cc: 46036 <at> debbugs.gnu.org
> > From: Riccardo Mottola <riccardo.mottola <at> libero.it>
> > Date: Sat, 30 Jan 2021 19:32:17 +0100
> > 
> > > Is this change safe, or will we need another pretest to be sure?  I
> > > thought we could next go straight to a release candidate.
> > 
> > to my knowledge it is safe: it is really equivalent code, the new syntax 
> > is just a shortcut. A test on a newer MacOS is of course needed, I don't 
> > have one.
> 
> Thanks.

I agree that it's safe so I've pushed the change.
-- 
Alan Third


This bug report was last modified 4 years and 111 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.