Subject: Re: bug#46036: fails do build on macos 10.7

From: Eli Zaretskii <[email-masked]>
Date: Sat, 30 Jan 2021 14:05:05 +0200

> Date: Sat, 30 Jan 2021 10:56:59 +0000
> From: Alan Third <[email-masked]>
> Cc: Riccardo Mottola <[email-masked]>, [email-masked]
> 
> On Sat, Jan 30, 2021 at 10:57:20AM +0200, Eli Zaretskii wrote:
> > > Date: Fri, 22 Jan 2021 15:57:18 +0100
> > > From: Riccardo Mottola <[email-masked]>
> > > 
> > > Compilation of 27.1 yields:
> > > nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
> > >    NSNumber *isUbiquitousItem = @YES;
> > >                                  ^
> > > /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> > > #define YES             (BOOL)1
> > >                           ^
> > > 
> > > this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> > > 
> > > It is as easy to write it old-style:
> > >    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> > > 
> > > and emacs 27.1 happily running on Lion again.
> > 
> > Alan, any comments on this?
> 
> Looks fine to me. Is this good to go into Emacs 27, or does it have to
> wait until the release is done?

Please push to emacs-27.

Is this change safe, or will we need another pretest to be sure?  I
thought we could next go straight to a release candidate.

Thanks.