From unknown Mon Jun 23 02:21:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#46031 <46031@debbugs.gnu.org> To: bug#46031 <46031@debbugs.gnu.org> Subject: Status: services: cuirass: Add "simple-cuirass-services". Reply-To: bug#46031 <46031@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:21:30 +0000 retitle 46031 services: cuirass: Add "simple-cuirass-services". reassign 46031 guix-patches submitter 46031 Mathieu Othacehe severity 46031 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 03:51:17 2021 Received: (at submit) by debbugs.gnu.org; 22 Jan 2021 08:51:17 +0000 Received: from localhost ([127.0.0.1]:59988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2sA0-00026p-Rb for submit@debbugs.gnu.org; Fri, 22 Jan 2021 03:51:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:48528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2s9k-00026A-ER for submit@debbugs.gnu.org; Fri, 22 Jan 2021 03:51:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2s9k-0002ut-6k for guix-patches@gnu.org; Fri, 22 Jan 2021 03:51:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59930) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2s9i-0004Fi-PT for guix-patches@gnu.org; Fri, 22 Jan 2021 03:50:59 -0500 Received: from [2a01:e0a:19b:d9a0:98b7:b002:9499:5e2c] (port=53170 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l2s9i-0006SI-CJ for guix-patches@gnu.org; Fri, 22 Jan 2021 03:50:58 -0500 From: Mathieu Othacehe To: guix-patches@gnu.org Subject: services: cuirass: Add "simple-cuirass-services". Date: Fri, 22 Jan 2021 09:50:56 +0100 Message-ID: <87czxxz767.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, Here is a service that provides some syntactic sugar over the (complex) Cuirass configuration. It uses Guix Channels to declare Cuirass inputs. In the future, it would be nice if Cuirass could operate directly on Channels. For now, this service only act as a translation layer for people willing to setup a simple Cuirass instance. Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-services-cuirass-Add-simple-cuirass-services.patch >From 14186c2d6ad7dd5a55f35b1364f34669c1e27a5e Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Fri, 22 Jan 2021 09:44:45 +0100 Subject: [PATCH] services: cuirass: Add "simple-cuirass-services". * gnu/services/cuirass.scm (, ): New records. (build-manifest, build-manifest?, simple-cuirass-configuration, simple-cuirass-configuration?, simple-cuirass-services): New procedures. (%default-cuirass-config): New variable. * doc/guix.texi (Continuous Integration): Document it. Signed-off-by: Mathieu Othacehe --- doc/guix.texi | 102 ++++++++++++++++++++++++++++++++++++++ gnu/services/cuirass.scm | 103 ++++++++++++++++++++++++++++++++++++++- 2 files changed, 204 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 13d95b36d1..8982ad82f5 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -26010,6 +26010,108 @@ The Cuirass package to use. @end table @end deftp +@cindex simple cuirass +@subsubheading Simple Cuirass + +The Cuirass service configuration described above can be a little +intimidating. The @code{simple-cuirass-services} procedure offers a way +to setup a continuous integration server more readily. + +It takes a @code{simple-cuirass-configuration} record as its first +argument. + +@deftp {Data Type} simple-cuirass-configuration +Data type representing the configuration of a simple Cuirass instance. + +@table @asis +@item @code{build} (default: @code{'all}) +The packages to be built by Cuirass. It defaults to @code{'all}, which +means that all the discovered packages in the subsequent @code{channels} +field are to be selected. + +It is also possible to set this field to a list of @code{build-manifest} +records, so that only the packages that are part of the declared +manifests are built. This record is described below. + +@deftp {Data Type} build-manifest +@table @asis +@item @code{channel-name} +The name of the channel where the manifest is located. + +@item @code{manifest} +The manifest path inside the channel. + +@end table +@end deftp + +@item @code{channels} (default: @code{%default-channels}) +The channels to be fetched by Cuirass, see @pxref{Channels}. + +@item @code{non-package-channels} (default: @code{'()}) +List the channel names that must not be searched for packages. That is +often the case for the channel containing the manifest. + +@item @code{systems} (default: @code{(list (%current-system))}) +Build every discovered package for each system in this list. By default +only the current system is selected. + +@end table +@end deftp + +Here is an example of how to setup a Cuirass instance that builds all +the packages declared by Guix and a user repository. The package list +is re-evaluated each time a commit is pushed in one of the declared +channels. + +@lisp +(simple-cuirass-services + (simple-cuirass-configuration + (build 'all) + (channels (cons (channel + (name 'my-guix) + (url "https://my-git-repo/guix.git")) + %default-channels)))) +@end lisp + +In the same spirit, this builds all the packages that are part of the +@code{'guix} or @code{'my-guix} channels and declared in the manifest +located in the @code{'conf} channel. + +@lisp +(simple-cuirass-services + (simple-cuirass-configuration + (build (list + (build-manifest + (channel-name 'conf) + (manifest "guix/manifest.scm")))) + (channels (cons* (channel + (name 'my-guix) + (url "https://my-git-repo/guix.git")) + (channel + (name 'conf) + (url "https://my-git-repo/conf.git")) + %default-channels)) + (non-package-channels '(conf)))) +@end lisp + +Finally, @code{simple-cuirass-services} takes as a second optional +argument a @code{cuirass-configuration} record. It can be used to +customize the configuration of the Cuirass instance. + +@lisp +(simple-cuirass-services + (simple-cuirass-configuration + (build 'all) + (channels (cons (channel + (name 'my-guix) + (url "https://my-git-repo/guix.git")) + %default-channels)) + (non-package-channels '(conf))) + (cuirass-configuration + (inherit %default-cuirass-config) + (host "0.0.0.0"))) ;listen on all interfaces. +@end lisp + @node Power Management Services @subsection Power Management Services diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm index f426b9a1a7..44b39cb78f 100644 --- a/gnu/services/cuirass.scm +++ b/gnu/services/cuirass.scm @@ -22,10 +22,13 @@ ;;; along with GNU Guix. If not, see . (define-module (gnu services cuirass) + #:use-module (guix channels) #:use-module (guix gexp) #:use-module (guix records) + #:use-module (guix utils) #:use-module (gnu packages admin) #:use-module (gnu packages ci) + #:use-module (gnu packages databases) #:use-module (gnu packages version-control) #:use-module (gnu services) #:use-module (gnu services base) @@ -33,6 +36,8 @@ #:use-module (gnu services shepherd) #:use-module (gnu services admin) #:use-module (gnu system shadow) + #:use-module (srfi srfi-1) + #:use-module (ice-9 match) #:export ( cuirass-remote-server-configuration cuirass-remote-server-configuration? @@ -45,7 +50,18 @@ cuirass-remote-worker-configuration cuirass-remote-worker-configuration? - cuirass-remote-worker-service-type)) + cuirass-remote-worker-service-type + + + build-manifest + build-manifest? + + + simple-cuirass-configuration + simple-cuirass-configuration? + + %default-cuirass-config + simple-cuirass-services)) ;;;; Commentary: ;;; @@ -338,3 +354,88 @@ CONFIG." cuirass-remote-worker-shepherd-service))) (description "Run the Cuirass remote build worker service."))) + +(define-record-type* + build-manifest make-build-manifest + build-manifest? + (channel-name build-manifest-channel-name) ;symbol + (manifest build-manifest-manifest)) ;string + +(define-record-type* + simple-cuirass-configuration make-simple-cuirass-configuration + simple-cuirass-configuration? + (build simple-cuirass-configuration-build + (default 'all)) ;symbol or list of + (channels simple-cuirass-configuration-channels + (default %default-channels)) ;list of + (non-package-channels simple-cuirass-configuration-package-channels + (default '())) ;list of channels name + (systems simple-cuirass-configuration-systems + (default (list (%current-system))))) ;list of strings + +(define %default-cuirass-config + (cuirass-configuration + (specifications #~()))) + +(define* (simple-cuirass-services config + #:optional + (cuirass %default-cuirass-config)) + (define (format-name name) + (if (string? name) + name + (symbol->string name))) + + (define (format-manifests build-manifests) + (map (lambda (build-manifest) + (match-record build-manifest + (channel-name manifest) + (cons (format-name channel-name) manifest))) + build-manifests)) + + (define (channel->input channel) + (let ((name (channel-name channel)) + (url (channel-url channel)) + (branch (channel-branch channel))) + `((#:name . ,(format-name name)) + (#:url . ,url) + (#:load-path . ".") + (#:branch . ,branch) + (#:no-compile? #t)))) + + (define (package-path channels non-package-channels) + (filter-map (lambda (channel) + (let ((name (channel-name channel))) + (and (not (member name non-package-channels)) + (not (eq? name 'guix)) + (format-name name)))) + channels)) + + (define (config->spec config) + (match-record config + (build channels non-package-channels systems) + `((#:name . "simple-config") + (#:load-path-inputs . ("guix")) + (#:package-path-inputs . ,(package-path channels + non-package-channels)) + (#:proc-input . "guix") + (#:proc-file . "build-aux/cuirass/gnu-system.scm") + (#:proc . cuirass-jobs) + (#:proc-args . ((systems . ,systems) + ,@(if (eq? build 'all) + '() + `((subset . "manifests") + (manifests . ,(format-manifests build)))))) + (#:inputs . ,(map channel->input channels)) + (#:build-outputs . ()) + (#:priority . 1)))) + + (list + (service cuirass-service-type + (cuirass-configuration + (inherit cuirass) + (specifications #~(list + '#$(config->spec config))))) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) + (service postgresql-role-service-type))) -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 11:38:07 2021 Received: (at 46031) by debbugs.gnu.org; 22 Jan 2021 16:38:07 +0000 Received: from localhost ([127.0.0.1]:32870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2zRm-0007SJ-Nu for submit@debbugs.gnu.org; Fri, 22 Jan 2021 11:38:06 -0500 Received: from mout.web.de ([212.227.15.4]:57735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2zRk-0007Rn-7S for 46031@debbugs.gnu.org; Fri, 22 Jan 2021 11:38:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1611333478; bh=tjHXTzsI1npvygkIubBYRN8NKK3xqz4tbA1snlu/S/I=; h=X-UI-Sender-Class:To:References:From:Subject:Date:In-Reply-To; b=eHlvZJdY1EIu2l8R1rZUJk7xAFuthAh4K5frx5UJr1TNz+hp0nV52BRyvTCPjLHs5 WNo+5xMB93vOMmZOczv8BHRVB6D9ch1TvY/3zuZqOvtxRtRPn4SnwDwvpB0Zl7SjT5 wDakb72Vw2VfieC5V3mPUp8YZdB561+2pKPQWBYE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.88] ([5.146.192.196]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MsaS7-1lr5tV0dLP-00td1X; Fri, 22 Jan 2021 17:37:58 +0100 To: Mathieu Othacehe , 46031@debbugs.gnu.org References: <87czxxz767.fsf@gnu.org> From: Jonathan Brielmaier Subject: Re: [bug#46031] services: cuirass: Add "simple-cuirass-services". Message-ID: Date: Fri, 22 Jan 2021 17:37:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.1 MIME-Version: 1.0 In-Reply-To: <87czxxz767.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zTkSqiIpEntp++fs1Zud0XDFQ7423fnOH/LpbAu/vVPyQQzfWl4 I4bxhL/7gYxtvKS6ScJ9hAd3OMu7QMVYexkUq9yeGT5s6b4rEtM2651/HWSoRke6oAj/h4g 4p9OGw5BZ8HBVzqCJQ8aQsPn3M4HrGI3pKGuwefSoyjBQIyvmAkO2kqQhDEBYXRcZXzjCoU 9/gTY09bkkQ66mKd+bK+A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xzD/mV5PIpY=:hRUCH5Khcx/UDma8xFlgBt oXgVcFOD+VVkzaaaUVn86pjhOSjRZvFaUR/6QjJF1kK7d4rc6UkKxkJlCtsLGT7tt7AuvOiGT O1hx5PBgD8RRrtr2Go4hAAlh4xzM0LL5p0rAsRuWonLgVLPoCvzL8K1KlptjKTXEOpK8+jHdP l5bzU1V0Qo2m1+zF2IvRw+ouRDimDlZugIMTuQS2YhrRytJHD61g1DcjOoe1vY38y6URK8xcK n7rQr+kPxMWmuvqTBT0a3n501iVCD03TUlE9WC0aTu6Os6yjaDFc0JVfY8RMLtNGBlNwuVwlJ rO6yILu2Y7EtsGHUz1hnhG7qo/+TpEkWf7ZfaQfpwq7U83ObC10zPUnZEwSnQDEr/9BbQpzD0 KVd8UT2vh5iDbb0ZE/xG/KHA6pH4pIZNcxms2HYIdXWcBSmEL8IZgqsXb0GzsIjloQBhylXo3 3eTGpuHro6BDkWbDWQLVTbiCG9W/NrqA9so5S5GKw16NRrBKsgFNlyUHzer5Wd8FXHjOEy5t1 Rh05fmCCS+MFuVxOHTbAJ7XlSqzJZZ8Ovu+0VKl7LjMryHfaivPLP+87/F//o610VIsj77JKi 1fWjOaBbAj/1vc9XWy+T6AmxiecdXNrdEJUIHUoAD5fK4umRzHtv/4HP5AUgQb932FSe/OHIa gjUis2TZuX4q/kYBH9sJURhczEGvhas54B8dLfhtGj2V1I/AxYcihCpkBOMilKbIHiLWeAEfq Me+hE0/xWMC4X3knN9d3mBFdLlYfV+8pW18SmNKeUPPPNsQpGBIYFWDVi1iFvbe41lvGRwNdm SL4JeNC6nSnQs07aJEWAtRQUdfKsn4/F52SiZZAedVCx8j9ImjVODtNDppYDViVl3UqB/EVBe W4Fb/0Du64CP2NEon4dylyzCnwuYREYgJCliJsBlQ= X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 46031 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 22.01.21 09:50, Mathieu Othacehe wrote: > Here is a service that provides some syntactic sugar over the (complex) > Cuirass configuration. It uses Guix Channels to declare Cuirass inputs. On my server I stopped cuirass && cuirass-web. Removed any signs from the config.scm and tried this barebone example from your branch: https://gitlab.com/mothacehe/guix/-/tree/simple-cuirass (use-modules (gnu) (guix channels)) [...] (simple-cuirass-services (simple-cuirass-configuration (build 'all) (channels (cons (channel (name 'my-guix) (url "https://gitlab.com/jonsger/guix.git")) %default-channels)))) It gave me this error: https://paste.opensuse.org/view/raw/110509 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 12:56:12 2021 Received: (at 46031) by debbugs.gnu.org; 22 Jan 2021 17:56:12 +0000 Received: from localhost ([127.0.0.1]:32978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l30fL-00030n-Pp for submit@debbugs.gnu.org; Fri, 22 Jan 2021 12:56:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l30fI-00030Z-82 for 46031@debbugs.gnu.org; Fri, 22 Jan 2021 12:56:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53032) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l30fC-0007Ax-UB; Fri, 22 Jan 2021 12:56:02 -0500 Received: from [2a01:e0a:19b:d9a0:98b7:b002:9499:5e2c] (port=60914 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l30fB-0004j6-Dx; Fri, 22 Jan 2021 12:56:02 -0500 From: Mathieu Othacehe To: Jonathan Brielmaier Subject: Re: [bug#46031] services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> Date: Fri, 22 Jan 2021 18:55:58 +0100 In-Reply-To: (Jonathan Brielmaier's message of "Fri, 22 Jan 2021 17:37:56 +0100") Message-ID: <87h7n8vosx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Jonathan, > It gave me this error: https://paste.opensuse.org/view/raw/110509 Thanks for testing! Be careful, "simple-cuirass-services" returns a list of services and has to be appended to the list of other services. Could you paste a bit more of your configuration? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 24 08:48:00 2021 Received: (at 46031) by debbugs.gnu.org; 24 Jan 2021 13:48:00 +0000 Received: from localhost ([127.0.0.1]:36079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3fkF-0006XT-VV for submit@debbugs.gnu.org; Sun, 24 Jan 2021 08:48:00 -0500 Received: from mout.web.de ([212.227.17.12]:59127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3fkA-0006XC-HC for 46031@debbugs.gnu.org; Sun, 24 Jan 2021 08:47:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1611496067; bh=ClJzCOf/oz5LebmAyCJQL+fFNqyHLg2iiy1dSDrCxhk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=GQTgcIdbQsa+IvGMsSIrDbH94CVWVxivgXN5vRntqA5c7u7oaL3/zODoHohnRAL1l +G/iEXMxHzj9QFCSDFzRt9EZ/Kjg77Znr3u3zGdUYKEb+U+xBVmHpGD8mlQF9bBB7u MwFQUDTXEdPOcTRt5XvBn3++eVAf9mqMtNxV/uhw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.88] ([5.146.192.196]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LgYG1-1lomkI2uKD-00nxCc; Sun, 24 Jan 2021 14:47:47 +0100 Subject: Re: [bug#46031] services: cuirass: Add "simple-cuirass-services". To: Mathieu Othacehe References: <87czxxz767.fsf@gnu.org> <87h7n8vosx.fsf@gnu.org> From: Jonathan Brielmaier Message-ID: <88959b06-fee9-e786-c105-d4766709281c@web.de> Date: Sun, 24 Jan 2021 14:47:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.1 MIME-Version: 1.0 In-Reply-To: <87h7n8vosx.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:NaG65Dkpy+tjZ0nb6iZBiO9BBpTp7bngGYj6aJjP4HS8kV1SRib whCHiQHjPVJtau7dHD1OXMdXLD951GI5oxmu2BWLtVqQ7Jd3QiTIuhZVdgMeZBX2BB/oD9U 8P7WwGA2pBEHHdJea+GFyITlSgEpCDWAOKZUVbqTWifWr81OEay1eOUl+4eWHk0oHy2zw5+ j3uKD1PuAL6z1qI0jVZGQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:paRfO/dPqs8=:Z8zDdG2635PiBqLCSXCSuI SbgcROHERveGy8lG/sjcUxJ1Z7dDkiUggaS8bYBZS+EOFwF3aYpzuRQdwPWM8W9kb0B/770PQ 7CHFR39OWSn/yRym+7AJXU47jEx7QnoO7q9QGz1miQ9ApJoWurq4aEOAeu5QTKsexKiXfcK4t 5n36tl/RTOaHXe8wNQzWyQ23xKLeyWHDPDs5Uzo6LheDc6Gth9yRyJH7HUv46dx/JWYCGd/Zc ip2qRa7ADRYXzQU5iA2JNbFtHt2bvOegN8hujZfHUJaHoprwWAsNF4jrpd7HZyDY5R+PhwrOr yE7u4f4/t+R7PBb225+5ZQPwJKG80uzg9hR3gjO1CkjlL0sPQnCSaYR5jJ6OdOFXB2HpZym8J GM3bXCDJEv2kU4+ph5UbjyVJtMBxO1NxXoBRbYmhOVaOLzCTIgW7ew3H1qrDcNQk54CBDMw6M lYwtC7n7fbLU+faSIA1MxvdtKK+/KKvw+h5qr/lCbP0c9EAuQQaDFfYCR+eY6ZfTEaA4Dmw1R g4qXWSJ/xTGjYghDG5EpU1Q2lVJrx0vgPN+dEJ6JA3V6QofZ0BoIlugHrA8mO6oRMCJUcf41f omozjeBAi4EbngDkE84tn/0fqQ2l6PuRzVRq2MMSNkpT3J0gNjSFixyN+kl+7rfF5J3DgnCAf FwBxGJT97755s/KXUJeSPnoRDkr9BBpgVXOvX+gmd8icA1rfyfLRrVHhOdMjkK14T3Oy2kuSN tKq54pAjQEcDiYiFzVsbnABCcCW8ZSkJ7XLwd0++BdIScSUDKsjMIE5ShvtJX/1tj861eQnjD fPqk6kiwGcX8PR+mwtOUNfObybwK99xx4vNxOxLGmz6k+7kp6oOUrg/rhXzBKGhVhcXbyke8e //oxtI7MHoeRTv0IZOT1X3gbv6BALBRkp+kAkUvL4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 22.01.21 18:55, Mathieu Othacehe wrote: > > Hello Jonathan, > >> It gave me this error: https://paste.opensuse.org/view/raw/110509 > > Thanks for testing! Be careful, "simple-cuirass-services" returns a list > of services and has to be appended to the list of other services. That is the problem, because of changes to guix-daemon. I have following construct: (services (cons* (service a-service-type) [...] (service z-service-type) (modify-services %base-services (guix-service-type config =3D> (guix-configuration (inherit config) (extra-options '("--cores=3Dx"))))))) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 29 06:39:54 2021 Received: (at 46031) by debbugs.gnu.org; 29 Jan 2021 11:39:54 +0000 Received: from localhost ([127.0.0.1]:51266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5S81-0006ur-Ra for submit@debbugs.gnu.org; Fri, 29 Jan 2021 06:39:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5S7y-0006uZ-OJ for 46031@debbugs.gnu.org; Fri, 29 Jan 2021 06:39:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42503) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5S7t-0006gL-Dy; Fri, 29 Jan 2021 06:39:45 -0500 Received: from [2a01:e0a:19b:d9a0:10b6:a2c3:9f4e:6dae] (port=55828 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l5S7s-0001Uy-5x; Fri, 29 Jan 2021 06:39:44 -0500 From: Mathieu Othacehe To: Jonathan Brielmaier Subject: Re: [bug#46031] services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <87h7n8vosx.fsf@gnu.org> <88959b06-fee9-e786-c105-d4766709281c@web.de> Date: Fri, 29 Jan 2021 12:39:42 +0100 In-Reply-To: <88959b06-fee9-e786-c105-d4766709281c@web.de> (Jonathan Brielmaier's message of "Sun, 24 Jan 2021 14:47:46 +0100") Message-ID: <875z3gj7k1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Jonathan, > (services > (cons* > (service a-service-type) > [...] > (service z-service-type) > (modify-services %base-services > (guix-service-type config => > (guix-configuration > (inherit config) > (extra-options '("--cores=x"))))))) That would impose to write something like: --8<---------------cut here---------------start------------->8--- (services (append (cons* (service a-service-type) [...] (service z-service-type) (modify-services %base-services (guix-service-type config => (guix-configuration (inherit config) (extra-options '("--cores=x")))))) (simple-cuirass-services (simple-cuirass-configuration (build 'all) (channels (cons (channel (name 'my-guix) (url "https://my-git-repo/guix.git")) %default-channels)))))) --8<---------------cut here---------------end--------------->8--- which is admittedly not that elegant. The problem I'd like to hide that "postgresql-service-type" and "postgresql-role-service-type" are required by Cuirass. Any idea? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 02 17:43:31 2021 Received: (at 46031) by debbugs.gnu.org; 2 Feb 2021 22:43:31 +0000 Received: from localhost ([127.0.0.1]:36344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l74OR-0005uG-FK for submit@debbugs.gnu.org; Tue, 02 Feb 2021 17:43:31 -0500 Received: from mout.web.de ([212.227.15.3]:58127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l74OP-0005u3-PZ for 46031@debbugs.gnu.org; Tue, 02 Feb 2021 17:43:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1612305803; bh=U5chc1Zlijxqoen/tXo3wwcVTtjS8J+nYvCqLM/Lvzs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Hp2m/MN4wS4TynvVzCG+9CUHoNb+Iv97tXSG0fKtsduMMxUTrx1YZ7MueiBU+MfcT TbA3Q1t0b2bUfKafZIGDpVHCBeMkgOHxG5aMktAVisuXazNDj1e7pWZ6nwq7/aLVE2 BC6NTfylP7JUpVbPE7qes2W8ZdkXLdqli/d/RH+M= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.88] ([5.146.192.196]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M4sbr-1l8RR62KeN-00232j; Tue, 02 Feb 2021 23:43:23 +0100 Subject: Re: [bug#46031] services: cuirass: Add "simple-cuirass-services". To: Mathieu Othacehe References: <87czxxz767.fsf@gnu.org> <87h7n8vosx.fsf@gnu.org> <88959b06-fee9-e786-c105-d4766709281c@web.de> <875z3gj7k1.fsf@gnu.org> From: Jonathan Brielmaier Message-ID: <9b90045c-8d02-34bc-1fcf-ff2061d87bb4@web.de> Date: Tue, 2 Feb 2021 23:43:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.1 MIME-Version: 1.0 In-Reply-To: <875z3gj7k1.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xXTDVxRr9Gp5DRggv9Mx+xRC0tn9VwT4b6tMcHwP1177TXpjVNa nTRFn3QNvwEoxuB5m5R4JxXLEAzyJXdLF0wXN2BW1veE8e0r+uNiSvboE28/2MCdlDb5O75 yskKc1/oyT5jWI0DyIhrR5Hox08ruiT4OhvsXRmyg+g/NOf8qUIdXlzBCS0GCC3R76GdzFw BUJViZpZ642jx8U92FCRQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kcdvYceE2rg=:Yr5a1NGvFx2g3WhYhoH6fN VX+se6RNcvi3fi6g0lX+QoDxnZaqH0nLQxsu3ILJMXNMFDmX4Rd2JoJnPPDq/8gvWsbXhrqW7 VetfXDTSLsX01j94/Tvz39S9eSrTDUy6VrWcf/NA02Klgge2duY+WiBy968Jp5WluP2sEElu2 Lr8LiYMYGS/3cBUIoNmtd9DHPRpaXodADX4axCLLmDWIbH64uIw0fiHSRIUt6FRKBkrxRGDFb jzPRgGUY0Ojn/qyRmkgtOQMyqthkBdgI8FAUvEpVR8P8pE2WlU+SIWRCm6v1EUKSvKtmbZ8xH c2pPoJhcgQQiyVW43wWRhDSFO22o1zDpiQhQGj6O2DiqGxwQn7Acxfne5+F8bIQgofqTEb6z9 bfJXDFC/mA4/1mNj0rDpRXwh4HyMUnZ54Jt+Gz0vtWgfYm04en/7O5Om9okb78KeKZ/4YIawX fyYqNHgJAbKopDCLDWEAQ7W19SLcQ2CX4LQ9+SAshWXM5F/If9SWJa1EacbW5Rct/HNkpT+BY /d6D3PYN78Z2R2aETyZyByd52RgSA2MrHf0HkxM51upfPw09SsjhAcuTQvVK78gGesNT3D63N +9hXYqoPHQEXreH5bwPDtYMJ0393MSmloZLuPlJm0hVh14/V/nmJ93rjfVVRwfhrDBDOkkAUA Dmmm3ULbHK0vb5CmNCs7qkff9pwccViDOcqMztql6ioxJ8iOgLVSdlv3Ho/uVHnIpLxn+srjA PyYtxit+LufvV1Q6KmvO7Rj9eHCjzwvFDXTYmczcliyQX/k2MQi8Av3YXpUSrtm2awknrA++E nbiTA34HSRxIgSCp/LLGmg/vWIJ+8L3Io+vXRoFNiluSe3f5RflycHLf8u+uyurEjlC/qqJEB LyJgXNkKXR+9HlmL17lVKBwD8il2ynHnfWH7qfpc0= X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 29.01.21 12:39, Mathieu Othacehe wrote: > > Hello Jonathan, > >> (services >> (cons* >> (service a-service-type) >> [...] >> (service z-service-type) >> (modify-services %base-services >> (guix-service-type config =3D> >> (guix-configuration >> (inherit config) >> (extra-options '("--cores=3Dx"))))))) > > That would impose to write something like: > > --8<---------------cut here---------------start------------->8--- > (services > (append > (cons* > (service a-service-type) > [...] > (service z-service-type) > (modify-services %base-services > (guix-service-type config =3D> > (guix-configuration > (inherit config) > (extra-options '("--cores=3Dx")))))) > (simple-cuirass-services > (simple-cuirass-configuration > (build 'all) > (channels (cons (channel > (name 'my-guix) > (url "https://my-git-repo/guix.git")) > %default-channels)))))) > --8<---------------cut here---------------end--------------->8--- Thanks Mathieu. I think we can merge and I'll try it then. If we found a nicer solution we can still change it... From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 14:16:16 2021 Received: (at 46031-done) by debbugs.gnu.org; 19 Feb 2021 19:16:16 +0000 Received: from localhost ([127.0.0.1]:50400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDBGC-0003sT-EN for submit@debbugs.gnu.org; Fri, 19 Feb 2021 14:16:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDBGA-0003sC-Em for 46031-done@debbugs.gnu.org; Fri, 19 Feb 2021 14:16:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56292) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDBG5-0000IL-4e; Fri, 19 Feb 2021 14:16:09 -0500 Received: from [2a01:e0a:19b:d9a0:d9da:9d9d:268a:155a] (port=60500 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lDBG4-0008Cp-O1; Fri, 19 Feb 2021 14:16:08 -0500 From: Mathieu Othacehe To: Jonathan Brielmaier Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <87h7n8vosx.fsf@gnu.org> <88959b06-fee9-e786-c105-d4766709281c@web.de> <875z3gj7k1.fsf@gnu.org> <9b90045c-8d02-34bc-1fcf-ff2061d87bb4@web.de> Date: Fri, 19 Feb 2021 20:16:07 +0100 In-Reply-To: <9b90045c-8d02-34bc-1fcf-ff2061d87bb4@web.de> (Jonathan Brielmaier's message of "Tue, 2 Feb 2021 23:43:22 +0100") Message-ID: <87zgzz7ts8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031-done Cc: 46031-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, > Thanks Mathieu. I think we can merge and I'll try it then. If we found a > nicer solution we can still change it... I added a system test and pushed, thanks for testing it. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 16:35:57 2021 Received: (at 46031) by debbugs.gnu.org; 19 Feb 2021 21:35:57 +0000 Received: from localhost ([127.0.0.1]:50538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDDRN-0007Gr-CQ for submit@debbugs.gnu.org; Fri, 19 Feb 2021 16:35:57 -0500 Received: from mout.web.de ([217.72.192.78]:58371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDDRI-0007Ga-CW for 46031@debbugs.gnu.org; Fri, 19 Feb 2021 16:35:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1613770544; bh=Jb55pm7Rp33xJSD9FySP7nJT4aGVgNZZpAgOgl3MYMs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=RHfc7lPRRVeyBdVgx9Bz+94aWN78diZRupsvvJVXSNZ+F3Upll/YmTTuNk0iokQ0o j4bpjHKpm9DFm9eokTjdy6JPm6NIPeLRotG3eMSpS+Kfgz/V50lCE+DsfrZmHJ8TRo 2oN6ikbjkw7uDe6oiHlD+VxMdyDb7wCh085Yo1cg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.88] ([88.152.184.4]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MKa2F-1lF8Jb3Lux-001y63; Fri, 19 Feb 2021 22:35:44 +0100 Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". To: Mathieu Othacehe References: <87czxxz767.fsf@gnu.org> <87h7n8vosx.fsf@gnu.org> <88959b06-fee9-e786-c105-d4766709281c@web.de> <875z3gj7k1.fsf@gnu.org> <9b90045c-8d02-34bc-1fcf-ff2061d87bb4@web.de> <87zgzz7ts8.fsf_-_@gnu.org> From: Jonathan Brielmaier Message-ID: <3ecc3bc1-0ef6-8932-1c59-262053ef2722@web.de> Date: Fri, 19 Feb 2021 22:35:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.7.1 MIME-Version: 1.0 In-Reply-To: <87zgzz7ts8.fsf_-_@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zb83+ViiVwNCJVBBttV27eUL3p4hwKmmdmf39lMjuCjJH2IydpD w0gA7+Nkge1v0zipGoq1f7TjODSMN4hfHxuE0jnIBNFzjawrwRRL4kTYTHxt1F9A4v+rTnV 0cnOUDb2yWhuhwyc/fhZloR/zKv58fDCLO+tHOnF+kTUiwKUmqLyPRydiNAUYZFpGoHa523 jDQozvmUU5SuQnMypBpig== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:s9IiJVqNV7U=:S0Ledy3tCgkE70Vz8BMgMh z38i2Y6NO9rBcp8NhENPNBQSOY+rlipVlNZCQkFXKR+VAOZ5YuxP/B+iOQUXUjtEF2izQYZHY l+bTeVaMUyZxECR0GlQneAUH19KWEGigTJC+K2A99UW5LUevCHJpfZqJnXzdI2Hn0cCsAQhfJ 7XHktpI8PHhEmhEnjAOJOM7NTqKZMTT31vwDjxak/nKdPAh5W+zjlui52tTWc9nk3ldNba4Ik 6dZgjNeE6sqXKIl/0kd38RyGYzSAyNXIYBv5DURgvqwEXbeLrRrfAN4RKY0vDQN4DOHRapGxZ g0sF/HFq0NrcRnB4Qo1xg5aX3rEOEYB8iEigqjuL5bnQ8k64+2y9k89LCYcr4XPakl0qlYuDk fcgmVzw+srJ60Z9/Yb9i2D2et0lFh5LEGUqr3p/7CNF3d/WOTenOT33zvbeOprUHfyskDl1Li ppK98RCLZuHY+iZXBy7pvVA6idxr/nrSsE84eD7kPKUdlAmqxVunRQcXRS2hJFilIWEDKRw+b kORYK0UJGqJxCy1hZxPC6yQs1SEfWGpSif5mi91dw8nJrbj8I6lV0Ik6Ryqris3oB3sjfFzSO 8Nuxqpg6WZdixllPjwuHAwb1bpbRm1eZ7PlCQlAXT6OM/mE98gpB98jIUlENeODJ7pbsMUbx3 gUL7kXwzzlbJb6segDPjRwid3yYqOt8MJCxAx2E8tP4CxJqbBJen1HKvx4L+oIagMMFoHEWtA YykVU3mCLCemIGXTe9Cy1kflyW34Ucqi004CcHoyRa2f5b3JxZzfM6KyY0er92pbPt+agUWDq 9/6esIjBKTKmZc2z+ucU5pRuA9KlW9jyymlSn6S8RuAa+VrND4fwrxQVxLXQ0cOi7l73PxMnM GHaSei58YMCniktK+nWuZ7yUtSR1Q1wRrUlSV4AcQ= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 19.02.21 20:16, Mathieu Othacehe wrote: > > Hello, > >> Thanks Mathieu. I think we can merge and I'll try it then. If we found = a >> nicer solution we can still change it... > > I added a system test and pushed, thanks for testing it. Merci Mathieu. Is it intended that I need to import `(guix channels)`? Shouldn't that come with the cuirass service module? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 05:59:51 2021 Received: (at 46031) by debbugs.gnu.org; 20 Feb 2021 10:59:51 +0000 Received: from localhost ([127.0.0.1]:51068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDPzL-00018P-7u for submit@debbugs.gnu.org; Sat, 20 Feb 2021 05:59:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDPzI-000186-Fz for 46031@debbugs.gnu.org; Sat, 20 Feb 2021 05:59:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41674) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDPzD-0002uZ-43 for 46031@debbugs.gnu.org; Sat, 20 Feb 2021 05:59:43 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34402 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lDPzB-00061m-Cl; Sat, 20 Feb 2021 05:59:42 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> Date: Sat, 20 Feb 2021 11:59:38 +0100 In-Reply-To: <87czxxz767.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 22 Jan 2021 09:50:56 +0100") Message-ID: <874ki7j97p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Mathieu Othacehe skribis: > Here is a service that provides some syntactic sugar over the (complex) > Cuirass configuration. It uses Guix Channels to declare Cuirass inputs. > > In the future, it would be nice if Cuirass could operate directly on > Channels. For now, this service only act as a translation layer for > people willing to setup a simple Cuirass instance. I had overlooked these patches; that=E2=80=99s really nice! > +@lisp > +(simple-cuirass-services > + (simple-cuirass-configuration > + (build (list > + (build-manifest > + (channel-name 'conf) > + (manifest "guix/manifest.scm")))) > + (channels (cons* (channel > + (name 'my-guix) > + (url "https://my-git-repo/guix.git")) > + (channel > + (name 'conf) > + (url "https://my-git-repo/conf.git")) > + %default-channels)) > + (non-package-channels '(conf)))) > +@end lisp I wonder if it would make sense to allow users to pass directly a manifest, as in (pseudo syntax): (simple-cuirass-configuration (build (list (build-manifest =E2=80=A6 (local-file "my-manifest.scm")))) (channels =E2=80=A6)) It=E2=80=99d be less expressive (you=E2=80=99d have to reconfigure when you= change the manifest), but perhaps easier to set up. WDYT? > + (define (config->spec config) > + (match-record config > + (build channels non-package-channels systems) > + `((#:name . "simple-config") > + (#:load-path-inputs . ("guix")) > + (#:package-path-inputs . ,(package-path channels > + non-package-channels)) > + (#:proc-input . "guix") > + (#:proc-file . "build-aux/cuirass/gnu-system.scm") > + (#:proc . cuirass-jobs) > + (#:proc-args . ((systems . ,systems) > + ,@(if (eq? build 'all) > + '() > + `((subset . "manifests") > + (manifests . ,(format-manifests build)))= ))) > + (#:inputs . ,(map channel->input channels)) > + (#:build-outputs . ()) > + (#:priority . 1)))) > + > + (list > + (service cuirass-service-type > + (cuirass-configuration > + (inherit cuirass) > + (specifications #~(list > + '#$(config->spec config))))) What about exposing =E2=80=98simple-cuirass-configuration->specs=E2=80=99, = and document it such that one can do: (service cuirass-service-type (cuirass-configuration (specifications (simple-cuirass-configuration->specs config)))) or even: (service cuirass-service-type (compile-simple-cuirass-configuration config)) ? That way, the relationship between =E2=80=9Csimple=E2=80=9D and =E2=80=9Cno= t simple=E2=80=9D would be clearer. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 03:50:54 2021 Received: (at 46031) by debbugs.gnu.org; 22 Feb 2021 08:50:54 +0000 Received: from localhost ([127.0.0.1]:55584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lE6vd-0002Y5-QT for submit@debbugs.gnu.org; Mon, 22 Feb 2021 03:50:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lE6vb-0002Xq-Mv for 46031@debbugs.gnu.org; Mon, 22 Feb 2021 03:50:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50583) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lE6vV-0000WS-N8; Mon, 22 Feb 2021 03:50:45 -0500 Received: from [2a01:e0a:19b:d9a0:d047:2c08:886f:ec31] (port=34366 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lE6vV-0005WK-6s; Mon, 22 Feb 2021 03:50:45 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <874ki7j97p.fsf@gnu.org> Date: Mon, 22 Feb 2021 09:50:43 +0100 In-Reply-To: <874ki7j97p.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 20 Feb 2021 11:59:38 +0100") Message-ID: <87k0r0iizg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hey Ludo! > I had overlooked these patches; that=E2=80=99s really nice! Thanks :) > I wonder if it would make sense to allow users to pass directly a > manifest, as in (pseudo syntax): > > (simple-cuirass-configuration > (build (list (build-manifest =E2=80=A6 (local-file "my-manifest.scm")= ))) > (channels =E2=80=A6)) It would be nice but Cuirass doesn't support specification update for now. Passing a manifest this way would require to drop the database content at each reconfiguration. > What about exposing =E2=80=98simple-cuirass-configuration->specs=E2=80=99= , and document > it such that one can do: > > (service cuirass-service-type > (cuirass-configuration > (specifications > (simple-cuirass-configuration->specs config)))) I agree it feels nicer, however with this service I'd like to hide the dependencies to postgresql-service-type and postgresql-role-service-type. That's why "simple-cuirass-services" returns three services. Maybe you see another way? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 03:53:55 2021 Received: (at 46031) by debbugs.gnu.org; 22 Feb 2021 08:53:55 +0000 Received: from localhost ([127.0.0.1]:55588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lE6yZ-0002cn-Af for submit@debbugs.gnu.org; Mon, 22 Feb 2021 03:53:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lE6yY-0002cX-8v for 46031@debbugs.gnu.org; Mon, 22 Feb 2021 03:53:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50631) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lE6yS-0001zz-Li; Mon, 22 Feb 2021 03:53:48 -0500 Received: from [2a01:e0a:19b:d9a0:d047:2c08:886f:ec31] (port=34384 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lE6yR-0005jQ-Q1; Mon, 22 Feb 2021 03:53:48 -0500 From: Mathieu Othacehe To: Jonathan Brielmaier Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <87h7n8vosx.fsf@gnu.org> <88959b06-fee9-e786-c105-d4766709281c@web.de> <875z3gj7k1.fsf@gnu.org> <9b90045c-8d02-34bc-1fcf-ff2061d87bb4@web.de> <87zgzz7ts8.fsf_-_@gnu.org> <3ecc3bc1-0ef6-8932-1c59-262053ef2722@web.de> Date: Mon, 22 Feb 2021 09:53:46 +0100 In-Reply-To: <3ecc3bc1-0ef6-8932-1c59-262053ef2722@web.de> (Jonathan Brielmaier's message of "Fri, 19 Feb 2021 22:35:44 +0100") Message-ID: <87ft1oiiud.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Jonathan, > Is it intended that I need to import `(guix channels)`? Shouldn't that > come with the cuirass service module? Yes you need it to declare the channels that are passed in the "channels" field of "simple-cuirass-configuration". Maybe I should add a comment about it in the documentation. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 07:59:37 2021 Received: (at 46031) by debbugs.gnu.org; 22 Feb 2021 12:59:37 +0000 Received: from localhost ([127.0.0.1]:55998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEAoL-0006kf-Ad for submit@debbugs.gnu.org; Mon, 22 Feb 2021 07:59:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEAoJ-0006kS-M2 for 46031@debbugs.gnu.org; Mon, 22 Feb 2021 07:59:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53395) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEAoD-0002KY-V9 for 46031@debbugs.gnu.org; Mon, 22 Feb 2021 07:59:30 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43006 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lEAoC-0002vs-0f; Mon, 22 Feb 2021 07:59:28 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <874ki7j97p.fsf@gnu.org> <87k0r0iizg.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 =?utf-8?Q?Vent=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 22 Feb 2021 13:59:25 +0100 In-Reply-To: <87k0r0iizg.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 22 Feb 2021 09:50:43 +0100") Message-ID: <87eeh8b6mq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! Mathieu Othacehe skribis: >> I wonder if it would make sense to allow users to pass directly a >> manifest, as in (pseudo syntax): >> >> (simple-cuirass-configuration >> (build (list (build-manifest =E2=80=A6 (local-file "my-manifest.scm"= )))) >> (channels =E2=80=A6)) > > It would be nice but Cuirass doesn't support specification update for > now. Passing a manifest this way would require to drop the database > content at each reconfiguration. Ah yes, that wouldn=E2=80=99t be convenient. >> What about exposing =E2=80=98simple-cuirass-configuration->specs=E2=80= =99, and document >> it such that one can do: >> >> (service cuirass-service-type >> (cuirass-configuration >> (specifications >> (simple-cuirass-configuration->specs config)))) > > I agree it feels nicer, however with this service I'd like to hide the > dependencies to postgresql-service-type and > postgresql-role-service-type. That's why "simple-cuirass-services" > returns three services. Maybe you see another way? When a service extends a service type, an instance of that service type is automatically added if it=E2=80=99s missing (provided that service type = has a default value). This happens in =E2=80=98instantiate-missing-services=E2= =80=99. So, if postgresql-role-service-type and postgresql-service-type have a default value, simple-cuirass-service could extend them both (possibly with a dummy value) and it would just work. HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 03:48:24 2021 Received: (at 46031) by debbugs.gnu.org; 23 Feb 2021 08:48:24 +0000 Received: from localhost ([127.0.0.1]:58273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lETMm-0002lY-CE for submit@debbugs.gnu.org; Tue, 23 Feb 2021 03:48:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lETMk-0002lL-2N for 46031@debbugs.gnu.org; Tue, 23 Feb 2021 03:48:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42629) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lETMe-0001AT-1u; Tue, 23 Feb 2021 03:48:16 -0500 Received: from [2a01:e0a:19b:d9a0:d047:2c08:886f:ec31] (port=48270 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lETMZ-0005mi-FO; Tue, 23 Feb 2021 03:48:14 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <874ki7j97p.fsf@gnu.org> <87k0r0iizg.fsf@gnu.org> <87eeh8b6mq.fsf@gnu.org> Date: Tue, 23 Feb 2021 09:48:09 +0100 In-Reply-To: <87eeh8b6mq.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 22 Feb 2021 13:59:25 +0100") Message-ID: <87blcbkw52.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hey, > When a service extends a service type, an instance of that service type > is automatically added if it=E2=80=99s missing (provided that service typ= e has a > default value). This happens in =E2=80=98instantiate-missing-services=E2= =80=99. Oh! Didn't know about that one! > So, if postgresql-role-service-type and postgresql-service-type have a > default value, simple-cuirass-service could extend them both (possibly > with a dummy value) and it would just work. With 8163f74542300720f6ee5dc061b79ddf0c345bb8 and 108e2c6116f01c3b0a98498717d65a96c1857a51, I made sure that those services are automatically instantiated when missing. This means simple-cuirass-configuration->specs makes way more sense, as you suggested. Took care of it with bebcf97600b2fa65482ae8ee870800dafa34d3f8. Now, as suggested by Jonathan on IRC yesterday, it would be nice to be able to build only the packages of a given channel. For that, we would need to be able to figure out which channel is providing a package, with something like a package-channel field. Do you think that would make sense? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 04:30:08 2021 Received: (at 46031) by debbugs.gnu.org; 23 Feb 2021 09:30:08 +0000 Received: from localhost ([127.0.0.1]:58325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEU1A-0003mk-1D for submit@debbugs.gnu.org; Tue, 23 Feb 2021 04:30:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEU16-0003ko-Uv for 46031@debbugs.gnu.org; Tue, 23 Feb 2021 04:30:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43304) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEU11-0002g5-Jf; Tue, 23 Feb 2021 04:29:59 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39496 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lEU0y-00030r-CL; Tue, 23 Feb 2021 04:29:56 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <874ki7j97p.fsf@gnu.org> <87k0r0iizg.fsf@gnu.org> <87eeh8b6mq.fsf@gnu.org> <87blcbkw52.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 =?utf-8?Q?Vent=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 23 Feb 2021 10:29:54 +0100 In-Reply-To: <87blcbkw52.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 23 Feb 2021 09:48:09 +0100") Message-ID: <87v9aj5dyl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Mathieu Othacehe skribis: >> So, if postgresql-role-service-type and postgresql-service-type have a >> default value, simple-cuirass-service could extend them both (possibly >> with a dummy value) and it would just work. > > With 8163f74542300720f6ee5dc061b79ddf0c345bb8 and > 108e2c6116f01c3b0a98498717d65a96c1857a51, I made sure that those > services are automatically instantiated when missing. > > This means simple-cuirass-configuration->specs makes way more sense, as > you suggested. Took care of it with > bebcf97600b2fa65482ae8ee870800dafa34d3f8. Yay! > Now, as suggested by Jonathan on IRC yesterday, it would be nice to > be able to build only the packages of a given channel. For that, we > would need to be able to figure out which channel is providing a > package, with something like a package-channel field. > > Do you think that would make sense? One could filter packages from the manifest. Currently there=E2=80=99s no definite way to know which channel a given pac= kage comes from. =E2=80=98package-provenance=E2=80=99 in (guix describe) approx= imates that. Perhaps we should try something along these lines. I guess the first step would be to provide an a =E2=80=98package-channel(s)= =E2=80=99 procedure that does like =E2=80=98package-provenance=E2=80=99, but returns = a list of channels. WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 08:30:17 2021 Received: (at 46031) by debbugs.gnu.org; 23 Feb 2021 13:30:17 +0000 Received: from localhost ([127.0.0.1]:58540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXlZ-0003ZH-4u for submit@debbugs.gnu.org; Tue, 23 Feb 2021 08:30:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXlX-0003Z0-5Q for 46031@debbugs.gnu.org; Tue, 23 Feb 2021 08:30:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45698) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEXlR-0001Jm-17; Tue, 23 Feb 2021 08:30:09 -0500 Received: from [2a01:e0a:19b:d9a0:d047:2c08:886f:ec31] (port=55952 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lEXlQ-0005NT-Gv; Tue, 23 Feb 2021 08:30:08 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". In-Reply-To: <87v9aj5dyl.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 23 Feb 2021 10:29:54 +0100") References: <87czxxz767.fsf@gnu.org> <874ki7j97p.fsf@gnu.org> <87k0r0iizg.fsf@gnu.org> <87eeh8b6mq.fsf@gnu.org> <87blcbkw52.fsf@gnu.org> <87v9aj5dyl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Tue, 23 Feb 2021 14:30:06 +0100 Message-ID: <875z2ilxnl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey, > I guess the first step would be to provide an a =E2=80=98package-channel(= s)=E2=80=99 > procedure that does like =E2=80=98package-provenance=E2=80=99, but return= s a list of > channels. Seems fine to me. Here's an implementation attached. If it works for you, the next step will be to make the "cuirass-jobs" procedure of "gnu-system.scm" operate on channels I guess. WDYT? Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-describe-Add-package-channels.patch >From d44dcd5d153ba0a4627c205f24a0741384f3d301 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 23 Feb 2021 14:24:39 +0100 Subject: [PATCH] describe: Add package-channels. * guix/describe.scm (package-channels): New procedure. --- guix/describe.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/guix/describe.scm b/guix/describe.scm index 03569b1db4..65e5772856 100644 --- a/guix/describe.scm +++ b/guix/describe.scm @@ -33,6 +33,7 @@ package-path-entries package-provenance + package-channels manifest-entry-with-provenance manifest-entry-provenance)) @@ -178,6 +179,26 @@ property of manifest entries, or #f if it could not be determined." `(,main ,@(if extra (list extra) '())))))))))) +(define (package-channels package) + "Return the list of channels providing PACKAGE or an empty list if it could +not be determined." + (match (and=> (package-location package) location-file) + (#f #f) + (file + (let ((file (if (string-prefix? "/" file) + file + (search-path %load-path file)))) + (and file + (string-prefix? (%store-prefix) file) + + (filter-map + (lambda (entry) + (let ((item (manifest-entry-item entry))) + (and (or (string-prefix? item file) + (string=? "guix" (manifest-entry-name entry))) + (manifest-entry-channel entry)))) + (current-profile-entries))))))) + (define (manifest-entry-with-provenance entry) "Return ENTRY with an additional 'provenance' property if it's not already there." -- 2.30.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 12:42:48 2021 Received: (at 46031) by debbugs.gnu.org; 23 Feb 2021 17:42:48 +0000 Received: from localhost ([127.0.0.1]:60434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEbhw-0001d0-IT for submit@debbugs.gnu.org; Tue, 23 Feb 2021 12:42:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEbhv-0001cn-P0 for 46031@debbugs.gnu.org; Tue, 23 Feb 2021 12:42:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48727) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEbhq-0005fX-Hu; Tue, 23 Feb 2021 12:42:42 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59752 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lEbhp-0007fz-LG; Tue, 23 Feb 2021 12:42:41 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#46031: services: cuirass: Add "simple-cuirass-services". References: <87czxxz767.fsf@gnu.org> <874ki7j97p.fsf@gnu.org> <87k0r0iizg.fsf@gnu.org> <87eeh8b6mq.fsf@gnu.org> <87blcbkw52.fsf@gnu.org> <87v9aj5dyl.fsf@gnu.org> <875z2ilxnl.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 =?utf-8?Q?Vent=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 23 Feb 2021 18:42:39 +0100 In-Reply-To: <875z2ilxnl.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 23 Feb 2021 14:30:06 +0100") Message-ID: <875z2i4r5c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46031 Cc: 46031@debbugs.gnu.org, Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Mathieu Othacehe skribis: >> I guess the first step would be to provide an a =E2=80=98package-channel= (s)=E2=80=99 >> procedure that does like =E2=80=98package-provenance=E2=80=99, but retur= ns a list of >> channels. > > Seems fine to me. Here's an implementation attached. If it works for > you, the next step will be to make the "cuirass-jobs" procedure of > "gnu-system.scm" operate on channels I guess. But by definition, =E2=80=9Cgnu-system.scm=E2=80=9D is about the 'guix chan= nel. Intuitively I=E2=80=99d expect channel handling to happen in user code: eit= her in the user-provided manifest, or in some helper code in Cuirass. WDYT? > From d44dcd5d153ba0a4627c205f24a0741384f3d301 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Tue, 23 Feb 2021 14:24:39 +0100 > Subject: [PATCH] describe: Add package-channels. > > * guix/describe.scm (package-channels): New procedure. [...] > +(define (package-channels package) > + "Return the list of channels providing PACKAGE or an empty list if it = could > +not be determined." > + (match (and=3D> (package-location package) location-file) > + (#f #f) The #f return value doesn=E2=80=99t match the docstring. > + (file > + (let ((file (if (string-prefix? "/" file) > + file > + (search-path %load-path file)))) > + (and file > + (string-prefix? (%store-prefix) file) > + > + (filter-map > + (lambda (entry) > + (let ((item (manifest-entry-item entry))) > + (and (or (string-prefix? item file) > + (string=3D? "guix" (manifest-entry-name entry)= )) > + (manifest-entry-channel entry)))) > + (current-profile-entries))))))) To avoid duplication, perhaps you should rewrite =E2=80=98package-provenanc= e=E2=80=99 in terms of =E2=80=98package-channels=E2=80=99? Otherwise LGTM, thanks! Thanks, Ludo=E2=80=99. From unknown Mon Jun 23 02:21:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Mar 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator