GNU bug report logs - #45965
[PATCH 0/2] Update fzf, include binaries and install completions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45965: closed ([PATCH 0/2] Update fzf, include binaries and
 install completions)
Date: Fri, 19 Mar 2021 21:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 19 Mar 2021 22:15:56 +0100
with message-id <87o8fec0ab.fsf_-_ <at> gnu.org>
and subject line Re: bug#45965: [PATCH 0/2] Update fzf, include binaries and install completions
has caused the debbugs.gnu.org bug report #45965,
regarding [PATCH 0/2] Update fzf, include binaries and install completions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45965: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45965
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: EuAndreh <eu <at> euandre.org>
To: guix-patches <at> gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH 0/2] Update fzf, include binaries and install completions
Date: Mon, 18 Jan 2021 15:59:25 -0300

I've tested both the package update and the extra phases added.
The Bash completions are being installed properly, but I haven't tested
the zsh ones.

I remember seeing somewhere a discussion on aliasing this type of package,
so that the "go-github-com-junegunn-fzf" is the default imported Go module,
to be used as input for other packages, and adding a top-level "fzf" package,
which does the ad-hoc packaging code I've added, so that a user can install
the "fzf" package with Bash integration and similar features.

I couldn't find anything on the manual also, I welcome comments on this :)

EuAndreh (2):
  gnu: go-github-com-junegunn-fzf: Copy binaries and install shell
    completions.
  gnu: go-github-com-junegunn-fzf: Update to 0.25.0.

 gnu/packages/terminals.scm | 35 +++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)

-- 
2.30.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: EuAndreh <eu <at> euandre.org>
Cc: 45965-done <at> debbugs.gnu.org, mail <at> nicolasgoaziou.fr
Subject: Re: bug#45965: [PATCH 0/2] Update fzf, include binaries and install
 completions
Date: Fri, 19 Mar 2021 22:15:56 +0100

Hi,

EuAndreh <eu <at> euandre.org> skribis:

> * gnu/packages/terminals.scm (fzf): New variable, which inherits
>   from the existing go-github-com-junegunn-fzf package, but also
>   install other binary, and completion for direct usage.

I think it had fallen through the cracks; applied!

> +    (arguments
> +     `(,@(ensure-keyword-arguments
        ^^^
I simplified this to:

  (arguments (ensure-keyword-arguments …))

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.