GNU bug report logs - #45954
Telegram-CLI

Previous Next

Package: guix-patches;

Reported by: Raghav Gururajan <rg <at> raghavgururajan.name>

Date: Mon, 18 Jan 2021 09:18:02 UTC

Severity: normal

Done: Leo Prikler <leo.prikler <at> student.tugraz.at>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45954 in the body.
You can then email your comments to 45954 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Mon, 18 Jan 2021 09:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Raghav Gururajan <rg <at> raghavgururajan.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 18 Jan 2021 09:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: guix-patches <at> gnu.org
Subject: Telegram-CLI
Date: Mon, 18 Jan 2021 04:16:59 -0500
[Message part 1 (text/plain, inline)]
Hello Guix!

Please find the attached patch-set to add telegram-cli and its 
dependencies into Guix.

Regards,
RG.
[0018-gnu-Add-telegram-client.patch (text/x-patch, attachment)]
[0017-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0016-gnu-Add-tl-parser.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Tue, 19 Jan 2021 15:09:01 GMT) Full text and rfc822 format available.

Message #8 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Subject: Telegram-CLI (v2)
Date: Tue, 19 Jan 2021 10:08:39 -0500
[Message part 1 (text/plain, inline)]

[0018-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[0017-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0016-gnu-Add-tl-parser.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Wed, 20 Jan 2021 10:45:02 GMT) Full text and rfc822 format available.

Message #11 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Subject: Telegram-CLI (v3)
Date: Wed, 20 Jan 2021 05:44:18 -0500
[Message part 1 (text/plain, inline)]

[0018-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[0017-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0016-gnu-Add-tl-parser.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Fri, 22 Jan 2021 04:45:02 GMT) Full text and rfc822 format available.

Message #14 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Subject: Telegram-CLI (v4)
Date: Thu, 21 Jan 2021 23:44:46 -0500
[Message part 1 (text/plain, inline)]

[0018-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[0017-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0016-gnu-Add-tl-parser.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Thu, 28 Jan 2021 01:01:01 GMT) Full text and rfc822 format available.

Message #17 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Subject: Telegram-CLI (v5)
Date: Wed, 27 Jan 2021 20:00:39 -0500
[Message part 1 (text/plain, inline)]

[0016-gnu-Add-tl-parser.patch (text/x-patch, attachment)]
[0017-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0018-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Sun, 31 Jan 2021 19:47:02 GMT) Full text and rfc822 format available.

Message #20 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Telegram-CLI (v6)
Date: Sun, 31 Jan 2021 14:46:40 -0500
[Message part 1 (text/plain, inline)]
P.S. Just in case if v5 doesn't apply on current master.
[0001-gnu-Add-tl-parser.patch (text/x-patch, attachment)]
[0002-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0003-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Mon, 01 Feb 2021 08:31:02 GMT) Full text and rfc822 format available.

Message #23 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v6)
Date: Mon, 01 Feb 2021 09:30:43 +0100
Am Sonntag, den 31.01.2021, 14:46 -0500 schrieb Raghav Gururajan:
> +(define-public tgl
> +  (package
> +    (name "tgl")
> +    (version "2.0.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/vysheng/tgl.git")
> +         (commit "ffb04caca71de0cddf28cd33a4575922900a59ed")))
The commit does not match up with the version.  If this is intended,
use git-version instead.

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin-to (string-append out "/bin"))
> +                    (include-to (string-append out "/include"))
> +                    (lib-to (string-append out "/lib"))
> +                    (source (string-append (getenv "TEMP")
> "/source"))
> +                    (bin-from (string-append source "/bin"))
> +                    (lib-from (string-append source "/libs")))
> +               ;; Install executables.
> +               (with-directory-excursion bin-from
> +                 (for-each
> +                  (lambda (file)
> +                    (install-file file bin-to))
> +                  (list
> +                   "generate")))
> +               ;; Install headers.
> +               (with-directory-excursion source
> +                 (for-each
> +                  (lambda (file)
> +                    (install-file file (string-append include-to
> "/tgl/crypto"))
> +                    (delete-file file))
> +                  (find-files "crypto" "\\.h$"))
> +                 (for-each
> +                  (lambda (file)
> +                    (install-file file (string-append include-to
> "/tgl/auto"))
> +                    (delete-file file))
> +                  (find-files "auto" "\\.h$"))
> +                 (for-each
> +                  (lambda (file)
> +                    (install-file file (string-append include-to
> "/tgl"))
> +                    (delete-file file))
> +                  (find-files "." "\\.h$")))
> +               ;; Install libraries.
> +               (for-each
> +                (lambda (file)
> +                  (install-file file (string-append lib-to "/tgl")))
> +                (find-files lib-from "\\.(a|so)$")))
> +             #t)))))
You might want to write that in terms of copy-build-system.

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (source (string-append (getenv "TEMP")
> "/source")))
> +               ;; Install client.
> +               (install-file
> +                (string-append source "/bin/telegram-cli")
> +                (string-append out "/bin"))
> +               ;; Install daemon.
> +               (install-file
> +                (string-append source "/start-telegram-daemon")
> +                (string-append out "/bin"))
> +               ;; Install daemon script.
> +               (install-file
> +                (string-append source "/telegram-daemon")
> +                (string-append out "/etc/init.d"))
> +               ;; Install server public-key.
> +               (install-file
> +                (string-append source "/server.pub")
> +                (string-append out "/etc/telegram-cli")))
> +             #t))
Same here.  Also, I'm not sure if SysV init scripts are that compatible
with Guix running on Shepherd.  Is there a more direct way of launching
the daemon?

> +                   (("/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr
> /sbin:/usr/bin")
> +                    "$PATH")
Not that it makes much of a difference, as I doubt this file will still
be needed, but PATH=$PATH is a noop.  Perhaps you want (getenv "PATH")
instead?

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Mon, 01 Feb 2021 22:09:02 GMT) Full text and rfc822 format available.

Message #26 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Telegram-CLI (v7)
Date: Mon, 1 Feb 2021 17:08:18 -0500
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-tl-parser.patch (text/x-patch, attachment)]
[0002-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0003-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Mon, 01 Feb 2021 22:19:02 GMT) Full text and rfc822 format available.

Message #29 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v6)
Date: Mon, 1 Feb 2021 17:18:05 -0500
[Message part 1 (text/plain, inline)]
Hi Leo!

> The commit does not match up with the version.  If this is intended,
> use git-version instead.

Changed in v7.

> You might want to write that in terms of copy-build-system.

Hmm. I tried but couldn't come up with a way to do it like that. :(

> Same here.  Also, I'm not sure if SysV init scripts are that compatible
> with Guix running on Shepherd.  Is there a more direct way of launching
> the daemon?

Updated git-version in v7.

The script may only be used on foreign-distro for now. For guix system, 
we need to define a service for it.

Also, running telegram-cli doesn't require daemon, but vice-versa. The 
daemon is intended to be a complimentary feature to run telegram-cli on 
headless server.

> Not that it makes much of a difference, as I doubt this file will still
> be needed, but PATH=$PATH is a noop.  Perhaps you want (getenv "PATH")
> instead?

I don't think so. The file is a run-time script. So the script will use 
the value of env-var PATH provided by the system. Using (getenv "PATH") 
will instead use the value of PATH inside the build environment.

Regards,
RG.
[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Mon, 01 Feb 2021 22:40:01 GMT) Full text and rfc822 format available.

Message #32 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v7)
Date: Mon, 01 Feb 2021 23:39:20 +0100
Am Montag, den 01.02.2021, 17:08 -0500 schrieb Raghav Gururajan:
> +(define-public telegram-cli
> +  (let ((commit "6547c0b21b977b327b3c5e8142963f4bc246187a")
> +        (revision "324"))
> +    (package
> +      (name "telegram-cli")
> +      (version
> +       (git-version "1.3.1" revision commit))
I didn't notice this before, but is there a reason to package this
version over 1.3.1?

> (getenv "TEMP")
Please stop trying to use this as a snippet to mean "the root of the
source and build directory".  It is extremely obscure and people are
already using "../source" just fine.  (Just do an rgrep if you aren't
convinced.)

> > You might want to write that in terms of copy-build-system.
> 
> Hmm. I tried but couldn't come up with a way to do it like that. :(
You can still try harder for v8 ;)

> The script may only be used on foreign-distro for now. For guix
> system, 
> we need to define a service for it.
> 
> Also, running telegram-cli doesn't require daemon, but vice-versa.
> The 
> daemon is intended to be a complimentary feature to run telegram-cli
> on 
> headless server.
In that case, does the daemon script have any value of its own?  Given
that the latest release of telegram-cli is about six years old, I doubt
there is – foreign distros should already have it in their repos and
Guix as a package manager makes no claim to manage system stuff like
services on foreign distros.

> The file is a run-time script.
That means literally nothing.  The wrap phase exists for a reason, some
programs and script are even wrapped twice.

> Using (getenv "PATH") will instead use the value of PATH inside the
> build environment.
So you'll inadvertently have some native-inputs in it, is what you're
trying to say?  Of course, there are better ways of wrapping PATH, but
in this case wouldn't it be wise to limit it to just the expected
paths?  Again, assuming that there is even merit in shipping this file,
which is yet to be proven.

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Tue, 02 Feb 2021 02:26:02 GMT) Full text and rfc822 format available.

Message #35 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Telegram-CLI (v8)
Date: Mon, 1 Feb 2021 21:25:41 -0500
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-tl-parser.patch (text/x-patch, attachment)]
[0002-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0003-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Tue, 02 Feb 2021 02:34:01 GMT) Full text and rfc822 format available.

Message #38 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v7)
Date: Mon, 1 Feb 2021 21:33:43 -0500
[Message part 1 (text/plain, inline)]
Hi Leo!

> I didn't notice this before, but is there a reason to package this
> version over 1.3.1?

Yeah, there are quite a lot of improvements after the 1.3.1 release.

> Please stop trying to use this as a snippet to mean "the root of the
> source and build directory".  It is extremely obscure and people are
> already using "../source" just fine.  (Just do an rgrep if you aren't
> convinced.)

Fixed in v8.

>> Hmm. I tried but couldn't come up with a way to do it like that. :(
> You can still try harder for v8 ;)

I tried different ways but the arguments key-words between gnu and copy 
differ a lot. I am unable use key-words from both build systems at the 
same time. Like using #:configure-flags (from gnu) and #:install (from 
copy).

Also, I spent significant amount time to come up the phase I have. So if 
there are no critical issues, I would like to keep it as-is. :-)

>> The script may only be used on foreign-distro for now. For guix
>> system,
>> we need to define a service for it.
>>
>> Also, running telegram-cli doesn't require daemon, but vice-versa.
>> The
>> daemon is intended to be a complimentary feature to run telegram-cli
>> on
>> headless server.
> In that case, does the daemon script have any value of its own?  Given
> that the latest release of telegram-cli is about six years old, I doubt
> there is – foreign distros should already have it in their repos and
> Guix as a package manager makes no claim to manage system stuff like
> services on foreign distros.
> 
>> The file is a run-time script.
> That means literally nothing.  The wrap phase exists for a reason, some
> programs and script are even wrapped twice.
> 
>> Using (getenv "PATH") will instead use the value of PATH inside the
>> build environment.
> So you'll inadvertently have some native-inputs in it, is what you're
> trying to say?  Of course, there are better ways of wrapping PATH, but
> in this case wouldn't it be wise to limit it to just the expected
> paths?  Again, assuming that there is even merit in shipping this file,
> which is yet to be proven.

I don't know what I was thinking. XD. It is pretty useless to ship. I 
removed it in v8.

Regards,
RG.
[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Tue, 02 Feb 2021 09:51:02 GMT) Full text and rfc822 format available.

Message #41 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v7/v8)
Date: Tue, 02 Feb 2021 10:50:53 +0100
Hi Raghav,

Am Montag, den 01.02.2021, 21:33 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > I didn't notice this before, but is there a reason to package this
> > version over 1.3.1?
> 
> Yeah, there are quite a lot of improvements after the 1.3.1 release.
Anything particularly worth noting?

> > Please stop trying to use this as a snippet to mean "the root of
> > the
> > source and build directory".  It is extremely obscure and people
> > are
> > already using "../source" just fine.  (Just do an rgrep if you
> > aren't
> > convinced.)
> 
> Fixed in v8.
"Fixed".  While it is true, that you're no longer using getenv, binding
source for string-append later on is not a particularly elegant
solution either.

> > > Hmm. I tried but couldn't come up with a way to do it like that.
> > > :(
> > You can still try harder for v8 ;)
> 
> I tried different ways but the arguments key-words between gnu and
> copy 
> differ a lot. I am unable use key-words from both build systems at
> the 
> same time. Like using #:configure-flags (from gnu) and #:install
> (from 
> copy).
Use something along the lines of
  (replace 'install 
    (lambda args
      (apply (assoc-ref copy:%standard-phases 'install)
             #:install-plan <your install plan>
             args)))
Phases should be written in a way, that gratuitous arguments will not
be read, but passing it in arguments through the package-arguments
fields remains tricky.  Though even if it were possible, the snippet
above has better locality.

> Also, I spent significant amount time to come up the phase I have. So
> if 
> there are no critical issues, I would like to keep it as-is. :-)
I personally regard readability as a severe issue in this case.  Of
course there would be ways of doing this without invoking copy-build-
system, but in my personal opinion an install plan would likely be the
most concise here.

For instance instead of using string-append source everywhere, you
could just use a directory excursion.  But more importantly, why is it,
that all of the stuff you're installing is located in the source
directory?  Do you even build anything that ends up in the
installation?  Would it make more sense to have #:out-of-source? #f?

In tgl, you use several directory excursions when arguably only one
would be needed.  Try to simplify your install process, so that you
need to bind as few variables as possible.

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Wed, 03 Feb 2021 01:57:01 GMT) Full text and rfc822 format available.

Message #44 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Telegram-CLI (v9)
Date: Tue, 2 Feb 2021 20:56:37 -0500
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-tl-parser.patch (text/x-patch, attachment)]
[0002-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0003-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Wed, 03 Feb 2021 02:42:01 GMT) Full text and rfc822 format available.

Message #47 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v7/v8)
Date: Tue, 2 Feb 2021 21:41:14 -0500
[Message part 1 (text/plain, inline)]
Hi Leo!

> Anything particularly worth noting?

Not sure. But based on commit messages, it seems lot of bug fixes.

>>> Please stop trying to use this as a snippet to mean "the root of
>>> the
>>> source and build directory".  It is extremely obscure and people
>>> are
>>> already using "../source" just fine.  (Just do an rgrep if you
>>> aren't
>>> convinced.)
>>
>> Fixed in v8.
> "Fixed".  While it is true, that you're no longer using getenv, binding
> source for string-append later on is not a particularly elegant
> solution either.
> 
>>>> Hmm. I tried but couldn't come up with a way to do it like that.
>>>> :(
>>> You can still try harder for v8 ;)
>>
>> I tried different ways but the arguments key-words between gnu and
>> copy
>> differ a lot. I am unable use key-words from both build systems at
>> the
>> same time. Like using #:configure-flags (from gnu) and #:install
>> (from
>> copy).
> Use something along the lines of
>    (replace 'install
>      (lambda args
>        (apply (assoc-ref copy:%standard-phases 'install)
>               #:install-plan <your install plan>
>               args)))
> Phases should be written in a way, that gratuitous arguments will not
> be read, but passing it in arguments through the package-arguments
> fields remains tricky.  Though even if it were possible, the snippet
> above has better locality.
> 
>> Also, I spent significant amount time to come up the phase I have. So
>> if
>> there are no critical issues, I would like to keep it as-is. :-)
> I personally regard readability as a severe issue in this case.  Of
> course there would be ways of doing this without invoking copy-build-
> system, but in my personal opinion an install plan would likely be the
> most concise here.
> 
> For instance instead of using string-append source everywhere, you
> could just use a directory excursion.  But more importantly, why is it,
> that all of the stuff you're installing is located in the source
> directory?  Do you even build anything that ends up in the
> installation?  Would it make more sense to have #:out-of-source? #f?
> 
> In tgl, you use several directory excursions when arguably only one
> would be needed.  Try to simplify your install process, so that you
> need to bind as few variables as possible.

Agreed. I have updated the pack-def in v9. :-)

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Wed, 03 Feb 2021 08:17:02 GMT) Full text and rfc822 format available.

Message #50 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v9)
Date: Wed, 03 Feb 2021 09:16:47 +0100
Hello Raghav,

Am Dienstag, den 02.02.2021, 20:56 -0500 schrieb Raghav Gururajan:
> +         (,@%gnu-build-system-modules
> +          (guix build copy-build-system))
> +         #:modules
> +         ((guix build gnu-build-system)
> +          ((guix build copy-build-system)
> +           #:prefix copy:)
> +          (guix build utils))
It is Guix convention to put the added component in front of the
others, i.e. 
> +         ((guix build copy-build-system)
> +          ,@%gnu-build-system-modules)
and so on.  Otherwise LGTM so far; I'll be doing functionality tests
later today.  If you don't send v10 by then, I can also make that
change for you.

Regards,
Leo





Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Wed, 03 Feb 2021 17:51:01 GMT) Full text and rfc822 format available.

Message #53 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 45954 <at> debbugs.gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Telegram-CLI (v10)
Date: Wed, 3 Feb 2021 12:50:37 -0500
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-tl-parser.patch (text/x-patch, attachment)]
[0002-gnu-Add-tgl.patch (text/x-patch, attachment)]
[0003-gnu-Add-telegram-cli.patch (text/x-patch, attachment)]
[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#45954; Package guix-patches. (Wed, 03 Feb 2021 17:53:02 GMT) Full text and rfc822 format available.

Message #56 received at 45954 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45954 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v9)
Date: Wed, 3 Feb 2021 12:52:00 -0500
[Message part 1 (text/plain, inline)]
Hi Leo!

> It is Guix convention to put the added component in front of the
> others, i.e.
>> +         ((guix build copy-build-system)
>> +          ,@%gnu-build-system-modules)
> and so on.  Otherwise LGTM so far; I'll be doing functionality tests
> later today.  If you don't send v10 by then, I can also make that
> change for you.

I have sent v10. :-)

Regards,
RG.
[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Reply sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
You have taken responsibility. (Wed, 03 Feb 2021 18:19:01 GMT) Full text and rfc822 format available.

Notification sent to Raghav Gururajan <rg <at> raghavgururajan.name>:
bug acknowledged by developer. (Wed, 03 Feb 2021 18:19:01 GMT) Full text and rfc822 format available.

Message #61 received at 45954-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 45954-done <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: Telegram-CLI (v10)
Date: Wed, 03 Feb 2021 19:18:20 +0100
Thanks, pushed!





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 04 Mar 2021 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 108 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.