From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 18 03:54:36 2021 Received: (at submit) by debbugs.gnu.org; 18 Jan 2021 08:54:36 +0000 Received: from localhost ([127.0.0.1]:46285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1QJ0-0001AV-55 for submit@debbugs.gnu.org; Mon, 18 Jan 2021 03:54:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:48824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1PrY-0000Un-GG for submit@debbugs.gnu.org; Mon, 18 Jan 2021 03:26:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1PrY-00078E-79 for guix-patches@gnu.org; Mon, 18 Jan 2021 03:26:12 -0500 Received: from mx08-00115501.pphosted.com ([91.207.212.23]:12624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1PrU-0004cF-RI for guix-patches@gnu.org; Mon, 18 Jan 2021 03:26:11 -0500 Received: from pps.filterd (m0030078.ppops.net [127.0.0.1]) by mx08-00115501.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10I8PUX1028354 for ; Mon, 18 Jan 2021 09:26:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=radiofrance.com; h=from : to : subject : date : message-id : content-type : content-id : content-transfer-encoding : mime-version; s=radiofrance20190306; bh=xEvn9GsDZ5fnhqUAPU9eZvLRe42UaqIShjI09A29I20=; b=f2sKlMUcKvaVrFQpMejhY5Yun64JukBhU451bbhsPW+wegDQEfPJMxeAzrM1wNeldqU5 xiV1DXf7A/MV0MjFxeRQWJwvSxDLY4qtUvnjEoBikjU6/CS4OcLziaN8Gin0VPhjVva4 jaG/pRjq/0iJsIEEbFi+oR8lYbmKIJtVmOnebU0FKdF+uBljFBtOPIU1WBVDGTG8aPCd mCoGQ2bsBo5QJ4ICvsylfyR8lCuEIuEWzIc8hRixLyhlyCkPStiwfqf5/nAq46+OnqYe RpLEddGRWSh7yDdVkRas0Gla/YTyYXQLjHuUso/W9CfOjMdDt6JuzDg0kkUEwRTfIyeq mA== Received: from fra01-pr2-obe.outbound.protection.outlook.com (mail-pr2fra01lp0102.outbound.protection.outlook.com [104.47.24.102]) by mx08-00115501.pphosted.com with ESMTP id 363mq0aa6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Jan 2021 09:26:04 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbF7PjAnPTYlEOJuHDFaKzV1U6/qP+LnF9aYtu4zKC9xzGK8SmKnZMenHqQpPSBG/BkAv3t7wETUK0I/0JgUsDyT9SvKv27H2ukgTgBpPhXbPLaAVavGLab3blAInHn3m3ZQ0M91Eei6OSQruCR2nvxFrbiOdmZNpAdH2b2eBcEMqho1FkVcY4hlMaqsDdJnsgZJwno+/fLBFc6tPvh4h+u/kpLZ9yZ6h+J8GCV/tdhVNvY0wj4eldpm7pDKvD8DrZaQKnp4VQtppjk9PAdHNAaVl1HXAhTpGvACxN8oxI60cx0CKf5jWSZcRETPaqacfjRMP0WcJFwZePKaprpnIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEvn9GsDZ5fnhqUAPU9eZvLRe42UaqIShjI09A29I20=; b=IzzPH9h37tPgH5yrEb5iCodapd9baV4QR3BJAd6ONwl2mqeCI3H5/Bdy+Q6IaABB7dKtpLG/+QgjD+POJsS9WFBTVsHMjoukvcjB+BT6mJEZi/iTeJWE/uWRvNMey6LTPQPJE1MiI0TF43fVi2NX/R8zoFOiBJq/PIN3PlXnsBuBxk/QjVfDtScwdBm/MNpthy/zkIUmHK6umnA8Y+7Nf16Ur/yaVjBzlgcOQt1XfzR1IISfERLiRn+M619lrlImaqilOvyLsEYOVpUoTLgnTRKoBngNtp7CAzd9oCZ4Qcu5JXmY8lLuAxPH2cgh5zsF9l6U7gf4T6MUQgIfPFVGyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=radiofrance.com; dmarc=pass action=none header.from=radiofrance.com; dkim=pass header.d=radiofrance.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=RFonline.onmicrosoft.com; s=selector2-RFonline-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEvn9GsDZ5fnhqUAPU9eZvLRe42UaqIShjI09A29I20=; b=iX58H3+F+AqkzICfn1PMHaP8031V5vdrA7/7Ar5rJfQj6gAU5ZFG3Ljz48DVAp3ui9LrF7ZshkOEuJ3Boj8o9BfEb+B0OmiCNSnHAqAWlQ2DOpiqP6tpJIxfl9hfQcvJq9iDqJjJ3yZJp0hCV0kuj7eYqGni+bFFLiwVcgUKqx4= Received: from PR0P264MB0425.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:b::20) by PR0P264MB0700.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:10::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.13; Mon, 18 Jan 2021 08:26:03 +0000 Received: from PR0P264MB0425.FRAP264.PROD.OUTLOOK.COM ([fe80::9b7:6491:8aa7:550b]) by PR0P264MB0425.FRAP264.PROD.OUTLOOK.COM ([fe80::9b7:6491:8aa7:550b%3]) with mapi id 15.20.3763.013; Mon, 18 Jan 2021 08:26:02 +0000 From: =?iso-8859-1?Q?JOULAUD_Fran=E7ois?= To: "guix-patches@gnu.org" Subject: [PATCH] environment: fix --root option with relative path Thread-Topic: [PATCH] environment: fix --root option with relative path Thread-Index: AQHW7XOOkTPfzcYV5EODBr2T6j9Swg== Date: Mon, 18 Jan 2021 08:26:02 +0000 Message-ID: <20210118082300.phr55ee5chgwmptl@fjo-extia-HPdeb.example.avalenn.eu> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=radiofrance.com; x-originating-ip: [88.126.13.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8fc5a7fd-5588-4607-93bf-08d8bb8ab169 x-ms-traffictypediagnostic: PR0P264MB0700: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PDquYvH7QK878rA5maDyuvatuf+qsMYVnF7dAknCxOBOvLj1UyFZ693GZsHhJ7s4xmJ1ggiew5A9U3rOD6Nq2bCaq2tRtI5ArQyKbRhU51RH3wpX27U3o+TjNe19T5r/zhFF3CdtX4NN1W5oFYoFa7c7QPN98ELD2xXXxzi16tmucOO5rGfDkfSsL1P/aams0seZUdzZaeAkqHMvPxuA/nVHmRn65Y0AZTzhLeKi/MbBo1EDaSQkjg2JP7+6+E0e3onlRsiUdhf6NJjOzgkUbO0E9YiCc3M4jgquNNE2cBjt6GAVFCvkfw7Vg74rL3hhH46EroQtz9liWd5MleNTW8O7veT58d4jDnvD8Ozke9YW+lueT6PLQsKFuIKLYcCdxii4qdekpqdl/pFGgSMqbw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR0P264MB0425.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(346002)(376002)(136003)(396003)(366004)(186003)(86362001)(66946007)(71200400001)(83380400001)(6486002)(6506007)(8936002)(8676002)(1076003)(5660300002)(76116006)(66446008)(4744005)(6916009)(26005)(64756008)(66556008)(66476007)(2906002)(316002)(6512007)(9686003)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?7aUppPrZtYnW+FA4RQn21lc4fYeZX47gtCP//bpdIuxDJ+WW5k8SFR9H7a?= =?iso-8859-1?Q?BI26OLXXpxtJ/nPoJQ/Gf7U9OkXo08AvzNqMs343Q/FDdFCJyydeeuKVoS?= =?iso-8859-1?Q?rye/tfh6VAXHM4kOiZfM9gsqy0Qzxwf+XPZrDrK+IQR644vwoIWATT+lXN?= =?iso-8859-1?Q?3pmKN3LHBOpaXCxV5a+7astErtPyTKx8kAkU/IIR80Ff9KagzYdMAltxdu?= =?iso-8859-1?Q?zMqBzwOR0lQj4lIWUOPINOaRVwIEw5rgOTPhW1pdz7cL9siP8ZpPUGWiUg?= =?iso-8859-1?Q?xF69AYAmRI77mKIczy3CaME9zWTGKd4JMd7a4iH/L7GOP6CJkmoERs05+Q?= =?iso-8859-1?Q?ljUWhxuMF8ibduoMWY0J5WsZAcZv3ok8yAYNvVyfNauHKp7wfEGle9M96Q?= =?iso-8859-1?Q?PGqb0WN1rKeNnOYY8E59COZGZfR0ELEA5HkbrkAG0k53w8+LxYozl+9yYS?= =?iso-8859-1?Q?EzQPBncA4lDMf15IIqFQ8BnH/YKRf+Zvf+5DCWUaJgcn77Th+NKkrm8/iA?= =?iso-8859-1?Q?xfh7bsqtjFT8XC3nytATfiB/qm60+ED9jjReKRFJr8pd7XKCHh8oDo5N44?= =?iso-8859-1?Q?t9pxiClGXeyb56+9Vz2o94BI1PCHgtRgtIovpn1+dGxB3wtQ2JkuIHFNFM?= =?iso-8859-1?Q?Kd4GlD+4/3itdXF2q0njKrQiRrLTRCpTKhPzCWiWodf6PxOs/BfMQmloYu?= =?iso-8859-1?Q?xN01vixeHaoHGSbOaUd8vStauS/Qi63lzrtEoFECvbR1zzqtXuuu72tH8D?= =?iso-8859-1?Q?TKeh9O3R9CLIgARZBOtSKHaC7s4f3LBVW23sfi2s0qpU5F4hoz+jdGimZA?= =?iso-8859-1?Q?eXP2Kind3K6AlJTZx9w0im07wgx9OyckA2codc6M2kbBXap8tn7NqBg9gw?= =?iso-8859-1?Q?JgyQGE5eiCrqe79uLQ4bbIJ0DCsNPpXtBvGI46dQ7oazRVNLa23/zc8eGz?= =?iso-8859-1?Q?yysj6PBxAd/Qjd+PqHBV8QPYKhgda4XQix/GXzok6HMbkfcmIbBwKZqRDL?= =?iso-8859-1?Q?P+XaKaXATgQMNYmnIh+ja9puVk44jhnjlvwJr6?= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <51523CF864F89347A618BB9F6308D7BC@FRAP264.PROD.OUTLOOK.COM> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: radiofrance.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PR0P264MB0425.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc5a7fd-5588-4607-93bf-08d8bb8ab169 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2021 08:26:02.8702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 1d643b07-8cf5-4e2d-ad1e-86d6b948fc3b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mvx4kgw9nrODdB9iFlTZ3Zgd1pb76ylOhBdk0Ifzq/nPs/hgPFPJVPS/EHHO1x2I5MFYUPGqHbXKKZbMU526MXZKKik1wmYHNPAGAPMYFpvoKpPeTcZ1YAIDJy5IxPZL X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR0P264MB0700 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-18_07:2021-01-15, 2021-01-18 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1011 mlxscore=0 mlxlogscore=602 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101180050 Received-SPF: pass client-ip=91.207.212.23; envelope-from=prvs=8652e8b8a9=francois.joulaud@radiofrance.com; helo=mx08-00115501.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 18 Jan 2021 03:54:32 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The path normalization of `--root` option of `guix environment` was buggy as it appended full argument after normalized directory. This patch fixes it. * guix/scripts/environment.scm: fix gc-root path normalization Signed-off-by: Francois Joulaud --- guix/scripts/environment.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index fbc202c658..f4d12f89bf 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -675,7 +675,7 @@ message if any test fails." (let* ((root (if (string-prefix? "/" root) root (string-append (canonicalize-path (dirname root)) - "/" root)))) + "/" (basename root))))) (catch 'system-error (lambda () (symlink target root) --=20 2.28.0= From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 12:17:05 2021 Received: (at 45953-done) by debbugs.gnu.org; 19 Jan 2021 17:17:05 +0000 Received: from localhost ([127.0.0.1]:51477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1ucr-0001NF-Gk for submit@debbugs.gnu.org; Tue, 19 Jan 2021 12:17:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1ucn-0001Mg-Ge for 45953-done@debbugs.gnu.org; Tue, 19 Jan 2021 12:17:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56580) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1uch-0006C4-Fs; Tue, 19 Jan 2021 12:16:55 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47648 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1ucg-0006ip-VQ; Tue, 19 Jan 2021 12:16:55 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: JOULAUD =?utf-8?Q?Fran=C3=A7ois?= Subject: Re: bug#45953: [PATCH] environment: fix --root option with relative path References: <20210118082300.phr55ee5chgwmptl@fjo-extia-HPdeb.example.avalenn.eu> Date: Tue, 19 Jan 2021 18:16:53 +0100 In-Reply-To: <20210118082300.phr55ee5chgwmptl@fjo-extia-HPdeb.example.avalenn.eu> ("JOULAUD =?utf-8?Q?Fran=C3=A7ois=22's?= message of "Mon, 18 Jan 2021 08:26:02 +0000") Message-ID: <87mtx4hmnu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45953-done Cc: 45953-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, JOULAUD Fran=C3=A7ois skribis: > The path normalization of `--root` option of `guix environment` was > buggy as it appended full argument after normalized directory. This > patch fixes it. > > * guix/scripts/environment.scm: fix gc-root path normalization Good catch! I added a test, tweaked the commit log, and pushed: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D4d79f072cc7b502fc= 25486d514c9200ba684a596 Thanks, Ludo=E2=80=99. From unknown Sat Aug 09 20:34:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Feb 2021 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator