GNU bug report logs - #45945
28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Mon, 18 Jan 2021 01:56:02 UTC

Severity: wishlist

Found in version 28.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45945 in the body.
You can then email your comments to 45945 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to rudalics <at> gmx.at, juri <at> linkov.net, bug-gnu-emacs <at> gnu.org:
bug#45945; Package emacs. (Mon, 18 Jan 2021 01:56:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dmitry Gutov <dgutov <at> yandex.ru>:
New bug report received and forwarded. Copy sent to rudalics <at> gmx.at, juri <at> linkov.net, bug-gnu-emacs <at> gnu.org. (Mon, 18 Jan 2021 01:56:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Feature request: Some kind of 'max-window-height' parameter
 for display-buffer-in-direction
Date: Mon, 18 Jan 2021 03:55:00 +0200
X-Debbugs-CC: rudalics <at> gmx.at, juri <at> linkov.net

It will be helpful to limit the height of the resulting window (either
in lines or in percentages of the parent window height). If the split 
has been performed, of course.

At the moment, it can take up almost all of the parent window's height,
and that's not ideal for our use of it in
xref-show-definitions-buffer-at-bottom.




Reply sent to Dmitry Gutov <dgutov <at> yandex.ru>:
You have taken responsibility. (Tue, 19 Jan 2021 01:12:02 GMT) Full text and rfc822 format available.

Notification sent to Dmitry Gutov <dgutov <at> yandex.ru>:
bug acknowledged by developer. (Tue, 19 Jan 2021 01:12:02 GMT) Full text and rfc822 format available.

Message #10 received at 45945-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 45945-done <at> debbugs.gnu.org
Subject: Re: bug#45945: 28.0.50; Feature request: Some kind of
 'max-window-height' parameter for display-buffer-in-direction
Date: Tue, 19 Jan 2021 03:11:50 +0200
On 18.01.2021 03:55, Dmitry Gutov wrote:
> It will be helpful to limit the height of the resulting window (either
> in lines or in percentages of the parent window height). If the split 
> has been performed, of course.

Looks like I've managed that with 'window-height' alist entry set to a 
function that wraps fit-window-to-buffer.

Commit 4ca808ee7a in master.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#45945; Package emacs. (Tue, 19 Jan 2021 17:59:03 GMT) Full text and rfc822 format available.

Message #13 received at 45945 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 45945 <at> debbugs.gnu.org
Cc: rudalics <at> gmx.at, dgutov <at> yandex.ru
Subject: Re: bug#45945: 28.0.50; Feature request: Some kind of
 'max-window-height' parameter for display-buffer-in-direction
Date: Tue, 19 Jan 2021 19:41:10 +0200
>> It will be helpful to limit the height of the resulting window (either
>> in lines or in percentages of the parent window height). If the split has
>> been performed, of course.
>
> Looks like I've managed that with 'window-height' alist entry set to
> a function that wraps fit-window-to-buffer.
>
> Commit 4ca808ee7a in master.

Indeed, maybe this could be customizable.  For example,
like there is the customizable variable display-buffer-alist,
a new customizable variable with a name like post-display-buffer-functions
could be used to add/remove such hooks as fit-window-to-buffer.
like temp-buffer-resize-mode does.  But this should a more general feature.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#45945; Package emacs. (Tue, 19 Jan 2021 19:32:01 GMT) Full text and rfc822 format available.

Message #16 received at 45945 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>, 45945 <at> debbugs.gnu.org
Subject: Re: bug#45945: 28.0.50; Feature request: Some kind of
 'max-window-height' parameter for display-buffer-in-direction
Date: Tue, 19 Jan 2021 21:31:43 +0200
On 19.01.2021 19:41, Juri Linkov wrote:
>>> It will be helpful to limit the height of the resulting window (either
>>> in lines or in percentages of the parent window height). If the split has
>>> been performed, of course.
>>
>> Looks like I've managed that with 'window-height' alist entry set to
>> a function that wraps fit-window-to-buffer.
>>
>> Commit 4ca808ee7a in master.
> 
> Indeed, maybe this could be customizable.  For example,
> like there is the customizable variable display-buffer-alist,
> a new customizable variable with a name like post-display-buffer-functions
> could be used to add/remove such hooks as fit-window-to-buffer.
> like temp-buffer-resize-mode does.  But this should a more general feature.

The general feature sounds interesting, but I personally have avoided 
customizing even display-buffer-alist so far, and doing that with either 
of the variables (the existing or the proposed one) seems pretty far 
from the capabilities of an average Emacs user.

Speaking of customization, I rather wondered whether the max height 
percentage in xref-show-definitions-buffer-at-bottom should be 
customizable (as a float number, probably).




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 17 Feb 2021 12:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.