GNU bug report logs - #45905
[PATCH] IPFS service definition

Previous Next

Full log

Message #26 received at 45905 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
Cc: 45905 <at> debbugs.gnu.org
Subject: [PATCH v3] IPFS service definition
Date: Tue, 30 Mar 2021 15:37:46 +0200

[Message part 1 (text/plain, inline)]

Hi Guix,

Revised patch series is attached.

Changes in v2:

* let the shepherd service depend on (loopback) instead of
  (networking)
* added a (broken) system test for the IPFS service

Changes in v3:

* added 'extensions' argument to 'marionette-operating-system'. 
* fixed the system test
* tweaked the documentation formatting and removed a misleading comment
  on forwarding (port forwarding would be fine here, as the test is run
  in a container so there is no risk of port conflicts IIUC)

Ludovic Courtès wrote:
> Nitpick: please avoid ‘@’.  Instead, explicitly do:
> [...]

I actually prefer '(@ (...) ...)' here, but whatever.  It's changed
in v3.

> As it stands, the test fails because you need to:
>  (define test
>    (with-extensions (list guile-json)
>      …))

As the uploading and downloading is done in the guest, not the host,
this needs to be done somewhat differently.  That's what the patch
‘tests: Support package extensions in the backdoor REPL’ is for.

Greetings,
Maxime

[0001-services-Add-ipfs-service-type.patch (text/x-patch, attachment)]

[0002-Add-guix-ipfs.patch (text/x-patch, attachment)]

[0003-tests-Support-package-extensions-in-the-backdoor-REP.patch (text/x-patch, attachment)]

[0004-gnu-tests-Test-basic-funtionality-of-the-IPFS-servic.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.