GNU bug report logs - #45897
27.1; python mode font-lock confused by string concatenation

Previous Next

Full log

Message #17 received at 45897 <at> debbugs.gnu.org (full text, mbox):

From: kobarity <kobarity <at> gmail.com>
To: Jakub Ječmínek <jecminek.k <at> gmail.com>
Cc: 45897 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#45897: [PATCH] 27.1;
 python mode font-lock confused by string concatenation
Date: Sun, 21 Jan 2024 00:41:22 +0900

[Message part 1 (text/plain, inline)]

On Sat, 20 Jan 2024 19:09:50 +0900,
Eli Zaretskii wrote:
> 
> > From: Jakub Ječmínek <jecminek.k <at> gmail.com>
> > Date: Fri, 19 Jan 2024 18:25:57 +0100
> > 
> > Tags: patch
> > 
> > I'm sending the patch once again with correct indentation and patch tag
> > (I'm still figuring out how the bug tracker works).
> 
> Thanks.
> 
> Kobarity, any comments?

Thank you for the patch.  I tried it and confirmed that the example
shown by Tom Tromey is fixed.

I think ppss and line-ppss would be the same in this example.  Can you
give an example of a case where ppss and line-ppss are different?

I noticed an error in the commit-msg hook when applying the patch.
CONTRIBUTE states the following:

- Lines in ChangeLog entries should preferably be not longer than 63
  characters, and must not exceed 78 characters, unless they consist
  of a single word of at most 140 characters; this 78/140 limit is
  enforced by a commit hook.

Also, the indentation still looks wrong to me.  It might be better to
attach the patch instead of pasting it into the body of the mail.

Attached is a patch to add an ERT that identifies this issue.  Please
add it to your patch if you like.

[0001-Add-an-ERT-for-bug-45897.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.