GNU bug report logs - #45889
Nextcloud Client

Previous Next

Full log

View this message in rfc822 format

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 45889 <at> debbugs.gnu.org
Subject: [bug#45889] Nextcloud Client (v16)
Date: Tue, 9 Mar 2021 05:50:43 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Try not to arbitrarily use too many new lines.  If you break Scheme
> code in such a manner for no good reason, it will look odd.

Done.

> Why not to UTF-8?

Done.

> You should install the shared libraries in the install phase.

Done.

> Use '(...) for fixed input.

Done.

> I'm starting to grow a little suspicious about matching the leading
> spaces.  You probably want to lead this (and similar stuff in 0001)
> with [ \t]*.

Done.

> LGTM, but probably deserves a comment.

Done.

> Definitely deserves a comment and perhaps a less broad match?

Done the comment.

I think this is perfect match. The mentioned libraries will get linked 
wherever synclib gets linked. Also, this patch is compatible with 
current master, which is different from this version.

> Also deserves a comment about QtSingleApplication differences.

Done.

> Would the raw string here exceed a line?

Yep!

> This is now just qtokenizer, right?

Changed.

Please find the attached v16.

Regards,
RG.

[0001-gnu-Add-appstream.patch (text/x-patch, attachment)]

[0002-gnu-Add-qtsolutions.patch (text/x-patch, attachment)]

[0003-gnu-Add-nextcloud-client.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.