From unknown Sat Jun 14 18:07:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45872 <45872@debbugs.gnu.org> To: bug#45872 <45872@debbugs.gnu.org> Subject: Status: 27.1; rcirc nick tracking Reply-To: bug#45872 <45872@debbugs.gnu.org> Date: Sun, 15 Jun 2025 01:07:02 +0000 retitle 45872 27.1; rcirc nick tracking reassign 45872 emacs submitter 45872 Ken Raeburn severity 45872 normal tag 45872 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 14 14:43:01 2021 Received: (at submit) by debbugs.gnu.org; 14 Jan 2021 19:43:01 +0000 Received: from localhost ([127.0.0.1]:39321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l08WK-0004eg-Cl for submit@debbugs.gnu.org; Thu, 14 Jan 2021 14:43:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:54792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l08WG-0004eX-Tc for submit@debbugs.gnu.org; Thu, 14 Jan 2021 14:42:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l08WG-0005nU-KZ for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 14:42:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l08WD-00016j-Ee for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 14:42:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610653369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=km+tARpXKsMQhJeoiWL6G18gLqzCDOdj2XzsDaW5pSA=; b=iNP8rLpOwklG41eMO6+nDcI3a/yqlav8QWphqGgUoVCW99iwTMnW7E0wsFTnzZ0A22ezzt E9IABaKDGCexBx8S9NJ0JwQEJdRT0pfdHXEC//TNR3mypGxzF6C/xWgnW1jzmQtXOJ0RaY ynVN8O8lkU9G1aFQbC+LL0Fv2j8RQ+w= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-5CBTHO4xNZGSraOnyUmKrQ-1; Thu, 14 Jan 2021 14:42:47 -0500 X-MC-Unique: 5CBTHO4xNZGSraOnyUmKrQ-1 Received: by mail-pl1-f197.google.com with SMTP id 32so3809236plf.3 for ; Thu, 14 Jan 2021 11:42:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=km+tARpXKsMQhJeoiWL6G18gLqzCDOdj2XzsDaW5pSA=; b=hwPI8Jy85+MQb8HG/ZJGoNUahp75PXa3D1W+KkDyCj+UPmyYW2Ox3Cw8B09g5stbAn 3tSJ7gjmdicqr+t0Lw17ph0s6V6HpnlhDrHBnzu9LpyvZQHZkPnXJOuOeoddtf5ZsrAd 2COvFBM/w0I0foANKfYIeC01/pcu4QTvXcAQv3trc5TMXtfEb4/GQcIRvWLMRbULN7pE SW9cRmd7IOIgaYmUhELBzUcuvypg3GxrwzPekMcvNYzhs3BCdpWKylRkFW1YcasBgS+Z dCuggSZMNSdMjV5IZ/w/A81AsTB0jHV7vfd9OrDNVYbLP+g6+CKETgzfRyaLbkqhLApP 6jqg== X-Gm-Message-State: AOAM533wajh84FhomPvZq3DhMg6w35j0IPhi0P7tj1iaT4H514or63VW tVUBFutTg0I9E4X3zmwOncVui61NskOcHyt8gj6FIz0xvu/WQ/FCnYsRof5olxwGeW92LhSNjD5 U/tfdsZzL7Qg6mKA= X-Received: by 2002:a62:3:0:b029:160:d92:2680 with SMTP id 3-20020a6200030000b02901600d922680mr8726679pfa.44.1610653366341; Thu, 14 Jan 2021 11:42:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVx5dsZODnk7YkkIBzZysJocwK/smQ/hEV3hyErpLoADjQuMk8W27YClGpTbmHagRU4Mjapw== X-Received: by 2002:a62:3:0:b029:160:d92:2680 with SMTP id 3-20020a6200030000b02901600d922680mr8726644pfa.44.1610653365930; Thu, 14 Jan 2021 11:42:45 -0800 (PST) Received: from crash (c-71-233-156-139.hsd1.ma.comcast.net. [71.233.156.139]) by smtp.gmail.com with ESMTPSA id b11sm5840486pfr.38.2021.01.14.11.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 11:42:45 -0800 (PST) From: Ken Raeburn To: bug-gnu-emacs@gnu.org Subject: 27.1; rcirc nick tracking Date: Thu, 14 Jan 2021 14:42:40 -0500 Message-ID: <87zh1bwbin.fsf@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=raeburn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=raeburn@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.248, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) One of my IRC contacts uses frequent nick changes to indicate away status, e.g., "johnsmith" when available, "johnsmith|away", "johnsmith|vacation", whatever. I've noticed that sometimes rcirc will fail to rename the buffer used for private messages between us, and so I'll wind up with a buffer "johnsmith|away" showing something along the lines of: ... *** johnsmith NICK johnsmith|away ... *** johnsmith|away NICK johnsmith but the buffer won't have been renamed back to "johnsmith@", and if I try sending him a message, it'll try sending to johnsmith|away and will fail. I can use "/msg johnsmith...", or he can send messages to me, and a new buffer will be created. If, after this new buffer has been created, he issues a NICK command, rcirc will attempt a rename, and may error out if it conflicts with the existing johnsmith|away buffer. The issue seems to be that rcirc-handler-NICK looks up the chat buffer using rcirc-get-buffer, which uses rcirc-buffer-alist, but doesn't update that alist, so a second invocation of rcirc-get-buffer using the new nick won't find that buffer. But fixing the assoc list won't address buffer renaming conflicts caused by nick changes happening while I'm offline; if rcirc renames a buffer to "johnsmith|away@server" and then I get disconnected, and when I reconnect I see "johnsmith" active and start exchanging messages (in a new buffer), and later I receive a NICK message causing another rename to "johnsmith|away@server", it'll conflict with the existing one. If the server isn't authenticating, we can't guarantee that the old "johnsmith|away" and the new "johnsmith" really are the same user, so I'm not sure if we should blithely try combining them or make them unique; erroring out during a rename is an ugly failure mode though. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2020-11-10 built on crash Windowing system distributor 'Fedora Project', version 11.0.12006000 System Description: Fedora 31 (Workstation Edition) Recent messages: Mark set [2 times] Quit Mark set Quit Mark set [2 times] Saving file /home/raeburn/.private/notes.org... Wrote /home/raeburn/.private/notes.org GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2020-11-10 Configured using: 'configure --prefix=/home/raeburn/dev/emacs/Install-20201110T0556 --with-x-toolkit=lucid' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: IELM Minor modes in effect: async-bytecomp-package-mode: t shell-dirtrack-mode: t rcirc-track-minor-mode: t display-time-mode: t desktop-save-mode: t global-edit-server-edit-mode: t which-function-mode: t icomplete-mode: t global-hi-lock-mode: t hi-lock-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/raeburn/elisp/with-editor hides /home/raeburn/.emacs.d/elpa/with-editor-20181113.1845/with-editor Features: (shadow emacsbug flyspell gnus-icalendar icalendar diary-lib diary-loaddefs novice systemtap-mode cc-awk apropos descr-text dired-aux mailalias smtpmail sendmail thai-util thai-word ispell pcmpl-unix pcmpl-gnu cc-langs completion gnus-eform etags fileloop xref project tramp-cmds follow flow-fill edmacro kmacro rect ibuf-ext ibuffer ibuffer-loaddefs term/xterm xterm cl-print ielm warnings nroff-mode eieio-opt speedbar sb-image ezimage dframe bookmark tabify timezone org-protocol pp help-fns radix-tree cus-edit org-capture grep url-http url-gw url-auth url-cache shr-color color mm-archive gnus-topic sort smiley gnus-cite mail-extr gnus-async gnus-bcklg qp gnus-ml mule-util cal-move with-editor async-bytecomp async ruby-mode misearch multi-isearch nndraft nnmh nnfolder utf-7 gnutls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache tramp-cache tramp-sh vagrant-tramp dash tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp network-stream nsm add-log face-remap conf-mode adaptive-wrap make-mode yaml-mode sh-script smie executable eww mm-url thingatpt url-queue cperl-mode smerge-mode diff perl-mode rst compile objdump vc-git diff-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl-extra help-mode org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-shell shell pcomplete ob ob-tangle org-src ob-ref ob-lob ob-table ob-exp ob-comint ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs rcirc gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum url url-proxy url-privacy url-expand url-methods url-history mailcap shr url-cookie url-domsuf url-util svg xml dom gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec gnus-int gnus-range message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search time-date mail-utils mm-util mail-prsvr wid-edit time desktop frameset cus-start cus-load kr-init edit-server iso-transl advice smart-quotes easy-mmode which-func imenu icomplete server term disp-table comint ansi-color ehelp ring hi-lock finder-inf info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 40581826 2812970) (symbols 48 52910 12) (strings 32 1258102 286070) (string-bytes 1 37999133) (vectors 16 91413) (vector-slots 8 2960172 1274366) (floats 8 689 867) (intervals 56 4370790 62376) (buffers 1000 514)) From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 07:49:27 2021 Received: (at 45872) by debbugs.gnu.org; 23 Jul 2021 11:49:27 +0000 Received: from localhost ([127.0.0.1]:42457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6tgF-0000DY-1A for submit@debbugs.gnu.org; Fri, 23 Jul 2021 07:49:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6tgD-0000DM-2z for 45872@debbugs.gnu.org; Fri, 23 Jul 2021 07:49:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UYcYWq6Vk56s7IdjKVOZsGOhN/97GEOrrOqq4dYvJbA=; b=NvND8eX995fAI3R/DqVqMobWhP bv15FgLunOafw7kI8blXM+ujmR/RSlfiksXE5xmQlcLt2yP4eGaiweSHAawOvdhymcL7TgKtafObp gncTpOB3IaaJFknO1fCJB7vEkoHMC9QV7Rtdaf/SbYSy/wJVhelp65bURRH92yJUeuf4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6tg4-0007Ge-RT; Fri, 23 Jul 2021 13:49:19 +0200 From: Lars Ingebrigtsen To: Ken Raeburn Subject: Re: bug#45872: 27.1; rcirc nick tracking References: <87zh1bwbin.fsf@redhat.com> X-Now-Playing: Bill Rieflin & Chris Connelly's _Largo_: "Close Watch" Date: Fri, 23 Jul 2021 13:49:16 +0200 In-Reply-To: <87zh1bwbin.fsf@redhat.com> (Ken Raeburn's message of "Thu, 14 Jan 2021 14:42:40 -0500") Message-ID: <87im11dzcz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ken Raeburn writes: > One of my IRC contacts uses frequent nick changes to indicate away > status, e.g., "johnsmith" when available, "johnsmith|away", > "johnsmith|vacation", whatever. I've noticed that sometimes rcirc w [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45872 Cc: Philip Kaludercic , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ken Raeburn writes: > One of my IRC contacts uses frequent nick changes to indicate away > status, e.g., "johnsmith" when available, "johnsmith|away", > "johnsmith|vacation", whatever. I've noticed that sometimes rcirc will > fail to rename the buffer used for private messages between us, and so > I'll wind up with a buffer "johnsmith|away" showing something along the > lines of: > > ... *** johnsmith NICK johnsmith|away > ... *** johnsmith|away NICK johnsmith > > but the buffer won't have been renamed back to "johnsmith@", and > if I try sending him a message, it'll try sending to johnsmith|away and > will fail. I can use "/msg johnsmith...", or he can send messages to me, > and a new buffer will be created. rcirc has gotten a lot of fixes in Emacs 28, but I'm not sure whether this is one of the things that have been fixed. I've added Philip to the CCs; he'll probably know. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 08:02:26 2021 Received: (at 45872) by debbugs.gnu.org; 23 Jul 2021 12:02:26 +0000 Received: from localhost ([127.0.0.1]:42475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6tso-0000YF-EL for submit@debbugs.gnu.org; Fri, 23 Jul 2021 08:02:26 -0400 Received: from mout01.posteo.de ([185.67.36.65]:35665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6tsj-0000Xw-47 for 45872@debbugs.gnu.org; Fri, 23 Jul 2021 08:02:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id C2C31240027 for <45872@debbugs.gnu.org>; Fri, 23 Jul 2021 14:02:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1627041734; bh=whjQu+Pqnn5rj3pSdH3/YJ81LS1lgKoeKwoglPf9gdE=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=rd1f6L6CXnPkW6TLizGqEeuEYQvAEoQuFl0iDihjOWR9NXOKRK9t0+nEXYj9DTonC 7bL5qGFqRGEc3J1M80qbxdjrMblU73gFObpgBRX18oG2HdZbOO+qUAw/IfmDHap/EE 3VjZBi+4j+G4HfRSDAyf28CCvwfrWhME0Cpe3vKjNcYw7OjNszRGqvYNecrRGd2qxj 9WQ85LtN/3Qj18Q8hRRs13cUjWl3HL8GqCRmPl88KaaW5YHV2baZYlmtjlnq680Qh7 PFvsGGQPHhB3I6vhriTIZWGS5rrCu1IsylRmOib5toMBCRLqE8eM0a7qPJTVY3tv2S JYI3R/neZroQQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GWSc52zS7z6tmH; Fri, 23 Jul 2021 14:02:13 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#45872: 27.1; rcirc nick tracking References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Fri, 23 Jul 2021 12:02:12 +0000 In-Reply-To: <87im11dzcz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 23 Jul 2021 13:49:16 +0200") Message-ID: <87czr99r23.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45872 Cc: Ken Raeburn , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > Ken Raeburn writes: > >> One of my IRC contacts uses frequent nick changes to indicate away >> status, e.g., "johnsmith" when available, "johnsmith|away", >> "johnsmith|vacation", whatever. I've noticed that sometimes rcirc will >> fail to rename the buffer used for private messages between us, and so >> I'll wind up with a buffer "johnsmith|away" showing something along the >> lines of: >> >> ... *** johnsmith NICK johnsmith|away >> ... *** johnsmith|away NICK johnsmith >> >> but the buffer won't have been renamed back to "johnsmith@", Do you have some idea in what cases the buffer is not renamed? In principle, the NICK handler (rcirc-handler-NICK) should handle this case, but there might be issues if you disconnect and reconnect. >> and if I try sending him a message, it'll try sending to >> johnsmith|away and will fail. I can use "/msg johnsmith...", or he >> can send messages to me, and a new buffer will be created. This hasn't been fixed yet, but I am intending to do so. > rcirc has gotten a lot of fixes in Emacs 28, but I'm not sure whether > this is one of the things that have been fixed. I've added Philip to > the CCs; he'll probably know. :-) -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 14:07:56 2021 Received: (at 45872) by debbugs.gnu.org; 23 Jul 2021 18:07:56 +0000 Received: from localhost ([127.0.0.1]:44566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6zaV-0001ub-UI for submit@debbugs.gnu.org; Fri, 23 Jul 2021 14:07:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6zaR-0001uR-3J for 45872@debbugs.gnu.org; Fri, 23 Jul 2021 14:07:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627063670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ui6vesrdB944gmmHhJJDyA4tFO+weMTq4j5WCixDPu8=; b=LEFpNw+oc+lyYxfVOnks1ooi0RUm68DFvMXABOaw3zgTF0mFpWPT44HXvVjBe0g5Q9Z/08 daepJ3lloHlXzZESieeIOdq+uFvkcdD8OfgG3p+KSWZzYqKjgevBOxurH9ybpeWFJXJ1Oh WJZlgjbHDswTos2JhNh4eyaf5hpUGao= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-QzOpSe-NMKWIuSZUKQozuQ-1; Fri, 23 Jul 2021 14:07:47 -0400 X-MC-Unique: QzOpSe-NMKWIuSZUKQozuQ-1 Received: by mail-qk1-f197.google.com with SMTP id h5-20020a05620a0525b02903b861bec838so1722642qkh.7 for <45872@debbugs.gnu.org>; Fri, 23 Jul 2021 11:07:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=Ui6vesrdB944gmmHhJJDyA4tFO+weMTq4j5WCixDPu8=; b=C76UkYOl+bus1T1LJrN9V0MfreHA6ucceIF7v97Bx212zhKXD8wCe8iIChsOw+g2uw IJd9/evV2fXhlqKHiTE/oHO5WueneG9exuGm9fbfRsLV1j19XcFIbdbktOGALlraSOl2 bTsDLCd3n4utq7A8+4LklTdDLDjvvFjThQxsA9mdohnqR0EhWhPbKKwGwpL6n09iLq+H BScbK5jnkISp3CXzLqIkgLhMmQtvzVWgkx/SqYRFcNeoEy0Zf7EaUTYC5GAvrYAvldpQ YFDgNBdRakL28k3BsToGu92dmtOTDszAHaZ4smThAjyhF2YGZu36Z7vBk/M2/R/rUu/T ULVQ== X-Gm-Message-State: AOAM532Nnpe8C4wds1qePry+1w1cearKmw/icgoOxI0dx0fRoirD5NW6 9nXszKqHhXmwRObK7nKPAFPlvA6Q4ZNK1dBqh81pn6T3txQU4wBy6jel3Uq6nXWZWPSS7RhLiuJ /9y1fHgrReqfWaHk= X-Received: by 2002:a37:9a12:: with SMTP id c18mr5815583qke.246.1627063667039; Fri, 23 Jul 2021 11:07:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuf03Weh6XwoMdHKfdNhiB1ixwZN5Ugd6cq2YAo+3Mmm3DIw5ycix96iRX2PVgb5aFNfImmA== X-Received: by 2002:a37:9a12:: with SMTP id c18mr5815568qke.246.1627063666829; Fri, 23 Jul 2021 11:07:46 -0700 (PDT) Received: from [192.168.23.129] (c-24-60-138-149.hsd1.ma.comcast.net. [24.60.138.149]) by smtp.gmail.com with ESMTPSA id z23sm9858915qts.96.2021.07.23.11.07.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 11:07:46 -0700 (PDT) Subject: Re: bug#45872: 27.1; rcirc nick tracking To: Philip Kaludercic , Lars Ingebrigtsen References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> From: Ken Raeburn Organization: Red Hat, Inc. Message-ID: Date: Fri, 23 Jul 2021 14:07:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87czr99r23.fsf@posteo.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=raeburn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 45872 Cc: 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 7/23/21 8:02 AM, Philip Kaludercic wrote: > Lars Ingebrigtsen writes: > >> Ken Raeburn writes: >> >>> One of my IRC contacts uses frequent nick changes to indicate away >>> status, e.g., "johnsmith" when available, "johnsmith|away", >>> "johnsmith|vacation", whatever. I've noticed that sometimes rcirc will >>> fail to rename the buffer used for private messages between us, and so >>> I'll wind up with a buffer "johnsmith|away" showing something along the >>> lines of: >>> >>> ... *** johnsmith NICK johnsmith|away >>> ... *** johnsmith|away NICK johnsmith >>> >>> but the buffer won't have been renamed back to "johnsmith@", > Do you have some idea in what cases the buffer is not renamed? In > principle, the NICK handler (rcirc-handler-NICK) should handle this > case, but there might be issues if you disconnect and reconnect. I forgot to update this ticket... I found that rcirc-buffer-alist included a nick that had text properties set, and scanning the list didn't find a match. I used advice-add to postprocess the list after rcirc-handler-NICK using string-equal to work around it, and that seems to do the job (as long as I can stay connected). I haven't checked in a while to see if it's been fixed. If not, a better fix might be stripping out the text properties before putting a nick into the list. Ken From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 16:33:41 2021 Received: (at 45872) by debbugs.gnu.org; 23 Jul 2021 20:33:41 +0000 Received: from localhost ([127.0.0.1]:44696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m71rZ-0001NY-2l for submit@debbugs.gnu.org; Fri, 23 Jul 2021 16:33:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m71rV-0001NO-Pd for 45872@debbugs.gnu.org; Fri, 23 Jul 2021 16:33:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627072417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XzRDh0hZiMDcauLWhu+bEfrfSpfRQn6Y0fuDjrj/cos=; b=LxnZ6WQTWa0mqT9n1N3sAIzhbV4M2egwNyn3jcgTppoxxvlwfkyhmoxsAixiTVM5QF6BFE 4JRgGvhK98Ut5PnHkqA771ge+0fU5pUWrmNJJvlLBZDHwcKnIeUhn+ZZx2IhS8xRURJS4C 7kVCfCfVTPCYM5yALG66WMpqUc4A7xQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-az5TOO_iOECl1btBsfn6rQ-1; Fri, 23 Jul 2021 16:33:35 -0400 X-MC-Unique: az5TOO_iOECl1btBsfn6rQ-1 Received: by mail-qv1-f70.google.com with SMTP id v16-20020a0562140510b029032511e85975so1340757qvw.23 for <45872@debbugs.gnu.org>; Fri, 23 Jul 2021 13:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=XzRDh0hZiMDcauLWhu+bEfrfSpfRQn6Y0fuDjrj/cos=; b=PVcQe7A2/JRj6c5xqkMV4vs/KilfkXwUKVHCt8X0orv1nW7T/oM50XqBA9XToimdX1 HOL9AycamxVMsyZzifMOUnLqin3CvqydNJCdqbdCSqQDsZCQDBVEe7dZ6yT7SmnbUhZE sOA9janCIgoq3x6S/WCvYjxONtingWf18xcLfsSvAwEfJLRMCAsi4/akuDckzqubFp6n vWF9lu/WSM1KF4T+rsWn3YoylSKAbIGlAgxM/l+65qsq3B0P/ZsVMGl8k83u2k553oM3 E0GEGcxFF0Xi+tVlk+KQI64IMvf8INwznypSNetrOuzWP1JQJuppSHymrjrV2CTKuunb 66mA== X-Gm-Message-State: AOAM5327X9LJJ5IxDVocuV+OEDHqmfGa14ajoZtGzAI5Fhtoo5bqm86A wXWFHZECN3cUPB0gORO/7BzQx5Ni+C4/eNPcGRasCdRoXfEKkmVxEa6GQlmW+TjxXpgFngvm7MM UW67rf6RaNWydnZw= X-Received: by 2002:a37:9142:: with SMTP id t63mr6239438qkd.59.1627072415577; Fri, 23 Jul 2021 13:33:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqVuZf8xWfm1/vE5qviC8VYzcKrKorScI64XpES7+wIt7KJPA2MsSQWnr+ILo5odtmtYh/fw== X-Received: by 2002:a37:9142:: with SMTP id t63mr6239425qkd.59.1627072415369; Fri, 23 Jul 2021 13:33:35 -0700 (PDT) Received: from [192.168.23.129] (c-24-60-138-149.hsd1.ma.comcast.net. [24.60.138.149]) by smtp.gmail.com with ESMTPSA id t30sm14548690qkm.11.2021.07.23.13.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 13:33:34 -0700 (PDT) Subject: Re: bug#45872: 27.1; rcirc nick tracking From: Ken Raeburn To: Philip Kaludercic , Lars Ingebrigtsen References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> Organization: Red Hat, Inc. Message-ID: Date: Fri, 23 Jul 2021 16:33:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=raeburn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 45872 Cc: 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Oh, but no, I'm not sure exactly what usage pattern cause this situation to arise, or why it wouldn't just show up for everyone. Ken From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 10:56:35 2021 Received: (at 45872) by debbugs.gnu.org; 24 Jul 2021 14:56:35 +0000 Received: from localhost ([127.0.0.1]:46739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7J4t-0003ou-KQ for submit@debbugs.gnu.org; Sat, 24 Jul 2021 10:56:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7J4p-0003od-09 for 45872@debbugs.gnu.org; Sat, 24 Jul 2021 10:56:34 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id B7B2C240027 for <45872@debbugs.gnu.org>; Sat, 24 Jul 2021 16:56:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1627138584; bh=nbdoWWJ0CN63mfeIlQa8AGjvBP1tcezsdj5Cmvkx2Pw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=cIqIUbLcDED1A+G6LfDO5XCMXJMVerlO5SaJ0u6OQELi085mx/tdvTlqev2Y+vxjj vJzbP5c8NF09VBjeD9V6WFrcGLrKEomS+MrJuRV5mk7EwKqRz6Z0xWMq4atl9U2OMc LQ+RnuB84d7+Gad2M3yL7YKyTYaDvXuRlg+f7tKn06Z5PB1RLDfAye42w5LrHo+ClX X47Ya0OgidftIuRxYFo0f3CmGEMtHuITy4x3NFdSMZYCOdn3fogXLnXI1701AM4z6t 4cL/fu/q9R+pFLoS+5adm3I7s6xxavRAF/RQ5Hjsuo/iBJlDaRa4V9gnF63eGoPXkZ hrbXy0fpR6TaA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GX8Qb4c9Kz9rxS; Sat, 24 Jul 2021 16:56:23 +0200 (CEST) From: Philip Kaludercic To: Ken Raeburn Subject: Re: bug#45872: 27.1; rcirc nick tracking References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Sat, 24 Jul 2021 14:56:23 +0000 In-Reply-To: (Ken Raeburn's message of "Fri, 23 Jul 2021 14:07:43 -0400") Message-ID: <87wnpfzroo.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45872 Cc: Lars Ingebrigtsen , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ken Raeburn writes: > On 7/23/21 8:02 AM, Philip Kaludercic wrote: >> Lars Ingebrigtsen writes: >> >>> Ken Raeburn writes: >>> >>>> One of my IRC contacts uses frequent nick changes to indicate away >>>> status, e.g., "johnsmith" when available, "johnsmith|away", >>>> "johnsmith|vacation", whatever. I've noticed that sometimes rcirc will >>>> fail to rename the buffer used for private messages between us, and so >>>> I'll wind up with a buffer "johnsmith|away" showing something along the >>>> lines of: >>>> >>>> ... *** johnsmith NICK johnsmith|away >>>> ... *** johnsmith|away NICK johnsmith >>>> >>>> but the buffer won't have been renamed back to "johnsmith@", >> Do you have some idea in what cases the buffer is not renamed? In >> principle, the NICK handler (rcirc-handler-NICK) should handle this >> case, but there might be issues if you disconnect and reconnect. > > I forgot to update this ticket... I found that rcirc-buffer-alist > included a nick that had text properties set, and scanning the list > didn't find a match. I used advice-add to postprocess the list after > rcirc-handler-NICK using string-equal to work around it, and that > seems to do the job (as long as I can stay connected). > > I haven't checked in a while to see if it's been fixed. If not, a > better fix might be stripping out the text properties before putting a > nick into the list. That shouldn't be an issue, but I wonder where the text properties come from. Could you find out what text properties these were that were confusing rcirc? > Ken > -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 26 17:47:10 2021 Received: (at 45872) by debbugs.gnu.org; 26 Jul 2021 21:47:10 +0000 Received: from localhost ([127.0.0.1]:51652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m88RK-000120-4G for submit@debbugs.gnu.org; Mon, 26 Jul 2021 17:47:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m88RH-00011s-ED for 45872@debbugs.gnu.org; Mon, 26 Jul 2021 17:47:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627336027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XX8wZfAPd908/oxMkTlDfsU78RIOyHWWVWYmbevDUfk=; b=HoFOnSqMfmBVZ3/8KwV2kVRSqgcBqCyLjUZyvz6nKLZJovEIkm9oHjwvzNhvIliqwwbnzo IgfjmAsS5mhdUC/48mbK7ba7M3CaKfnEGw91W0XOnkAiqedbY7SdyqIoHAMgX7r8PWmv28 4guAZSFQ/HBODZd9e6c3SVwXGiQIq5g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-prAnVOZXNOmkqfaZOi5YJA-1; Mon, 26 Jul 2021 17:47:05 -0400 X-MC-Unique: prAnVOZXNOmkqfaZOi5YJA-1 Received: by mail-wm1-f69.google.com with SMTP id o32-20020a05600c5120b0290225ef65c35dso199107wms.2 for <45872@debbugs.gnu.org>; Mon, 26 Jul 2021 14:47:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=XX8wZfAPd908/oxMkTlDfsU78RIOyHWWVWYmbevDUfk=; b=U4/zdPKpS07qX3wq1pJYsX89aZBaEk1TGtw1MG4SNsNV0ZNHDvZ7hOsZXrplDAY8do 5Wg5znyWTCLCe7GiLc+UvufbMWvxi8S1dy12hyaekvxMe40UqvyMWPzyYoTeuW85LzcD Mr34CQKJTKOIicajD313UTxebfy41lizsTBkc3jDo2NIU+8mGRAXmJDdL6JJqy/jmeDy Y/6E1vLLLYrmtDWYRIRuGC847CxWnMViAcfnAviyVmr+VgT726mgQubqxfFjgA/eSutd dZikvQUjPaLTlygj80n9TMuGtSSNH+DfQdKypc/8WbjlyVHiPr25w4oXn18lwy9eP8G9 y8Kg== X-Gm-Message-State: AOAM533jSlbi5YqnmeG9FcgdMIIz+yUreRf3K95iejbip/1m15lVw8/V i5f+Ed2Q/x4xlL4H4UzHSx8VqnfR5+o2LHMMPJEJ0QsmJ0dsaPt04Wjkig5uTkKbSuj5pdGe+Pu LDVJRCeWNSAFsPh8= X-Received: by 2002:a05:6000:1367:: with SMTP id q7mr7519629wrz.395.1627336024680; Mon, 26 Jul 2021 14:47:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyUxS9MG90MCISfwXJlldW0jhUMpfUDgGaGUN8pxKwBodme9ZbawEed0MygM31Y7F2zTPtSA== X-Received: by 2002:a05:6000:1367:: with SMTP id q7mr7519617wrz.395.1627336024459; Mon, 26 Jul 2021 14:47:04 -0700 (PDT) Received: from [192.168.23.129] (c-24-60-138-149.hsd1.ma.comcast.net. [24.60.138.149]) by smtp.gmail.com with ESMTPSA id a14sm929156wrf.97.2021.07.26.14.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 14:47:04 -0700 (PDT) Subject: Re: bug#45872: 27.1; rcirc nick tracking To: Philip Kaludercic References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> From: Ken Raeburn Organization: Red Hat, Inc. Message-ID: Date: Mon, 26 Jul 2021 17:46:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87wnpfzroo.fsf@posteo.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=raeburn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 45872 Cc: Lars Ingebrigtsen , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 7/24/21 10:56 AM, Philip Kaludercic wrote: > Ken Raeburn writes: > I forgot to update this ticket... I found that rcirc-buffer-alist > included a nick that had text properties set, and scanning the list > didn't find a match. I used advice-add to postprocess the list after > rcirc-handler-NICK using string-equal to work around it, and that > seems to do the job (as long as I can stay connected). > > I haven't checked in a while to see if it's been fixed. If not, a > better fix might be stripping out the text properties before putting a > nick into the list. > That shouldn't be an issue, but I wonder where the text properties come > from. Could you find out what text properties these were that were > confusing rcirc? It's setting font-lock-face to rcirc-other-nick. Oh... but I'm mixing this up with some other issue, I think. My apologies... the text properties are stored, but they're just a distraction. The access methods like assoc-string do ignore them. Looking back at the 27.1 code I'm still running, I don't think there's anything even trying to update rcirc-buffer-alist in response to NICK. Rename the buffer, yes, but not change the key it's listed under. If a buffer johnsmith@irc.server is initially stored in the alist under the key "johnsmith" (or #("johnsmith" 0 9 (font-lock-face (rcirc-other-nick)))) then it'll still be stored under that key even if the buffer is renamed to johnsmith|away@irc.server. So one failure to rename the buffer is those cases where the key in rcirc-buffer-alist doesn't match, because a previous rename didn't update the key, and the handle hasn't been renamed back to its original value as stored in as a key in the alist. If the buffer rename back to remove the "|away" is missed, then I can't use the johnsmith|away@irc.server buffer to talk to johnsmith@irc.server any more, as I described in my original report. The handle info stored in the buffer is out of date. I can use "/msg johnsmith" and it'll create a new johnsmith@irc.server buffer, but another NICK message might try to rename that to johnsmith|away@irc.server again and would fail. Ken From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 27 04:22:34 2021 Received: (at 45872) by debbugs.gnu.org; 27 Jul 2021 08:22:34 +0000 Received: from localhost ([127.0.0.1]:52442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m8IME-0008A7-76 for submit@debbugs.gnu.org; Tue, 27 Jul 2021 04:22:34 -0400 Received: from mout02.posteo.de ([185.67.36.66]:43151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m8IMB-00089s-LI for 45872@debbugs.gnu.org; Tue, 27 Jul 2021 04:22:33 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 2105E240104 for <45872@debbugs.gnu.org>; Tue, 27 Jul 2021 10:22:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1627374145; bh=P51+ElxGwGHaJG4rxncfEYd0Oy1z24pGG4JosLIcXPg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Rq1odJea56dxOZQ8fiOZS01gq/bmMIYF7aLCa1xR6yxK4CrUO6sPORYgbSMFcQ3st FLsC7DovbuguUMPkfiSQgDhuz7cEMXj7uBpwbEPtrjlxWMZcnUm7Zk+jYsNqDsP1Vt FC6fNee0CbwuBTXQedCUsMlP4W7n/4Y6k+BHdz6SIPjedkdQd2lNUGqCNQDiyfskax 5MRqKMNZvmLn8Ie7AXbWlezHWLZYn55jT1RDoRY9KSzMeHaU1YSJ6uE8DOjgktLb2U +89xspXgYBu/5PytUMAprCt+e5FOidFFme8wVCzPbXIzl7JpVNw+xRWxIUP09kYvKh lj1gZTP/FQmyg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GYqXc17Jxz9rxX; Tue, 27 Jul 2021 10:22:24 +0200 (CEST) From: Philip Kaludercic To: Ken Raeburn Subject: Re: bug#45872: 27.1; rcirc nick tracking References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 27 Jul 2021 08:22:23 +0000 In-Reply-To: (Ken Raeburn's message of "Mon, 26 Jul 2021 17:46:58 -0400") Message-ID: <87wnpcxj28.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45872 Cc: Lars Ingebrigtsen , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Ken Raeburn writes: > On 7/24/21 10:56 AM, Philip Kaludercic wrote: > >> Ken Raeburn writes: > >> I forgot to update this ticket... I found that rcirc-buffer-alist >> included a nick that had text properties set, and scanning the list >> didn't find a match. I used advice-add to postprocess the list after >> rcirc-handler-NICK using string-equal to work around it, and that >> seems to do the job (as long as I can stay connected). >> >> I haven't checked in a while to see if it's been fixed. If not, a >> better fix might be stripping out the text properties before putting a >> nick into the list. >> That shouldn't be an issue, but I wonder where the text properties come >> from. Could you find out what text properties these were that were >> confusing rcirc? > > It's setting font-lock-face to rcirc-other-nick. Oh... but I'm mixing > this up with some other issue, I think. My apologies... the text > properties are stored, but they're just a distraction. The access > methods like assoc-string do ignore them. > > Looking back at the 27.1 code I'm still running, I don't think there's > anything even trying to update rcirc-buffer-alist in response to > NICK. Rename the buffer, yes, but not change the key it's listed > under. If a buffer johnsmith@irc.server is initially stored in the > alist under the key "johnsmith" (or #("johnsmith" 0 9 (font-lock-face > (rcirc-other-nick)))) then it'll still be stored under that key even > if the buffer is renamed to johnsmith|away@irc.server. That is true, the following should fix that: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 60751c14e2..e5663d3fe6 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -3149,7 +3149,11 @@ rcirc-handler-NICK (with-current-buffer chat-buffer (rcirc-print process sender "NICK" old-nick new-nick) (setq rcirc-target new-nick) - (rename-buffer (rcirc-generate-new-buffer-name process new-nick))))) + (rename-buffer (rcirc-generate-new-buffer-name process new-nick)))) + (setf rcirc-buffer-alist + (cons (cons new-nick chat-buffer) + (delq (assoc-string old-nick rcirc-buffer-alist t) + rcirc-buffer-alist)))) ;; remove old nick and add new one (with-rcirc-process-buffer process (let ((v (gethash old-nick rcirc-nick-table))) --=-=-= Content-Type: text/plain Since the handler hasn't been changed since 2005, you should be able to apply the change and see if it works. > So one failure to rename the buffer is those cases where the key in > rcirc-buffer-alist doesn't match, because a previous rename didn't > update the key, and the handle hasn't been renamed back to its > original value as stored in as a key in the alist. > > If the buffer rename back to remove the "|away" is missed, then I > can't use the johnsmith|away@irc.server buffer to talk to > johnsmith@irc.server any more, as I described in my original > report. The handle info stored in the buffer is out of date. I can use > "/msg johnsmith" and it'll create a new johnsmith@irc.server buffer, > but another NICK message might try to rename that to > johnsmith|away@irc.server again and would fail. > > Ken > -- Philip Kaludercic --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 14:55:19 2022 Received: (at 45872) by debbugs.gnu.org; 17 Mar 2022 18:55:19 +0000 Received: from localhost ([127.0.0.1]:55196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUvHL-0002Si-Il for submit@debbugs.gnu.org; Thu, 17 Mar 2022 14:55:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:59089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUvHK-0002SY-3f for 45872@debbugs.gnu.org; Thu, 17 Mar 2022 14:55:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647543317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hteot5c0R+lkIzlHuk/nOZLulzZ2ibcdzn/3FSljS/4=; b=Uyx5yM9DwskJw7QhbtlHBnXY3GD9fsdvNg8+iQX1CxJccO+joS0c+yqTqmmKBWEwUKr9HI v++wPQPJ0xjonrk3iUZACibmyLBVSgjsrL8GpBbzLdAYv51O6CBOULzAT+ONlkg6b+L48i v16OVSqiZvOJIqhjQdG9f5QlnP6q7gU= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-189-hTexD-fdMHmdRl0VFA0btQ-1; Thu, 17 Mar 2022 14:55:16 -0400 X-MC-Unique: hTexD-fdMHmdRl0VFA0btQ-1 Received: by mail-qk1-f199.google.com with SMTP id m6-20020a37a306000000b0067b189190c3so3939117qke.20 for <45872@debbugs.gnu.org>; Thu, 17 Mar 2022 11:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hPq+NFo3IsiPSJwYf+7bcR0fW/mtCT7CF4hA5tCLsIQ=; b=0Dth7W8ymGRa/KBZ3ivEBy2v9Y9Ukjz2QwDtPOAxVH6vJdzDaUW5yftXdwwyui9TkO GBfoykDR0SbJxecA1FbFZylpj3tYtUEj62xIClhreEN8Zj+LifMqZsFJxDaiuB1Y/NgX Vp77BOGuQcbpdYVBzwHKeNE58qiyi6SQVs0HyfNBec5ceUDyNj6UrwHj/LEIeqY2erJL DjIrSXztT+hMyWNA2C6LsjykBk68DJVZ9npxrNO+uFqlvIogueGp9VxB8iBiV0jH8PSN 8RyLd3ZQEKlebFI1Aw4+cDTCdcphIPjUMFMKp86DnfEng7w5xaTdr9YZq83XGbGtWCBW I2gA== X-Gm-Message-State: AOAM532CrveUdyYIBjhgtAEOQUfkS7oD63MqJnpDxRtIzWFYVW2Loz3j wEIVbU2n2mwuPtaGSOjBVCEF4HVXCiULLBVYLKPFA89S3ON7dfbTwcRxVT7rae6JuM5cjQ9CTow 8i34nyWldAkBtbTo= X-Received: by 2002:a05:620a:319d:b0:67d:4bc5:fe45 with SMTP id bi29-20020a05620a319d00b0067d4bc5fe45mr3768771qkb.493.1647543315885; Thu, 17 Mar 2022 11:55:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMsUscZtwuq09TvdPbOf8rAxVUIgo3DCVjoBcBkRiJBPPiNdgZ+sGAj2SdCZlIrtsea9Y2tA== X-Received: by 2002:a05:620a:319d:b0:67d:4bc5:fe45 with SMTP id bi29-20020a05620a319d00b0067d4bc5fe45mr3768756qkb.493.1647543315623; Thu, 17 Mar 2022 11:55:15 -0700 (PDT) Received: from crash (c-24-60-138-149.hsd1.ma.comcast.net. [24.60.138.149]) by smtp.gmail.com with ESMTPSA id s16-20020ac85cd0000000b002e1ed82f1e5sm3022248qta.75.2022.03.17.11.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 11:55:15 -0700 (PDT) From: Ken Raeburn To: Philip Kaludercic Subject: Re: bug#45872: 27.1; rcirc nick tracking References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> <87wnpcxj28.fsf@posteo.net> Date: Thu, 17 Mar 2022 14:55:13 -0400 In-Reply-To: <87wnpcxj28.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 27 Jul 2021 08:22:23 +0000") Message-ID: <878rt8be9a.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=raeburn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 45872 Cc: Lars Ingebrigtsen , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > That is true, the following should fix that: Sorry for the delays in getting back to this. I see that 28.0.91 incorporates the change you included, but I=E2=80=99m still seeing messages logged in the server buffer like this: 2022-03-16T08:24:29 !!! ":someuser|away!~someuser@some-internal-host.redhat= .com NICK :someuser" (error Buffer name =E2=80=98someuser@some-irc-host.red= hat.com=E2=80=99 is in use) I think this is coming from cases where I=E2=80=99ve been offline for a nic= k renaming, so when I come online, =E2=80=9Csomeuser|away=E2=80=9D is online = but I have a buffer =E2=80=9Csomeuser=E2=80=9D. Perhaps the UNIQUE argument to rename-bu= ffer should be set? Ken From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 09:31:03 2022 Received: (at 45872) by debbugs.gnu.org; 7 Jun 2022 13:31:03 +0000 Received: from localhost ([127.0.0.1]:39003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyZIU-0006KC-UL for submit@debbugs.gnu.org; Tue, 07 Jun 2022 09:31:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyZIS-0006DW-Dv for 45872@debbugs.gnu.org; Tue, 07 Jun 2022 09:31:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vAAmVSt0AqIHfqeuPtldB1hsvsFMYUWjRqpbb+yok+U=; b=HAMTeQ6dtE6W1ijgT2Eq146LG2 MrutPMKK+xV49gPlLmkQZ9MsT9enk+kckwMdfCMYBwGMZAd+LD21VkEM3OpqqvuGiRgKq8igyHpTJ sflVTirsf4HXfIHp+wfWt4SwEiiSYC4z4JxS0bSUJngjGHxMxzxBdexPBNkZWxBXeigs=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyZIF-00037H-Rk; Tue, 07 Jun 2022 15:30:54 +0200 From: Lars Ingebrigtsen To: Ken Raeburn Subject: Re: bug#45872: 27.1; rcirc nick tracking References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> <87wnpcxj28.fsf@posteo.net> <878rt8be9a.fsf@redhat.com> X-Now-Playing: Blaine L. Reininger's _The Blue Sleep_: "Dry Food" Date: Tue, 07 Jun 2022 15:30:47 +0200 In-Reply-To: <878rt8be9a.fsf@redhat.com> (Ken Raeburn's message of "Thu, 17 Mar 2022 14:55:13 -0400") Message-ID: <87mteoha7s.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ken Raeburn writes: > 2022-03-16T08:24:29 !!! > ":someuser|away!~someuser@some-internal-host.redhat.com NICK > :someuser" (error Buffer name ‘someuser@some-irc-host.redhat.com’ is > in use) > > I think this is coming [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45872 Cc: Philip Kaludercic , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ken Raeburn writes: > 2022-03-16T08:24:29 !!! > ":someuser|away!~someuser@some-internal-host.redhat.com NICK > :someuser" (error Buffer name =E2=80=98someuser@some-irc-host.redhat.com= =E2=80=99 is > in use) > > I think this is coming from cases where I=E2=80=99ve been offline for a n= ick > renaming, so when I come online, =E2=80=9Csomeuser|away=E2=80=9D is onlin= e but I have a > buffer =E2=80=9Csomeuser=E2=80=9D. Perhaps the UNIQUE argument to rename-= buffer should > be set? So the suggested change is: diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 0d30b34922..815dfef50f 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -3298,7 +3298,7 @@ rcirc-handler-NICK (with-current-buffer chat-buffer (rcirc-print process sender "NICK" old-nick new-nick) (setq rcirc-target new-nick) - (rename-buffer (rcirc-generate-new-buffer-name process new-nick))) + (rename-buffer (rcirc-generate-new-buffer-name process new-nick) t)) (setf rcirc-buffer-alist (cons (cons new-nick chat-buffer) (delq (assoc-string old-nick rcirc-buffer-alist t) Skimming the code, it seems like this should do the trick (but I haven't tested it). Ken, Philip, does this look OK to you? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 09:31:06 2022 Received: (at control) by debbugs.gnu.org; 7 Jun 2022 13:31:07 +0000 Received: from localhost ([127.0.0.1]:39006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyZIY-0006Mt-Fo for submit@debbugs.gnu.org; Tue, 07 Jun 2022 09:31:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyZIX-0006Hs-8z for control@debbugs.gnu.org; Tue, 07 Jun 2022 09:31:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xKSSdtYq2tWjX46j43KtfCgzKEJUxka/5nJfOCZVq00=; b=YKzrzihMkkSSX7Jott0cR0tnDA fqFE4PRxEmQRDeZlFtPgMPCNJugQZxxmuhRD4xbqAB0efhZM4ki1kQlYHSGYlKATaTstqt98nhmAd 6NYxFOyVBVigRZlfTa8DR3FtsPSui4ExxsXUtObO5fDxTIhHKL7bEdGY0ds83l4cvNr4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyZIP-00037P-DA for control@debbugs.gnu.org; Tue, 07 Jun 2022 15:30:59 +0200 Date: Tue, 07 Jun 2022 15:30:56 +0200 Message-Id: <87leu8ha7j.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45872 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45872 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 45872 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 15:07:13 2022 Received: (at 45872) by debbugs.gnu.org; 5 Jul 2022 19:07:13 +0000 Received: from localhost ([127.0.0.1]:51682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8ntA-0003me-T7 for submit@debbugs.gnu.org; Tue, 05 Jul 2022 15:07:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8nt7-0003lz-MV for 45872@debbugs.gnu.org; Tue, 05 Jul 2022 15:07:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=itln/z8uY9IsITaLX9lh3JCqd98VWvUM3DJOgMG1Yfc=; b=XG6NDP0mpJ96o+QB1BLhEF/XWC d6O4G3WuiocHGtWzvgndOvGCvirjokCdQ7E4Jo7D+46mNhUMLQaYisQ108ix/AVU+ef9kzo5mGCIc Coe7Ndn+4/fXJCbnDoEGlaO9UW7yXzxQBsjQh9FQJYdpwiCGW2j5DonQhpiNExNJzHks=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8nsy-0004se-8W; Tue, 05 Jul 2022 21:07:02 +0200 From: Lars Ingebrigtsen To: Ken Raeburn Subject: Re: bug#45872: 27.1; rcirc nick tracking In-Reply-To: <87mteoha7s.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 07 Jun 2022 15:30:47 +0200") References: <87zh1bwbin.fsf@redhat.com> <87im11dzcz.fsf@gnus.org> <87czr99r23.fsf@posteo.net> <87wnpfzroo.fsf@posteo.net> <87wnpcxj28.fsf@posteo.net> <878rt8be9a.fsf@redhat.com> <87mteoha7s.fsf@gnus.org> X-Now-Playing: King Crimson's _Beat_: "Waiting Man" Date: Tue, 05 Jul 2022 21:06:59 +0200 Message-ID: <87o7y3ml9o.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Skimming the code, it seems like this should do the trick (but I haven't > tested it). Ken, Philip, does this look OK to you? There were no comments in a month, so I've now pushed the change to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45872 Cc: Philip Kaludercic , 45872@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Skimming the code, it seems like this should do the trick (but I haven't > tested it). Ken, Philip, does this look OK to you? There were no comments in a month, so I've now pushed the change to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 15:07:18 2022 Received: (at control) by debbugs.gnu.org; 5 Jul 2022 19:07:19 +0000 Received: from localhost ([127.0.0.1]:51685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8ntD-0003mx-2f for submit@debbugs.gnu.org; Tue, 05 Jul 2022 15:07:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8ntB-0003mE-Cm for control@debbugs.gnu.org; Tue, 05 Jul 2022 15:07:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4iEsG5ycZDEU55313xv+m9rdVfrPfJFcNjQy2tz06sM=; b=FmA44/TtCELPFRVfECO/eKoGOw ev0yPYTjP0QYxSg5XQCTBMX1yWyGeyPuYxV/f+hH+T2cgoAOvkE6FeILl2e4N/es2NJqjvWGvA3QQ I4FQA7nrgnHxNWZA3OUEokU7sC6XK0odyMSoU5xrX1ySoc/k+X7FWLvK56XKtMX5IPVE=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8nt3-0004so-EC for control@debbugs.gnu.org; Tue, 05 Jul 2022 21:07:07 +0200 Date: Tue, 05 Jul 2022 21:07:04 +0200 Message-Id: <87mtdnml9j.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45872 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 45872 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 45872 29.1 quit From unknown Sat Jun 14 18:07:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 03 Aug 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator