From unknown Sat Jun 21 05:16:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45867: hurd-vm: custom disk-size ignored Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 14 Jan 2021 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45867 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 45867@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161064741832019 (code B ref -1); Thu, 14 Jan 2021 18:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jan 2021 18:03:38 +0000 Received: from localhost ([127.0.0.1]:39130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l06y9-0008KM-T9 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 13:03:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:44678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l06y5-0008KB-E4 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 13:03:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06y5-00079T-7R for bug-guix@gnu.org; Thu, 14 Jan 2021 13:03:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55490) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l06y5-0003rL-01; Thu, 14 Jan 2021 13:03:33 -0500 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=56648 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l06y3-0007v7-OQ; Thu, 14 Jan 2021 13:03:32 -0500 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl X-Url: http://AvatarAcademy.nl Date: Thu, 14 Jan 2021 19:03:28 +0100 Message-ID: <87eeinqtu7.fsf@verum.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On current master, setting a bigger disk-size for a childhurd --8<---------------cut here---------------start------------->8--- (service hurd-vm-service-type (hurd-vm-configuration (disk-size (* 12 (expt 2 30))) ;12GiB --8<---------------cut here---------------end--------------->8--- is being ignored. I am suspecting > commit 859b362f81598830d7ff276b96a8724aee3c4db7 > Author: Ludovic Court=C3=A8s > AuthorDate: Mon Dec 7 12:38:25 2020 +0100 > > services: hurd-vm: Avoid circular dependency with (gnu system images = hurd). >=20=20=20=20=20 > * gnu/services/virtualization.scm (hurd-vm-disk-image): Use > 'lookup-image-type-by-name' instead of referring to 'hurd-disk-image' > from (gnu system images hurd). > --- > gnu/services/virtualization.scm | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualizatio= n.scm > index eaf0bbd..f435630 100644 > --- a/gnu/services/virtualization.scm > +++ b/gnu/services/virtualization.scm [..] > @@ -913,14 +912,12 @@ that will be listening to receive secret keys on po= rt 1004, TCP." > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG. The secret-ser= vice > is added to the OS specified in CONFIG." > - (let ((os (secret-service-operating-system (hurd-vm-configuration-os c= onfig))) > - (disk-size (hurd-vm-configuration-disk-size config))) > - (system-image > - (image > - (inherit hurd-disk-image) > - (format 'compressed-qcow2) > - (size disk-size) > - (operating-system os))))) This system-image included (size disk-size), and here > + (let* ((os (secret-service-operating-system > + (hurd-vm-configuration-os config))) > + (disk-size (hurd-vm-configuration-disk-size config)) > + (type (lookup-image-type-by-name 'hurd-qcow2)) > + (os->image (image-type-constructor type))) > + (system-image (os->image os)))) disk-size goes unused. So we probably need something like diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.= scm index f435630faf..3ede822183 100644 --- a/gnu/services/virtualization.scm +++ b/gnu/services/virtualization.scm @@ -917,7 +917,9 @@ is added to the OS specified in CONFIG." (disk-size (hurd-vm-configuration-disk-size config)) (type (lookup-image-type-by-name 'hurd-qcow2)) (os->image (image-type-constructor type))) - (system-image (os->image os)))) + (system-image + (image (inherit (os->image os)) + (size disk-size))))) =20 (define (hurd-vm-port config base) "Return the forwarded vm port for this childhurd config." Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From unknown Sat Jun 21 05:16:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jan Nieuwenhuizen Subject: bug#45867: closed (Re: bug#45867: hurd-vm: custom disk-size ignored) Message-ID: References: <87k0sfpbnn.fsf@gnu.org> <87eeinqtu7.fsf@verum.com> X-Gnu-PR-Message: they-closed 45867 X-Gnu-PR-Package: guix Reply-To: 45867@debbugs.gnu.org Date: Thu, 14 Jan 2021 19:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1610652122-15658-1" This is a multi-part message in MIME format... ------------=_1610652122-15658-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #45867: hurd-vm: custom disk-size ignored which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 45867@debbugs.gnu.org. --=20 45867: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45867 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1610652122-15658-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 45867-done) by debbugs.gnu.org; 14 Jan 2021 19:21:48 +0000 Received: from localhost ([127.0.0.1]:39297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l08Bo-000444-3u for submit@debbugs.gnu.org; Thu, 14 Jan 2021 14:21:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l08Bj-00043m-Fb for 45867-done@debbugs.gnu.org; Thu, 14 Jan 2021 14:21:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57254) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l08Bd-0002eB-Mb; Thu, 14 Jan 2021 14:21:37 -0500 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=57006 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l08Bb-0007vL-C9; Thu, 14 Jan 2021 14:21:36 -0500 From: Jan Nieuwenhuizen To: 45867-done@debbugs.gnu.org Subject: Re: bug#45867: hurd-vm: custom disk-size ignored Organization: AvatarAcademy.nl References: <87eeinqtu7.fsf@verum.com> X-Url: http://AvatarAcademy.nl Date: Thu, 14 Jan 2021 20:21:32 +0100 In-Reply-To: <87eeinqtu7.fsf@verum.com> (Jan Nieuwenhuizen's message of "Thu, 14 Jan 2021 19:03:28 +0100") Message-ID: <87k0sfpbnn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45867-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jan Nieuwenhuizen writes: > On current master, setting a bigger disk-size for a childhurd > > (service hurd-vm-service-type > (hurd-vm-configuration > (disk-size (* 12 (expt 2 30))) ;12GiB > > > is being ignored. I am suspecting [..] > disk-size goes unused. So we probably need something like > > diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualizatio= n.scm > index f435630faf..3ede822183 100644 > --- a/gnu/services/virtualization.scm > +++ b/gnu/services/virtualization.scm > @@ -917,7 +917,9 @@ is added to the OS specified in CONFIG." > (disk-size (hurd-vm-configuration-disk-size config)) > (type (lookup-image-type-by-name 'hurd-qcow2)) > (os->image (image-type-constructor type))) > - (system-image (os->image os)))) > + (system-image > + (image (inherit (os->image os)) > + (size disk-size))))) >=20=20 > (define (hurd-vm-port config base) > "Return the forwarded vm port for this childhurd config." I can connfirm this works, pushed to master as 5b785b2a62b885a65aeece1399f7= e3a732dd1cea. > Greetings, > Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com ------------=_1610652122-15658-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jan 2021 18:03:38 +0000 Received: from localhost ([127.0.0.1]:39130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l06y9-0008KM-T9 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 13:03:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:44678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l06y5-0008KB-E4 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 13:03:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06y5-00079T-7R for bug-guix@gnu.org; Thu, 14 Jan 2021 13:03:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55490) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l06y5-0003rL-01; Thu, 14 Jan 2021 13:03:33 -0500 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=56648 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l06y3-0007v7-OQ; Thu, 14 Jan 2021 13:03:32 -0500 From: Jan Nieuwenhuizen To: bug-guix@gnu.org Subject: hurd-vm: custom disk-size ignored Organization: AvatarAcademy.nl X-Url: http://AvatarAcademy.nl Date: Thu, 14 Jan 2021 19:03:28 +0100 Message-ID: <87eeinqtu7.fsf@verum.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On current master, setting a bigger disk-size for a childhurd --8<---------------cut here---------------start------------->8--- (service hurd-vm-service-type (hurd-vm-configuration (disk-size (* 12 (expt 2 30))) ;12GiB --8<---------------cut here---------------end--------------->8--- is being ignored. I am suspecting > commit 859b362f81598830d7ff276b96a8724aee3c4db7 > Author: Ludovic Court=C3=A8s > AuthorDate: Mon Dec 7 12:38:25 2020 +0100 > > services: hurd-vm: Avoid circular dependency with (gnu system images = hurd). >=20=20=20=20=20 > * gnu/services/virtualization.scm (hurd-vm-disk-image): Use > 'lookup-image-type-by-name' instead of referring to 'hurd-disk-image' > from (gnu system images hurd). > --- > gnu/services/virtualization.scm | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualizatio= n.scm > index eaf0bbd..f435630 100644 > --- a/gnu/services/virtualization.scm > +++ b/gnu/services/virtualization.scm [..] > @@ -913,14 +912,12 @@ that will be listening to receive secret keys on po= rt 1004, TCP." > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG. The secret-ser= vice > is added to the OS specified in CONFIG." > - (let ((os (secret-service-operating-system (hurd-vm-configuration-os c= onfig))) > - (disk-size (hurd-vm-configuration-disk-size config))) > - (system-image > - (image > - (inherit hurd-disk-image) > - (format 'compressed-qcow2) > - (size disk-size) > - (operating-system os))))) This system-image included (size disk-size), and here > + (let* ((os (secret-service-operating-system > + (hurd-vm-configuration-os config))) > + (disk-size (hurd-vm-configuration-disk-size config)) > + (type (lookup-image-type-by-name 'hurd-qcow2)) > + (os->image (image-type-constructor type))) > + (system-image (os->image os)))) disk-size goes unused. So we probably need something like diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.= scm index f435630faf..3ede822183 100644 --- a/gnu/services/virtualization.scm +++ b/gnu/services/virtualization.scm @@ -917,7 +917,9 @@ is added to the OS specified in CONFIG." (disk-size (hurd-vm-configuration-disk-size config)) (type (lookup-image-type-by-name 'hurd-qcow2)) (os->image (image-type-constructor type))) - (system-image (os->image os)))) + (system-image + (image (inherit (os->image os)) + (size disk-size))))) =20 (define (hurd-vm-port config base) "Return the forwarded vm port for this childhurd config." Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com ------------=_1610652122-15658-1--