GNU bug report logs - #45862
[PATCH 0/1] Fix libnode and r-v8

Previous Next

Package: guix-patches;

Reported by: zimoun <zimon.toutoune <at> gmail.com>

Date: Thu, 14 Jan 2021 14:32:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45862: closed ([PATCH 0/1] Fix libnode and r-v8)
Date: Wed, 20 Jan 2021 21:36:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 20 Jan 2021 22:35:00 +0100
with message-id <87mtx3l2bf.fsf <at> elephly.net>
and subject line Re: [bug#45862] [PATCH 0/1] Fix libnode and r-v8
has caused the debbugs.gnu.org bug report #45862,
regarding [PATCH 0/1] Fix libnode and r-v8
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45862: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45862
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] Fix libnode and r-v8
Date: Thu, 14 Jan 2021 15:30:54 +0100
Hi,

Commit 1d77141f6d introduces a regression about libnode.  See:

--8<---------------cut here---------------start------------->8---
$ for ci in $(git -C ~/src/guix/guix log --format="%H" 1d77141f6d^^..1d77141f6d) ;\
  do echo "# Commit: $ci" ;\
     guix time-machine --commit=$ci -- build libnode --no-grafts -v 0 ;\
  done

# Commit: 1d77141f6d5004cf10d1f9ead53855f25a973847
Mise à jour du canal « guix » depuis le dépôt Git « https://git.savannah.gnu.org/git/guix.git »...
guix build: error: build of `/gnu/store/yzpk9vr4ipa58vhfqcb66jpwjs808y3n-libnode-10.20.0.drv' failed

# Commit: ac80cbfab69b59d17fcf38ef9f4ce0acc0e5f9e6
Mise à jour du canal « guix » depuis le dépôt Git « https://git.savannah.gnu.org/git/guix.git »...
/gnu/store/7m6nkxcaky1423078mnxa9zkrxyz2c30-libnode-10.20.0
--8<---------------cut here---------------end--------------->8---

The patch fixes it.  The test is done against r-v8 which uses libnode.
Everything builds fine now.


All the best,
simon

zimoun (1):
  gnu: libnode: Fix regression in unused phases.

 gnu/packages/node.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: 88eb5370ec155902ed5fe7636e91e932079b338a
-- 
2.29.2



[Message part 3 (message/rfc822, inline)]
From: Ricardo Wurmus <rekado <at> elephly.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 45862-done <at> debbugs.gnu.org
Subject: Re: [bug#45862] [PATCH 0/1] Fix libnode and r-v8
Date: Wed, 20 Jan 2021 22:35:00 +0100
Hi,

> Commit 1d77141f6d introduces a regression about libnode.  See: […]

Sorry about that!

> The patch fixes it.  The test is done against r-v8 which uses libnode.
> Everything builds fine now.

Indeed!  Applied and pushed with commit 41134f915f.

Thank you!

-- 
Ricardo


This bug report was last modified 4 years and 125 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.