Subject: Re: [PATCH v2 5/5] services: postgresql: Add postgresql-role-service-type.

From: Mathieu Othacehe <[email-masked]>
Date: Thu, 28 Jan 2021 13:05:47 +0100

Hey,

> Why only support these two permissions/options? Accepting strings or
> symbols, and then just converting to an upper case string would allow
> all the permission options to be specified.

Sure, fixed.

> I'm guessing this service will fail if it's run twice, as the
> role/database will already exist?

Yes, I added a check for already existing roles before pushing.

Thanks,

Mathieu