From unknown Tue Jun 17 01:29:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45818 <45818@debbugs.gnu.org> To: bug#45818 <45818@debbugs.gnu.org> Subject: Status: 28.0.50; Test solar-sunrise-sunset fails Reply-To: bug#45818 <45818@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:29:37 +0000 retitle 45818 28.0.50; Test solar-sunrise-sunset fails reassign 45818 emacs submitter 45818 "Basil L. Contovounesios" severity 45818 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 11:28:43 2021 Received: (at submit) by debbugs.gnu.org; 12 Jan 2021 16:28:43 +0000 Received: from localhost ([127.0.0.1]:32923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzMXC-0006FB-O0 for submit@debbugs.gnu.org; Tue, 12 Jan 2021 11:28:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:35202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzMX8-0006Ey-F2 for submit@debbugs.gnu.org; Tue, 12 Jan 2021 11:28:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzMX8-0005Wj-4F for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 11:28:38 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:42670) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzMX5-0004iU-OS for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 11:28:37 -0500 Received: by mail-wr1-x431.google.com with SMTP id m4so1775226wrx.9 for ; Tue, 12 Jan 2021 08:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=esPYy0shEwx4gpSjiphuwnBjxbl5G2JjKQ1s0AfC2jc=; b=PWWmkXFpevdMi7zBxVFbPpKHNkWKav1MbD52IRyiKzB5b8QpZ8ySWxqu+k8u/s2Q4o UsHo1GBwoA1F323vrwj51I2AGBlGyEThoTVrJVqXf0dsuAf9mh4KBIAGRDiiUC4fixRG LRTVwRlywYnkVR43s3Q5TVaR6QDlfK0uL2FZDzcePLtL4PGC05xNaG3Sos46MOkmCR6T BIIyGeGQIacpdc4fjaRx/CVRcnU2H7kVhzQyGocM/cTEkvgQx0oI2gp/fMBKp/rqZ0V3 u8SF0DMpyfP0zTkDXSXQWvcTupnEk5kdH9FzEkaWAyLyBJxLvWmrZmFAIzKxxqkHHjac Udyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=esPYy0shEwx4gpSjiphuwnBjxbl5G2JjKQ1s0AfC2jc=; b=SH/Y9gvUBOBakIC41MNOc5NjN7M5NlNMGuCrgoR9oW3LKv4sEv0f1+NVBcC9UNucV5 +cqNXoVLwSHTFcF5NqB4pwX7TSaDhXSCPNEkWJEGXLK7vdC0u5GPBzq9/Dzms6uwt0xK 720o8SfVjEgvaGMQQ4NYFbY3sag/V3ee4fikq4Mm+T5LCsCcGJSHqzIQ8xyplUnwuZ8L pGNmSinc3djfI0tOk43qD4T5PsQOQhRhJz1+EP0UnIiMiliWRwDBRKj8PccUhIESQuf0 rOV/jYRe0oJnFgvpEqw6Jz9tWMA+a5w8TnSnzEDUKM4TlX+10sbuenHQgMVYHT13+SC+ kLFA== X-Gm-Message-State: AOAM532UShacyGtO9EY26vCkpMm+KnTlPFurTZpWKWUZ4ZczUVQFjYjh o3T5SXKMWAvHVPdPrSgC8NL8dwOc2vDTsBNT X-Google-Smtp-Source: ABdhPJyKH4v81FxZNovKPzYq//wqWi/WsI+48CwgPdaQi/N0ApUA9ST3zu297h+C9UUSiDmCjEFD5w== X-Received: by 2002:adf:a29d:: with SMTP id s29mr5086607wra.329.1610468913027; Tue, 12 Jan 2021 08:28:33 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id q73sm4830974wme.44.2021.01.12.08.28.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 08:28:32 -0800 (PST) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Test solar-sunrise-sunset fails Date: Tue, 12 Jan 2021 16:28:22 +0000 Message-ID: <871reqp1ax.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: none client-ip=2a00:1450:4864:20::431; envelope-from=contovob@tcd.ie; helo=mail-wr1-x431.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) X-Debbugs-Cc: Mattias Engdeg=C3=A5rd The following test has been failing for me, probably since it was introduced: --8<---------------cut here---------------start------------->8--- Running 1 tests (2021-01-12 15:11:42+0000, selector =E2=80=98(not (or (tag = :expensive-test) (tag :unstable)))=E2=80=99) Test solar-sunrise-sunset backtrace: signal(ert-test-failed (((should (< (abs (- sunrise 7.27)) epsilon)) ert-fail(((should (< (abs (- sunrise 7.27)) epsilon)) :form (< 1.003 #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name solar-sunrise-sunset :documentation n ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/calendar/solar-tests command-line() normal-top-level() Test solar-sunrise-sunset condition: (ert-test-failed ((should (< (abs ...) epsilon)) :form (< 1.0033333324640985 0.016666666666666666) :value nil)) FAILED 1/1 solar-sunrise-sunset (0.001369 sec) Ran 1 tests, 0 results as expected, 1 unexpected (2021-01-12 15:11:42+0000,= 0.071452 sec) 1 unexpected results: FAILED solar-sunrise-sunset --8<---------------cut here---------------end--------------->8--- The failure corresponds to the following line in the test: (should (< (abs (- sunrise 7.27)) epsilon)) At that point, sunrise-sunset has the following value: ((6.266666667535901 #1=3D"IST") (16.716666667722166 #1#) "10:26") In case it matters, my time zone is currently GMT +0000, and IST can also refer to Irish Standard Time here. I tried binding calendar-{standard,daylight}-time-zone-name to "+0530" in the test, but that didn't change anything. Any ideas? Thanks, --=20 Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo versio= n 1.16.0, Xaw3d scroll bars) of 2021-01-12 built on tia Repository revision: ca024b0575c4ea754c4c6e6dbf21ed610e0d1fb8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=3Dccache gcc' 'CFLAGS=3D-O2 -march=3Dnative' --config-cache --prefix=3D/home/blc/.local --enable-checking=3Dstructs --with-x-toolkit=3Dlucid --with-file-notification=3Dyes --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XAW3D XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 13:50:41 2021 Received: (at 45818) by debbugs.gnu.org; 12 Jan 2021 18:50:41 +0000 Received: from localhost ([127.0.0.1]:33120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzOkb-0003lF-2z for submit@debbugs.gnu.org; Tue, 12 Jan 2021 13:50:41 -0500 Received: from mail33c50.megamailservers.eu ([91.136.10.43]:57610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzOkY-0003l3-Ar for 45818@debbugs.gnu.org; Tue, 12 Jan 2021 13:50:39 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610477436; bh=Q5ajh8l8II4I2ngWH9MIUhI6sIune0vxzaWrqBwF7+U=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Mx/JbgUDHxgP+qcfO6JJhWh9YuxTXDhC+W+kGetp6oJN3pElpVliDJnve/1CG7lBF oZEftlt9G8ZM/NwvVIIdjbEndzAcCyeyKRfoPsDcfJi4aAcse+6HCza4hDAm0h1ATT JSa8jcrPtFBxzszWuNomc9Vo65MzHQwkckH/5hpg= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10CIoY0A000817; Tue, 12 Jan 2021 18:50:35 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <871reqp1ax.fsf@tcd.ie> Date: Tue, 12 Jan 2021 19:50:33 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> References: <871reqp1ax.fsf@tcd.ie> To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1C.5FFDEF7C.002F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=aNeOVo1m c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=oEtWdfj_UpYxO7E9avkA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 45818 Cc: 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 12 jan. 2021 kl. 17.28 skrev Basil L. Contovounesios : > At that point, sunrise-sunset has the following value: >=20 > ((6.266666667535901 #1=3D"IST") (16.716666667722166 #1#) "10:26") On my machines (sitting in CET) it is ((7.2666666666045785 "IST") (17.716666666790843 "IST") "10:26") and the time zone names don't seem to matter for the numerical results = today, but maybe it depends on when it's run. In any case we should = probably use something less ambiguous than IST (which is apparently also = used for Israeli standard time). I've been unable to reproduce your results but am not sure how to go = about doing so exactly; running with TZ=3DGMT does not alter the = results. Could you try tracking down the origin of those numbers? Here is a trace = of some of the relevant functions on my machines: 1 -> (solar-sunrise-sunset (12 30 2020)) | 2 -> (solar-exact-local-noon (12 30 2020)) | | 3 -> (solar-julian-ut-centuries (12 30 2020)) | | 3 <- solar-julian-ut-centuries: 0.2099520876112252 | 2 <- solar-exact-local-noon: ((12 30 2020) 6.9905251059993585) | 2 -> (solar-julian-ut-centuries (12 30 2020)) | 2 <- solar-julian-ut-centuries: 0.2099520876112252 | 2 -> (solar-sidereal-time 0.2099520876112252) | 2 <- solar-sidereal-time: 6.592887211896198 | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) = 1.0 75.8 0) | 2 <- solar-sunrise-and-sunset: (6.5198219809993585 18.46122823099936 = 11.941406250000002) | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) = 26.9 75.8 -0.61) | 2 <- solar-sunrise-and-sunset: (7.2698219809993585 17.71122823099936 = 10.441406250000002) | 2 -> (dst-adjust-time (12 30 2020) 7.2698219809993585) | 2 <- dst-adjust-time: ((12 30 2020) 7.2666666666045785 "IST") | 2 -> (dst-adjust-time (12 30 2020) 17.71122823099936) | 2 <- dst-adjust-time: ((12 30 2020) 17.716666666790843 "IST") | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) | 2 <- calendar-date-equal: t | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) | 2 <- calendar-date-equal: t 1 <- solar-sunrise-sunset: ((7.2666666666045785 #1=3D"IST") = (17.716666666790843 #1#) "10:26") From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 15:06:41 2021 Received: (at 45818) by debbugs.gnu.org; 12 Jan 2021 20:06:41 +0000 Received: from localhost ([127.0.0.1]:33247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzPw8-0005oX-PG for submit@debbugs.gnu.org; Tue, 12 Jan 2021 15:06:41 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:37255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzPw6-0005oG-ND for 45818@debbugs.gnu.org; Tue, 12 Jan 2021 15:06:39 -0500 Received: by mail-wr1-f44.google.com with SMTP id i9so3802995wrc.4 for <45818@debbugs.gnu.org>; Tue, 12 Jan 2021 12:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0T8ZVaU4niv8o6QZXy4H9CmwN+tIZjpjyqLvxDvEyXU=; b=cw6S12KHP/SZyHCz6NCNm5WovK4GbJAp+UJZ8xzcoyKohDh9JSxAG1/uojLG/4UFVT 87kQxXL6gNhYRYPljLfDQzVQxd9kCtxkCaw1YS+0700+dvw7UI81XWx67zxueGq8gVgw xixxWtKHyZ74XHqxMA559QbqO7rhECeASq74ZrrTuVpbhTC93cSHil17NEFleXgDMmhI k0TCvjSCIdabDzyENlmB2suLZy8/SVYHhbg2AkoHYzoXT/EcZ4plblQ4RpOzln2kRwJU toEBl6r83MI20e4/kza7okmNLwN1LUgGH7cnqHOrObUDqxqoh2B0wxGLVEdb84IsOWGq F6AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0T8ZVaU4niv8o6QZXy4H9CmwN+tIZjpjyqLvxDvEyXU=; b=HGGfOWxMsH3YM5dOLvK2HACuqMhGWY4qd7Gki32eMyIhjiuqiUEnaZ/Xp7292HX5SR xcN4TY+lsu+x9AFxrDvKKihfb8sCeQHMbBpkrBfnUVeNJMc8ZS9TQyNzUxuv8Veqlrok QqbSQnqF0G4mfC4cl0AFx2OX/lmp4kiFbzAmSdodaNbWcJfc9hRrFfBi4q8KDwgbmYXZ YY5HnfZGXOu56Vydwzl5+QETglTFAsSSSKDYIcZzoW/5jwqbl7JkDwglwxa0UETrxgca yqBlMkVHlLhByyHBmUwerWINmbq2PFYvhctds81JzKVFr7++nMdEdDx1WUnLwM6E40zg zMQQ== X-Gm-Message-State: AOAM531YANtHgx32aMpUcEXnOQJ4ms5Nj7HCJMJczUnnG1n1xT4SrU+V Bov5Nm+lS4cgKyZ0l2CheuCIiw== X-Google-Smtp-Source: ABdhPJwaVVkKd201kg+oRsnV7VJ4mScDOY/2CcAKhsu8YAANbpCPM45PXc7e8fQgWMO4tMuqFt87qQ== X-Received: by 2002:a5d:54cc:: with SMTP id x12mr534757wrv.132.1610481992721; Tue, 12 Jan 2021 12:06:32 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id r1sm6732329wrl.95.2021.01.12.12.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 12:06:31 -0800 (PST) From: "Basil L. Contovounesios" To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> Date: Tue, 12 Jan 2021 20:06:30 +0000 In-Reply-To: <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 12 Jan 2021 19:50:33 +0100") Message-ID: <87ft35j4xl.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45818 Cc: 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd writes: > Could you try tracking down the origin of those numbers? Here is a trace = of some > of the relevant functions on my machines: > > 1 -> (solar-sunrise-sunset (12 30 2020)) > | 2 -> (solar-exact-local-noon (12 30 2020)) > | | 3 -> (solar-julian-ut-centuries (12 30 2020)) > | | 3 <- solar-julian-ut-centuries: 0.2099520876112252 > | 2 <- solar-exact-local-noon: ((12 30 2020) 6.9905251059993585) > | 2 -> (solar-julian-ut-centuries (12 30 2020)) > | 2 <- solar-julian-ut-centuries: 0.2099520876112252 > | 2 -> (solar-sidereal-time 0.2099520876112252) > | 2 <- solar-sidereal-time: 6.592887211896198 > | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) = 1.0 75.8 0) > | 2 <- solar-sunrise-and-sunset: (6.5198219809993585 18.46122823099936 11= .941406250000002) > | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) = 26.9 75.8 -0.61) > | 2 <- solar-sunrise-and-sunset: (7.2698219809993585 17.71122823099936 10= .441406250000002) > | 2 -> (dst-adjust-time (12 30 2020) 7.2698219809993585) > | 2 <- dst-adjust-time: ((12 30 2020) 7.2666666666045785 "IST") > | 2 -> (dst-adjust-time (12 30 2020) 17.71122823099936) > | 2 <- dst-adjust-time: ((12 30 2020) 17.716666666790843 "IST") > | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) > | 2 <- calendar-date-equal: t > | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) > | 2 <- calendar-date-equal: t > 1 <- solar-sunrise-sunset: ((7.2666666666045785 #1=3D"IST") (17.716666666= 790843 #1#) "10:26") Here's my version of this trace: 1 -> (solar-sunrise-sunset (12 30 2020)) | 2 -> (solar-exact-local-noon (12 30 2020)) | | 3 -> (solar-julian-ut-centuries (12 30 2020)) | | 3 <- solar-julian-ut-centuries: 0.2099520876112252 | 2 <- solar-exact-local-noon: ((12 30 2020) 6.9905251059993585) | 2 -> (solar-julian-ut-centuries (12 30 2020)) | 2 <- solar-julian-ut-centuries: 0.2099520876112252 | 2 -> (solar-sidereal-time 0.2099520876112252) | 2 <- solar-sidereal-time: 6.592887211896198 | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) 1.= 0 75.8 0) | 2 <- solar-sunrise-and-sunset: (6.5198219809993585 18.46122823099936 11.9= 41406250000002) | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) 26= .9 75.8 -0.61) | 2 <- solar-sunrise-and-sunset: (7.2698219809993585 17.71122823099936 10.4= 41406250000002) | 2 -> (dst-adjust-time (12 30 2020) 7.2698219809993585) | 2 <- dst-adjust-time: ((12 30 2020) 6.266666667535901 "IST") | 2 -> (dst-adjust-time (12 30 2020) 17.71122823099936) | 2 <- dst-adjust-time: ((12 30 2020) 16.716666667722166 "IST") | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) | 2 <- calendar-date-equal: t | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) | 2 <- calendar-date-equal: t 1 <- solar-sunrise-sunset: ((6.266666667535901 #1=3D"IST") (16.716666667722= 166 #1#) "10:26") So I'm guessing dst-adjust-time adjusts for DST in my locale (based on some cache), but not yours? The following change lets the test succeed for me: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dst.diff diff --git a/test/lisp/calendar/solar-tests.el b/test/lisp/calendar/solar-tests.el index 7a37f8db55..dff64635e5 100644 --- a/test/lisp/calendar/solar-tests.el +++ b/test/lisp/calendar/solar-tests.el @@ -26,7 +26,7 @@ solar-sunrise-sunset (calendar-longitude 75.8) (calendar-time-zone +330) (calendar-standard-time-zone-name "IST") - (calendar-daylight-time-zone-name "IST") + (calendar-daylight-savings-starts nil) (epsilon (/ 60.0))) ; Minute accuracy is good enough. (let* ((sunrise-sunset (solar-sunrise-sunset '(12 30 2020))) (sunrise (car (nth 0 sunrise-sunset))) --=-=-= Content-Type: text/plain Does it look like TRT? Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 16:03:27 2021 Received: (at 45818-done) by debbugs.gnu.org; 12 Jan 2021 21:03:27 +0000 Received: from localhost ([127.0.0.1]:33441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzQp4-0003Ee-RF for submit@debbugs.gnu.org; Tue, 12 Jan 2021 16:03:27 -0500 Received: from mail1447c50.megamailservers.eu ([91.136.14.47]:42954 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzQp2-0003EQ-Dq for 45818-done@debbugs.gnu.org; Tue, 12 Jan 2021 16:03:25 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610485397; bh=1iRMA4fsRybSwn9Jt4NKEbXsQhWWmdnFU1z8j12Pfgs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=AMp6AVffUvMMQmBpdzQwOCgwtns8A7X7q+biUqzepIvozR3oU3LyzQiymDWSR/SjW fIB2pYcKKnabIRqTbhvR6ChbrkG8rkp1XUCiPDlxkfubDWkhj8kno78GP6kELWjQOM jkqy3I71mDqZUlCdEHt+NUSGi7Ngjd/ul6Pc6+88= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10CL3Fex015709; Tue, 12 Jan 2021 21:03:17 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87ft35j4xl.fsf@tcd.ie> Date: Tue, 12 Jan 2021 22:02:15 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F21.5FFE0E95.006B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QoAgIm6d c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=Ot-t5D0Ek9gns1uj3wwA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 12 jan. 2021 kl. 21.06 skrev Basil L. Contovounesios : > So I'm guessing dst-adjust-time adjusts for DST in my locale (based on > some cache), but not yours? The following change lets the test succeed > for me: Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 45818-done Cc: 45818-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 12 jan. 2021 kl. 21.06 skrev Basil L. Contovounesios : > So I'm guessing dst-adjust-time adjusts for DST in my locale (based on > some cache), but not yours? The following change lets the test = succeed > for me: Thank you, and I agree that it's probably the pragmatic choice. Much as = I would have liked to track down and explain the exact reason for the = observed phenomenon, I gave up and pushed your suggested patch. If I would hazard a guess, it's related to the fact that Ireland uses = daylight saving in winter (with opposite adjustment) rather than in = summer; this may trigger a daylight-saving adjustment for the dates in = question (late December). The fact that IST is used for both Irish and = Indian time may be significant or a mere coincidence; it certainly = didn't help matters. Date and time calculations can be both infuriatingly and delightfully = messy, but in this case the code didn't really help either, with way too = many implicit input parameters -- global variables, caches, system = settings, time-zone files, and so on. Not something to make a test = writer happy! Thanks again for the report, and for persevering! From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 17:09:18 2021 Received: (at 45818) by debbugs.gnu.org; 12 Jan 2021 22:09:18 +0000 Received: from localhost ([127.0.0.1]:33532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRqo-00052Z-9W for submit@debbugs.gnu.org; Tue, 12 Jan 2021 17:09:18 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:35710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRqj-000522-Qk for 45818@debbugs.gnu.org; Tue, 12 Jan 2021 17:09:14 -0500 Received: by mail-wm1-f51.google.com with SMTP id e25so3545853wme.0 for <45818@debbugs.gnu.org>; Tue, 12 Jan 2021 14:09:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+dUaKp3u309XD56S49fEmzRtgs8XMIKa6Nueyz1u7pY=; b=ecyZfweUXR/W1NUHz0X3mZQakH37mbAQhd2dI1w7/R47kLyxUvHCmb6BTbhxXbuaxl XUyteHAqnWJXgUJ/F0pjQqGcTT6uqy3Gpfk/BQHrx+N4Xsmuk10doANT4O/tRbu3kkvs XD0Wok9PfW/r1UGZjs2rJk4R1Odr4oKJVpifC/CbhPFIN1U8K16YsBdQStdsj9tFzbli ZU8Ok1lYtzln7F4H0BUAxvz0FCzayg5MIVFTlNRwlKIVKZ0RrysiOlDG6ZT8NIgNbbGI xxNqtqvDn8BvEkmiumKRO+lLQsVsEVJWX+0d8q4mt9ZbZHXCtqt8ZOL7VfGZypmTf8tf Jckw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+dUaKp3u309XD56S49fEmzRtgs8XMIKa6Nueyz1u7pY=; b=az19AmRzArDi0zf3rIhD0nNkC8WtycMmB6c97EfcxZaw8Uhp1I4fwmjBL6uva1i5x9 CqcuOan5WxbWpnp1Ns2aHVVf8mpOoCwsrX2Jx1lcf0AXhywWZAEuRDzSDtvQiHakkcR9 FDZukJ0fUj9AyrC1SSL08Sn4o683vbMJOiWL0CLjhLbF4jQVbVPPWVBsSqfAviM2qtef WnlrzP1TvikdoAr1eFg/2uELyP4rhALvu7r0jcDDetpyBvNizeGLNPo4kK2uI5oSz8An HW9AbXBZKgN/Xl90MScp8p7t/WgmkqTf8dXqE8PU8gR1E9xDNAEu3LG7CbUlP6/WrtB0 whiQ== X-Gm-Message-State: AOAM532J7zV4vUt2BZkBB8zK+A4aj7n8L1ALhCaamWbw63bS/tf61oiz Qx3VdJ/cAJ0OtZTv82FzUuoX1A== X-Google-Smtp-Source: ABdhPJzomnFQ56+29Pj2sq2LSlYsl2ywjjeVe6qltPQ4Sg/oIF/ZYvOmIleUDdr8ELFMh6e/Kz3nyA== X-Received: by 2002:a1c:e3c4:: with SMTP id a187mr1200308wmh.58.1610489348111; Tue, 12 Jan 2021 14:09:08 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id m14sm6945605wrh.94.2021.01.12.14.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 14:09:06 -0800 (PST) From: "Basil L. Contovounesios" To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> Date: Tue, 12 Jan 2021 22:09:05 +0000 In-Reply-To: <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 12 Jan 2021 22:02:15 +0100") Message-ID: <87eeiphkou.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45818 Cc: Stefan Kangas , 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > 12 jan. 2021 kl. 21.06 skrev Basil L. Contovounesios : > >> So I'm guessing dst-adjust-time adjusts for DST in my locale (based on >> some cache), but not yours? The following change lets the test succeed >> for me: > > Thank you, and I agree that it's probably the pragmatic choice. Much as I= would > have liked to track down and explain the exact reason for the observed > phenomenon, I gave up and pushed your suggested patch. > > If I would hazard a guess, it's related to the fact that Ireland uses day= light > saving in winter (with opposite adjustment) rather than in summer; this m= ay > trigger a daylight-saving adjustment for the dates in question (late > December). The fact that IST is used for both Irish and Indian time may be > significant or a mere coincidence; it certainly didn't help matters. > > Date and time calculations can be both infuriatingly and delightfully mes= sy, but > in this case the code didn't really help either, with way too many implic= it > input parameters -- global variables, caches, system settings, time-zone = files, > and so on. Not something to make a test writer happy! Agreed. If this is the sort of stuff that gets you (or Stefan, CCed) out of bed in the morning, then you might also be interested in looking at lunar-test-phase-list. I tried applying the same calendar-daylight-savings-starts trick in with-lunar-test, but that just brought down the difference in actual vs expected times from 2hrs to 1hr. My guess as to why this happens is because calendar-dst-find-data (or similar) calls current-time-zone without an explicit time zone argument, meaning tests can't truly specify a time zone other than the system's in general. Is this new wishlist bug report material, or are we happy to leave lunar-test-phase-list marked as unstable and forget about this? > Thanks again for the report, and for persevering! Thanks for writing the test and making it more robust! That's two of my 'make check' failures fixed in one day, only one to go :). --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 07:41:39 2021 Received: (at 45818) by debbugs.gnu.org; 13 Jan 2021 12:41:39 +0000 Received: from localhost ([127.0.0.1]:34608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzfT0-00081l-Va for submit@debbugs.gnu.org; Wed, 13 Jan 2021 07:41:39 -0500 Received: from mail1470c50.megamailservers.eu ([91.136.14.70]:38730 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzfSx-00081V-Jz for 45818@debbugs.gnu.org; Wed, 13 Jan 2021 07:41:36 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610539972; bh=ZeKNjYv51LC3AZJyl+oSRrOcKttFbKq/bwlLN9SYsdw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=aaMew23bgORUzCjIO5iezdn6SCTb0L/nUI87ScvoxVwzh4uHy5qDSIqj6HNe0YO3n mqgCXiU1N0we1aiELTKd5m7fBNIvvKB3VW1c3fOR3W9pawxMcT5pw8vlHF6h/MihWT glMOwSI3kgBvs10ptjiD7PWqMGIiOqBXB7ybPhvA= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10DCCnW2027747; Wed, 13 Jan 2021 12:12:50 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87eeiphkou.fsf@tcd.ie> Date: Wed, 13 Jan 2021 13:12:48 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> <87eeiphkou.fsf@tcd.ie> To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1F.5FFEE3C4.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=d6CLNirE c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=thWGRzfbAAAA:8 a=izbNSLyvrweggoMxd1gA:9 a=CjuIK1q_8ugA:10 a=Xo0djKA56MUA:10 a=tIp4BSgjzBjTsUfidmXJ:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 12 jan. 2021 kl. 23.09 skrev Basil L. Contovounesios : > Agreed. If this is the sort of stuff that gets you (or Stefan, CCed) > out of bed in the morning, then you might also be interested in looking > at lunar-test-phase-list. I tried applying the same > [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 45818 Cc: Stefan Kangas , 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 12 jan. 2021 kl. 23.09 skrev Basil L. Contovounesios : > Agreed. If this is the sort of stuff that gets you (or Stefan, CCed) > out of bed in the morning, then you might also be interested in = looking > at lunar-test-phase-list. I tried applying the same > calendar-daylight-savings-starts trick in with-lunar-test, but that = just > brought down the difference in actual vs expected times from 2hrs to > 1hr. Let's give lunar-tests.el a go then. Stefan, what is the ground truth = here? Where does the data come from? (And what does "** Eclipse **" mean? That the Moon intersects the = Earth-Sun orbital plane without causing an actual eclipse? I can't be = the only one confused by this.) If https://stellafane.org/observing/moon_phase.html can be trusted, the = times of day in the test are off by about one hour. The discrepancies = are almost exactly one hour for new moons but a few minutes off for full = moons. Thus it looks like the test numbers were produced from a test run = in summer, which is consistent with the file creation date. > My guess as to why this happens is because calendar-dst-find-data (or > similar) calls current-time-zone without an explicit time zone = argument, > meaning tests can't truly specify a time zone other than the system's = in > general. Could be -- if so, the code would benefit from an override for test = purposes. > Is this new wishlist bug report material, or are we happy to leave > lunar-test-phase-list marked as unstable and forget about this? Marking a test as unstable is tantamount to commenting it out. There = needs to be an open bug or the problem is quickly forgotten. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 08:05:05 2021 Received: (at 45818) by debbugs.gnu.org; 13 Jan 2021 13:05:05 +0000 Received: from localhost ([127.0.0.1]:34618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzfph-00009k-CF for submit@debbugs.gnu.org; Wed, 13 Jan 2021 08:05:05 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:40758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzfpe-000098-SZ for 45818@debbugs.gnu.org; Wed, 13 Jan 2021 08:05:04 -0500 Received: by mail-pl1-f169.google.com with SMTP id q4so1032002plr.7 for <45818@debbugs.gnu.org>; Wed, 13 Jan 2021 05:05:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=MqjZVF+zDCxViICSKSIiogb+MyrCtPJdL3nq+xmUdQg=; b=iu9bDcPlCfSGja6VClCELy1/eU6cSOmFiKpmBGTsTYjnoh3a+a8W8wwBN5laoti5wt SKznBjFru5C9plTMfyqD3cPQOMxTK5bCN89XU7RBDsnh6n98jNhbE2uOyQDtQiL0ILP1 6uN9Y1+r++UXinSlLBoxwguSv+J8VwTItoLzu6zK6gh+/MHr+X9q4M147o7/53NFb2z8 ZcC0rhV6R/ju2tqnv3VbKSnKb2g3DFjKVL2B8sw3Rwq7fy0w+5HjOKyHY+VdW5hMn5M4 46HZ/8JDaa3XlyvYWnOVopvIY08BMUAyqibTDkFbVDY34HYqLGtsW6sbI0lzJ4OGccHS NCGg== X-Gm-Message-State: AOAM533Lvtn+x6GS0et/PIN+xtrTzCvwFJxi0qciPrxDZSktO089GFWR bfH/Z//NjrFyZ3MMcucnbrPbJaopNGTZiIRSJwY= X-Google-Smtp-Source: ABdhPJw/tiaEaPtdmwJhSCy+/fkBieiLMgloxZZEO8e1we6BYtx3gCPDMo0QB738wAvEcK8jCoDfXkuPiphbSf5tBt0= X-Received: by 2002:a17:902:9309:b029:db:c725:d19c with SMTP id bc9-20020a1709029309b02900dbc725d19cmr2235780plb.39.1610543097020; Wed, 13 Jan 2021 05:04:57 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Jan 2021 07:04:56 -0600 From: Stefan Kangas In-Reply-To: <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> <87eeiphkou.fsf@tcd.ie> <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> MIME-Version: 1.0 Date: Wed, 13 Jan 2021 07:04:56 -0600 Message-ID: Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 45818 Cc: 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Mattias Engdeg=C3=A5rd writes: > Let's give lunar-tests.el a go then. Stefan, what is the ground truth > here? Where does the data come from? I just assumed that the current calculations were correct and tested for that. This was to be able to verify that nothing changed when I turned on lexical-binding for lunar.el. Please do not assume that some deep thought that went into this: it's more or less something I hacked together in an hour or three. Feel free to change any aspect of it if you think you can find something more precise. Thank you for working on this. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 08:29:11 2021 Received: (at 45818) by debbugs.gnu.org; 13 Jan 2021 13:29:11 +0000 Received: from localhost ([127.0.0.1]:34642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzgD1-0000o4-0v for submit@debbugs.gnu.org; Wed, 13 Jan 2021 08:29:11 -0500 Received: from mail211c50.megamailservers.eu ([91.136.10.221]:48224 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzgCy-0000nq-KA for 45818@debbugs.gnu.org; Wed, 13 Jan 2021 08:29:09 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610544544; bh=brRrVXB1JIQwmguQj3exx/4DT5GsjJ/QQ7z0fwY7+zY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=E+II9pDx2YJSTTS1jPs6Ui0r1bqivdKxKEymAn/xTBjNUi0u+d2aeOKNJhhI5Jo8O JTdfy1UKNZylBY6BDq757btk/okq9Spr0ls2iZCwu05nO8x9TeQq9iZAJBAVxw3BO6 91bOAouq08PauxL9BpzdajOkzZpRgBNExcMcdMxY= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10DDT0uO022629; Wed, 13 Jan 2021 13:29:03 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Wed, 13 Jan 2021 14:29:00 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> <87eeiphkou.fsf@tcd.ie> <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> To: Stefan Kangas X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F15.5FFEF5A0.001B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=AfXP4EfG c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=en_O0qbODLsfJQoFLxwA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 45818 Cc: "Basil L. Contovounesios" , 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 13 jan. 2021 kl. 14.04 skrev Stefan Kangas : > I just assumed that the current calculations were correct and tested = for > that. This was to be able to verify that nothing changed when I = turned > on lexical-binding for lunar.el. You are certainly forgiven for that assumption. I would have done the = same. Thanks for writing it in the first place! Now the test has been enabled again, in the hope that it will remain = stable: the reference data have been corrected and are now in UTC, = daylight saving disabled. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 14:03:51 2021 Received: (at 45818) by debbugs.gnu.org; 13 Jan 2021 19:03:51 +0000 Received: from localhost ([127.0.0.1]:36606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzlQt-00021L-0S for submit@debbugs.gnu.org; Wed, 13 Jan 2021 14:03:51 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:40513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzlQq-000219-Vz for 45818@debbugs.gnu.org; Wed, 13 Jan 2021 14:03:50 -0500 Received: by mail-wm1-f51.google.com with SMTP id r4so2600097wmh.5 for <45818@debbugs.gnu.org>; Wed, 13 Jan 2021 11:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=pOX4CeILnzKCdcFrXhiwMushN7uhbZ+wph4kmWftEdM=; b=k5Q2loyPAaG3vVR0qi0TfzZz2GnaA4vZVKvyR4voHiScXvidRZm8Eb58F2NeeOjANf XIt5PmxyAtwgYIGXqehQSLfp3Yowj9YwPIeYO5H20O99R7SNL3h+SoIexLqrGOSdLUeK Tm8JsgZnJCq2tJxbYisBaNFpJgAofJDS4uGbR4iIXxfOF+oLtgKqYE6rBK5LYLe1FWNJ bFFwAp0Pf0WLN2gG9QYWGBx8SLwgvnjk/9WvX66Y9Hi0CXoMFk1Sl2WNnZPsXceex03q jwMdFgQPjhaFfPysZg+14ip17exZTyhYbCTIgRcmNurek9Y/M/RnVFuM05iWAaSgXicq ++BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pOX4CeILnzKCdcFrXhiwMushN7uhbZ+wph4kmWftEdM=; b=QaqnK8016J5gdSEO4X6B8ab9ZPG/4ihzCALqTyAVn/KD4SVhdwnbXl4lYyrWcc/+MT c5Fh4T8fZNOB/h5YGYdxaPYBLzMu37SVKHU3ghBtgGc9oWrQpAJMwZbSeQKZQFPbBFrE CO3Fkz6QKZM6lz9BP8RxvlLxEvof5Cu/ggVyY3v6P1ge9UvOUGbMMvU4T2p36fdZxTTt w3CAaaf1FfSjoTCbl2njS2Pf47P4MAsBQ/HbQUmhwuD0ZTipWL49zSiH1rHFbpTrqNi7 hgt3u+lHpv5f4EzH08e9DC17gzb1AFIbf8qE6d+mHAqc46jHJ420AlBZOP0g0gxclDSj sZBQ== X-Gm-Message-State: AOAM531hjeyKRGLV2QsSyK/e/e4nqKvj/czwSlkmDF+q6p7H3GwU40x0 xTtzpiS9vC1I6kTXro7AH3DcxA== X-Google-Smtp-Source: ABdhPJx6aqINuuIMr8+1ZUPvNBGUSURcBS6oIEUNZ4+wYAK1xiNlycamJSgflcMMEcsvudKk828NOA== X-Received: by 2002:a1c:40d6:: with SMTP id n205mr662986wma.0.1610564623061; Wed, 13 Jan 2021 11:03:43 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id p8sm5186873wru.50.2021.01.13.11.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 11:03:41 -0800 (PST) From: "Basil L. Contovounesios" To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#45818: 28.0.50; Test solar-sunrise-sunset fails References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> <87eeiphkou.fsf@tcd.ie> <6F0AA926-37CF-4E5D-B2A6-8BECE7E5465E@acm.org> Date: Wed, 13 Jan 2021 19:03:40 +0000 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 13 Jan 2021 14:29:00 +0100") Message-ID: <87k0sgacc3.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45818 Cc: Stefan Kangas , 45818@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > Now the test has been enabled again, in the hope that it will remain stab= le: the > reference data have been corrected and are now in UTC, daylight saving di= sabled. Thanks, it passes here. --=20 Basil From unknown Tue Jun 17 01:29:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Feb 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator