From unknown Tue Jun 17 03:39:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45797 <45797@debbugs.gnu.org> To: bug#45797 <45797@debbugs.gnu.org> Subject: Status: 28.0.50; [PATCH]: Simplify comint-read-input-ring Reply-To: bug#45797 <45797@debbugs.gnu.org> Date: Tue, 17 Jun 2025 10:39:35 +0000 retitle 45797 28.0.50; [PATCH]: Simplify comint-read-input-ring reassign 45797 emacs submitter 45797 Brian Leung severity 45797 normal tag 45797 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 14:20:19 2021 Received: (at submit) by debbugs.gnu.org; 11 Jan 2021 19:20:19 +0000 Received: from localhost ([127.0.0.1]:58306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kz2jj-0002wo-7R for submit@debbugs.gnu.org; Mon, 11 Jan 2021 14:20:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:51364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kz2jg-0002wc-P7 for submit@debbugs.gnu.org; Mon, 11 Jan 2021 14:20:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2jg-0005Eu-Eq for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:20:16 -0500 Received: from wilbur.contactoffice.com ([212.3.242.68]:55266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2jc-0000X6-Aw for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 14:20:16 -0500 Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id C89F4762 for ; Mon, 11 Jan 2021 20:20:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com; s=20160819-nLV10XS2; t=1610392807; bh=Ic7XcllCGBRbDBhjvygjUlH4qJBqhmPPVF7mz1qJIV0=; h=Date:To:Subject:Reply-To:From:From; b=tkhEPO/xdMuqqjRuWrnF05TTpySnpWPr/97Z+TZIqhsDE8XNB/NO5rvc28I5Gdp/7 qb5eyiOm7vwWwLXpvvKElTUB5JLh4fvjeTAaGib171y1S0HH5+Q87LqfOA3M1tonPY w0dUV48Z33siS2WqlMsZH6kW6D+h9gbcCBHnRQtL29zWc84lFp7sQ+TYrHihb7AlRm Qaw2pwh87cjzJsO7q4tY00dmJVyg2a86iuNWqxBYxF/TYMzn8xF0zADd+X6tV08XBa T1FN5PTRPPhSTDVhZPg74pQ8q0cxGsZNDIPvUoNoU1lcfwEddsI9BhbMaUtUfRNJQt zfhWCYSfW6Jvg== Date: Mon, 11 Jan 2021 20:20:04 +0100 (CET) Message-ID: <1374515308.96389.1610392804487@ichabod.co-bxl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_96349_1550428200.1610392779197" To: Bug Gnu Emacs Subject: 28.0.50; [PATCH]: Simplify comint-read-input-ring X-Priority: 3 From: Brian Leung X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 Received-SPF: pass client-ip=212.3.242.68; envelope-from=leungbk@mailfence.com; helo=wilbur.contactoffice.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Brian Leung Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ------=_Part_96349_1550428200.1610392779197 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable See attached. --=C2=A0 Sent with https://mailfence.com Secure and private email ------=_Part_96349_1550428200.1610392779197 Content-Type: text/x-diff; charset=us-ascii; name=0001-comint-read-input-ring-Simplify-last-commit.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0001-comint-read-input-ring-Simplify-last-commit.patch Content-Disposition: attachment; filename=0001-comint-read-input-ring-Simplify-last-commit.patch >From 7adf2a49d3b247f424b7a9c2fab24a82418bbb8e Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Mon, 11 Jan 2021 11:09:30 -0800 Subject: [PATCH] comint-read-input-ring: Simplify last commit * lisp/comint.el (comint-read-input-ring): Simplify. It is not necessary to use `goto-char' again since we have already moved point to the desired location. --- lisp/comint.el | 1 - 1 file changed, 1 deletion(-) diff --git a/lisp/comint.el b/lisp/comint.el index 3476fd146c..53153af7d2 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -1000,7 +1000,6 @@ comint-read-input-ring (goto-char (match-end 0))) (setq start (point)) (setq history (buffer-substring start end)) - (goto-char start) (when (and (not (string-match history-ignore history)) (or (null ignoredups) (ring-empty-p ring) -- 2.29.2 ------=_Part_96349_1550428200.1610392779197-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 07:29:46 2021 Received: (at 45797) by debbugs.gnu.org; 12 Jan 2021 12:29:46 +0000 Received: from localhost ([127.0.0.1]:59510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzIny-0003gE-Dw for submit@debbugs.gnu.org; Tue, 12 Jan 2021 07:29:46 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzInw-0003fx-AI for 45797@debbugs.gnu.org; Tue, 12 Jan 2021 07:29:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cInvbfIPhaAfIWfnMjnukW6gFNAWyHgrbr4MJonhd6g=; b=VMyJNawWdI/lDyNCX0c/a3Ltbu MHPv2ydb68Y/7efx/3xD3/JW4PaQbqzHeQbX1OQIZl0Vg0PKJU5ld5OHocLDl3RX5r0frbLp9A3Ak O/3N0KxCphczDgfij+40C+a0tCdH9YaR/1CCXQvwA/VK0QcbONnueFMxD+1Au0GxDNRM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzInk-0004hE-EJ; Tue, 12 Jan 2021 13:29:38 +0100 From: Lars Ingebrigtsen To: Brian Leung Subject: Re: bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring References: <1374515308.96389.1610392804487@ichabod.co-bxl> X-Now-Playing: Soft Cell's _Cruelty Without Beauty (2)_: "Last Chance (2020 Extended Mix)" Date: Tue, 12 Jan 2021 13:29:31 +0100 In-Reply-To: <1374515308.96389.1610392804487@ichabod.co-bxl> (Brian Leung's message of "Mon, 11 Jan 2021 20:20:04 +0100 (CET)") Message-ID: <87ft36baok.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Brian Leung writes: > See attached. Thanks; applied to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45797 Cc: 45797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brian Leung writes: > See attached. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 07:29:50 2021 Received: (at control) by debbugs.gnu.org; 12 Jan 2021 12:29:51 +0000 Received: from localhost ([127.0.0.1]:59513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzIo2-0003gU-Mm for submit@debbugs.gnu.org; Tue, 12 Jan 2021 07:29:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzIo1-0003g6-NF for control@debbugs.gnu.org; Tue, 12 Jan 2021 07:29:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AZGccvPYm2MkC2fMWMwoRY/WAjvgx8S3CN9LJv2rlA4=; b=bAedDdva8XJA1GRHuFfSmYok25 A2gYhIbT3Axdc8bB8Ro5mPdlmc/9slScKXP3DoqlwtG6Uz+HoNgIQafXi0jOosthBeTupI2Z8UY1Q AUJJrzxBUx/YeqKizWOMF8M+BtJTHzImugBWcxkE1ZDStgeSU1cLFfFv3BWjfd6WsZHY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzInt-0004hP-Nr for control@debbugs.gnu.org; Tue, 12 Jan 2021 13:29:43 +0100 Date: Tue, 12 Jan 2021 13:29:40 +0100 Message-Id: <87eeiqbaob.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45797 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45797 fixed close 45797 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45797 fixed close 45797 28.1 quit From unknown Tue Jun 17 03:39:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 10 Feb 2021 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator