From unknown Fri Sep 05 21:31:30 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4578: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found Reply-To: Jari Aalto , 4578@debbugs.gnu.org Resent-From: Jari Aalto Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 28 Sep 2009 11:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4578 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125413795118478 (code B ref -1); Mon, 28 Sep 2009 11:45:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 28 Sep 2009 11:39:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.6 required=4.0 tests=AWL,IMPRONONCABLE_2, MURPHY_DRUGS_REL8,SARE_MLB_Stock6 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh06.mail.saunalahti.fi (emh06.mail.saunalahti.fi [62.142.5.116]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8SBd9Fn018474 for ; Mon, 28 Sep 2009 04:39:10 -0700 Received: from saunalahti-vams (vs3-10.mail.saunalahti.fi [62.142.5.94]) by emh06-2.mail.saunalahti.fi (Postfix) with SMTP id 8BE47C818C for ; Mon, 28 Sep 2009 14:39:08 +0300 (EEST) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-10.mail.saunalahti.fi ([62.142.5.94]) with SMTP (gateway) id A047D2884F5; Mon, 28 Sep 2009 14:39:08 +0300 Received: from jondo.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 78255158A63 for ; Mon, 28 Sep 2009 14:39:07 +0300 (EEST) From: Jari Aalto To: submit@debbugs.gnu.org Date: Mon, 28 Sep 2009 14:39:07 +0300 Message-ID: <87k4zjwb6s.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS --=-=-= Tags: patch If the empty slot is not checked, the spell checking breaks in myterious errors. E.g. flyspell-get-casechars returns nil, which breaks all of flyspell. 2009-09-28 Jari Aalto * textmodes/ispell.el (ispell-get-decoded-string): signal an error if no matching slot is found from `ispell-current-dictionary' --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-textmodes-ispell.el-ispell-get-decoded-string-s.patch >From b301e76fdf3e83de88101891a3cd7ea13f5fba14 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Mon, 28 Sep 2009 14:35:21 +0300 Subject: [PATCH] lisp/textmodes/ispell.el: (ispell-get-decoded-string): signal an error if no slot found Signed-off-by: Jari Aalto --- lisp/textmodes/ispell.el | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 6d02cf9..729122b 100644 --- a/lisp/textmodes/ispell.el +++ b/lisp/textmodes/ispell.el @@ -1289,7 +1289,8 @@ Protects against bogus binding of `enable-multibyte-characters' in XEmacs." (defun ispell-get-decoded-string (n) (let* ((slot (or (assoc ispell-current-dictionary ispell-local-dictionary-alist) - (assoc ispell-current-dictionary ispell-dictionary-alist))) + (assoc ispell-current-dictionary ispell-dictionary-alist) + (error "No slot match in ispell-current-dictionary"))) (str (nth n slot))) (when (and (> (length str) 0) (not (multibyte-string-p str))) -- 1.6.3.3 --=-=-=-- From unknown Fri Sep 05 21:31:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Jari Aalto Subject: bug#4578 closed by Glenn Morris (Re: Bug#4578: ispell.el (ispell-get-decoded-string): signal an error if no slot found) Message-ID: References: <87k4zjwb6s.fsf@jondo.cante.net> X-Emacs-PR-Message: they-closed 4578 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Reply-To: 4578@debbugs.gnu.org Date: Sat, 17 Oct 2009 03:20:13 +0000 Content-Type: multipart/mixed; boundary="----------=_1255749613-3274-1" This is a multi-part message in MIME format... ------------=_1255749613-3274-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4578: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an = error if no slot found It has been closed by Glenn Morris . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Glenn Morris by replying to this email. --=20 4578: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4578 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1255749613-3274-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4578-done) by emacsbugs.donarmstrong.com; 17 Oct 2009 03:10:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9H3Ads7002242 for <4578-done@emacsbugs.donarmstrong.com>; Fri, 16 Oct 2009 20:10:40 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Myzgk-0004Tl-Oa; Fri, 16 Oct 2009 23:10:38 -0400 From: Glenn Morris To: 4578-done@debbugs.gnu.org Subject: Re: Bug#4578: ispell.el (ispell-get-decoded-string): signal an error if no slot found References: <87k4zjwb6s.fsf@jondo.cante.net> X-Spook: MIT-LL digicash Syria Treasury USDOJ Noriega Bush Wired X-Ran: W2VNBU'?0'N+q]]OPq_:;P*QHjrz}>trON'2XbSzlq[EG8Pbo0x7%4/SuZ4-bwO4k6e8HC X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 16 Oct 2009 23:10:38 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks; applied. ------------=_1255749613-3274-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 28 Sep 2009 11:39:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.6 required=4.0 tests=AWL,IMPRONONCABLE_2, MURPHY_DRUGS_REL8,SARE_MLB_Stock6 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh06.mail.saunalahti.fi (emh06.mail.saunalahti.fi [62.142.5.116]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8SBd9Fn018474 for ; Mon, 28 Sep 2009 04:39:10 -0700 Received: from saunalahti-vams (vs3-10.mail.saunalahti.fi [62.142.5.94]) by emh06-2.mail.saunalahti.fi (Postfix) with SMTP id 8BE47C818C for ; Mon, 28 Sep 2009 14:39:08 +0300 (EEST) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-10.mail.saunalahti.fi ([62.142.5.94]) with SMTP (gateway) id A047D2884F5; Mon, 28 Sep 2009 14:39:08 +0300 Received: from jondo.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 78255158A63 for ; Mon, 28 Sep 2009 14:39:07 +0300 (EEST) From: Jari Aalto To: submit@debbugs.gnu.org Subject: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found Date: Mon, 28 Sep 2009 14:39:07 +0300 Message-ID: <87k4zjwb6s.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS --=-=-= Tags: patch If the empty slot is not checked, the spell checking breaks in myterious errors. E.g. flyspell-get-casechars returns nil, which breaks all of flyspell. 2009-09-28 Jari Aalto * textmodes/ispell.el (ispell-get-decoded-string): signal an error if no matching slot is found from `ispell-current-dictionary' --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-textmodes-ispell.el-ispell-get-decoded-string-s.patch >From b301e76fdf3e83de88101891a3cd7ea13f5fba14 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Mon, 28 Sep 2009 14:35:21 +0300 Subject: [PATCH] lisp/textmodes/ispell.el: (ispell-get-decoded-string): signal an error if no slot found Signed-off-by: Jari Aalto --- lisp/textmodes/ispell.el | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index 6d02cf9..729122b 100644 --- a/lisp/textmodes/ispell.el +++ b/lisp/textmodes/ispell.el @@ -1289,7 +1289,8 @@ Protects against bogus binding of `enable-multibyte-characters' in XEmacs." (defun ispell-get-decoded-string (n) (let* ((slot (or (assoc ispell-current-dictionary ispell-local-dictionary-alist) - (assoc ispell-current-dictionary ispell-dictionary-alist))) + (assoc ispell-current-dictionary ispell-dictionary-alist) + (error "No slot match in ispell-current-dictionary"))) (str (nth n slot))) (when (and (> (length str) 0) (not (multibyte-string-p str))) -- 1.6.3.3 --=-=-=-- ------------=_1255749613-3274-1--