GNU bug report logs - #45759
[PATCH] Remove unused argument from set_frame_menubar

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Sun, 10 Jan 2021 11:54:01 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45759 in the body.
You can then email your comments to 45759 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#45759; Package emacs. (Sun, 10 Jan 2021 11:54:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 10 Jan 2021 11:54:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove unused argument from set_frame_menubar
Date: Sun, 10 Jan 2021 05:53:11 -0600

[Message part 1 (text/plain, inline)]
Severity: wishlist

The set_frame_menubar argument first_time has been unused since at least
1998, AFAICT.  I think it can be safely removed.

[0001-Remove-unused-argument-from-set_frame_menubar.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#45759; Package emacs. (Wed, 20 Jan 2021 22:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 45759 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 45759 <at> debbugs.gnu.org
Subject: Re: bug#45759: [PATCH] Remove unused argument from set_frame_menubar
Date: Wed, 20 Jan 2021 23:07:33 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> The set_frame_menubar argument first_time has been unused since at least
> 1998, AFAICT.  I think it can be safely removed.

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#45759; Package emacs. (Sat, 30 Jan 2021 15:18:02 GMT) Full text and rfc822 format available.

Message #11 received at 45759 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 45759 <at> debbugs.gnu.org
Subject: Re: bug#45759: [PATCH] Remove unused argument from set_frame_menubar
Date: Sat, 30 Jan 2021 09:17:27 -0600

tags 45759 fixed
close 45759 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> The set_frame_menubar argument first_time has been unused since at least
>> 1998, AFAICT.  I think it can be safely removed.
>
> Looks good to me.

Thanks, pushed to master as commit 3555657585.
Added tag(s) fixed. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sat, 30 Jan 2021 15:18:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 45759 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sat, 30 Jan 2021 15:18:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 28 Feb 2021 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 169 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.