GNU bug report logs - #45754
[PATCH] gnu: Add emacs-anki-editor

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Noah Evans via Guix-patches via <guix-patches <at> gnu.org>
Cc: 45754 <at> debbugs.gnu.org, Noah Evans <clonex100 <at> protonmail.com>
Subject: Re: [bug#45754] [PATCH] gnu: Add emacs-anki-editor
Date: Sun, 10 Jan 2021 19:53:07 +0100

Hello,

Noah Evans via Guix-patches via <guix-patches <at> gnu.org> writes:

> +(define-public emacs-anki-editor

Thank you. Some comments follow.

You did not provide a commit message. Could you provide one? For
example,

    gnu: Add emacs-anki-editor

    * gnu/packages/emacs-xyz.scm (emacs-anki-editor): New variable.

is enough.

Also, your indentation is off. Could you use, e.g., M-q in Emacs to fix
it?

> + (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df")
> + (revision "0")
> + (version "0.3.3"))

Could you explain why you chose the latest commit instead "0.3.3"
release? It might be because that release is more than two years old.

> + (package
> + (name "emacs-anki-editor")
> + (version (git-version version revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/louietan/anki-editor")
> + (commit commit)))

There's a

  (file-name (git-file-name name version))

missing here.

> + (sha256
> + (base32
> + "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-request" ,emacs-request)
> + ("emacs-dash" ,emacs-dash)))

Could you order inputs alphabetically?

> + (synopsis
> + "Minor mode for making Anki cards with org-mode")

Could you replace org-mode with Org mode?

> + (description
> + "This package is for people who use Anki as SRS but would like to
> +make cards in @code{org-mode}.")

Could you explain in the description what is a "SRS"? Also,
@code{org-mode} should become Org mode.

You can also update your copyright line at the beginning of the file.

As the last point, could you move the package elsewhere than at the end
of the file. There, it is likely to introduce a merge conflict, e.g., if
someone also submits a package there while yours is being reviewed.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.