From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 01:07:57 2021 Received: (at submit) by debbugs.gnu.org; 10 Jan 2021 06:07:57 +0000 Received: from localhost ([127.0.0.1]:53002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyTtN-0004jT-5s for submit@debbugs.gnu.org; Sun, 10 Jan 2021 01:07:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:56660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyTtL-0004jI-9x for submit@debbugs.gnu.org; Sun, 10 Jan 2021 01:07:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyTtK-0003Lt-BN for guix-patches@gnu.org; Sun, 10 Jan 2021 01:07:55 -0500 Received: from mail2.protonmail.ch ([185.70.40.22]:46055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyTtI-0005Pb-6D for guix-patches@gnu.org; Sun, 10 Jan 2021 01:07:53 -0500 Date: Sun, 10 Jan 2021 06:07:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1610258868; bh=qmcjy+vktpzw2xC8nHMNZdN/39hJhOVGOj/cZHYH6fU=; h=Date:To:From:Reply-To:Subject:From; b=chT77I44buWqG+PSI+pZ/sKk3DmvGYlbP0JmvVCjR2k154ciQZyt+njhQ1xYCNG+/ d3qgzlNzKtvgYkVXpK/+hWmr5jlBrudxvq21A3J83cJYiLVzXvpfNMkT2DeGO9praa HwoaThRyAbkVi5Ife69d8uC6G54bAxn2MY30oA5s= To: "guix-patches@gnu.org" From: Noah Evans Subject: [PATCH] gnu: Add emacs-anki-editor Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_w0p3M66m4wClj7quqdmjXYPkRg5Rb5EN0rOaJdMXJE" X-Spam-Status: No, score=-0.7 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.22; envelope-from=clonex100@protonmail.com; helo=mail2.protonmail.ch X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Noah Evans Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) This is a multi-part message in MIME format. --b1_w0p3M66m4wClj7quqdmjXYPkRg5Rb5EN0rOaJdMXJE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 LS0tCmdudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIHwgMjkgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9n bnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmlu ZGV4IGM4NjQ1MmZlMmIuLmYxZmFiZDRmMTcgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFj cy14eXouc2NtCisrKyBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC0yNjQyMywzICsy NjQyMywzMiBAQCB0byBwYXN0ZWJpbi1saWtlIHNlcnZpY2VzLiBJdCBzdXBwb3J0cyBtb3JlIHRo YW4gb25lIHNlcnZpY2UgYW5kIHdpbGwKZmFpbG92ZXIgaWYgb25lIHNlcnZpY2UgZmFpbHMuIE1v cmUgc2VydmljZXMgY2FuIGVhc2lseSBiZSBhZGRlZCBvdmVyIHRpbWUKYW5kIHByZWZlcmVkIHNl cnZpY2VzIGNhbiBlYXNpbHkgYmUgY29uZmlndXJlZC4iKQoobGljZW5zZSBsaWNlbnNlOmdwbDMr KSkpCisKKyhkZWZpbmUtcHVibGljIGVtYWNzLWFua2ktZWRpdG9yCisgKGxldCAoKGNvbW1pdCAi NTQ2Nzc0YTQ1M2VmNDYxN2IxYmNiMGQxNjI2ZTQxNWM2N2NjODhkZiIpCisgKHJldmlzaW9uICIw IikKKyAodmVyc2lvbiAiMC4zLjMiKSkKKyAocGFja2FnZQorIChuYW1lICJlbWFjcy1hbmtpLWVk aXRvciIpCisgKHZlcnNpb24gKGdpdC12ZXJzaW9uIHZlcnNpb24gcmV2aXNpb24gY29tbWl0KSkK KyAoc291cmNlCisgKG9yaWdpbgorIChtZXRob2QgZ2l0LWZldGNoKQorICh1cmkgKGdpdC1yZWZl cmVuY2UKKyAodXJsICJodHRwczovL2dpdGh1Yi5jb20vbG91aWV0YW4vYW5raS1lZGl0b3IiKQor IChjb21taXQgY29tbWl0KSkpCisgKHNoYTI1NgorIChiYXNlMzIKKyAiMWlmNjEwaHE1ajhyYmpo MWNhdzVid2JnbnNuMjMxYXd3eHFicHd2cmg5NjZrZHh6bDRxZiIpKSkpCisgKGJ1aWxkLXN5c3Rl bSBlbWFjcy1idWlsZC1zeXN0ZW0pCisgKHByb3BhZ2F0ZWQtaW5wdXRzCisgYCgoImVtYWNzLXJl cXVlc3QiICxlbWFjcy1yZXF1ZXN0KQorICgiZW1hY3MtZGFzaCIgLGVtYWNzLWRhc2gpKSkKKyAo aG9tZS1wYWdlCisgImh0dHBzOi8vZ2l0aHViLmNvbS9sb3VpZXRhbi9hbmtpLWVkaXRvciIpCisg KHN5bm9wc2lzCisgIk1pbm9yIG1vZGUgZm9yIG1ha2luZyBBbmtpIGNhcmRzIHdpdGggb3JnLW1v ZGUiKQorIChkZXNjcmlwdGlvbgorICJUaGlzIHBhY2thZ2UgaXMgZm9yIHBlb3BsZSB3aG8gdXNl IEFua2kgYXMgU1JTIGJ1dCB3b3VsZCBsaWtlIHRvCittYWtlIGNhcmRzIGluIEBjb2Rle29yZy1t b2RlfS4iKQorIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkpCi0tCjIuMzAuMA== --b1_w0p3M66m4wClj7quqdmjXYPkRg5Rb5EN0rOaJdMXJE Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdj4tLS08YnI+PC9kaXY+PGRpdj5nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSB8IDI5ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrPGJyPjwvZGl2PjxkaXY+MSBmaWxlIGNoYW5nZWQs IDI5IGluc2VydGlvbnMoKyk8YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5kaWZmIC0tZ2l0 IGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNj bTxicj48L2Rpdj48ZGl2PmluZGV4IGM4NjQ1MmZlMmIuLmYxZmFiZDRmMTcgMTAwNjQ0PGJyPjwv ZGl2PjxkaXY+LS0tIGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY208YnI+PC9kaXY+PGRpdj4r KysgYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbTxicj48L2Rpdj48ZGl2PkBAIC0yNjQyMywz ICsyNjQyMywzMiBAQCB0byBwYXN0ZWJpbi1saWtlIHNlcnZpY2VzLiZuYnNwOyBJdCBzdXBwb3J0 cyBtb3JlIHRoYW4gb25lIHNlcnZpY2UgYW5kIHdpbGw8YnI+PC9kaXY+PGRpdj5mYWlsb3ZlciBp ZiBvbmUgc2VydmljZSBmYWlscy4mbmJzcDsgTW9yZSBzZXJ2aWNlcyBjYW4gZWFzaWx5IGJlIGFk ZGVkIG92ZXIgdGltZTxicj48L2Rpdj48ZGl2PmFuZCBwcmVmZXJlZCBzZXJ2aWNlcyBjYW4gZWFz aWx5IGJlIGNvbmZpZ3VyZWQuIik8YnI+PC9kaXY+PGRpdj4mbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKTxicj48L2Rpdj48ZGl2Pis8YnI+PC9kaXY+PGRp dj4rKGRlZmluZS1wdWJsaWMgZW1hY3MtYW5raS1lZGl0b3I8YnI+PC9kaXY+PGRpdj4rJm5ic3A7 IChsZXQgKChjb21taXQgIjU0Njc3NGE0NTNlZjQ2MTdiMWJjYjBkMTYyNmU0MTVjNjdjYzg4ZGYi KTxicj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsgKHJldmlzaW9uICIwIik8YnI+PC9kaXY+PGRpdj4rJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7ICh2ZXJzaW9uICIwLjMuMyIpKTxicj48L2Rpdj48ZGl2PismbmJz cDsmbmJzcDsmbmJzcDsgKHBhY2thZ2U8YnI+PC9kaXY+PGRpdj4rJm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7IChuYW1lICJlbWFjcy1hbmtpLWVkaXRvciIpPGJyPjwvZGl2PjxkaXY+KyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAodmVyc2lvbiAoZ2l0LXZlcnNpb24gdmVyc2lv biByZXZpc2lvbiBjb21taXQpKTxicj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsgKHNvdXJjZTxicj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm bmJzcDsmbmJzcDsgKG9yaWdpbjxicj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKG1ldGhvZCBnaXQtZmV0Y2gpPGJyPjwvZGl2Pjxk aXY+KyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAodXJp IChnaXQtcmVmZXJlbmNlPGJyPjwvZGl2PjxkaXY+KyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyAodXJsICI8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vbG91aWV0YW4vYW5raS1lZGl0b3Ii Pmh0dHBzOi8vZ2l0aHViLmNvbS9sb3VpZXRhbi9hbmtpLWVkaXRvcjwvYT4iKTxicj48L2Rpdj48 ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKGNvbW1pdCBjb21taXQpKSk8YnI+PC9k aXY+PGRpdj4rJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 IChzaGEyNTY8YnI+PC9kaXY+PGRpdj4rJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IChiYXNlMzI8YnI+PC9kaXY+PGRpdj4rJm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7ICIxaWY2MTBo cTVqOHJiamgxY2F3NWJ3Ymduc24yMzFhd3d4cWJwd3ZyaDk2NmtkeHpsNHFmIikpKSk8YnI+PC9k aXY+PGRpdj4rJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IChidWlsZC1zeXN0ZW0gZW1h Y3MtYnVpbGQtc3lzdGVtKTxicj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm bmJzcDsgKHByb3BhZ2F0ZWQtaW5wdXRzPGJyPjwvZGl2PjxkaXY+KyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyBgKCgiZW1hY3MtcmVxdWVzdCIgLGVtYWNzLXJlcXVlc3QpPGJy PjwvZGl2PjxkaXY+KyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyAoImVtYWNzLWRhc2giICxlbWFjcy1kYXNoKSkpPGJyPjwvZGl2PjxkaXY+KyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAoaG9tZS1wYWdlPGJyPjwvZGl2PjxkaXY+KyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAiPGEgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29t L2xvdWlldGFuL2Fua2ktZWRpdG9yIj5odHRwczovL2dpdGh1Yi5jb20vbG91aWV0YW4vYW5raS1l ZGl0b3I8L2E+Iik8YnI+PC9kaXY+PGRpdj4rJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 IChzeW5vcHNpczxicj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm bmJzcDsgIk1pbm9yIG1vZGUgZm9yIG1ha2luZyBBbmtpIGNhcmRzIHdpdGggb3JnLW1vZGUiKTxi cj48L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKGRlc2NyaXB0aW9u PGJyPjwvZGl2PjxkaXY+KyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAiVGhp cyBwYWNrYWdlIGlzIGZvciBwZW9wbGUgd2hvIHVzZSBBbmtpIGFzIFNSUyBidXQgd291bGQgbGlr ZSB0bzxicj48L2Rpdj48ZGl2PittYWtlIGNhcmRzIGluIEBjb2Rle29yZy1tb2RlfS4iKTxicj48 L2Rpdj48ZGl2PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKGxpY2Vuc2UgbGljZW5z ZTpncGwzKykpKSk8YnI+PC9kaXY+PGRpdj4tLTxicj48L2Rpdj48ZGl2PjIuMzAuMDxicj48L2Rp dj4= --b1_w0p3M66m4wClj7quqdmjXYPkRg5Rb5EN0rOaJdMXJE-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 13:53:19 2021 Received: (at submit) by debbugs.gnu.org; 10 Jan 2021 18:53:19 +0000 Received: from localhost ([127.0.0.1]:54945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyfq3-0001B9-9F for submit@debbugs.gnu.org; Sun, 10 Jan 2021 13:53:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:41774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyfq2-0001Aw-63 for submit@debbugs.gnu.org; Sun, 10 Jan 2021 13:53:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyfq1-00079w-T8 for guix-patches@gnu.org; Sun, 10 Jan 2021 13:53:17 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyfpz-0007H9-Ao for guix-patches@gnu.org; Sun, 10 Jan 2021 13:53:17 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A227420006; Sun, 10 Jan 2021 18:53:08 +0000 (UTC) From: Nicolas Goaziou To: Noah Evans via Guix-patches via Subject: Re: [bug#45754] [PATCH] gnu: Add emacs-anki-editor References: Date: Sun, 10 Jan 2021 19:53:07 +0100 In-Reply-To: (Noah Evans via Guix-patches via's message of "Sun, 10 Jan 2021 06:07:42 +0000") Message-ID: <875z44oc8c.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.200; envelope-from=mail@nicolasgoaziou.fr; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: 45754@debbugs.gnu.org, Noah Evans X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hello, Noah Evans via Guix-patches via writes: > +(define-public emacs-anki-editor Thank you. Some comments follow. You did not provide a commit message. Could you provide one? For example, gnu: Add emacs-anki-editor * gnu/packages/emacs-xyz.scm (emacs-anki-editor): New variable. is enough. Also, your indentation is off. Could you use, e.g., M-q in Emacs to fix it? > + (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df") > + (revision "0") > + (version "0.3.3")) Could you explain why you chose the latest commit instead "0.3.3" release? It might be because that release is more than two years old. > + (package > + (name "emacs-anki-editor") > + (version (git-version version revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/louietan/anki-editor") > + (commit commit))) There's a (file-name (git-file-name name version)) missing here. > + (sha256 > + (base32 > + "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf")))) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-request" ,emacs-request) > + ("emacs-dash" ,emacs-dash))) Could you order inputs alphabetically? > + (synopsis > + "Minor mode for making Anki cards with org-mode") Could you replace org-mode with Org mode? > + (description > + "This package is for people who use Anki as SRS but would like to > +make cards in @code{org-mode}.") Could you explain in the description what is a "SRS"? Also, @code{org-mode} should become Org mode. You can also update your copyright line at the beginning of the file. As the last point, could you move the package elsewhere than at the end of the file. There, it is likely to introduce a merge conflict, e.g., if someone also submits a package there while yours is being reviewed. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 15:33:59 2021 Received: (at 45754) by debbugs.gnu.org; 10 Jan 2021 20:33:59 +0000 Received: from localhost ([127.0.0.1]:55020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyhPT-0007Ap-By for submit@debbugs.gnu.org; Sun, 10 Jan 2021 15:33:59 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:15721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyhPR-0007AB-GW for 45754@debbugs.gnu.org; Sun, 10 Jan 2021 15:33:58 -0500 Date: Sun, 10 Jan 2021 20:33:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1610310830; bh=sRo1WbU9wJPFflyAC+JfYdAXbhRpx2I1ho7KnuUQuuo=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:From; b=J3Y81hBI18/OROg0t27T6xjjUszTcj3dr0mrC9aHPzUpoMScVPpOZcsH4yfl0sucW bfbQH++ykx8lKfzBaxu40nm9cwL322PlsJoLE0PuPSeU4qutQzhPo9zgy8xhCceS+d myC54eJQd10+4I9UScoWqwLn8bhYtHzrC4udVzuU= To: "45754@debbugs.gnu.org" <45754@debbugs.gnu.org> From: Noah Evans Subject: Re: [bug#45754] [PATCH] gnu: Add emacs-anki-editor Message-ID: In-Reply-To: <875z44oc8c.fsf@nicolasgoaziou.fr> References: <875z44oc8c.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thank you for the feedback, here is an updated patch. From 197ef9f0ebd4473cd9590bcbfd7d77781191c308 Mon Sep 17 00:00:00 2001 From: Noah Evans Date: Sun, 10 Jan 2021 15:25:02 -0500 Subject: [PATCH] gnu: Add emacs-anki-editor Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [185.70.40.131 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (clonex100[at]protonmail.com) 0.2 FREEMAIL_REPLYTO_END_DIGIT Reply-To freemail username ends in digit (clonex100[at]protonmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (clonex100[at]protonmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: nixo.xyz (xyz)] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 45754 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Noah Evans Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thank you for the feedback, here is an updated patch. From 197ef9f0ebd4473cd9590bcbfd7d77781191c308 Mon Sep 17 00:00:00 2001 From: Noah Evans Date: Sun, 10 Jan 2021 15:25:02 -0500 Subject: [PATCH] gnu: Add emacs-anki-editor Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [185.70.40.131 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (clonex100[at]protonmail.com) 0.2 FREEMAIL_REPLYTO_END_DIGIT Reply-To freemail username ends in digit (clonex100[at]protonmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (clonex100[at]protonmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: nixo.xyz (xyz)] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Thank you for the feedback, here is an updated patch. >From 197ef9f0ebd4473cd9590bcbfd7d77781191c308 Mon Sep 17 00:00:00 2001 From: Noah Evans Date: Sun, 10 Jan 2021 15:25:02 -0500 Subject: [PATCH] gnu: Add emacs-anki-editor * gnu/packages/emacs-xyz.scm (emacs-anki-editor): New variable. --- gnu/packages/emacs-xyz.scm | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 76cbe7e075..2a94939a3e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -88,7 +88,7 @@ ;;; Copyright =C2=A9 2020 Nicol=C3=B2 Balzarotti ;;; Copyright =C2=A9 2020 Andr=C3=A9 A. Gomes ;;; Copyright =C2=A9 2020 Jonathan Rostran -;;; Copyright =C2=A9 2020 Noah Evans +;;; Copyright =C2=A9 2020, 2021 Noah Evans ;;; ;;; This file is part of GNU Guix. ;;; @@ -6344,6 +6344,37 @@ drill sessions to aid in memorization. In these ses= sions you are shown flash cards created in Org mode.") (license license:gpl3+))) +(define-public emacs-anki-editor + ;; Last release was in 2018 + (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df") + (revision "0") + (version "0.3.3")) + (package + (name "emacs-anki-editor") + (version (git-version version revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/louietan/anki-editor") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-request" ,emacs-request))) + (home-page + "https://github.com/louietan/anki-editor") + (synopsis + "Minor mode for making Anki cards with Org mode") + (description + "This package is for people who use Anki as a spaced repetition sys= tem +(SRS) but would like to make cards in Org mode.") + (license license:gpl3+)))) + (define-public emacs-org-superstar (package (name "emacs-org-superstar") -- 2.30.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 12 03:41:42 2021 Received: (at submit) by debbugs.gnu.org; 12 Jan 2021 08:41:42 +0000 Received: from localhost ([127.0.0.1]:59171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzFF3-0003VV-Eg for submit@debbugs.gnu.org; Tue, 12 Jan 2021 03:41:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:45056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzFF0-0003VG-LD for submit@debbugs.gnu.org; Tue, 12 Jan 2021 03:41:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzFEz-00063F-Qk for guix-patches@gnu.org; Tue, 12 Jan 2021 03:41:26 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzFEx-0003O1-L7 for guix-patches@gnu.org; Tue, 12 Jan 2021 03:41:25 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B40A8E000B; Tue, 12 Jan 2021 08:41:17 +0000 (UTC) From: Nicolas Goaziou To: Noah Evans via Guix-patches via Subject: Re: [bug#45754] [PATCH] gnu: Add emacs-anki-editor References: <875z44oc8c.fsf@nicolasgoaziou.fr> Date: Tue, 12 Jan 2021 09:41:16 +0100 In-Reply-To: (Noah Evans via Guix-patches via's message of "Sun, 10 Jan 2021 20:33:49 +0000") Message-ID: <87a6temtsj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 45754-done@debbugs.gnu.org, Noah Evans X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Noah Evans via Guix-patches via writes: > Thank you for the feedback, here is an updated patch. I applied your patch with the following changes. > + (base32 > + "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf")))) I moved the string on the line above. > + (home-page > + "https://github.com/louietan/anki-editor") > + (synopsis > + "Minor mode for making Anki cards with Org mode") Same in the two cases above. Thank you! Regards, -- Nicolas Goaziou From unknown Fri Jun 20 07:24:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Feb 2021 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator