From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 08 20:03:46 2021 Received: (at submit) by debbugs.gnu.org; 9 Jan 2021 01:03:47 +0000 Received: from localhost ([127.0.0.1]:51000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky2fS-0001YV-9F for submit@debbugs.gnu.org; Fri, 08 Jan 2021 20:03:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:60686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxwzj-0001Rz-Ht for submit@debbugs.gnu.org; Fri, 08 Jan 2021 14:00:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxwzj-0005LE-7G for bug-gnu-emacs@gnu.org; Fri, 08 Jan 2021 14:00:19 -0500 Received: from mail.omarpolo.com ([144.91.116.244]:61918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxwzf-0003l2-Bc for bug-gnu-emacs@gnu.org; Fri, 08 Jan 2021 14:00:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1610132397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=11ieU8rI5fl8ptijfK1Ops0cbDvoi5fSHD0Pz5yxzg4=; b=M2+FoCoieK3J0Ok3WbGMh/Z2nlr5rlXryT1rDjCC25OjW1By+VY9pTmH0HIBNkGCrQIJ8K Lg9ikALr4oteOxnAo9O27E6e0uAhZApjzj6Q6au17MTrFmn3JIexLryuq6EzcTJzcqw7aN ids2GlGkxGBRegRHcL7zgm9fjpPlfgo= Received: from localhost (host-80-116-112-105.retail.telecomitalia.it [80.116.112.105]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 2218c049 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 8 Jan 2021 19:59:57 +0100 (CET) Received: from venera (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 0e3d58dd for ; Fri, 8 Jan 2021 19:59:56 +0100 (CET) From: Omar Polo To: bug-gnu-emacs@gnu.org Subject: [PATCH] system_process_attributes for OpenBSD Date: Fri, 08 Jan 2021 19:59:56 +0100 Message-ID: <87sg7bgspf.fsf@omarpolo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 08 Jan 2021 20:03:45 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch Hello, The attached patch implements system_process_attributes for OpenBSD. With this I am able to use proced \o/ There are five stats that I don't know how to collect (cminflt, cmajflt, cstime, ctime and thcount). Everything else seem consistent with top(1). I avoided to dynamically allocate the args string and instead reused the existing storage; this is similar to the freebsd code, but if it seems ugly I can replace that with a calloc+strlcat like in the previous patch sent to emacs-devel@. Note: I don't know how sysctl behaves on other systems, but at least on OpenBSD it's not possible to get the argv for every process. In my environment only for a couple of process the KERN_PROC_ARGV sysctl fails. So, it's possible to see some entries with `?' as `args' in proced, but you can verify that it's "expected" by running "ps $PID" and see that you get "(executable-name)" under the COMMAND column. (top(1) seems to just hide them) Should the patch include an entry in etc/NEWS? Thanks, Omar Polo In GNU Emacs 28.0.50 (build 4, x86_64-unknown-openbsd6.8, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2021-01-05 built on venera Repository revision: ce0c9c349363b5dbea56f7e32c838a93c729263d Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: OpenBSD venera 6.8 GENERIC.MP#223 amd64 Configured using: 'configure --prefix=/home/op/opt/emacs --with-x-toolkit=lucid' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=system_process_attribute-2.diff diff 5ef30fbf11c3ee0ff1c30061dab554b9bd3ce841 /home/op/build/emacs blob - 29c88f5308e47611e425f89a916eca578c86e09f file + src/sysdep.c --- src/sysdep.c +++ src/sysdep.c @@ -53,6 +53,10 @@ along with GNU Emacs. If not, see #endif +#if defined __OpenBSD__ +# include +#endif + #ifdef DARWIN_OS # include #endif @@ -2984,6 +2988,14 @@ make_lisp_timeval (struct timeval t) return make_lisp_time (timeval_to_timespec (t)); } +#elif defined __OpenBSD__ + +static Lisp_Object +make_lisp_timeval (long sec, long usec) +{ + return make_lisp_time(make_timespec(sec, usec * 1000)); +} + #endif #ifdef GNU_LINUX @@ -3673,6 +3685,189 @@ system_process_attributes (Lisp_Object pid) return attrs; } +#elif defined __OpenBSD__ + +Lisp_Object +system_process_attributes (Lisp_Object pid) +{ + int proc_id, nentries, fscale, i; + int pagesize = getpagesize (); + int mib[6]; + size_t len; + double pct; + char *ttyname, args[ARG_MAX]; + struct kinfo_proc proc; + struct passwd *pw; + struct group *gr; + struct timespec t; + struct uvmexp uvmexp; + + Lisp_Object attrs = Qnil; + Lisp_Object decoded_comm; + + CHECK_NUMBER (pid); + CONS_TO_INTEGER (pid, int, proc_id); + + len = sizeof proc; + mib[0] = CTL_KERN; + mib[1] = KERN_PROC; + mib[2] = KERN_PROC_PID; + mib[3] = proc_id; + mib[4] = len; + mib[5] = 1; + if (sysctl (mib, 6, &proc, &len, NULL, 0) != 0) + return attrs; + + attrs = Fcons (Fcons (Qeuid, INT_TO_INTEGER (proc.p_uid)), attrs); + + block_input (); + pw = getpwuid (proc.p_uid); + unblock_input (); + if (pw) + attrs = Fcons (Fcons (Quser, build_string(pw->pw_name)), attrs); + + attrs = Fcons (Fcons (Qegid, INT_TO_INTEGER(proc.p_svgid)), attrs); + + block_input (); + gr = getgrgid (proc.p_svgid); + unblock_input (); + if (gr) + attrs = Fcons (Fcons (Qgroup, build_string (gr->gr_name)), attrs); + + AUTO_STRING (comm, proc.p_comm); + decoded_comm = code_convert_string_norecord (comm, Vlocale_coding_system, 0); + attrs = Fcons (Fcons (Qcomm, decoded_comm), attrs); + + { + char state[2] = {'\0', '\0'}; + switch (proc.p_stat) { + case SIDL: + state[0] = 'I'; + break; + case SRUN: + state[0] = 'R'; + break; + case SSLEEP: + state[0] = 'S'; + break; + case SSTOP: + state[0] = 'T'; + break; + case SZOMB: + state[0] = 'Z'; + break; + case SDEAD: + state[0] = 'D'; + break; + } + attrs = Fcons (Fcons (Qstate, build_string (state)), attrs); + } + + attrs = Fcons (Fcons (Qppid, INT_TO_INTEGER (proc.p_ppid)), attrs); + attrs = Fcons (Fcons (Qpgrp, INT_TO_INTEGER (proc.p_gid)), attrs); + attrs = Fcons (Fcons (Qsess, INT_TO_INTEGER (proc.p_sid)), attrs); + + block_input (); + ttyname = proc.p_tdev == NODEV ? NULL : devname (proc.p_tdev, S_IFCHR); + unblock_input (); + if (ttyname) + attrs = Fcons (Fcons (Qttname, build_string (ttyname)), attrs); + + attrs = Fcons (Fcons (Qtpgid, INT_TO_INTEGER (proc.p_tpgid)), attrs); + attrs = Fcons (Fcons (Qminflt, INT_TO_INTEGER (proc.p_uru_minflt)), + attrs); + attrs = Fcons (Fcons (Qmajflt, INT_TO_INTEGER (proc.p_uru_majflt)), + attrs); + + /* FIXME: missing cminflt, cmajflt. */ + + attrs = Fcons (Fcons (Qutime, make_lisp_timeval (proc.p_uutime_sec, + proc.p_uutime_usec)), + attrs); + attrs = Fcons (Fcons (Qstime, make_lisp_timeval (proc.p_ustime_sec, + proc.p_ustime_usec)), + attrs); + t = timespec_add (make_timespec (proc.p_uutime_sec, + proc.p_uutime_usec * 1000), + make_timespec (proc.p_ustime_sec, + proc.p_ustime_usec * 1000)); + attrs = Fcons (Fcons (Qtime, make_lisp_time (t)), attrs); + + attrs = Fcons (Fcons (Qcutime, make_lisp_timeval (proc.p_uctime_sec, + proc.p_uctime_usec)), + attrs); + + /* FIXME: missing cstime and thus ctime. */ + + attrs = Fcons (Fcons (Qpri, make_fixnum (proc.p_priority)), attrs); + attrs = Fcons (Fcons (Qnice, make_fixnum (proc.p_nice)), attrs); + + /* FIXME: missing thcount (thread count) */ + + attrs = Fcons (Fcons (Qstart, make_lisp_timeval (proc.p_ustart_sec, + proc.p_ustart_usec)), + attrs); + + len = (proc.p_vm_tsize + proc.p_vm_dsize + proc.p_vm_ssize) * pagesize >> 10; + attrs = Fcons (Fcons (Qvsize, make_fixnum (len)), attrs); + + attrs = Fcons (Fcons (Qrss, make_fixnum (proc.p_vm_rssize * pagesize >> 10)), + attrs); + + t = make_timespec (proc.p_ustart_sec, + proc.p_ustart_usec * 1000); + t = timespec_sub (current_timespec (), t); + attrs = Fcons (Fcons (Qetime, make_lisp_time (t)), attrs); + + len = sizeof (fscale); + mib[0] = CTL_KERN; + mib[1] = KERN_FSCALE; + if (sysctl (mib, 2, &fscale, &len, NULL, 0) != -1) + { + pct = (double)proc.p_pctcpu / fscale * 100.0; + attrs = Fcons (Fcons (Qpcpu, make_float (pct)), attrs); + } + + len = sizeof (uvmexp); + mib[0] = CTL_VM; + mib[1] = VM_UVMEXP; + if (sysctl (mib, 2, &uvmexp, &len, NULL, 0) != -1) + { + pct = (100.0 * (double)proc.p_vm_rssize / uvmexp.npages); + attrs = Fcons (Fcons (Qpmem, make_float (pct)), attrs); + } + + len = sizeof args; + mib[0] = CTL_KERN; + mib[1] = KERN_PROC_ARGS; + mib[2] = proc_id; + mib[3] = KERN_PROC_ARGV; + if (sysctl (mib, 4, &args, &len, NULL, 0) == 0 && len != 0) + { + char **argv = (char**)args; + + /* concatenate argv reusing the existing storage storage. + sysctl(8) guarantees that "the buffer pointed to by oldp is + filled with an array of char pointers followed by the strings + themselves." */ + for (i = 0; argv[i] != NULL; ++i) + { + if (argv[i+1] != NULL) + { + len = strlen (argv[i]); + argv[i][len] = ' '; + } + } + + AUTO_STRING (comm, *argv); + decoded_comm = code_convert_string_norecord (comm, + Vlocale_coding_system, 0); + attrs = Fcons (Fcons (Qargs, decoded_comm), attrs); + } + + return attrs; +} + #elif defined DARWIN_OS Lisp_Object --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 08:29:10 2021 Received: (at 45729) by debbugs.gnu.org; 10 Jan 2021 13:29:10 +0000 Received: from localhost ([127.0.0.1]:53452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyamM-0000mF-8g for submit@debbugs.gnu.org; Sun, 10 Jan 2021 08:29:10 -0500 Received: from quimby.gnus.org ([95.216.78.240]:40866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyamK-0000lw-JQ for 45729@debbugs.gnu.org; Sun, 10 Jan 2021 08:29:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=paL3Zxis3Mn1wYn8b0OXuYU9cR5BrGWjc8qhNmomX/E=; b=CiP9UdoR8AKYkjp3Fl85zDQ8D3 TsFCXWFq5qjPuEWGFw4RrKaN1GFtb3UPf6Jv8bb60EqFN6vPco/QiovOWyxX/1p9cwq9QdvW+RWKp Z1rkfsxJeC0SI3QIIWxttvmLcQP8mLSbkUgATQZtLSwN5VwDciNBviX7t+TOIJ9szS5I=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyam9-0007DR-GH; Sun, 10 Jan 2021 14:29:02 +0100 From: Lars Ingebrigtsen To: Omar Polo Subject: Re: bug#45729: [PATCH] system_process_attributes for OpenBSD References: <87sg7bgspf.fsf@omarpolo.com> X-Now-Playing: Michelle Shocked's _Short Sharp Shocked_: "The L&N Don't Stop Here Anymore" Date: Sun, 10 Jan 2021 14:28:56 +0100 In-Reply-To: <87sg7bgspf.fsf@omarpolo.com> (Omar Polo's message of "Fri, 08 Jan 2021 19:59:56 +0100") Message-ID: <87zh1gudif.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Omar Polo writes: > The attached patch implements system_process_attributes for OpenBSD. > With this I am able to use proced \o/ Looks good to me, and I've tested it slightly on OpenBSD, and it seems to work fine, so I've now pushed it to Emacs 28. (I see that your copyright is on file... er... OK, your entry has a timestamp of [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45729 Cc: 45729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Omar Polo writes: > The attached patch implements system_process_attributes for OpenBSD. > With this I am able to use proced \o/ Looks good to me, and I've tested it slightly on OpenBSD, and it seems to work fine, so I've now pushed it to Emacs 28. (I see that your copyright is on file... er... OK, your entry has a timestamp of "2021-07-07", so that makes it even better -- it's from the future!) (Oh, one minor note for future patches -- using "git format-patch" (or something similar) to format it is usually a good idea, because then it'll apply automatically. I had to do a "patch -p0" here.) > Should the patch include an entry in etc/NEWS? I've added one. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 08:29:15 2021 Received: (at control) by debbugs.gnu.org; 10 Jan 2021 13:29:15 +0000 Received: from localhost ([127.0.0.1]:53455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyamR-0000md-GD for submit@debbugs.gnu.org; Sun, 10 Jan 2021 08:29:15 -0500 Received: from quimby.gnus.org ([95.216.78.240]:40880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyamP-0000m7-Vh for control@debbugs.gnu.org; Sun, 10 Jan 2021 08:29:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G9UiniLsVCrPutdyVOIFOyy0rvWuksSEAqvtlm6NFO4=; b=GmN7i/MYNaUuezB7zI89wtGckW bpgvBtY29Xm5aNsGaf1ffA4jsMC856BiAuc0lOaTK+aaBoo2v628RNVCsxaXlnCS8iyr8IM9+s/61 xB9q7+HFUBuwD3P6dTy1jfJXiLI8HqwfgvNNM70CK1jcXtIQp+Q3kjd6QmSvfElc9T/E=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyamI-0007Da-DB for control@debbugs.gnu.org; Sun, 10 Jan 2021 14:29:08 +0100 Date: Sun, 10 Jan 2021 14:29:05 +0100 Message-Id: <87y2h0udi6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45729 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45729 fixed close 45729 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45729 fixed close 45729 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 09:15:42 2021 Received: (at 45729) by debbugs.gnu.org; 10 Jan 2021 14:15:43 +0000 Received: from localhost ([127.0.0.1]:53526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybVO-0007Ru-Fq for submit@debbugs.gnu.org; Sun, 10 Jan 2021 09:15:42 -0500 Received: from mail.omarpolo.com ([144.91.116.244]:59984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybVM-0007KS-7J for 45729@debbugs.gnu.org; Sun, 10 Jan 2021 09:15:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1610288117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3/cE4laBqF+ooyttcFsSy32bP0+VhGJDIru2YMYx5sg=; b=kbpJ+o9fMex43HwM8+fjwtTjQeBE/BEPBmErWISR2bH3XNXdT/VRafn6lxmU42Dzf7LqXq Dv/ZTcPiIT/VUHxVo54dVqAJPLBxxEoGv6JQTUQlkaRN9bl3gGImiAgSAY6VYf3L9Rarok saTUVXD6RifN/e84W5b6/hVc4IaquyM= Received: from localhost (host-80-116-112-105.retail.telecomitalia.it [80.116.112.105]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id c68ead28 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 10 Jan 2021 15:15:17 +0100 (CET) Received: from venera (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d8e5138e; Sun, 10 Jan 2021 15:15:11 +0100 (CET) References: <87sg7bgspf.fsf@omarpolo.com> <87zh1gudif.fsf@gnus.org> User-agent: mu4e 1.4.13; emacs 28.0.50 From: Omar Polo To: Lars Ingebrigtsen Subject: Re: bug#45729: [PATCH] system_process_attributes for OpenBSD In-reply-to: <87zh1gudif.fsf@gnus.org> Date: Sun, 10 Jan 2021 15:15:11 +0100 Message-ID: <878s906fps.fsf@omarpolo.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45729 Cc: 45729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Omar Polo writes: > >> The attached patch implements system_process_attributes for OpenBSD. >> With this I am able to use proced \o/ > > Looks good to me, and I've tested it slightly on OpenBSD, and it seems > to work fine, so I've now pushed it to Emacs 28. (I see that your > copyright is on file... er... OK, your entry has a timestamp of > "2021-07-07", so that makes it even better -- it's from the future!) Sorry, I don't understand this. Do you mean the date in my copyright assignment? On the pdf I have, both my sign and the fsf one are dated 2021-01-07. I'm missing something? > (Oh, one minor note for future patches -- using "git format-patch" (or > something similar) to format it is usually a good idea, because then > it'll apply automatically. I had to do a "patch -p0" here.) Sorry, I was playing with another vcs and I forgot to re-test the patch before sending. I'll pay more attention in the future. >> Should the patch include an entry in etc/NEWS? > > I've added one. Thanks! Omar Polo From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 09:37:27 2021 Received: (at 45729) by debbugs.gnu.org; 10 Jan 2021 14:37:27 +0000 Received: from localhost ([127.0.0.1]:53558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybqQ-0003CX-V8 for submit@debbugs.gnu.org; Sun, 10 Jan 2021 09:37:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybqP-0003CF-5H for 45729@debbugs.gnu.org; Sun, 10 Jan 2021 09:37:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xHQyJmcA0sJTqAgEOvNHMf0wyEWDunTw8ENQg+UQAF8=; b=phedcMnjFGcht+NVCi8ma4jGMN 4WAi89bmrPfwPwcrfKvpM3L7UVMcJSi8NIEa1xOdlVPciovTJQD9mJX8XXKjCS31zJY8XkusxCQt7 kRgpOjT1GHEM+3vSmxqkOUFl7nlBqPVb9RpLYiK7nv0fGGmeDGIWfs5d9uvSANpZu8ak=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kybqH-0007ld-6T; Sun, 10 Jan 2021 15:37:19 +0100 From: Lars Ingebrigtsen To: Omar Polo Subject: Re: bug#45729: [PATCH] system_process_attributes for OpenBSD References: <87sg7bgspf.fsf@omarpolo.com> <87zh1gudif.fsf@gnus.org> <878s906fps.fsf@omarpolo.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEVIQ0JCPDw8NjlH Rj5SUEen6Vt5mk2v8WFFPUKAp0xjZ1T///+DEEqfAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+UBCg4H Iz84I/oAAAGuSURBVDjLbZO9TsMwEMd9KEPEZLsMWW3xAhVlL6oDUickFCKxUaEO7FHXhilPwANU 7ZKn5M4fsePyl/J1P/9tn+/CGGPAcgkh6AEcBPcRLrwsdS8cIESlEiGO4lNcSEFgsVz470Ck1ghk 3TS76NNKaLw70O7S8cpinMqDZAkH+uBAIiOJjmRHeOPXQGtaJAWcNoMGzE5RHpAAa5DKnkRcnPV+ X9oBO5VOJT147Jr3333UNzIlEdy3zSFVdyIbAll3jVXrHs0HOgiQhaItDbfk5BxkoZCbp3MWXFwL dd9kOglXQbl6QK2M2Rh8Xmx9ktL64vnCedBjnSqP6rmDh8YJgF1NNgGgg6VuwxrgKIgA8JuP43Yk OQcEB7s7m9s1M8YIeUmmsl2L1xrHhDXAxRgrxvN2fILqJnH4Vme0BwEBQPw96I1b4BYHnvwzfHJk qiIo+2ogMTawYah+EHwiKFlhZtpcsGvA9dVcbdctBXVJfcjUvinMoIccoAFc7+aOV451w2xfckcJ tg7l836uryMeAeVcDk6YxHCka0oWE0lyWc9PYmJFBor/HMYkjgD+ADmYzPamzRSfAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIxLTAxLTEwVDE0OjA3OjM0KzAwOjAwjlr6QAAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMS0wMS0xMFQxNDowNzozNCswMDowMP8HQvwAAAAASUVORK5CYII= X-Now-Playing: Joy Division's _Substance_: "Glass" Date: Sun, 10 Jan 2021 15:37:15 +0100 In-Reply-To: <878s906fps.fsf@omarpolo.com> (Omar Polo's message of "Sun, 10 Jan 2021 15:15:11 +0100") Message-ID: <87h7nosvs4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Omar Polo writes: >> Looks good to me, and I've tested it slightly on OpenBSD, and it seems >> to work fine, so I've now pushed it to Emacs 28. (I see that your >> copyright is on file... er... OK, your entry has a tim [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45729 Cc: 45729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Omar Polo writes: >> Looks good to me, and I've tested it slightly on OpenBSD, and it seems >> to work fine, so I've now pushed it to Emacs 28. (I see that your >> copyright is on file... er... OK, your entry has a timestamp of >> "2021-07-07", so that makes it even better -- it's from the future!) > > Sorry, I don't understand this. Do you mean the date in my copyright > assignment? On the pdf I have, both my sign and the fsf one are dated > 2021-01-07. I'm missing something? Sorry, just being silly. It looks like all the entries in the database on the FSF side from that date is marked as 2021-07-07 instead of 2021-01-07 (just a typo from somebody). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 10 09:43:10 2021 Received: (at 45729) by debbugs.gnu.org; 10 Jan 2021 14:43:10 +0000 Received: from localhost ([127.0.0.1]:53562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybvy-0003O8-KD for submit@debbugs.gnu.org; Sun, 10 Jan 2021 09:43:10 -0500 Received: from mail.omarpolo.com ([144.91.116.244]:53239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kybvv-0003NY-Kg for 45729@debbugs.gnu.org; Sun, 10 Jan 2021 09:43:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1610289780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=noVo4svXRRp/sHjhmRuvvsBtumo94ucwhZhsdDQoPI8=; b=Uhpc8caY90kE8hd+A9kA6/e9d4TtZrux4d+ya+gvMzbs6fn4+5pfdOulPb0ZUfEi8K8EP8 sk7QeiU7UunwmDTiOHUtVTyIrM+eHAyxHJj7alWi0q1EKMZVOp/flvrJVtmrtbCcuP4/Iz j5TghHI8mHDs32yeukcdWoxD8K3sWjk= Received: from localhost (host-80-116-112-105.retail.telecomitalia.it [80.116.112.105]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id a13ac886 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 10 Jan 2021 15:43:00 +0100 (CET) Received: from venera (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d4afe490; Sun, 10 Jan 2021 15:42:59 +0100 (CET) References: <87sg7bgspf.fsf@omarpolo.com> <87zh1gudif.fsf@gnus.org> <878s906fps.fsf@omarpolo.com> <87h7nosvs4.fsf@gnus.org> User-agent: mu4e 1.4.13; emacs 28.0.50 From: Omar Polo To: Lars Ingebrigtsen Subject: Re: bug#45729: [PATCH] system_process_attributes for OpenBSD In-reply-to: <87h7nosvs4.fsf@gnus.org> Date: Sun, 10 Jan 2021 15:42:59 +0100 Message-ID: <875z446efg.fsf@omarpolo.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45729 Cc: 45729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Omar Polo writes: > >>> Looks good to me, and I've tested it slightly on OpenBSD, and it seems >>> to work fine, so I've now pushed it to Emacs 28. (I see that your >>> copyright is on file... er... OK, your entry has a timestamp of >>> "2021-07-07", so that makes it even better -- it's from the future!) >> >> Sorry, I don't understand this. Do you mean the date in my copyright >> assignment? On the pdf I have, both my sign and the fsf one are dated >> 2021-01-07. I'm missing something? > > Sorry, just being silly. It looks like all the entries in the database > on the FSF side from that date is marked as 2021-07-07 instead of > 2021-01-07 (just a typo from somebody). I was worried I've done something wrong, sorry. (overly so) Thanks again, Omar Polo From unknown Sat Jun 21 10:44:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Feb 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator