GNU bug report logs - #45692
[PATCH 0/4] Even Better ZFS Support on Guix

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raid5atemyhomework <raid5atemyhomework <at> protonmail.com>
Cc: "45692 <at> debbugs.gnu.org" <45692 <at> debbugs.gnu.org>
Subject: [bug#45692] [PATCH v3 2/3] gnu: Add zfs-auto-snapshot.
Date: Tue, 11 May 2021 16:05:42 +0200

Hi,

> +                (invoke "make" "install"
> +                        "PREFIX="
> +                        (string-append "DESTDIR=" out)))

Are you sure about that?

Usually, DESTDIR is in order to supply a temporary build root (which will not
be referred-to by the installed programs--because that directory will be
deleted after the build) and PREFIX is in order to supply an actual
installation directory (installed programs can refer to that whenever they
want).

Is it different for this program?

Also, I'd suggest to use #:make-flags so other phases can also see the PREFIX
chosen.  Otherwise, those could erroneously default to another prefix (for
loading of config files at runtime etc).

What do you think?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.