From unknown Sun Sep 07 12:44:40 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4568: version test in .elc files is too complicated Reply-To: Dan Nicolaescu , 4568@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 28 Sep 2009 02:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4568 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125410391623226 (code B ref -1); Mon, 28 Sep 2009 02:20:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 28 Sep 2009 02:11:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8S2BtW9023223 for ; Sun, 27 Sep 2009 19:11:56 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ms5iU-0004Bi-OW for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2009 22:11:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ms5iP-0004BG-QH for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2009 22:11:53 -0400 Received: from [199.232.76.173] (port=56774 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ms5iP-0004BD-KH for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2009 22:11:49 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:57488) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1Ms5iP-0008B9-62 for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2009 22:11:49 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8S2ABjK001086 for ; Sun, 27 Sep 2009 19:10:11 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8S2ABQb015443; Sun, 27 Sep 2009 19:10:11 -0700 (PDT) Date: Sun, 27 Sep 2009 19:10:11 -0700 (PDT) Message-Id: <200909280210.n8S2ABQb015443@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Lines: 16 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8S2ABjK001086 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) The version test in all the .elc files is too complicated: (if (and (boundp 'emacs-version) (< (aref emacs-version (1- (length emacs-version))) ?A) (or (and (boundp 'epoch::version) epoch::version) (string-lessp emacs-version "19.29"))) (error "`vc-hooks.el' was compiled for Emacs 19.29 or later")) if anyone still runs epoch (very doubtful), there are many other things that will fail when trying to run emacs-23 byte compiled code. This was discussed on emacs-devel some time ago (can't find the link at the moment), but nothing happened. IMVHO a single condition based on emacs-major-version should be enough. From unknown Sun Sep 07 12:44:40 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4568: version test in .elc files is too complicated Reply-To: Stefan Monnier , 4568@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 28 Sep 2009 05:50:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4568 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125411673721477 (code B ref -1); Mon, 28 Sep 2009 05:50:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 28 Sep 2009 05:45:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8S5jZUl021473 for ; Sun, 27 Sep 2009 22:45:36 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ms93H-0004vD-1a for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2009 01:45:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ms93B-0004uI-S3 for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2009 01:45:33 -0400 Received: from [199.232.76.173] (port=45212 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ms93B-0004uF-JN for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2009 01:45:29 -0400 Received: from mx20.gnu.org ([199.232.41.8]:61527) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ms93B-0002ge-8M for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2009 01:45:29 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ms93A-0000Tl-6S for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2009 01:45:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvIEADvqv0pFxIo//2dsb2JhbACBUNEdhB4Fh32CZw X-IronPort-AV: E=Sophos;i="4.44,464,1249272000"; d="scan'208";a="46686644" Received: from 69-196-138-63.dsl.teksavvy.com (HELO ceviche.home) ([69.196.138.63]) by ironport2-out.pppoe.ca with ESMTP; 28 Sep 2009 01:45:26 -0400 Received: by ceviche.home (Postfix, from userid 20848) id A5617B4228; Mon, 28 Sep 2009 01:45:25 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4568@debbugs.gnu.org, bug-gnu-emacs Message-ID: References: <200909280210.n8S2ABQb015443@godzilla.ics.uci.edu> Date: Mon, 28 Sep 2009 01:45:25 -0400 In-Reply-To: <200909280210.n8S2ABQb015443@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 27 Sep 2009 19:10:11 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) > The version test in all the .elc files is too complicated: Please just remove it. Stefan From rgm@gnu.org Mon Sep 28 18:15:30 2009 Received: (at control) by emacsbugs.donarmstrong.com; 29 Sep 2009 01:15:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8T1FSnq011937 for ; Mon, 28 Sep 2009 18:15:29 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MsRJO-0004kk-WE; Mon, 28 Sep 2009 21:15:27 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19137.24494.912438.999717@fencepost.gnu.org> Date: Mon, 28 Sep 2009 21:15:26 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes severity 4571 minor severity 4568 minor reassign 4529 emacs,ns severity 4268 wishlist severity 4019 wishlist reassign 4019 emacs,cc-mode close 4464 reassign 4528 emacs,ns From dann@godzilla.ics.uci.edu Fri Dec 4 16:24:42 2009 Received: (at control) by emacsbugs.donarmstrong.com; 5 Dec 2009 00:24:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,MURPHY_DRUGS_REL8,ONEWORD, VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB50OeSp011656 for ; Fri, 4 Dec 2009 16:24:42 -0800 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nB50OUJP015067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 4 Dec 2009 16:24:30 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nB50OU5V011260; Fri, 4 Dec 2009 16:24:30 -0800 (PST) Date: Fri, 4 Dec 2009 16:24:30 -0800 (PST) Message-Id: <200912050024.nB50OU5V011260@godzilla.ics.uci.edu> From: Dan Nicolaescu To: control@debbugs.gnu.org Subject: control X-Debbugs-No-Ack: yes Lines: 10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nB50OUJP015067 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=1.057, required 5, autolearn=disabled, ALL_TRUSTED -1.44, LOCALPART_IN_SUBJECT 2.50) X-ICS-MailScanner-SpamScore: s X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu tags 1589 3261 3462 + patch retitle 4529 --enable-ns should be on by default on macs close 4568 close 2678 close 3789 close 3968 close 4454 close 3644 forcemerge 1589 3088 quit