From unknown Tue Sep 09 14:02:36 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4565: 23.1.50; [Patch] The doctor thinks that "family" is an adverb Reply-To: Ulrich Mueller , 4565@debbugs.gnu.org Resent-From: Ulrich Mueller Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 27 Sep 2009 15:05:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4565 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125406349616572 (code B ref -1); Sun, 27 Sep 2009 15:05:12 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 27 Sep 2009 14:58:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,ENTIST,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8REwEQQ016569 for ; Sun, 27 Sep 2009 07:58:16 -0700 Received: from mx10.gnu.org ([199.232.76.166]:55993) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MrvCX-0002ks-UQ for emacs-pretest-bug@gnu.org; Sun, 27 Sep 2009 10:58:13 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MrvCV-0006f3-Ur for emacs-pretest-bug@gnu.org; Sun, 27 Sep 2009 10:58:13 -0400 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:37957) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrvCV-0006cd-GP for emacs-pretest-bug@gnu.org; Sun, 27 Sep 2009 10:58:11 -0400 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id n8REvvb3031164 for ; Sun, 27 Sep 2009 16:57:58 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.3/8.14.2) with ESMTP id n8REvuQl030410; Sun, 27 Sep 2009 16:57:56 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.3/8.14.3/Submit) id n8REvuV3030407; Sun, 27 Sep 2009 16:57:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19135.32116.624421.695685@a1i15.kph.uni-mainz.de> Date: Sun, 27 Sep 2009 16:57:56 +0200 To: emacs-pretest-bug@gnu.org X-Mailer: VM 8.0.12 under 23.1.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) When calling "psychoanalyze-pinhead" in Emacs from today's CVS trunk, but with the yow.lines file restored from Emacs 21, it stops at a phrase containing the word "family". To reproduce: $ emacs -Q M-x doctor RET While I'm in LEVITTOWN I thought I'd like to see the NUCLEAR FAMILY!! RET RET Actual behaviour: Minibuffer prompt "family what ?" appears. Expected behaviour: Doctor printing an answer like "Tell me something about your family." The problem is in function doctor-adverbp which recognises all words ending with "ly" as adverbs. The patch included below fixes it for some common words. (Actually, there are many more non-adverbs ending with "ly". I've limited it to words contained in the list of 850 words of Ogden's Basic English, or in yow.lines.) Ulrich 2009-09-27 Ulrich Mueller * play/doctor.el (doctor-adverbp): Exclude some common nouns. --- emacs-orig/lisp/play/doctor.el +++ emacs/lisp/play/doctor.el @@ -1190,7 +1190,8 @@ (defun doctor-adverbp (xx) (let ((xxstr (doctor-make-string xx))) (and (>= (length xxstr) 2) - (string-equal (substring (doctor-make-string xx) -2) "ly")))) + (string-equal (substring (doctor-make-string xx) -2) "ly") + (not (memq xx '(family fly jelly rally)))))) (defun doctor-articlep (x) (memq x '(the a an))) From rgm@gnu.org Fri Oct 2 17:15:07 2009 Received: (at control) by emacsbugs.donarmstrong.com; 3 Oct 2009 00:15:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n930F5Nc028519 for ; Fri, 2 Oct 2009 17:15:06 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MtsHB-0002df-2y; Fri, 02 Oct 2009 20:15:05 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19142.38793.26660.496725@fencepost.gnu.org> Date: Fri, 2 Oct 2009 20:15:05 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: yellow X-Ran: `1HVlPAe]oX58p&Mww>"vcHF148BX1RE=klf?{tlYoKADa1BE*zv Subject: bug#4565 closed by Glenn Morris (Re: Bug#4565; [Patch] The doctor thinks that "family" is an adverb) Message-ID: References: <19135.32116.624421.695685@a1i15.kph.uni-mainz.de> X-Emacs-PR-Message: they-closed 4565 X-Emacs-PR-Package: emacs Reply-To: 4565@debbugs.gnu.org Date: Sat, 17 Oct 2009 03:20:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1255749606-3045-1" This is a multi-part message in MIME format... ------------=_1255749606-3045-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4565: 23.1.50; [Patch] The doctor thinks that "family" is an adverb It has been closed by Glenn Morris . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Glenn Morris by replying to this email. --=20 4565: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4565 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1255749606-3045-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4565-done) by emacsbugs.donarmstrong.com; 17 Oct 2009 03:10:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,ENTIST,MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9H3AiIn002247 for <4565-done@emacsbugs.donarmstrong.com>; Fri, 16 Oct 2009 20:10:45 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Myzgp-0004U1-Fx; Fri, 16 Oct 2009 23:10:43 -0400 From: Glenn Morris To: 4565-done@debbugs.gnu.org Subject: Re: Bug#4565; [Patch] The doctor thinks that "family" is an adverb References: <19135.32116.624421.695685@a1i15.kph.uni-mainz.de> X-Spook: Legion of Doom [Hello to all my friends and fans in X-Ran: eNo/|@~E,=Wmk9Ab8\d\9?0{KD6_2`HZUg$}AT"jjPB$)((2xw>:3/@b*,C!r|iW)aF&in X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 16 Oct 2009 23:10:43 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks; applied. ------------=_1255749606-3045-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 27 Sep 2009 14:58:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,ENTIST,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8REwEQQ016569 for ; Sun, 27 Sep 2009 07:58:16 -0700 Received: from mx10.gnu.org ([199.232.76.166]:55993) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MrvCX-0002ks-UQ for emacs-pretest-bug@gnu.org; Sun, 27 Sep 2009 10:58:13 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MrvCV-0006f3-Ur for emacs-pretest-bug@gnu.org; Sun, 27 Sep 2009 10:58:13 -0400 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:37957) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrvCV-0006cd-GP for emacs-pretest-bug@gnu.org; Sun, 27 Sep 2009 10:58:11 -0400 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id n8REvvb3031164 for ; Sun, 27 Sep 2009 16:57:58 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.3/8.14.2) with ESMTP id n8REvuQl030410; Sun, 27 Sep 2009 16:57:56 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.3/8.14.3/Submit) id n8REvuV3030407; Sun, 27 Sep 2009 16:57:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19135.32116.624421.695685@a1i15.kph.uni-mainz.de> Date: Sun, 27 Sep 2009 16:57:56 +0200 To: emacs-pretest-bug@gnu.org Subject: 23.1.50; [Patch] The doctor thinks that "family" is an adverb X-Mailer: VM 8.0.12 under 23.1.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) When calling "psychoanalyze-pinhead" in Emacs from today's CVS trunk, but with the yow.lines file restored from Emacs 21, it stops at a phrase containing the word "family". To reproduce: $ emacs -Q M-x doctor RET While I'm in LEVITTOWN I thought I'd like to see the NUCLEAR FAMILY!! RET RET Actual behaviour: Minibuffer prompt "family what ?" appears. Expected behaviour: Doctor printing an answer like "Tell me something about your family." The problem is in function doctor-adverbp which recognises all words ending with "ly" as adverbs. The patch included below fixes it for some common words. (Actually, there are many more non-adverbs ending with "ly". I've limited it to words contained in the list of 850 words of Ogden's Basic English, or in yow.lines.) Ulrich 2009-09-27 Ulrich Mueller * play/doctor.el (doctor-adverbp): Exclude some common nouns. --- emacs-orig/lisp/play/doctor.el +++ emacs/lisp/play/doctor.el @@ -1190,7 +1190,8 @@ (defun doctor-adverbp (xx) (let ((xxstr (doctor-make-string xx))) (and (>= (length xxstr) 2) - (string-equal (substring (doctor-make-string xx) -2) "ly")))) + (string-equal (substring (doctor-make-string xx) -2) "ly") + (not (memq xx '(family fly jelly rally)))))) (defun doctor-articlep (x) (memq x '(the a an))) ------------=_1255749606-3045-1--