From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 22:12:39 2021 Received: (at submit) by debbugs.gnu.org; 4 Jan 2021 03:12:39 +0000 Received: from localhost ([127.0.0.1]:39115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwGIQ-0006d6-Pf for submit@debbugs.gnu.org; Sun, 03 Jan 2021 22:12:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:60130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwGIP-0006cy-Aw for submit@debbugs.gnu.org; Sun, 03 Jan 2021 22:12:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwGIP-0007cF-68 for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2021 22:12:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53346) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwGIO-0001HF-TX; Sun, 03 Jan 2021 22:12:36 -0500 Received: from [2607:fea8:3fdf:f688:805e:fbe0:e7c1:c8e] (port=54722 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwGIN-0001iV-SR; Sun, 03 Jan 2021 22:12:36 -0500 From: Amin Bandali To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Last character of mode-line-format is dropped with mode-line-compact of t Date: Sun, 03 Jan 2021 22:12:31 -0500 Message-ID: <878s99o0o0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I've noticed that the last (non-space) character of the mode-line-format string is dropped when I set the newly-introduced mode-line-compact setting to t. The following appears to fix the issue for me, but I'm not sure if it's the best/correct way to fix it (this is my first time touching any of Emacs's C bits). --8<---------------cut here---------------start------------->8--- diff --git a/src/xdisp.c b/src/xdisp.c index 749893baad..2e564d536d 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -25503,7 +25503,7 @@ display_mode_line (struct window *w, enum face_id face_id, Lisp_Object format) if (start < i) display_string (NULL, Fsubstring (mode_string, make_fixnum (start), - make_fixnum (i - 1)), + make_fixnum (i)), Qnil, 0, 0, &it, 0, 0, 0, STRING_MULTIBYTE (mode_string)); } --8<---------------cut here---------------end--------------->8--- In GNU Emacs 28.0.50 (build 20, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.10, Xaw3d scroll bars) of 2021-01-03 built on trisquel Repository revision: 20ad0cc03b73f6576ece195bb16878415c313d45 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Trisquel GNU/Linux Etiona (9.0) Configured using: 'configure --without-gconf --without-gsettings --without-gpm --with-x-toolkit=lucid --with-xaw3d --with-mailutils' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 Important settings: value of $LANG: en_CA.UTF-8 locale-coding-system: utf-8-unix Major mode: Group Minor modes in effect: gnus-topic-mode: t gnus-undo-mode: t yas-global-mode: t yas-minor-mode: t global-hl-todo-mode: t recentf-mode: t display-battery-mode: t display-time-mode: t save-place-mode: t savehist-mode: t show-paren-mode: t icomplete-mode: t fido-mode: t server-mode: t winner-mode: t global-auto-revert-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (char-fold misearch multi-isearch mailalias dabbrev pp shadow sort gnus-cite orgalist org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs flyspell ispell mail-extr emacsbug gnus-topic nndraft nnmh gnutls utf-7 epa-file network-stream nsm nnfolder nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win ebdb-message sendmail message rmc puny dired-x dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base cal-menu calendar cal-loaddefs timezone gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search time-date mail-utils mm-util mail-prsvr smerge-mode diff cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs whitespace vc-mtn vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir ewoc vc vc-dispatcher boxquote rect yasnippet hl-todo pcase easy-mmode delight recentf tree-widget wid-edit format-spec battery dbus time xml finder-inf info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source password-cache json subr-x map url-vars cl-extra help-mode saveplace savehist paren bandali-erc bandali-ebdb bandali-message bandali-gnus bandali-dired bandali-ibuffer ibuf-macs bandali-eshell icomplete bandali-org bandali-exwm exwm-edit exwm-systemtray xcb-systemtray xcb-xembed exwm-randr xcb-randr exwm-config ido seq exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core easymenu xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types cl-seq xcb-debug eieio byte-opt bytecomp byte-compile cconv eieio-core eieio-loaddefs server edmacro kmacro advice winner ring autorevert filenotify cl-macs gv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 401169 41320) (symbols 48 38210 4) (strings 32 124258 4175) (string-bytes 1 4069135) (vectors 16 73360) (vector-slots 8 1160672 44596) (floats 8 396 1693) (intervals 56 7442 891) (buffers 984 29)) -- https://bndl.org Free Software activist | GNU maintainer & webmaster GPG: BE62 7373 8E61 6D6D 1B3A 08E8 A21A 0202 4881 6103 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 05:02:37 2021 Received: (at control) by debbugs.gnu.org; 4 Jan 2021 10:02:37 +0000 Received: from localhost ([127.0.0.1]:55202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMh3-0005Fn-Sy for submit@debbugs.gnu.org; Mon, 04 Jan 2021 05:02:36 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMgq-00051s-Es for control@debbugs.gnu.org; Mon, 04 Jan 2021 05:02:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DPuc97r2+x6sy324IApCSlSvNty3QUNokpf+sxTRmFE=; b=J7bT17XU9IBapJpoknv/u+BvoI YBvM8P/XTG9OSGtWWTPN4UOCOnJ6AKUZmg/lY/9xSFTjMYoqkJzhCykOVJOhYUJXLzjcFBlQnPi94 5uC8p2Q4wKYv5wloVh+fK2+0UfduzqqkpO9Q6EVmuuUvo8IUgx8y/gm1SEsGkhbPl60Y=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwMTf-0001tN-OY for control@debbugs.gnu.org; Mon, 04 Jan 2021 10:48:41 +0100 Date: Mon, 04 Jan 2021 10:48:38 +0100 Message-Id: <87ft3h58y1.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45646 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45646 fixed close 45646 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45646 fixed close 45646 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 05:03:06 2021 Received: (at 45646) by debbugs.gnu.org; 4 Jan 2021 10:03:07 +0000 Received: from localhost ([127.0.0.1]:55239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMhY-0005Os-Ox for submit@debbugs.gnu.org; Mon, 04 Jan 2021 05:03:06 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMhL-00051s-GJ for 45646@debbugs.gnu.org; Mon, 04 Jan 2021 05:02:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bX6mMxe0ltPBkmrwYQ0cIG491EW2i02isyPPW2ZLfcI=; b=Ob2DwcnMI0NBkFA/pULjBMrHPd 47Ly9Hp2UDRtLtfMwznM3uqy71i0ZCTrolFJM4jLZSEIqpwF6ScoGvY+Z8qOdIypE940xVmL8LiXm fytiI8Lwm6dSbF2iKGG2lWws2gmcKjCDmWeyB9RBB+crzeNrb2oTmKrjsCG9qaCZQJ8U=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwMTY-0001r4-Cc; Mon, 04 Jan 2021 10:48:34 +0100 From: Lars Ingebrigtsen To: Amin Bandali Subject: Re: bug#45646: 28.0.50; Last character of mode-line-format is dropped with mode-line-compact of t References: <878s99o0o0.fsf@gnu.org> X-Now-Playing: Can Can's _En lek i forhold_: =?utf-8?Q?=22R=C3=B8dt?= lys" Date: Mon, 04 Jan 2021 10:48:31 +0100 In-Reply-To: <878s99o0o0.fsf@gnu.org> (Amin Bandali's message of "Sun, 03 Jan 2021 22:12:31 -0500") Message-ID: <87h7nx58y8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Amin Bandali writes: > I've noticed that the last (non-space) character of the mode-line-format > string is dropped when I set the newly-introduced mode-line-compact > setting to t. > > The following appears to fix the is [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45646 Cc: 45646@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Amin Bandali writes: > I've noticed that the last (non-space) character of the mode-line-format > string is dropped when I set the newly-introduced mode-line-compact > setting to t. > > The following appears to fix the issue for me, but I'm not sure if it's > the best/correct way to fix it (this is my first time touching any of > Emacs's C bits). Looks good to me; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 10:40:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Feb 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator