From unknown Sat Jun 21 05:19:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45623: 28.0.50; widget-backward sometimes skips one widget Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jan 2021 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 45623@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16096833709585 (code B ref -1); Sun, 03 Jan 2021 14:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2021 14:16:10 +0000 Received: from localhost ([127.0.0.1]:37229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw4Az-0002UW-IS for submit@debbugs.gnu.org; Sun, 03 Jan 2021 09:16:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:45182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw4Ay-0002UQ-MT for submit@debbugs.gnu.org; Sun, 03 Jan 2021 09:16:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kw4Ay-0004zL-Hs for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2021 09:16:08 -0500 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]:44053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kw4Aw-0000fZ-Jn for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2021 09:16:08 -0500 Received: by mail-qt1-x832.google.com with SMTP id u21so16774310qtw.11 for ; Sun, 03 Jan 2021 06:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:subject:date:mime-version; bh=aw579XVeqct5lpOershT9OkT2jB9ApJXRVDfRxuYPNg=; b=JsHhKAYSYC7tn1og90wZOhNQLdH1P2ncgmgzoaS8E6jcOWUzl7QGhel0NbsRn7qvOU tKwfGWlexnVkjdhNyLtHv1RKuBRqE9lHIXoKnpyRX0vRKupRe9o6dmZwX3VGy03SId2k frvve+RvoheeOL0IpkSa7jcFAivLVLefGk/WZIfXWJxMnaVAlWphvxnC+WRVaP6uq6z/ wjcJk+IG+qAcfo3CaCkSOa+u0OjmWZGpkQTh6+vSMPHEd0OA7LGPpGzsQbo6GvZ3FGuX uCm1nV5di9cIQklhoG6xCB30UHNKmkDBYc5mkFF8gXNuNCBeJxBj4HSv6TlEsFnt7BiC LwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:subject:date:mime-version; bh=aw579XVeqct5lpOershT9OkT2jB9ApJXRVDfRxuYPNg=; b=iqmeBYGTcshtSWIqJwsrw3OrGRNUzp+AejLR37tauochcHZMm04suTjg6dpUkwIeFS nUMJRQKNhqouHQ8C4tO7W8ztU1DC5Rq5vwLtmU7OsQaOTG39NkT1FkYwrCP4ojeDZFtl ECY93yhUGYup6mX1bJQA6otYCAUMJh09iv51IkhTPRD3aDQIwa3rJhZsZDjZSRcyD3aI TIdzqGqM5p7W7WscJU80//f+JbVfgf9vCSHF+q+fQyDQNueKiMv2FAmrJN+Ry2Yl+6yE rBdvQo4d35U6lEUkLn5nq14HgIaKH8GGPo5ZiOZhQLKST6RfkRQfeU9lojmJgMf4aHLS eXFw== X-Gm-Message-State: AOAM532RlcEGe0exbt85QCw3XPIVwRVQKfbfayuULyjKT5hLmFKsdk96 Txq9H2NYQkv862Qp3NExHL4TiLFgJzE= X-Google-Smtp-Source: ABdhPJx/7scOtO9kTmISeJjqn8ItljWfkKAANolGo6NKKXEJvRmgr9fohq3Ps/6g6VX8vNNPHCwDkA== X-Received: by 2002:aed:2ac1:: with SMTP id t59mr67476015qtd.165.1609683364406; Sun, 03 Jan 2021 06:16:04 -0800 (PST) Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id a203sm29347486qkb.31.2021.01.03.06.16.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jan 2021 06:16:03 -0800 (PST) Message-ID: <5ff1d1a3.1c69fb81.41cd3.92bc@mx.google.com> X-Google-Original-Message-ID: <87ble6ayxq.fsf@maurooaranda@gmail.com> From: Mauro Aranda Date: Sun, 03 Jan 2021 11:16:01 -0300 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=maurooaranda@gmail.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Starting from emacs -Q: 1. Eval the following code: (require 'wid-edit) (defun test-widget-backward () (interactive) (switch-to-buffer "*Widget Test*") (kill-all-local-variables) (let ((inhibit-read-only t)) (erase-buffer)) (remove-overlays) (widget-insert "Testing widget movement commands.\n\n") (dolist (el '("First" "Second" "Third")) (widget-create 'push-button el)) (widget-insert "\n") (goto-char (point-min)) (use-local-map widget-keymap) (widget-setup)) 2. C-u 3 C-i to move to the start of the button labeled Third: 3. C-M-i to run the widget-backward command. Point moves to the start of the button labeled First, not to the start of the button labeled Second. I expected point to move to the start of the button labeled Second. If instead I use buttons from button.el, moving point with backward-button (the analogous to widget-backward) behaves as I expected. The very first line of widget-move is: (or (bobp) (> arg 0) (backward-char)) That backward-char moves point from the third button to the second button before starting to look for the previous widget, so that's the reason point ends up at the start of the first button. I don't understand why that call to backward-char is there. Does anyone know of a situation where it is useful? In GNU Emacs 28.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-01-03 built on tbb-desktop Repository revision: 825b4ec338e82869dc656c7041ab2483b6c22479 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Ubuntu 18.04.5 LTS Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER Important settings: value of $LC_MONETARY: es_AR.UTF-8 value of $LC_NUMERIC: es_AR.UTF-8 value of $LC_TIME: es_AR.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils wid-edit cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 54440 9138) (symbols 48 7084 1) (strings 32 19227 1450) (string-bytes 1 632153) (vectors 16 12046) (vector-slots 8 168478 8434) (floats 8 23 47) (intervals 56 240 0) (buffers 984 12)) From unknown Sat Jun 21 05:19:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45623: 28.0.50; widget-backward sometimes skips one widget Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 45623@debbugs.gnu.org Received: via spool by 45623-submit@debbugs.gnu.org id=B45623.160975558732198 (code B ref 45623); Mon, 04 Jan 2021 10:20:02 +0000 Received: (at 45623) by debbugs.gnu.org; 4 Jan 2021 10:19:47 +0000 Received: from localhost ([127.0.0.1]:55971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMxn-0008NG-DO for submit@debbugs.gnu.org; Mon, 04 Jan 2021 05:19:47 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMxj-0008Mk-WB for 45623@debbugs.gnu.org; Mon, 04 Jan 2021 05:19:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DoqoCE2kEnUzzvAeRj5QQQMnv5FKapVb9/QiwQKiRs0=; b=csPQilN89ZRzYAvcUD+021Tqk/ aK/yeXfAEksDvfFaVnL22iJ2ZNNnn0X6vDONYcIn3+mZmTWg4ldKQgBkjLQCqpb64kwuLJTXO8p8j xzmieqHhK/+g4rVF+fBXP7uxvYW4xN4q25SKHrh15aqrOMGBG7jb8a+EjBanAs+YltmA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwMxa-0002Du-Bh; Mon, 04 Jan 2021 11:19:37 +0100 From: Lars Ingebrigtsen References: <5ff1d1a3.1c69fb81.41cd3.92bc@mx.google.com> X-Now-Playing: The Wolfgang Press's _Scarecrow_: "Ecstasy" Date: Mon, 04 Jan 2021 11:19:32 +0100 In-Reply-To: <5ff1d1a3.1c69fb81.41cd3.92bc@mx.google.com> (Mauro Aranda's message of "Sun, 03 Jan 2021 11:16:01 -0300") Message-ID: <8735zh57ij.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > I don't understand why that call to backward-char is there. Does anyone > know of a situation where it is useful? If point is just after a button, it makes C-M-i not going to that button, but the previous one? But that doesn't really sound like something you'd want, either? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I don't understand why that call to backward-char is there. Does anyone > know of a situation where it is useful? If point is just after a button, it makes C-M-i not going to that button, but the previous one? But that doesn't really sound like something you'd want, either? So, no, I don't see any situation where it would useful -- looks like a misfeature to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 05:19:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45623: 28.0.50; widget-backward sometimes skips one widget References: <5ff1d1a3.1c69fb81.41cd3.92bc@mx.google.com> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 45623@debbugs.gnu.org Received: via spool by 45623-submit@debbugs.gnu.org id=B45623.160976408410373 (code B ref 45623); Mon, 04 Jan 2021 12:42:01 +0000 Received: (at 45623) by debbugs.gnu.org; 4 Jan 2021 12:41:24 +0000 Received: from localhost ([127.0.0.1]:58066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPAq-0002hF-6B for submit@debbugs.gnu.org; Mon, 04 Jan 2021 07:41:24 -0500 Received: from mail-qt1-f170.google.com ([209.85.160.170]:37348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPAn-0002h0-W6 for 45623@debbugs.gnu.org; Mon, 04 Jan 2021 07:41:22 -0500 Received: by mail-qt1-f170.google.com with SMTP id z9so18302443qtn.4 for <45623@debbugs.gnu.org>; Mon, 04 Jan 2021 04:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=+tBz4rAWbOMMXe+vSrdN2sLokDr62EbG8cabSUA8YYU=; b=NOOKFgwICeqqhgNXeydrIX8KT6OGFhF1P0SNiYmaJaRQj/rIDhN/kN9Snhw0sRkANV J6m2qkTJ5oQJ2LwkMo+L07xc3ZLoXJM8i2Ic51pFQIRh1oELVwlfo46aEdCKD05NgeR7 fhJ5/rMNAJGA/vMtxdHFsK33iPzSJRNlx3IDHKymzz68SWguEL9H0j0kzr9C+XpsxCCq 2gPAZnVACetdrDCNINDj1mRHhwLT7erKN72PsHVlt6Ae5akgOSBr4u+y30NbynNZDAuT x2K7F/vJkSjtbL3NljzfDBUQ7C7+GECiFvu9RaPnzDv+sTQ0fEUx1XCvuA22//FaALsO sLmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=+tBz4rAWbOMMXe+vSrdN2sLokDr62EbG8cabSUA8YYU=; b=NA/kBGAumqTmY+yKk4jrcnveEhce1Y/GCi8tfikJikA250gPAjU+XiPoDnDCnAEPwv TumkQJF4Bxj82UZ2r/60MvJKE1HHBLkweKSZ4dNyi+Pz5WqDANj3ZoKRHsu3XMm/nDdl kt5i3owu3BCj3QCPXEbsmtTzuzhVkTyqQILE+QceiM7u79aHQbDdHX33pZYYCV1jWKzE XgCtU75zblgJc+y2WZF6xwvJNQ7i24himYnas9U2XNEY3rPGhUehNO8Y2wHDFfO4Kszj iqCpUaJskZbdpxtsuUAa+JDIAPL7Yw3vLlR9q9veWko5OpIIefgnxeiaPj9Zu9RoDw3C ouGQ== X-Gm-Message-State: AOAM531SmkTunVXkU+9/S//ov1JdH3bSCoN13qhGCfAEkQ27y6990KBz fBm0rqNHNvVVkSF3/bngkoQGbP9LZlk= X-Google-Smtp-Source: ABdhPJw8+3xXMxJDrwx7ndhYVXNzEFhW9YME2pFyEtiwBJFR21BIfzHZFHQyrR9bXVAseMrPb76aZg== X-Received: by 2002:ac8:1282:: with SMTP id y2mr68894132qti.283.1609764076214; Mon, 04 Jan 2021 04:41:16 -0800 (PST) Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id p15sm36888789qke.11.2021.01.04.04.41.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jan 2021 04:41:15 -0800 (PST) Message-ID: <5ff30ceb.1c69fb81.db5ba.99bf@mx.google.com> X-Google-Original-Message-ID: <87k0ss50yf.fsf@maurooaranda@gmail.com> From: Mauro Aranda In-Reply-To: <8735zh57ij.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 04 Jan 2021 11:19:32 +0100) Date: Mon, 04 Jan 2021 09:41:12 -0300 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I don't understand why that call to backward-char is there. Does anyone >> know of a situation where it is useful? > > If point is just after a button, it makes C-M-i not going to that > button, but the previous one? But that doesn't really sound like > something you'd want, either? > > So, no, I don't see any situation where it would useful -- looks like a > misfeature to me. Agreed. So, any objections to installing this patch and see if something breaks? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Don-t-skip-widgets-when-moving-backward.patch Content-Description: Patch >From 86c211725ab39ddfc569a16fefd0db6724651b43 Mon Sep 17 00:00:00 2001 From: Mauro Aranda Date: Sun, 3 Jan 2021 11:27:02 -0300 Subject: [PATCH] Don't skip widgets when moving backward * lisp/wid-edit.el (widget-move): Remove code that caused widget-backward to skip a previous adjacent widget when moving backward from the start of a widget. (Bug#45623) * test/lisp/wid-edit-tests.el (widget-test-widget-backward): New test. --- lisp/wid-edit.el | 1 - test/lisp/wid-edit-tests.el | 22 ++++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index f920130226..8b10d71dcb 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -1204,7 +1204,6 @@ widget-move ARG may be negative to move backward. When the second optional argument is non-nil, nothing is shown in the echo area." - (or (bobp) (> arg 0) (backward-char)) (let ((wrapped 0) (number arg) (old (widget-tabable-at))) diff --git a/test/lisp/wid-edit-tests.el b/test/lisp/wid-edit-tests.el index 35235c6566..f2e8c321f5 100644 --- a/test/lisp/wid-edit-tests.el +++ b/test/lisp/wid-edit-tests.el @@ -301,4 +301,26 @@ widget-test-option-can-handle-inlinable-choice (should child) (should (equal (widget-value widget) '((1 "One"))))))) +(ert-deftest widget-test-widget-backward () + "Test that `widget-backward' works OK." + (with-temp-buffer + (widget-insert "Testing.\n\n") + (dolist (el '("First" "Second" "Third")) + (widget-create 'push-button el)) + (widget-insert "\n") + (goto-char (point-min)) + (use-local-map widget-keymap) + (widget-setup) + ;; Check that moving from the widget's start works. + (widget-forward 3) + (should (string= "Third" (widget-value (widget-at)))) + (widget-backward 1) + (should (string= "Second" (widget-value (widget-at)))) + ;; Check that moving from inside the widget works. + (goto-char (point-min)) + (widget-forward 3) + (forward-char) + (widget-backward 1) + (should (string= "Second" (widget-value (widget-at)))))) + ;;; wid-edit-tests.el ends here -- 2.29.2 --=-=-=-- From unknown Sat Jun 21 05:19:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45623: 28.0.50; widget-backward sometimes skips one widget Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 45623@debbugs.gnu.org Received: via spool by 45623-submit@debbugs.gnu.org id=B45623.160976447710994 (code B ref 45623); Mon, 04 Jan 2021 12:48:01 +0000 Received: (at 45623) by debbugs.gnu.org; 4 Jan 2021 12:47:57 +0000 Received: from localhost ([127.0.0.1]:58075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPHB-0002rG-6q for submit@debbugs.gnu.org; Mon, 04 Jan 2021 07:47:57 -0500 Received: from quimby.gnus.org ([95.216.78.240]:59642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPH9-0002r0-Dn for 45623@debbugs.gnu.org; Mon, 04 Jan 2021 07:47:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a4EYUiTUNBp8VC1oBz2hKY6c/MJAmSf+CNv8o0zWBNw=; b=qaHgrtsuEHkEvUXgIkf2PTtvLz K9BHBGBm9Ec7jVOYnswS8MDLvtEA1OAbuFRnEe2GnqcDIypg9Ygo4KdsVp7Z8dxTWCoGq7c8TW8+G MtLIOiMeFLI+91kKPNUHBTKcgmjrn1Gh5fujuN3uxKjGZUryeRl0rBEUjr/auqCcl7VU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwPGx-0003vG-Dg; Mon, 04 Jan 2021 13:47:48 +0100 From: Lars Ingebrigtsen References: <5ff30ceb.1c69fb81.db5ba.99bf@mx.google.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEVIIh1hIRedUijm khKyi2ewazaKLxzEq5lzFg+MFg7///+2Sd5LAAAAAWJLR0QKaND0VgAAAAd0SU1FB+UBBAwqCr77 QiQAAAGYSURBVDjLbdQxT+MwFABgszE2EnAZ6WuTlrnTjeQMniktB6vFue6KAl4PJKqX9XSKkn/L S+I0NX1Psuz4y/NLIjtCiJPoOEZCiNFosrg8JkFtKu+6C/MNlLpux8mvmwB+OKVohHGyXI0PYeaU myPix1qcWOqjKEZ8F1H8nMuchvi5HAnch4jwzIOGS3E6QIwfTr20493f03gAaip/bMd/5Lw6BDtZ PNZNzFxeUIfUqgaqyeKpmS+dc90dTQi6J7lv4T/BbQCTDjYEbwNsKWPhQX4DX2OTS/XKwbNMpnKA el98I2EtrxiYqQymAfilfss8iULoMpTLbbRlMpxL7QVTvMzAvG9rJqOczvUTB1rZdcYB3ACsWYBb 0NxTLQF0ymUkAIaDkjJsCP5bUe3UcEutGPjpM6DgQGZpcsUB3O30Hqq2eAcmNSYEX/zfA/JQg7X9 F6EtegB6vDP9fAAG0PTzKIpqAB1X/bzf7e1T1SXMMTg4fUYdQtWfDzprPNjzcRws5aFaZeYQiroH +g01UPj3oF6nwz7zgfgFlDL4XdFSL0gAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDEtMDRUMTI6 NDI6MTArMDA6MDCdsjnxAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAxLTA0VDEyOjQyOjEwKzAw OjAw7O+BTQAAAABJRU5ErkJggg== X-Now-Playing: repository's _Howard Jones_: "The 12" Album/04-Like To Get To Know You Well (international mix).mp3" Date: Mon, 04 Jan 2021 13:47:42 +0100 In-Reply-To: <5ff30ceb.1c69fb81.db5ba.99bf@mx.google.com> (Mauro Aranda's message of "Mon, 04 Jan 2021 09:41:12 -0300") Message-ID: <87turw50nl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > Agreed. So, any objections to installing this patch and see if > something breaks? Go ahead. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Agreed. So, any objections to installing this patch and see if > something breaks? Go ahead. We've had some of the same issues with TAB/BACKTAB with button.el buttons (and eww links) -- the edge cases where two buttons touch each other have been under-scrutinised, although I hope I got all of them the last time. *crosses fingers* -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 05:19:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45623: 28.0.50; widget-backward sometimes skips one widget References: <5ff1d1a3.1c69fb81.41cd3.92bc@mx.google.com> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 45623@debbugs.gnu.org Received: via spool by 45623-submit@debbugs.gnu.org id=B45623.160976638914024 (code B ref 45623); Mon, 04 Jan 2021 13:20:02 +0000 Received: (at 45623) by debbugs.gnu.org; 4 Jan 2021 13:19:49 +0000 Received: from localhost ([127.0.0.1]:58112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPm1-0003e3-Bh for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:19:49 -0500 Received: from mail-qk1-f179.google.com ([209.85.222.179]:45287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPlz-0003dm-D0; Mon, 04 Jan 2021 08:19:48 -0500 Received: by mail-qk1-f179.google.com with SMTP id b64so23223997qkc.12; Mon, 04 Jan 2021 05:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=1ZvdLKZVd5f/BAcY7R4GkbJJ+vGe2GfjmJJGUl6/cAM=; b=VfuMPJI4UhwiU2hLnj2U1KhAKum+JrjLvyQlQ5rsbsxG0wqV7ixRp1hAVD5ROuOOtF 3pyPlnhySCx/tlo8vv02mQ4R6ecgasbqEj043fgavafU+E9pJ+XNPnNEd/crYTR7/Fi7 zzYpg+pbjlkB5uEkJ8JxZEYEMSGozJatANL0apS34j75L/gJT3BmTDmrC0bvnkDoeSoF AOrmWPDtTUEYJDICDsgxz0RNoV4boUb/RhgI5K2TVzi+3MiKgfpT9B5wbjo8lk595PzA 38W/Q5fRzfBXFpfmsO7drTuOnQYMgu0ZvBT74F4hV835oW6XJc3CAI3S8r3RxQD7h7nK 3knw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=1ZvdLKZVd5f/BAcY7R4GkbJJ+vGe2GfjmJJGUl6/cAM=; b=dnSyAhgG+zqZHJ3DV89MRAe0ILmNJP20ruo9hpeZawgOuz1Wd5tAGeXKcGwJR95qTe RZjISdcn6a2BnHU2hKmLq8qok3a6JCO0BrFWE3wU68veKb5n3KPdeK0vxh+93l/qfV0m 143kl/e3vnwu+7OGHhMod+RpMqTJTuqhqorGEvhdUi4DMnPRrcdosiKGzS44qYgeHYix nyjrUCSHrNVLYXzMHipvXTOpZS/B2DRnw9lqRfA/WZEjfY1w5nPTagrnoia/fo0aNZC6 QKBxBYjjOSO1PbKtqlY27FMLy3OzonVfz0HJaa8SL07cuON+ObkJebo5zbEBlmoGJWpb guBQ== X-Gm-Message-State: AOAM530qCkrdIIw7X1dPa8WyIJJqguGIYzoA9AVO6rSDqbKfHCSitSxI w03/Ccn2ScHCQFDbZqGjGxS8fdlwlp4= X-Google-Smtp-Source: ABdhPJyTcv0GWXyG5Sasf2B7Oc9ZNcyfHzefvb38sHX7zNGaLsyMRFc7Q5Le356qoY9qECasufL94g== X-Received: by 2002:a05:620a:12b9:: with SMTP id x25mr72785770qki.421.1609766381562; Mon, 04 Jan 2021 05:19:41 -0800 (PST) Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id l191sm36513601qke.7.2021.01.04.05.19.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jan 2021 05:19:40 -0800 (PST) Message-ID: <5ff315ec.1c69fb81.ecd9e.705d@mx.google.com> X-Google-Original-Message-ID: <87eej04z6d.fsf@maurooaranda@gmail.com> From: Mauro Aranda In-Reply-To: <87turw50nl.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 04 Jan 2021 13:47:42 +0100) Date: Mon, 04 Jan 2021 10:19:38 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45623 fixed close 45623 quit Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Agreed. So, any objections to installing this patch and see if >> something breaks? > > Go ahead. Thanks; done.