GNU bug report logs - #45620
28.0.50; Child frames should have their own border width and colour

Previous Next

Full log

Message #44 received at 45620 <at> debbugs.gnu.org (full text, mbox):

From: Alexander Miller <alexanderm <at> web.de>
To: rudalics <at> gmx.at
Cc: 45620 <at> debbugs.gnu.org, tumashu <at> 163.com, eliz <at> gnu.org
Subject: Re: bug#45620: 28.0.50; Child frames should have their own border
 width and colour
Date: Wed, 6 Jan 2021 17:32:18 +0100

[Message part 1 (text/plain, inline)]

>> >> - Currently the actual width of the border is still controlled by
the
>> >> `internal-border-width` parameter for both frame types. Should I
try to
>> >> do something about that as well? If yes, what's my entry point?
>> >
>> > Add a 'child-frame-border-width' parameter. But in this case I would
>> > propose to proceed as follows:
>> >
>> > - If for a frame the 'child-frame-border-width' was explicitly
set, use
>> > it.
>> >
>> > - If it was not set, use the 'internal-border-width' parameter.
>>
>> That's done now too, at least for X. I'll attach patches of my first
>> working drafts for both changes. Let me know if I'm on the right
path so
>> far.
>
> You're already at the end of it. Please document the changes in the
> Elisp manual and announce them as (probably incompatible) changes in
> NEWS.
>

Ok, all done now, see attached patch.

For the copyright I have asked my employer to make sure that the
copyright parts from my contract don't apply to the work I do on my own
time like this, but most of the company will still be on holidays or on
sick
leave, so it could be a few days before I get an answer.

[0001-Add-distinct-controls-for-the-appearance-of-child-fr.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.