From unknown Wed Aug 20 03:36:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45620 <45620@debbugs.gnu.org> To: bug#45620 <45620@debbugs.gnu.org> Subject: Status: 28.0.50; Child frames should have their own border width and colour Reply-To: bug#45620 <45620@debbugs.gnu.org> Date: Wed, 20 Aug 2025 10:36:54 +0000 retitle 45620 28.0.50; Child frames should have their own border width and = colour reassign 45620 emacs submitter 45620 Alexander Miller severity 45620 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 08:18:48 2021 Received: (at submit) by debbugs.gnu.org; 3 Jan 2021 13:18:48 +0000 Received: from localhost ([127.0.0.1]:37164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw3HT-000146-Va for submit@debbugs.gnu.org; Sun, 03 Jan 2021 08:18:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:44822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw3HR-00013x-Ur for submit@debbugs.gnu.org; Sun, 03 Jan 2021 08:18:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kw3HR-0006qo-7l for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2021 08:18:45 -0500 Received: from mout.web.de ([212.227.17.12]:44945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kw3HJ-0007cH-9m for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2021 08:18:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609679912; bh=gV7auACdPse6s/++Ylh5NHMvvCoJhHSY93mvsxuwx8o=; h=X-UI-Sender-Class:To:Subject:From:Date; b=Gcy+Zj3RwLjUk8PA3xNdAYPrTt0lujpC69WWmEAq2K7ifSgAgBgMvSMqCaevI5u7w 25EDltJplx1uMlYRLILfG/L/LADnKKwxPCc0hxN9kyqAMSRzJ4m1gdrWlZEhqOA1It AHGR/WJnK9awuK8qwH25PPOXMiDjPbdojIqpRLcw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MActe-1kpUky13o8-00B0GT for ; Sun, 03 Jan 2021 14:18:32 +0100 To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de> Date: Sun, 3 Jan 2021 14:24:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Provags-ID: V03:K1:IkLjEI8dZ3y4Dc3CmKqlF786LTVskVekp7gEFeedTqE0BnK5Ko7 MhPbznSIGcUQS6VRpITs2+hvlhzSLaLlPfoRlF7TjQtKTu84zbEDinovUJV+xYcSdb+qdMR SbgoO0Wkcu62wGdsyOLtt9I09nUA4dUATczzDrQLxwxY627a0+fKfh+4BvLXcvw4GsXHzg3 66oCJprsqjW84EN9QZcgw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:70oVuPByUXI=:mHVs/990PEJ76v+1yEnAOI Br5OI9dgXv6BZYsB6gR6BPU2fdJGPxLl7YX18iytPeVDTWyCWByoMsx0QvFjEo0t610Wf9AXw 8nJa1hFTouWxuDnWRbwvVJ4+b6Hhp7it9B7iJaDeJ/7HXt6xk/Lw5hPgq8C+zt/gyw3/xq3u9 UBPeaI9YkttiogdoOdm5kolOthm0uKDY6IWNfLB4mLmztjghMAjB/bxG/mKacFBiNX3IPxJ+7 Yafr6j11nc11aurA2nnOff784K+8AntRQxeIBAT3N+rQ+jKpJTe9aXQ3hMy/apqYY0X5kjBAK xA1ugMEU2y/XpVCgKtj0PxggFGBm/8JJTWlEId4gJdmZNCT48k1oJDF9Vf0xmOyPb11V1kszq B9AtCI10tfChj1QaOSIKOZ9riNg6dWIRP2TIWcmKB2l3PlrHLg+CKoHOFL7JWb4IpgR3ftcg4 BxGk8OzhrWkwKBLieICcsz+oyOX00+4K+xfMtHj+IeUzuVeTadqTu64u81qg1j+kUkEdrJ6od uTN5QtB6H21vce5PIZtis+MCDzKjs3GrtPY645uUl805QvZfPd4+u7aF647cAZshDks0h6ct9 xFAreDco5aO4mWAAjMJqK7EoTf4S9bAnUsFf4ozV29pt0hyLAEGcs2RpuElKLr9v/sdfQri0i ETfTITDoC8mBI6eo7fbheWJZFPRniQMSSVdziIANqsayUGp0ZnMaeL/4/Ds7442TUmg3IGGRu i7quASj/oEzwbhDolyN7j60hiHKyJ6KEivWZHhiz69SmLlGAuF2PqOMIZKns419obDP4qUMeE 1n2wYGpfxUMqcoFwkmQWqDC89E32NXL5AaIW8zL4G9kPI12H8HlBh7uSmOCWG0dIMjE0l57WH oqpMZaW/0hWes6kFqVWQ== Received-SPF: pass client-ip=212.227.17.12; envelope-from=alexanderm@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is an idea set off by this discussion: https://github.com/Alexander-Miller/treemacs/issues/242#issuecomment-75329= 6634 Basically the problem is that child frames need a distinct border colour to be properly visible (and just using a different background colour does not look nearly as good). That can be achieved by customising the `internal-border' face, however that face controls the appearance of the border of all frames, and as I have learned there is a non-trivial amount of users who by default use a large internal border as a margin for their frames. And for these users the `internal-border' should have the same colour as the default background. So there is a conflict between wanting a distinct border colour for child frames and using the default background for normal frames. Packages can work around that individually, for example posframe accepts an `internal-border-color' argument that overrides the `internal-border' face frame-locally. But that still means that every package using child frames needs its own user option for the child frames' border colour when such matters clearly belong under the domain of the user's theme. I think that since child frames serve sufficiently distinct use cases than normal frames it makes sense for them to have their own border appearance controls. In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.17.3) of 2020-12-20 built on am-laptop Repository revision: ab985f41db5fdaeada513d28a065332fd8838cf4 Repository branch: makepkg Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Manjaro Linux Configured using: 'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/usr/lib =2D-localstatedir=3D/var --mandir=3D/usr/share/man --with-gameuser=3D:game= s =2D-with-sound=3Dalsa --with-modules --without-gconf --without-gsettings =2D-with-nativecomp --with-x-toolkit=3Dgtk3 --without-xaw3d =2D-without-m17n-flt --with-cairo --without-compress-install 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -g -fuse-ld=3Dgold' CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2 LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES NATIVE_COMP THREADS LIBSYSTEMD JSON PDUMPER LCMS2 Important settings: value of $LC_MONETARY: de_DE.UTF-8 value of $LC_NUMERIC: de_DE.UTF-8 value of $LC_TIME: de_DE.UTF-8 value of $LANG: en_GB.utf8 locale-coding-system: utf-8 Major mode: Fundamental Minor modes in effect: helm-mode: t helm--remap-mouse-mode: t async-bytecomp-package-mode: t projectile-mode: t company-prescient-mode: t global-company-mode: t company-mode: t global-evil-vimish-fold-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-mode: t org-super-agenda-mode: t treemacs-icons-dired-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: deferred treemacs-fringe-indicator-mode: t gcmh-mode: t winner-mode: t framey-mode: t purpose-mode: t shackle-mode: t winum-mode: t eyebrowse-mode: t global-ligature-mode: t ligature-mode: t global-subword-mode: t subword-mode: t global-evil-surround-mode: t evil-surround-mode: t evil-lion-mode: t evil-goggles-mode: t shell-dirtrack-mode: t evil-mode: t evil-local-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: ~/Documents/git/cfrs/cfrs hides /home/am/.emacs.d/straight/build/cfrs/cfrs /usr/share/emacs/28.0.50/lisp/emacs-lisp/let-alist hides /home/am/.emacs.d/straight/build/let-alist/let-alist ~/Documents/git/treemacs/src/elisp/treemacs-interface hides /home/am/.emacs.d/straight/build/treemacs/treemacs-interface ~/Documents/git/treemacs/src/elisp/treemacs-rendering hides /home/am/.emacs.d/straight/build/treemacs/treemacs-rendering ~/Documents/git/treemacs/src/elisp/treemacs-hydras hides /home/am/.emacs.d/straight/build/treemacs/treemacs-hydras ~/Documents/git/treemacs/src/elisp/treemacs-dom hides /home/am/.emacs.d/straight/build/treemacs/treemacs-dom ~/Documents/git/treemacs/src/elisp/treemacs-tags hides /home/am/.emacs.d/straight/build/treemacs/treemacs-tags ~/Documents/git/treemacs/src/elisp/treemacs hides /home/am/.emacs.d/straight/build/treemacs/treemacs ~/Documents/git/treemacs/src/elisp/treemacs-workspaces hides /home/am/.emacs.d/straight/build/treemacs/treemacs-workspaces ~/Documents/git/treemacs/src/elisp/treemacs-customization hides /home/am/.emacs.d/straight/build/treemacs/treemacs-customization ~/Documents/git/treemacs/src/elisp/treemacs-faces hides /home/am/.emacs.d/straight/build/treemacs/treemacs-faces ~/Documents/git/treemacs/src/elisp/treemacs-themes hides /home/am/.emacs.d/straight/build/treemacs/treemacs-themes ~/Documents/git/treemacs/src/elisp/treemacs-mouse-interface hides /home/am/.emacs.d/straight/build/treemacs/treemacs-mouse-interface ~/Documents/git/treemacs/src/elisp/treemacs-mode hides /home/am/.emacs.d/straight/build/treemacs/treemacs-mode ~/Documents/git/treemacs/src/elisp/treemacs-icons hides /home/am/.emacs.d/straight/build/treemacs/treemacs-icons ~/Documents/git/treemacs/src/elisp/treemacs-compatibility hides /home/am/.emacs.d/straight/build/treemacs/treemacs-compatibility ~/Documents/git/treemacs/src/elisp/treemacs-follow-mode hides /home/am/.emacs.d/straight/build/treemacs/treemacs-follow-mode ~/Documents/git/treemacs/src/elisp/treemacs-visuals hides /home/am/.emacs.d/straight/build/treemacs/treemacs-visuals ~/Documents/git/treemacs/src/elisp/treemacs-core-utils hides /home/am/.emacs.d/straight/build/treemacs/treemacs-core-utils ~/Documents/git/treemacs/src/elisp/treemacs-extensions hides /home/am/.emacs.d/straight/build/treemacs/treemacs-extensions ~/Documents/git/treemacs/src/elisp/treemacs-filewatch-mode hides /home/am/.emacs.d/straight/build/treemacs/treemacs-filewatch-mode ~/Documents/git/treemacs/src/elisp/treemacs-persistence hides /home/am/.emacs.d/straight/build/treemacs/treemacs-persistence ~/Documents/git/treemacs/src/elisp/treemacs-async hides /home/am/.emacs.d/straight/build/treemacs/treemacs-async ~/Documents/git/treemacs/src/elisp/treemacs-bookmarks hides /home/am/.emacs.d/straight/build/treemacs/treemacs-bookmarks ~/Documents/git/treemacs/src/elisp/treemacs-tag-follow-mode hides /home/am/.emacs.d/straight/build/treemacs/treemacs-tag-follow-mode ~/Documents/git/treemacs/src/elisp/treemacs-logging hides /home/am/.emacs.d/straight/build/treemacs/treemacs-logging ~/Documents/git/treemacs/src/elisp/treemacs-header-line hides /home/am/.emacs.d/straight/build/treemacs/treemacs-header-line ~/Documents/git/treemacs/src/elisp/treemacs-fringe-indicator hides /home/am/.emacs.d/straight/build/treemacs/treemacs-fringe-indicator ~/Documents/git/treemacs/src/elisp/treemacs-diagnostics hides /home/am/.emacs.d/straight/build/treemacs/treemacs-diagnostics ~/Documents/git/treemacs/src/elisp/treemacs-macros hides /home/am/.emacs.d/straight/build/treemacs/treemacs-macros ~/Documents/git/treemacs/src/elisp/treemacs-scope hides /home/am/.emacs.d/straight/build/treemacs/treemacs-scope Features: (shadow ispell rainbow-delimiters rainbow-mode xterm-color display-line-numbers hl-todo prose-complete emacsbug face-remap helm-command helm-elisp helm-eval edebug backtrace helm-info info sort gnus-cite smiley shr-color color mm-archive mail-extr gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader wid-edit pp view helm-mode helm-projectile helm-files docker-tramp tramp-cache tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp helm-tags helm-buffers helm-occur helm-grep helm-regexp helm-utils helm-locate helm-help helm-types framey-helm helm-config helm async-bytecomp helm-global-bindings helm-source helm-multi-match helm-lib async treemacs-projectile projectile grep compile ibuf-ext ibuffer ibuffer-loaddefs mu4e-alert time alert log4e notifications dbus company-keywords company-dabbrev-code company-dabbrev company-yasnippet company-files company-capf company-prescient prescient company server evil-vimish-fold vimish-fold smartparens-config smartparens-org smartparens-text paren smartparens xml gntp org-mu4e mu4e desktop frameset mu4e-org german-holidays org-super-agenda ts org-habit org-element avl-tree generator org-agenda org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs find-func mu4e-main mu4e-view cal-menu calendar cal-loaddefs browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 smtpmail sendmail mu4e-mark mu4e-message flow-fill mu4e-proc mu4e-utils doc-view jka-compr mu4e-lists mule-util mu4e-vars message rmc puny treemacs-icons-dired treemacs-evil treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-extensions treemacs-mouse-interface treemacs-tags imenu xref project treemacs-persistence treemacs-filewatch-mode filenotify treemacs-follow-mode treemacs-rendering treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture hl-line treemacs-logging treemacs-customization treemacs-macros dired+ image-dired image-mode exif image-file image-converter dired-x dired-aux dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source password-cache json map text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader mu4e-meta gcmh doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path f all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons memoize winner framey inline ht s window-purpose window-purpose-fixes window-purpose-prefix-overload window-purpose-switch let-alist window-purpose-layout window-purpose-core window-purpose-configuration eieio-compat eieio window-purpose-utils shackle trace winum eyebrowse format-spec ligature morning-star-theme cap-words superword subword evil-surround evil-lion evil-goggles pulse evil evil-keybindings evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-types evil-search evil-ex shell pcomplete comint ansi-color evil-macros evil-repeat evil-states evil-core comp comp-cstr warnings subr-x cl-extra help-mode seq byte-opt bytecomp byte-compile cconv advice evil-common windmove thingatpt rect evil-digraphs evil-vars ring edmacro kmacro cl-seq dash yequake-autoloads yasnippet-autoloads yaml-mode-autoloads xwidgets-reuse-autoloads xterm-color-autoloads wttrin-autoloads writeroom-mode-autoloads with-editor-autoloads winum-autoloads window-purpose-autoloads eieio-core cl-macs eieio-loaddefs vterm-autoloads visual-fill-column-autoloads vimish-fold-autoloads ts-autoloads tridactylrc-mode-autoloads treepy-autoloads treemacs-autoloads transient-posframe-autoloads transient-autoloads toml-mode-autoloads toc-org-autoloads tablist-autoloads straight-autoloads spinner-autoloads smartparens-autoloads shrink-path-autoloads shackle-autoloads s-autoloads rust-mode-autoloads restart-emacs-autoloads rainbow-mode-autoloads rainbow-delimiters-autoloads projectile-autoloads pretty-hydra-autoloads prescient-autoloads posframe-autoloads pos-tip-autoloads popup-autoloads pkg-info-autoloads pfuture-autoloads perspective-autoloads persp-mode-autoloads peep-dired-autoloads pdf-tools-autoloads pcre2el-autoloads package-lint-autoloads org-superstar-autoloads org-super-agenda-autoloads org-autoloads multi-compile-autoloads mu4e-views-autoloads mu4e-alert-autoloads morning-star-autoloads memoize-autoloads markdown-mode-autoloads magit-todos-autoloads magit-autoloads macrostep-autoloads lv-autoloads lsp-ui-autoloads lsp-treemacs-autoloads lsp-mode-autoloads log4e-autoloads link-hint-autoloads ligature-autoloads let-alist-autoloads ledger-mode-autoloads json-snatcher-autoloads json-reformat-autoloads json-mode-autoloads rx imenu-list-autoloads i3wm-config-mode-autoloads hydra-autoloads ht-autoloads hl-todo-autoloads helpful-autoloads helm-projectile-autoloads helm-org-autoloads helm-easymenu easymenu helm-core-autoloads helm-ag-autoloads helm-autoloads goto-chg-autoloads gntp-autoloads git-modes-autoloads git-gutter-fringe-autoloads git-gutter-autoloads git-commit-autoloads ghub-autoloads german-holidays-autoloads gcmh-autoloads frog-menu-autoloads fringe-helper-autoloads framey-autoloads frame-local-autoloads forge-autoloads flyspell-correct-autoloads flycheck-pos-tip-autoloads flycheck-autoloads fish-mode-autoloads fill-column-indicator-autoloads f-autoloads eyebrowse-autoloads expand-region-autoloads evil-vimish-fold-autoloads evil-surround-autoloads evil-numbers-autoloads evil-nerd-commenter-autoloads evil-magit-autoloads evil-lion-autoloads evil-ledger-autoloads evil-goggles-autoloads evil-exchange-autoloads evil-collection-autoloads evil-autoloads eros-autoloads epl-autoloads epkg-autoloads emacsql-sqlite-autoloads emacsql-autoloads elisp-refs-autoloads elfeed-org-autoloads elfeed-autoloads doom-modeline-autoloads doct-autoloads dockerfile-mode-autoloads docker-tramp-autoloads docker-compose-mode-autoloads docker-autoloads dired+-autoloads dash-functional-autoloads dash-autoloads ctrlf-autoloads easy-mmode company-shell-autoloads company-quickhelp-autoloads company-prescient-autoloads company-box-autoloads company-autoloads closql-autoloads cfrs-autoloads buttercup-autoloads avy-autoloads async-autoloads anzu-autoloads annalist-autoloads all-the-icons-autoloads alert-autoloads ace-window-autoloads cl-loaddefs cl-lib gv iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face pcase macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 668840 513173) (symbols 48 43798 0) (strings 32 152762 59495) (string-bytes 1 5475171) (vectors 16 63689) (vector-slots 8 1094531 320683) (floats 8 926 1405) (intervals 56 6773 8846) (buffers 984 21)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 11:16:11 2021 Received: (at 45620) by debbugs.gnu.org; 3 Jan 2021 16:16:11 +0000 Received: from localhost ([127.0.0.1]:38450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw638-0005k2-Ta for submit@debbugs.gnu.org; Sun, 03 Jan 2021 11:16:11 -0500 Received: from mout.gmx.net ([212.227.15.18]:40523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw634-0005jG-4y for 45620@debbugs.gnu.org; Sun, 03 Jan 2021 11:16:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609690559; bh=+K3N7ZRKe8mY+dHybf4e97W+xu/cykxKVjBKV9D6bzk=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=SUeWeW0OFdtN58zXSoQkp6GqSElboGhl3XXYNHJVFxe+TSMWjCRlyJPhNbFxXjRiQ OUKRuFEaF8e31Lc5eI3jM6yJbnU+MiSc5xc7iRCmr+s69SygXey6ZdN9bbvrEn6XQy 4Tz5ktodKet6NfT2718WVw6bFMFTIfWe29ajvcfA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.103] ([212.95.5.250]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhU5R-1kIece30F9-00eaxx; Sun, 03 Jan 2021 17:15:59 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller , 45620@debbugs.gnu.org References: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de> From: martin rudalics Message-ID: <43ccff46-1d67-2300-7098-b419966dfd66@gmx.at> Date: Sun, 3 Jan 2021 17:15:58 +0100 MIME-Version: 1.0 In-Reply-To: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:UuzUO+Wrh1/qx5TvdqA8U5IFGhWZZK1w23hCyhIJzKCbmciIMzf bnuCY9xvRku/s+75+qfcOpN/BpX8us6Xn6NNUgh2ycTUrbAbpNDxrTLgwirc2cqrxipkBcx DKesSjR8bei/i3ZmzEcnfyTdk5/rJtVji8WGtXmPQ+HydHcT1UhcqLVZJv9ocDaHh8lTsX+ CrHO7m4kkA0wYh4uRIMHw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:DR6xLBF69oc=:ziTPKPY6WbfR4jRuREJ2VL RNyfq8dx0TFFgFdjk/DB52omgy9VaYUNeIuy9ne4cpwV48rXtF67bQ+BoTm2J/g4RVoQeTCfQ wH9ERSXOef7c8UqX5VDX3Zqs+ds1jlfxXeJzoPqB95hT64exPMvnURR/GK0yv3X3iNNCuC/dz UOvDgSWfeFfdab3ZXezhGOke333+4Nbs7EmX8uyw+u4pibtJHLBDsQy36yEXg6hrClVI7ntjC bXOug2r872bqLqH+JQCfDA6eZEzX850Ny4NnHdUHVUnGQeMoKlQ+PA+u7vrAlvej/38ZYzYPI zMNOE0IoEo4KByB3Yj4HXXnIgPlcu/vx8iwoJlUu5R/CYsRDNq5fL8l5nC7+0kNQzwhvFbp9x 0DnY3PxgMhBjxE91yRXXwapsJD1E8zaj9/qitG1N2F6P0cpkQMQAIUb9sJI3zs6o7fLNDiT7n pRHvCGTA/+RKlmAQfY4o/0CclNZZQLfiB/MmAV8dYPywH+tVhvwjAZ0zyUnlHFUz2WuppJRIR faoOZArL1B0fSH20jd82XTybDuvmeWzngcOkX0Y1uSWNI6yWVSFkyADTUHr5BeWGbLXkFOlR0 tPWNPvw4KsMaKAOOj81kzOlZGVMff7nfuHLcBYjKXf/6OBtPI+kIrzJ4Tsn329EjxGXYImehp D3QcSmvlQbTuMzoUiIWMwCydVrBKNl5j3qMUvcaKA95Z7bPwKAzENkM1VSxYNJtAiw5iq8PCO /1Xo73Q1nzZ3R26wwsc1DxHMFudOXg28Azk5IZfDh7EB/Dj/fPKu2o60eKkT4x3rTIjgU4vUa 4+5JmcKGxFRRfkz9irLqYRfBhk//5axOX3j30C63JAqscLhbj8hQAFm0djaCwXmhTs1u5oOCe E9fRBgDr+14Yaw2SvaySkmvAx4nNlH/KN9YHZpfBs= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > This is an idea set off by this discussion: > https://github.com/Alexander-Miller/treemacs/issues/242#issuecomment-753296634 > > Basically the problem is that child frames need a distinct border co [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.250 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 45620 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > This is an idea set off by this discussion: > https://github.com/Alexander-Miller/treemacs/issues/242#issuecomment-753296634 > > Basically the problem is that child frames need a distinct border co [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.250 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > This is an idea set off by this discussion: > https://github.com/Alexander-Miller/treemacs/issues/242#issuecomment-753296634 > > Basically the problem is that child frames need a distinct border colour > to be properly visible (and just using a different background colour does > not look nearly as good). > > That can be achieved by customising the `internal-border' face, however > that face controls the appearance of the border of all frames, and as I > have learned there is a non-trivial amount of users who by default use a > large internal border as a margin for their frames. And for these users > the `internal-border' should have the same colour as the default > background. Isn't the situation even worse than how you describe it here? When I customize 'internal-border' face, that affects all frames, including those for which I have set it already via 'set-face-background'. Which means that whatever a package does to set that face for a specific (child) frame, that setting is undone by a later customization. IIUC the discussion you refer to above arrived at the same conclusion. > So there is a conflict between wanting a distinct border colour for > child frames and using the default background for normal frames. If I'm not mistaken we use that face for our tooltip frames too which means one more conflict. > Packages can work around that individually, for example posframe accepts > an `internal-border-color' argument that overrides the `internal-border' > face frame-locally. But that still means that every package using child > frames needs its own user option for the child frames' border colour > when such matters clearly belong under the domain of the user's theme. "clearly" is clearly too strong here. Ultimately, the package must have the choice and its choice should prevail (it currently doesn't). > I think that since child frames serve sufficiently distinct use cases > than normal frames it makes sense for them to have their own border > appearance controls. So what should we do? Provide a separate 'child-frame-internal-border' face and then probably also a 'tooltip-internal-border-face'? Customizing such a face would still override individual frame settings. What we need is probably a strategy to avoid setting the background for those frames that have their internal border already set. But then we should do that for all faces running through 'set-face-attribute'. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 08:32:46 2021 Received: (at 45620) by debbugs.gnu.org; 4 Jan 2021 13:32:46 +0000 Received: from localhost ([127.0.0.1]:58121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPyY-00063s-JW for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:32:46 -0500 Received: from mout.web.de ([212.227.15.4]:40777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPyX-00063f-H4 for 45620@debbugs.gnu.org; Mon, 04 Jan 2021 08:32:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609767159; bh=LuZS3/QTR95Yjm9JJ69w1DH3AddsYhI30HefdcBk/aM=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=N7xZxdySOoZCYXK87IGo9zbw5OPldn7XlfMixlTU5x/viBwzOyQqdZZlfLWiMOUkY /Z1ttjTJfH3iQjljQIuAn+nROsdmdEodn5aJNZjhT0+CMw9A4FZ1zdTFncwb43dxvI DSGcBKzsFhuDtBjRJx/CQ9/NDVvEOAh2I7yPveAI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MgOQQ-1kb1jV0YBa-00NiYp; Mon, 04 Jan 2021 14:32:39 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: Date: Mon, 4 Jan 2021 14:38:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:q88wDpFyBAdLuO6DZDF3Nssk+wdqbwMOF0KuonQ0Vgu1zhfauz1 r549hndy6bdphMKZ6fM5E/ateyea+klGE4bC2vkm5MHOJkIKYGKFpjjCNnJ5wHtQW68PG8A 6lOXsaGlW0hBYd3T63vt0AtzuiapNCNNWT5DQGyNkGTSak7kSh5Qri1McOLIjeEz8WX5XGp IxlgGAUrYAxi/JvJ9PnTg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rvkTNeUBjDA=:530zLSHERdI6bcpDuJ8aq6 5ldQKh7DU12Ya44axQFSfNAIzMZPi35DE/C5bdjMuHUv+IJL/m0/Q0Hk+N3qjYHG3d/tSQfU3 o04kzqnw/0NY5NQij0J4Q6xk2EMxXwqkMO/0fehUdfxn79iZJvoOC8rg9rop5XqCAO0nxcsfQ gqKr28oCsBtDe5Nr3CSUAa/Da+UuZ7yfZwdxOS7UkbiineyPgesi01OjWkbYEsogyNnAZ18gQ 6MHADxyGntzz/CVDtfQfJWzOUP9opVlT7hrgI9rQJguKfpR+g0WW3L5z85AY9+klBFCQL02/S 2YUSlMraLUBsqDmLYGCxd/nPqXBouxOkQ+tNHhDeobSf0I+h+tfMBZJxYXb7A04WG11uGKtPu lE6gkzcdfIG84zSxgovjY7o0crRXO0TWUSb3+KoYD8fBe0/K7MjSVH3BGpgvNePco0r3jwp6R jZA+bfkjlCMJPdIYLnDxoitmRSljH+TT/WDwmDZedB756WPWRo1KPnXEDKgNVl33Ub2Dbz9Ev 2SoOmtIsiwjBeKMOTHgT5XavT5WP3VQgvWcDgqCc7BwEFriMy5lqbocAPfSX/r7Lt30IrgXV6 ygBQfy5DuGHKip8MRLOBPJpHXjwEH2fDqckcP5ueWZxkLRDhGut1bPtmkCYAZSXAR+nET4SOs M/8Hm2jWSMSP5Bsw9LQHY9feHeqT2xwaTW1RjPJy+Z7tisGSC062tF2uh3Oyck1Cb1FejojQ1 GV0eRzkG+TweEl0RUXORwXBh0QP9xfZ1Z4Ikw9mc3TOigLQ0HZT/rwJqtqtyYOytWaFBS0PLR lv4YRL+dtQu2tZgBbX8+OL2mYrqMN2OhrKM2vKuH1THKhtrL8z2Y3GpxqFNpBcdc8/Zz8jIWd Au7RcsWVXIwW1OtD1VkQ== X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Isn't the situation even worse than how you describe it here? When I > customize 'internal-border' face, that affects all frames, including > those for which I have set it already via 'set-face-bac [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Isn't the situation even worse than how you describe it here? When I > customize 'internal-border' face, that affects all frames, including > those for which I have set it already via 'set-face-bac [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.8 FAKE_REPLY_A1 No description available. > Isn't the situation even worse than how you describe it here? When I > customize 'internal-border' face, that affects all frames, including > those for which I have set it already via 'set-face-background'. Which > means that whatever a package does to set that face for a specific > (child) frame, that setting is undone by a later customization. IIUC > the discussion you refer to above arrived at the same conclusion. What customisations are you referring to? I cannot think of any scenario, other than changing and reloading your theme, that could change the settings of already present child frames. > If I'm not mistaken we use that face for our tooltip frames too which > means one more conflict. Partially. On my system the internal-border colour and width only applied to the top and left sides of the tooltip frame. > "clearly" is clearly too strong here. Ultimately, the package must have > the choice and its choice should prevail (it currently doesn't). Packages do have the choice, they just have to make sure to override the frame-local faces whenever they show something. The problem, as I see it, is that they *have to* create a face to override the local internal-border, instead of just having the option to do it, because themes cannot offer a general setting, like an easily visible dark border on a bright foreground, because they run into the frame margin colour conflict like modus did in the linked issue. So if a package doesn't overwrite the local internal-border your default look-and-feel is a badly visible same-colour-on-same-colour popup. > So what should we do? Provide a separate 'child-frame-internal-border' > face and then probably also a 'tooltip-internal-border-face'? That would be perfectly good enough for themes like modus, yes. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 11:22:54 2021 Received: (at 45620) by debbugs.gnu.org; 4 Jan 2021 16:22:54 +0000 Received: from localhost ([127.0.0.1]:60035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSdC-0002Mu-3a for submit@debbugs.gnu.org; Mon, 04 Jan 2021 11:22:54 -0500 Received: from mout.gmx.net ([212.227.15.18]:53891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSd9-0002Mg-IG for 45620@debbugs.gnu.org; Mon, 04 Jan 2021 11:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609777365; bh=WNcE0v5B3WJ7uceBo+UgtbucUoJ7gDeBpXsMk+E6MG8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Kmu3WBT1bF64vEAPDM0CiGKZ9oYqNKQq6HJe5EA16qn5XuIlhYJBNvGOJqU3T7u34 O1M59tWL/zAz+pI00aOg0J7FqSTYtA80hlbbQOGaS7xRqdKmCxyyrO3jX9GSai51Mo p/vygGC35yKFdX42l3reBljaDBWf2H223LmenIgI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.15]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MBUqL-1kqBdy25fz-00Cy7t; Mon, 04 Jan 2021 17:22:45 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: From: martin rudalics Message-ID: <8af92126-3e57-66c0-08e9-b0b5326fa538@gmx.at> Date: Mon, 4 Jan 2021 17:22:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Iga+wE2fNobC5IlTcghW6ROb3IKwOe3hIIDsr6jnqvmf+ETHbqU 6d4eRfKUoF9hoWkjH2SIo/0C5aH0c8+DC1MhI8SxF96ZWyxftM47xUeOfNbth3rLhWMYhQz jidnAvMEern6fp640Wx5mLOgEt1g+LuAlrjt9Hk1k63UxGrcOjKKE5/bPOtI99CBjZRCOHb ybC6R6sN6Po20ztIin2ow== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Yh75fMbcWI4=:9dBjICyVhKtxet0nWHJbVn 38pyPINmpRsH1r/JrGVADscqDCoO4mLzcjxk6nFtOaZZPyG0vFfoP9d+pwX4WByTgzH1/mdYN NsTQ+32GhAutawlzsWkRk7yejxlW2zlMmdVXRxT1O7uiRpjutaF2FAE1txQkYnpkvfOjSHjnB Lma7fZou5PnoDdCC5BQiYnV1Kf+IXmXkdbbddE8yIf3z3lWr3ICVQSWVJP7lGHQgDEcDWUop+ IuU6XIYa4fvqz2srnqA++/zBHmEISSwUFloqJODSe2w3BQFA4ur5aNsBKzd123b/aRX9ujEIo hteQ2DPbHjt4rRFpfY7k2eKSx2IrT1hQie4fBjmcS6QP1tm3swboVYcugh9SnKJETqJMi7e+R LN0GQTJ6Qzq9VAMtNuE4KdPg8ECkQ+WZ/kIiQYkm3rPwn99FHAEYFQdeBbBzXPgPah9UrPfhd Ei2FDK7f9FbuGsBmLNN8UzkMjvDHOSPSM6TMLj4V/ULRRciAzYDKz+e8WqdMD86660kCutcFa 5LViMjVQErJqo5DwYk6oPZM+saRNXWkisAWxHRT18zHEICw5lT44DKNOt4DlL5pQF1QICEtk8 X30qoLsUnGT8hu/H5bU9sG+jVbLDkOwxUlM2PZ/2pDrUE0UpVHX5d/UlvV7P4m7NeBdi7xNlm ZnqycFAfqcqKB0myTv1BETuYZKUnp+x5BJW4WIZj+Po6TEvWKQkydS2QYtxbhNEmBl1aXQWYN ZS9G+QrQK/PlVOTLeCrY2cgmoUde3Pljy6ChMyJCOTZtspa/lgXyJqYDzrm6MRnyxkPofibee 8iBAsC7BBLPHZLu54PyZQbO82y+FylZq9aZKTpG4Ws9ZKSkKsOiQTLi1SuLJEDkYwVdMZf/KQ iro1vq0UJnmtVIhTeYuQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > What customisations are you referring to? I cannot think of any > scenario, other than changing and reloading your theme, that could > change the settings of already present child frames. Here I'm using a child frame for popping up the minibuffer with the customization (defcustom pop-up-mini-internal-border "blue" "Background of internal border of 'pop-up-mini-frame'." ... and the form (set-face-background 'internal-border pop-up-mini-internal-border pop-up-mini-frame) to put it into practice when setting up such a frame. This works fine until I do M-x customize-face RET internal-border RET. As soon as I apply the value I customized there, my minibuffer child frame gets that border instead of the one specified via 'pop-up-mini-internal-border' above. > > If I'm not mistaken we use that face for our tooltip frames too which > > means one more conflict. > > Partially. On my system the internal-border colour and width only > applied to the top and left sides of the tooltip frame. Yes. I think there's a bug somewhere but the only time I tried to locate it, I decided that someone else intentionally does it that way. > Packages do have the choice, they just have to make sure to override the > frame-local faces whenever they show something. The problem, as I see > it, is that they *have to* create a face to override the local > internal-border, instead of just having the option to do it, because > themes cannot offer a general setting, like an easily visible dark > border on a bright foreground, because they run into the frame margin > colour conflict like modus did in the linked issue. So if a package > doesn't overwrite the local internal-border your default look-and-feel > is a badly visible same-colour-on-same-colour popup. Agreed. On a historical note, I had to add the entire internal border entertainment to child frames because neither gtk nor X bother to supply the normal window manager border for them (Windows does) and so you can neither make them stand apart easily nor can you resize them with the mouse. Implementing the latter from within Emacs was even very entertaining. I intentionally left the border color alone because I'm convinced that customizing it is a bad idea as sketched in the above scenario and packages should always try their own way to specify it. > > So what should we do? Provide a separate 'child-frame-internal-border' > > face and then probably also a 'tooltip-internal-border-face'? > > That would be perfectly good enough for themes like modus, yes. Can you propose a patch? Look at where we use INTERNAL_BORDER_FACE_ID to set up a face (x_clear_under_internal_border in xterm.c is an example), check f for child-frameness there and use the new face if the frame is a child frame. But be aware: Users like me will then have to separately set the background for the child frame face so you might get incompatibility complaints ... martin From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 12:43:06 2021 Received: (at 45620) by debbugs.gnu.org; 4 Jan 2021 17:43:06 +0000 Received: from localhost ([127.0.0.1]:60192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwTso-0004Ta-2m for submit@debbugs.gnu.org; Mon, 04 Jan 2021 12:43:06 -0500 Received: from mout.web.de ([212.227.15.14]:58825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwTsm-0004T5-JG for 45620@debbugs.gnu.org; Mon, 04 Jan 2021 12:43:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609782178; bh=Mqw7RYINajh54a5NE+LRv/Muv/vPp/k3WNQNOJUQXQw=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=OpoEC6d+7lrCEAoNAWNKdaw0K2HAyIbAwWaPKCMvC2c4dM65wDBVK1RKrNvKrL+++ 2rwjKNg7pj8F/vJYs9d7hrTjwA045Nfr89gnhTBKOA7tCbC8H+R86y10g356wIh5DH P5Ba24oB8VcREIaFoOOJ3g+uGbycc02HJ5lZMtAk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MNLAn-1ktzqd0tTt-006t6q; Mon, 04 Jan 2021 18:42:58 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: <35f3b179-5e1f-e327-d909-6d934092b01d@web.de> Date: Mon, 4 Jan 2021 18:48:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Provags-ID: V03:K1:bE/UtfGqRE03AWzyUyy3D3BqYejywoxxg8ZM7ENOm11JBNSj1VC zBrTMXTwBBlV0xpvmaygXHzgJ7F8UXmwYJTtaqqx7YJbmjq7Er21FGGbE/9kCDLOUjxi4Wn Y5tpQwMGt5gaafoPmCrdwuDauCK17S6myW1I1r9ApNKZIlWDQlKpuD+HzFzmB7QyYzpT7th VZ0mT9muz1o77tYyikieQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:lSNi0XbST3U=:zOYUrFd9Q2+aZgRvDSY8Su XiohRYvwivJHrSyBOVoF6B78xrpRDy7Jm9j+ObhyXAnduyLN0K0wZAGSnro181Cl9sUfGsK4H 4giwRNk/qYZxw5H4r026GZc9Y/HR07KjKMMAsC2hYg/ACDFTsUwkkq5Y3/bIADBWtmZqgQSgK gS/afYKVBtnrzvBvAoZGY/FP8XxbHDaahHIalmi05kRCN91gchSWMfRZNl1BFN6/2O8l6/o0I eqwjNjt2FlMXur7TRhrCXqz0QWWBSQJH7yQ6be/EgQZ9Ed7egBVcrI4sQmS4IgXBzAtH2xuHS bMeut+P/TTXYtMBL6x9lMLSrXWE0YrPgeZnOfeH3J+9822NEiT5Q73RmfmFvo8XaaJsEZ9E7v evn1Z6ppQ85lTpNuKXg8Ht1/0VfzOUKNw37XZXPJeqg5QanRLXq1bZGVcVJJ+hud5Z8b/6AXN oWwMOX6Ci6O6Q7vdfwdd06KNmbmZ/nQAo14PC6HaZykxsa/GsWtsI8S2B+sGIdHZ+oJGUyRvN JqnMuDAkt+bqly8nvwNBBWgnR+/4dHL7b9ty/1Och9Lhm497IEC2DNu1K8pj/xw+JmVSNzpHF DY+bAlpQtnC26vR+PnedMBf59wnorhU7wXnTDMIReVH23XEnUOT6tD/m3/eoIs+XOzEOiwzto xcLK/WCz7QYc3+EEuYBB5PI9Qd/ZkNUgaMhdh7ckBWMZHr/o6YYedH4vu8TQhaSFNFuQuhMcs LFE2li7RGPK9C4GfDzUYlMq/rH/XS2akgLUhRdP7LRLi75y46xGY10BV/tTctr6ConHVp/Dh9 ehN4chukJfNc4oSbUBxjbOsTCqvmXH8EHTl0CxZMcC7wtc94Q9Sb6Ieul6OQ2I3Byr8XCB4T9 vE+s1rFFn7XyhOOxSbtA== X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > As soon as I apply the value I customized there, my minibuffer child > frame gets that border instead of the one specified via > 'pop-up-mini-internal-border' above. Personally I would think this behaviour is mildly inconvenient at worst, but hardly a real problem. It's just a new global default overriding local customisations. Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.14 listed in wl.mailspike.net] 2.8 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > As soon as I apply the value I customized there, my minibuffer child > frame gets that border instead of the one specified via > 'pop-up-mini-internal-border' above. Personally I would think this behaviour is mildly inconvenient at worst, but hardly a real problem. It's just a new global default overriding local customisations. Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.14 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.8 FAKE_REPLY_A1 No description available. > As soon as I apply the value I customized there, my minibuffer child > frame gets that border instead of the one specified via > 'pop-up-mini-internal-border' above. Personally I would think this behaviour is mildly inconvenient at worst, but hardly a real problem. It's just a new global default overriding local customisations. And that is only if I manage to run into the situation in the first place - I am not usually in the habit of customising frame border faces, and I don't think many other people are, either. So from my perspective I don't really see the danger (or annoyance) in this behaviour. > Can you propose a patch? I can *try*. I am absolutely not a C programmer, but as long as the task is limited to a monkey see, monkey do situation for handling a new face I should be able to hammer something useful together. In fact my first attempt seems to compile and behave as expected, so I have a few questions on how to proceed: - I need to repeatedly use a pattern that looks like this: int is_child_frame =3D FRAME_PARENT_FRAME(f) !=3D NULL; int border_face_id =3D is_child_frame =C2=A0=C2=A0 ? CHILD_FRAME_BORDER_FACE_ID =C2=A0=C2=A0 : INTERNAL_BORDER_FACE_ID; int face_id =3D !NILP (Vface_remapping_alist) =C2=A0=C2=A0 ? lookup_basic_face (NULL, f, border_face_id) =C2=A0=C2=A0 : border_face_id; and I would like to put it into a single function accessible from anywhere. Is that the right call, and if yes, where would be the right place to put it? - Currently the actual width of the border is still controlled by the `internal-border-width` parameter for both frame types. Should I try to do something about that as well? If yes, what's my entry point? - I think I'll need to sign the FSF copyright assignment, unless the limit is higher than the 15 lines I am remembering. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 13:54:36 2021 Received: (at 45620) by debbugs.gnu.org; 4 Jan 2021 18:54:36 +0000 Received: from localhost ([127.0.0.1]:60289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwUzz-0006Sz-Ov for submit@debbugs.gnu.org; Mon, 04 Jan 2021 13:54:36 -0500 Received: from mout.gmx.net ([212.227.17.20]:45605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwUzx-0006Sl-Vh for 45620@debbugs.gnu.org; Mon, 04 Jan 2021 13:54:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609786464; bh=LNktjEmdQC/GXuSovlnb7vJc9r51ot4yJlymzgQNxfw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=SOZgiImiebPZtLmof0GwK6i8mq0GWsyfgHT6mdNjnqBPc2bNFoVnKU87py9IIiie4 OsqunNgU82fLGTdeDLURNUeNvz7hsQ9I46Ft8s9V0Wi8zvZh2L1dYq8wIrOR/g9sWT zjgyIDyAPFpce3ORqWU0Y+ADlnTmzXYJDrtMHcf8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.15]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvK4f-1k5Uu11RI1-00rGyJ; Mon, 04 Jan 2021 19:54:24 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: <35f3b179-5e1f-e327-d909-6d934092b01d@web.de> From: martin rudalics Message-ID: <000f7dc3-8d6a-a1ba-3f63-b5dd33bb10d6@gmx.at> Date: Mon, 4 Jan 2021 19:54:22 +0100 MIME-Version: 1.0 In-Reply-To: <35f3b179-5e1f-e327-d909-6d934092b01d@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:lg0U5VcMrkEh+QVNbCqYyFb5jXaFFqItV+AnnqsGbSkJ656+9rL pZdu3d/XRJtWG7wL3QKrlOsB/aXdOZeIWbvLWHo9LnRO8RTWHBCrTyWFKNbfSSanTChBwyj 3gf/flsfFb12nV/5nXEOL9iRHEKD3LLXi6OBB0AFEZEJcmmvKyj8cbtV/gXtb8XNihtHBUK Z4XfRmYFuOeuMoV4k6cIg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:SdUm01RjIUQ=:J5nVBFi2xa0MpNVpnEF20A i9mW/x6S+wmXtVHsClXkERDxpeqY3VrHAwevKNntrcIpbaRi7lt3kpYOTM/xJg1atSoMhkxyw 9FBCTDAdAvdFmdi0kWkuMdttwd10qwoPjbLcuKhbvqCH7asifbKalkJZBpxydPo6wVS6jdUoF 9Jx2nVzX6dLzgXotCzNJ0DaN38InHoMkYEpMEhf5+EVRp567wK5WM3DfRVgacyTQWcl3DjX/h Kuw6s0YLRaHszrps+B8aq3lThGrdj//rVWM8b17aDaddWplZ3a7Tww53OcL0Jwobk2/p/IO1L tg0wKLbVBW18nYuz4XEo+75xtr6eN7FKOrLCxPzd1QwosVABR9t8Y4bpPOijM0Jp2dFbjiZoN rDYCtbX1R1HuNRm2uQmCN8yCxgkHrHywIu7GxEYK2DtGi7VdTw5396IpJLg81g+iJLGf2AP9W KgN7tremN2BbMnj30VcDtFMzB63rIo8M5DQzz+9V9ckCWrQnS8tyPqtLyPs0avBhK35nDkmwN QVf+jkCkEFCFf3iigRNW832fXII1+AOodmg3R9BWr0vbJtBDisuXyohLXC+Uo/H9nP6+UT6Ot mTfZwp7dcfFeiOyb83WKK+uEy+T15ZqtqTZogCJ70wrPVdpj7W17VbFoIoQX5ja5GuZscks7J 6IGQWKJIF+VFZ76c95rZIcN1cCSbogB9SSiVFLRJYGrdSXRz0ZqKrrPOCvl6xStHU16j0CsdW Oxax4Np67iLJwS+T2GIIcOsV8cQuSEb4oPpDkju7FaZmikgOose2IZELWDJ1zuizOiMdgNub9 jN7X65oDXuEOmjEr8GheFynWT0bYAsOuGAtFAhJNERWShDPJscrzY0Uj0Qq89r8KRGrlvG7go N1rDxv9+y1Vr8pnaeCVQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, Feng Shu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > Can you propose a patch? > > I can *try*. I am absolutely not a C programmer, but as long as the task > is limited to a monkey see, monkey do situation for handling a new face > I should be able to hammer something useful together. That's one way to become a C programmer ... > In fact my first attempt seems to compile and behave as expected, so I > have a few questions on how to proceed: > > - I need to repeatedly use a pattern that looks like this: > > int is_child_frame = FRAME_PARENT_FRAME(f) != NULL; In that case you should make is_child_frame a bool and not an int. But it's much simpler to just test for FRAME_PARENT_FRAME (f) wherever you see a need for is_child_frame like in > int border_face_id = is_child_frame int border_face_id = FRAME_PARENT_FRAME (f) > ? CHILD_FRAME_BORDER_FACE_ID > : INTERNAL_BORDER_FACE_ID; > int face_id = !NILP (Vface_remapping_alist) > ? lookup_basic_face (NULL, f, border_face_id) > : border_face_id; > > and I would like to put it into a single function accessible from > anywhere. Is that the right call, and if yes, where would be the right > place to put it? This is the first time I see the internal border face getting remapped. I wasn't aware that nsterm.c does that and I'm not sure whether we should add something similar to xterm.c and w32term.c. In nsterm.c I would not write an extra function but instead of what we have now use int face_id = (FRAME_PARENT_FRAME (f) ? (!NILP (Vface_remapping_alist) ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) : CHILD_FRAME_BORDER_FACE_ID) : (!NILP (Vface_remapping_alist) ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) : INTERNAL_BORDER_FACE_ID)); and in lookup_basic_face in xfaces.c you'd then have to add case CHILD_FRAME_BORDER_FACE_ID: name = Qchild_frame_border; break; It's augmenting forms like that last one that get the most obscure bugs, so don't despair. > - Currently the actual width of the border is still controlled by the > `internal-border-width` parameter for both frame types. Should I try to > do something about that as well? If yes, what's my entry point? Add a 'child-frame-border-width' parameter. But in this case I would propose to proceed as follows: - If for a frame the 'child-frame-border-width' was explicitly set, use it. - If it was not set, use the 'internal-border-width' parameter. Note that people have already set up their own child frame creation routines and we should try to not punish them too much. And please try to discuss this on the list you cited earlier and also with the posframe.el designer. Mister Feng Shu you've inevitably become a participant of this thread now. > - I think I'll need to sign the FSF copyright assignment, unless the > limit is higher than the 15 lines I am remembering. I think so too. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 07:45:12 2021 Received: (at 45620) by debbugs.gnu.org; 5 Jan 2021 12:45:12 +0000 Received: from localhost ([127.0.0.1]:41053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwli4-0008Bq-06 for submit@debbugs.gnu.org; Tue, 05 Jan 2021 07:45:12 -0500 Received: from mout.web.de ([212.227.17.12]:53089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwli1-0008BF-Gv for 45620@debbugs.gnu.org; Tue, 05 Jan 2021 07:45:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609850691; bh=jRDAVjMGIQ9jwuwI5WGnJ2HSeUw3ARp++cgPrtMbzvA=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=PCvRhX34kSjFTp/V+16hvsPEogtsbnoN1rjUVsjBWUmymcv1Ywntx0i9Ex5e9Qkvf h9jJrwELwgoVq/1glpMg/73dsPlOhvfN7+qgnmTvpLplEFZRwzNBeejc0bFmFQzbfv rmogxhuWeqiYlNHQkPuSBXd61AoGjnleg2deK2+E= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Ml4B4-1kG1yY3pSm-00lRIH; Tue, 05 Jan 2021 13:44:51 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> Date: Tue, 5 Jan 2021 13:50:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------EF81FC4DEFDA1E52D80AABA6" Content-Language: en-US X-Provags-ID: V03:K1:5vQxHGctm6PkbnbesGxtkLDUMBVDbzQxQHi7kRCMcn+BOhNXBeh UNeb3jw3MZIHfH9AT0Gpm9W62VAkcKaAkwqmUSrvLQIbqMLwud2Lk+sMb075Sp9DHhuvznf szu0596ZBIBPP30ZwvSC4oTnxz5oaz2kwTcyoMZXb+aNtlZgrP0VCVoa6pGvdFhjBJRP2mS gBnecg3ZXBfZWBus47q3A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1Yu+H3lbRFg=:rqgOBf36nonoiEJFLbQn+5 y7SmMDXSoQ89CjAOAbL8LeHKAObJbRRhShJEjPfmQyYiN9K5NwWHoPaW8QQYnDuvEALofZni8 +6Wq8S2egO3/5HSudxlcVHdBEIIG1NbFgw0USemOKCJyWGHWA8lEYvYpcBw1o03tcDkOFKRAe 0PnKhcI0OSZkeBbR30bDBqKnkY9/BJDM9T8ZomXm786VoEwp02ioXmx/F1ogfMYqpYNByaNR0 xo6ulFDuFdNheuBD1WLl5GhnExOQpoeF84Zr0iVvq5O+yDXPlepHzIriYhlHP15gtxw+FCxXg 4LNq317rFU7iodGdxJOiHw04RCaen6qZ3Ww3XvVkT7X6eh2LGjDZr4AUlM50tne+yjCBKQH0j Vn8qkUWMOE4PsP/EGTRFZUXSI4okY6ZTTUsTpXnsmmA09q6Sg9fuUL8dwZztRD1OsM8/WriGP 2pJMhOHoC2hKyIO/oxbUukEuhZS5ZLiQSTDCDbn3NVCPQI4OoSn3NgrF5VcDBQRG9rsIL3tNt xkAlfhnP9lN1sXB8U3nBRvRS3vhVpIG7/QD0E9E28/DgItqwXTp52BD9kvcEdSh8qvV7eNwTl SIk6S9cqIetskqvc8NQ4CwowGJsS28ard7pFrNup3w/41TzAPtFMEvynKGxB+9gYn9suxmQyI z4fN0B0hkAaaiHn1hw129YM8pwyLTkTp+vmmjAKuCYn5axQ1ak0aOc36H3P0Nn0kJoezbzGdd GMcbgxR3LBSaOv/MkjgClrTrzGBO1iRUZpe/sQsMC707ot/0KCTlBR8CDOr+KxzmR4OTMzIfS ubdGEAOupPUNjxlrikI/q7nPnsbH67G1hSmB8TvNcSlVeGVJE7Y4jBuFFtBPB4XK1eC1nm0zX 1L6t9oRO9M0VUGTu+DVg== X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>> Can you propose a patch? >> >> I can *try*. I am absolutely not a C programmer, but as long as the task >> is limited to a monkey see, monkey do situation for handling a new face >> I should be a [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.12 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>> Can you propose a patch? >> >> I can *try*. I am absolutely not a C programmer, but as long as the task >> is limited to a monkey see, monkey do situation for handling a new face >> I should be a [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.12 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. This is a multi-part message in MIME format. --------------EF81FC4DEFDA1E52D80AABA6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable >>> Can you propose a patch? >> >> I can *try*. I am absolutely not a C programmer, but as long as the task >> is limited to a monkey see, monkey do situation for handling a new fac= e >> I should be able to hammer something useful together. > > That's one way to become a C programmer ... To be honest I've don't really like C as a language, and learning it would not do anything professionally for me either. So I'm jumping into this strictly for the sake of improving Emacs. >> and I would like to put it into a single function accessible from >> anywhere. Is that the right call, and if yes, where would be the right >> place to put it? > > This is the first time I see the internal border face getting remapped. > I wasn't aware that nsterm.c does that and I'm not sure whether we > should add something similar to xterm.c and w32term.c. In nsterm.c I > would not write an extra function but instead of what we have now use > > int face_id =3D > (FRAME_PARENT_FRAME (f) > ? (!NILP (Vface_remapping_alist) > ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) > : CHILD_FRAME_BORDER_FACE_ID) > : (!NILP (Vface_remapping_alist) > ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) > : INTERNAL_BORDER_FACE_ID)); x, ns and w32 all used the same code, so I changed them all to look like this now. >> - Currently the actual width of the border is still controlled by the >> `internal-border-width` parameter for both frame types. Should I try t= o >> do something about that as well? If yes, what's my entry point? > > Add a 'child-frame-border-width' parameter. But in this case I would > propose to proceed as follows: > > - If for a frame the 'child-frame-border-width' was explicitly set, use > it. > > - If it was not set, use the 'internal-border-width' parameter. That's done now too, at least for X. I'll attach patches of my first working drafts for both changes. Let me know if I'm on the right path so far. >> - I think I'll need to sign the FSF copyright assignment, unless the >> limit is higher than the 15 lines I am remembering. > > I think so too. > Ok, what do I do? --------------EF81FC4DEFDA1E52D80AABA6 Content-Type: text/x-patch; charset=UTF-8; name="0001-WIP-child-frame-border.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-WIP-child-frame-border.patch" =46rom 50e3d31abf4bd12e24f82bb2f8e39ec1c3c073e0 Mon Sep 17 00:00:00 2001 From: Alexander Miller Date: Tue, 5 Jan 2021 11:33:31 +0100 Subject: [PATCH 1/2] WIP child-frame-border =2D-- lisp/faces.el | 11 ++++++++++- src/dispextern.h | 1 + src/nsterm.m | 10 +++++++--- src/w32fns.c | 10 +++++++--- src/xfaces.c | 3 +++ src/xterm.c | 20 ++++++++++++++------ 6 files changed, 42 insertions(+), 13 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index 4e98338432..639dbeb09a 100644 =2D-- a/lisp/faces.el +++ b/lisp/faces.el @@ -2683,11 +2683,20 @@ window-divider-last-pixel (defface internal-border '((t nil)) - "Basic face for the internal border." + "Basic face for the internal border. +For the internal border of child frames see `child-frame-border'." :version "26.1" :group 'frames :group 'basic-faces) +(defface child-frame-border + '((t nil)) + "Basic face for the internal border of child frames. +For the internal border of non-child frames see `internal-border'." + :version "28.1" + :group 'frames + :group 'basic-faces) + (defface minibuffer-prompt '((((background dark)) :foreground "cyan") ;; Don't use blue because many users of the MS-DOS port customize diff --git a/src/dispextern.h b/src/dispextern.h index 3ad98b8344..f4e872644d 100644 =2D-- a/src/dispextern.h +++ b/src/dispextern.h @@ -1826,6 +1826,7 @@ #define FACE_UNIBYTE_P(FACE) ((FACE)->charset < 0) WINDOW_DIVIDER_FIRST_PIXEL_FACE_ID, WINDOW_DIVIDER_LAST_PIXEL_FACE_ID, INTERNAL_BORDER_FACE_ID, + CHILD_FRAME_BORDER_FACE_ID, TAB_BAR_FACE_ID, TAB_LINE_FACE_ID, BASIC_FACE_ID_SENTINEL diff --git a/src/nsterm.m b/src/nsterm.m index 2defb9e2ee..76f67d2531 100644 =2D-- a/src/nsterm.m +++ b/src/nsterm.m @@ -3029,9 +3029,13 @@ so some key presses (TAB) are swallowed by the syst= em. */ NSRectEdge edge[] =3D {NSMinXEdge, NSMinYEdge, NSMaxXEdge, NSMaxYEd= ge}; int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); if (!face) diff --git a/src/w32fns.c b/src/w32fns.c index c1e18ff7fa..061886f0bc 100644 =2D-- a/src/w32fns.c +++ b/src/w32fns.c @@ -1519,9 +1519,13 @@ w32_clear_under_internal_border (struct frame *f) int width =3D FRAME_PIXEL_WIDTH (f); int height =3D FRAME_PIXEL_HEIGHT (f); int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); block_input (); diff --git a/src/xfaces.c b/src/xfaces.c index b3b19a9cb2..5080120957 100644 =2D-- a/src/xfaces.c +++ b/src/xfaces.c @@ -4913,6 +4913,7 @@ lookup_basic_face (struct window *w, struct frame *f= , int face_id) case WINDOW_DIVIDER_FIRST_PIXEL_FACE_ID: name =3D Qwindow_divider_fir= st_pixel; break; case WINDOW_DIVIDER_LAST_PIXEL_FACE_ID: name =3D Qwindow_divider_last= _pixel; break; case INTERNAL_BORDER_FACE_ID: name =3D Qinternal_border; break; + case CHILD_FRAME_BORDER_FACE_ID: name =3D Qchild_frame_border; break= ; default: emacs_abort (); /* the caller is supposed to pass us a basic face i= d */ @@ -5619,6 +5620,7 @@ realize_basic_faces (struct frame *f) realize_named_face (f, Qwindow_divider_last_pixel, WINDOW_DIVIDER_LAST_PIXEL_FACE_ID); realize_named_face (f, Qinternal_border, INTERNAL_BORDER_FACE_ID); + realize_named_face (f, Qchild_frame_border, CHILD_FRAME_BORDER_FACE= _ID); realize_named_face (f, Qtab_bar, TAB_BAR_FACE_ID); realize_named_face (f, Qtab_line, TAB_LINE_FACE_ID); @@ -6967,6 +6969,7 @@ syms_of_xfaces (void) DEFSYM (Qwindow_divider_first_pixel, "window-divider-first-pixel"); DEFSYM (Qwindow_divider_last_pixel, "window-divider-last-pixel"); DEFSYM (Qinternal_border, "internal-border"); + DEFSYM (Qchild_frame_border, "child-frame-border"); /* TTY color-related functions (defined in tty-colors.el). */ DEFSYM (Qtty_color_desc, "tty-color-desc"); diff --git a/src/xterm.c b/src/xterm.c index 0a86738cc2..92dcd95043 100644 =2D-- a/src/xterm.c +++ b/src/xterm.c @@ -1293,9 +1293,13 @@ x_clear_under_internal_border (struct frame *f) int height =3D FRAME_PIXEL_HEIGHT (f); int margin =3D FRAME_TOP_MARGIN_HEIGHT (f); int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); block_input (); @@ -1360,9 +1364,13 @@ x_after_update_window_line (struct window *w, struc= t glyph_row *desired_row) { int y =3D WINDOW_TO_FRAME_PIXEL_Y (w, max (0, desired_row->y)); int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); block_input (); =2D- 2.29.2 --------------EF81FC4DEFDA1E52D80AABA6 Content-Type: text/x-patch; charset=UTF-8; name="0002-WIP-child-frame-border-width.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-WIP-child-frame-border-width.patch" =46rom b176909995eea600d99354be2127469f472ce4bb Mon Sep 17 00:00:00 2001 From: Alexander Miller Date: Tue, 5 Jan 2021 13:31:09 +0100 Subject: [PATCH 2/2] WIP child-frame-border-width =2D-- src/frame.c | 4 ++++ src/frame.h | 14 +++++++++++++- src/xfns.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 67 insertions(+), 5 deletions(-) diff --git a/src/frame.c b/src/frame.c index 45ee96e962..d5040dfae6 100644 =2D-- a/src/frame.c +++ b/src/frame.c @@ -3744,6 +3744,7 @@ DEFUN ("set-frame-window-state-change", Fset_frame_w= indow_state_change, {"foreground-color", -1}, {"icon-name", SYMBOL_INDEX (Qicon_name)}, {"icon-type", SYMBOL_INDEX (Qicon_type)}, + {"child-frame-border-width", SYMBOL_INDEX (Qchild_frame_border_width)}, {"internal-border-width", SYMBOL_INDEX (Qinternal_border_width)}, {"right-divider-width", SYMBOL_INDEX (Qright_divider_width)}, {"bottom-divider-width", SYMBOL_INDEX (Qbottom_divider_width)}, @@ -4287,6 +4288,8 @@ gui_report_frame_params (struct frame *f, Lisp_Objec= t *alistptr) store_in_alist (alistptr, Qborder_width, make_fixnum (f->border_width)); + store_in_alist (alistptr, Qchild_frame_border_width, + make_fixnum (CHILD_FRAME_BORDER_WIDTH (f))); store_in_alist (alistptr, Qinternal_border_width, make_fixnum (FRAME_INTERNAL_BORDER_WIDTH (f))); store_in_alist (alistptr, Qright_divider_width, @@ -5984,6 +5987,7 @@ syms_of_frame (void) DEFSYM (Qhorizontal_scroll_bars, "horizontal-scroll-bars"); DEFSYM (Qicon_name, "icon-name"); DEFSYM (Qicon_type, "icon-type"); + DEFSYM (Qchild_frame_border_width, "child-frame-border-width"); DEFSYM (Qinternal_border_width, "internal-border-width"); DEFSYM (Qleft_fringe, "left-fringe"); DEFSYM (Qline_spacing, "line-spacing"); diff --git a/src/frame.h b/src/frame.h index 8cf41dc004..7d816f2516 100644 =2D-- a/src/frame.h +++ b/src/frame.h @@ -534,6 +534,10 @@ #define EMACS_FRAME_H /* Border width of the frame window as known by the (X) window system. = */ int border_width; + /* Width of child frames' internal border. Acts exactly like + internal_border_width below and will fall back on it when not set.*/ + int child_frame_border_width; + /* Width of the internal border. This is a line of background color just inside the window's border. When the frame is selected, a highlighting is displayed inside the internal border. */ @@ -1432,11 +1436,19 @@ FRAME_TOTAL_FRINGE_WIDTH (struct frame *f) return FRAME_LEFT_FRINGE_WIDTH (f) + FRAME_RIGHT_FRINGE_WIDTH (f); } +INLINE int +CHILD_FRAME_BORDER_WIDTH (struct frame *f) +{ + return frame_dimension (f->child_frame_border_width); +} + /* Pixel-width of internal border lines. */ INLINE int FRAME_INTERNAL_BORDER_WIDTH (struct frame *f) { - return frame_dimension (f->internal_border_width); + return f->child_frame_border_width + ? CHILD_FRAME_BORDER_WIDTH(f) + : frame_dimension (f->internal_border_width); } /* Pixel-size of window divider lines. */ diff --git a/src/xfns.c b/src/xfns.c index 9ab537ca8d..663146d7f2 100644 =2D-- a/src/xfns.c +++ b/src/xfns.c @@ -1800,6 +1800,28 @@ x_change_tool_bar_height (struct frame *f, int heig= ht) #endif /* USE_GTK */ } +static void +x_set_child_frame_border_width (struct frame *f, Lisp_Object arg, Lisp_Ob= ject oldval) +{ + int border =3D check_int_nonnegative (arg); + + if (border !=3D CHILD_FRAME_BORDER_WIDTH (f)) + { + f->child_frame_border_width =3D border; + +#ifdef USE_X_TOOLKIT + if (FRAME_X_OUTPUT (f)->edit_widget) + widget_store_internal_border (FRAME_X_OUTPUT (f)->edit_widget); +#endif + + if (FRAME_X_WINDOW (f)) + { + adjust_frame_size (f, -1, -1, 3, false, Qchild_frame_border_width); + x_clear_under_internal_border (f); + } + } + +} static void x_set_internal_border_width (struct frame *f, Lisp_Object arg, Lisp_Objec= t oldval) @@ -3897,14 +3919,37 @@ DEFUN ("x-create-frame", Fx_create_frame, Sx_creat= e_frame, parms =3D Fcons (Fcons (Qinternal_border_width, value), parms); } + /* Same for child frames. */ + if (NILP (Fassq (Qchild_frame_border_width, parms))) + { + Lisp_Object value; + + value =3D gui_display_get_arg (dpyinfo, parms, Qchild_frame_border_= width, + "internalBorder", "internalBorder", + RES_TYPE_NUMBER); + if (! EQ (value, Qunbound)) + parms =3D Fcons (Fcons (Qchild_frame_border_width, value), + parms); + + } + + gui_default_parameter (f, parms, Qchild_frame_border_width, +#ifdef USE_GTK /* We used to impose 0 in xg_create_frame_widgets. */ + make_fixnum (0), +#else + make_fixnum (1), +#endif + "childFrameBorderWidth", "childFrameBorderWidth", + RES_TYPE_NUMBER); gui_default_parameter (f, parms, Qinternal_border_width, #ifdef USE_GTK /* We used to impose 0 in xg_create_frame_widgets. */ - make_fixnum (0), + make_fixnum (0), #else - make_fixnum (1), + make_fixnum (1), #endif - "internalBorderWidth", "internalBorderWidth", - RES_TYPE_NUMBER); + "internalBorderWidth", "internalBorderWidth", + RES_TYPE_NUMBER); + gui_default_parameter (f, parms, Qright_divider_width, make_fixnum (0), NULL, NULL, RES_TYPE_NUMBER); gui_default_parameter (f, parms, Qbottom_divider_width, make_fixnum (0)= , @@ -7762,6 +7807,7 @@ DEFUN ("x-gtk-debug", Fx_gtk_debug, Sx_gtk_debug, 1,= 1, 0, x_set_foreground_color, x_set_icon_name, x_set_icon_type, + x_set_child_frame_border_width, x_set_internal_border_width, gui_set_right_divider_width, gui_set_bottom_divider_width, =2D- 2.29.2 --------------EF81FC4DEFDA1E52D80AABA6-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 10:33:23 2021 Received: (at 45620) by debbugs.gnu.org; 5 Jan 2021 15:33:23 +0000 Received: from localhost ([127.0.0.1]:42453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwoKp-0000L4-EV for submit@debbugs.gnu.org; Tue, 05 Jan 2021 10:33:23 -0500 Received: from mout.gmx.net ([212.227.15.19]:37727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwoKo-0000Kq-C4 for 45620@debbugs.gnu.org; Tue, 05 Jan 2021 10:33:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609860786; bh=yoJhMiVxaqMjSZVFhQ9fV/wApLG9e12HMj3E7cxYRGM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZppFXxW/vc9oL01PEVcRFWHL+ZBS4tm4YvE0AiuAAam3PTkxRbJ5BCd09wNAijBAw qI4yLurPpM9AY7bFuwxFLH4stFshdpXwTlzULR+KzE5WY+VJqkujISOjUhl5C66S2W ZPG2H1OKJa6exCiz4mT+SMSPdvOBa82aqp1MoTBc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.231]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mof9P-1kCoOJ2ovp-00p4dK; Tue, 05 Jan 2021 16:33:06 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> From: martin rudalics Message-ID: <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> Date: Tue, 5 Jan 2021 16:33:05 +0100 MIME-Version: 1.0 In-Reply-To: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:5aqltkapmNh0T6Drq0VQS9gRUj2/eL2sNKS/vOPqPSq/SBha0+o PdfYG5FDlnGz+IvnseM7x8ybQ2nzq7eGpChYtk1aSXUTfpmjbQbnMwIeoq0Wp4j3Ib861Wm YYKJwTy02eXdLrBwaFycACznTH2LpLKXEsm/8TBWCBzjN84QrQD816+2QNn0duzl95qEKad E0cljIfOq43UFqfD8e7Zw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:pkJLkkm0Fr0=:Ay/Qhs6qpVol9LQzADSVaE segk7qSAf6QAYfICjukbk1ed66CTmL9BZle92vDRCG2/KZrT+FreatRnVv8uReELMct99CeQ/ iTWSuwJVmkSaL/ZpXB2ok8P7FyNIxNF2xfhM5n4O0qx/cQCrBw6E8mCjSAP8X03IZMZK45roQ 1eyeHPmbiAanLC+eYtYnFKB1dqI8e1HlhZtXc95T2px5jpE58SGecK710ARO7S5uBdQm8DDo8 oWLEBSZrx2HmB+n1V144GGlCWLqu9NKW7b44biCCYsER2aC3g3XHHLe9DOVAdZb4Aa8p3QD+r 0O5Ve2V9FXixj4tiFh6erQJ1s+AcGjAumbRA3EWexB1X2+6cuyuUyL2mj15CnmGYfhooDXNc0 aKqAL1aKdG+oaL83exMV1xPBzZp0gqU6smiPmuoyxVA4AvtAE4xtiXEramdistPrEPB9e3T2F 58bA2lQ6Uk9udF73B1u9sV/R9WgBS2aMySImCTKlrWot3lPi8nwXxn6MA/N5W9skVTNEzYKn1 z/QNuvp/b0wsFb5foJsN9ELedlB200Q8s1tDQO7RTVh8G5fCa2D2rvDPPYiEBhKwbelFhKlzV yar3/ELw1JLW84CANL5LrxEp/8idDr5WpeDvLCxkpZHrJur+HNtehGwMjSN8g2o7Hg2r1E6R0 xHbeUwRBFO8i4AvaTrRE+CnnuS2mo6FsOYH7ML3IDXiZJDxYL24kuFTpjnxPd3NQnDhjZM9fu 7fMUjIkToMGIYS0hOVDBKOtmlKzQU0xVckNjhd1u0GD0OiP/AusoeqmZ/TzvW63w3mV+s0zNg kJfjzAe4tLJTIzRCuIuhTKNQOfqyfqgr0OTXHOVfr3qOLrnKiggW05iecQc08U5FHUhIplbE5 pAdfiJouoxSHjHY297MA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > To be honest I've don't really like C as a language, and learning it > would not do anything professionally for me either. So I'm jumping into > this strictly for the sake of improving Emacs. Then please jump into this as often as you want. > x, ns and w32 all used the same code, so I changed them all to look like > this now. OK. I think a main reason that we usually do not factor out code in these is that only one of them gets compiled in anyway - so we just save an extra call. > >> - Currently the actual width of the border is still controlled by the > >> `internal-border-width` parameter for both frame types. Should I try to > >> do something about that as well? If yes, what's my entry point? > > > > Add a 'child-frame-border-width' parameter. But in this case I would > > propose to proceed as follows: > > > > - If for a frame the 'child-frame-border-width' was explicitly set, use > > it. > > > > - If it was not set, use the 'internal-border-width' parameter. > > That's done now too, at least for X. I'll attach patches of my first > working drafts for both changes. Let me know if I'm on the right path so > far. You're already at the end of it. Please document the changes in the Elisp manual and announce them as (probably incompatible) changes in NEWS. > >> - I think I'll need to sign the FSF copyright assignment, unless the > >> limit is higher than the 15 lines I am remembering. > > > > I think so too. > > > > Ok, what do I do? Eli, can you send Arthur the forms please? Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 10:34:52 2021 Received: (at 45620) by debbugs.gnu.org; 5 Jan 2021 15:34:52 +0000 Received: from localhost ([127.0.0.1]:42457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwoMF-0000N8-PR for submit@debbugs.gnu.org; Tue, 05 Jan 2021 10:34:52 -0500 Received: from mout.gmx.net ([212.227.15.18]:47583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwoME-0000Mv-DA for 45620@debbugs.gnu.org; Tue, 05 Jan 2021 10:34:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609860875; bh=h6jAawu/wrrZcz7F83Mp2xZ+VV6K9fDmw4kTgdOSB2M=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=e/KeycCY0f2gMkjRih3p6PzkPRJ+ykhZXqh1Gj7TzrIBQ9sDweRgFymZKk24yAleo MqGJxI2urp+jzZu0GZkX9iZUv+c94duQFrZRt4GDF0ZVn08LG7lhRNOgSxaxpt9LXW qdD+cp/1XEEAxFwfKDsmHzpKG6zrsATYD6PlKHK4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.231]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mo6qv-1kDMKe2rWt-00pZgJ; Tue, 05 Jan 2021 16:34:35 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> From: martin rudalics Message-ID: <37736abb-082f-cc3b-8eae-5fb34ee9fcfd@gmx.at> Date: Tue, 5 Jan 2021 16:34:34 +0100 MIME-Version: 1.0 In-Reply-To: <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:GRmd2qYs6Z0IUzPzVvLpAKWMp3G6ZzeZnPvt8YMJyUMxuiZnyY8 iFIKuKPywkW3Ea6KTI/682I4mErwi2fbZlNstC4l0RoRcNuJt+Qbvcl0JUy4nbZcAzvu4AX KMvb2YP0swIGefD56ODJsRe7cZdUB0WfuYwjn0+QGABYkhC6rUsI4M8m/kYcHpeEO/BgGTE 1Bd3WFF+rZww40OoejJlw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:qcBI+Fbj+e0=:KqE0ues01FVM/2XWeubl07 FzCSMA23+vBTKoJzMYJyKvexXa8FG6ZzEgWYsGvUiv7nuffRIyC8wPKnf65IdPW1BEVKTOE+w 3o1IUJXoFq/iIJv3CIqgwziY5Iug6QCnjkDHLdjUoZ+1pxVszOsdaSZDKHcO6Fp06MKMvBwt8 pA8uIUOO3A46gTyqAKUQdfH0dX4N5XpHtu7HezxvRbgpclUQKc7wBc9D5O1NFDKO4CldbnDVa yNhzWhKLHpi9DUvrrcKMUmM6NsBGb1KG0NSAzeHZN4tXm4MeOTvY2lCji7+SzmqhEwgaxGeB5 CfCDF5/lz2QmzYrvZhJfwrdGLksBKsmSnxGAlk4UOmhk0vGH605FtYBBUkeoO0plhQzr1yHPC iZtyndF0kORUmK2QaOhOmN5FcUfws4UTctR4h3aRQAG1anftquXgR3HDh7X/PvO/2GxUJMfF9 HfJ4noZC9RQxyrWOWF/jDPfFQCLv3yXG+poptwLplFo//c4FY71s3eyios39G1kkLf1BeZLEq DxcYTmm0ZCmfw72CSQkwM209Z9OM1hV05pk63W0BXr4Gx0suMn86Oe8SmOwu2u5hJx+lM/cfx MBXaZTPZuidxU7CmknZYK2f2ffJBDNNBas0mXUuvJRX/+CYVX1LJwcQQBE3VLLhOluq0kKXqS wSQx9SkaP/YcrFvSkP/VhshjZNlvOv7RyoY/bWy3y34n5Pby6dm9fl+bR2PH5FdDu/n9ormf+ G7YTohrGN3YXCf/V4MyVM5cKM1zTSI0UbUDNsAwhqYd8jBczaHBUMfpDD16KZ8kz/5/IOIJ94 jnSVa6TtZJ1VR3joGvZOw4Tz3YBfx7ipghLUKC1M0gdOWXkGnonCbavZBAlru3J0GE8l6hZc/ 79E+0XceesxDMKE3hNEQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Eli, can you send Arthur the forms please? ^^^^^ Alexander, obviously ... martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 11:26:34 2021 Received: (at 45620) by debbugs.gnu.org; 5 Jan 2021 16:26:34 +0000 Received: from localhost ([127.0.0.1]:42499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwpAH-0001ct-Re for submit@debbugs.gnu.org; Tue, 05 Jan 2021 11:26:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwpAF-0001ce-Jy for 45620@debbugs.gnu.org; Tue, 05 Jan 2021 11:26:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39649) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwpA6-0001EF-US; Tue, 05 Jan 2021 11:26:22 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4250 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwpA0-0008V2-2c; Tue, 05 Jan 2021 11:26:18 -0500 Date: Tue, 05 Jan 2021 18:26:10 +0200 Message-Id: <83k0sr9wpp.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> (message from martin rudalics on Tue, 5 Jan 2021 16:33:05 +0100) Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, alexanderm@web.de, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 45620@debbugs.gnu.org, tumashu@163.com, Eli Zaretskii > From: martin rudalics > Date: Tue, 5 Jan 2021 16:33:05 +0100 > > Eli, can you send Arthur the forms please? Done. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 06 06:34:50 2021 Received: (at 45620) by debbugs.gnu.org; 6 Jan 2021 11:34:50 +0000 Received: from localhost ([127.0.0.1]:43617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kx75V-0006va-Vn for submit@debbugs.gnu.org; Wed, 06 Jan 2021 06:34:50 -0500 Received: from mail-oln040092073047.outbound.protection.outlook.com ([40.92.73.47]:22558 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kx75T-0006vC-BG for 45620@debbugs.gnu.org; Wed, 06 Jan 2021 06:34:48 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LB1N9kJ5AlqpJ9URAoxMahiIbExx+MdnktnW6bnfPxUicnlbZjWqgFnsC02bTL+7qT9w4kok0p2Yh/I2aAURRqMwCvMSWwItMVGHWm0LULEnQDmwPHhVed7HZlN7aM/k9/MSLLx7vUCe4bJSWzwpCCUcDiEl0xxkM2Gdef8CU4t6XYkEMxu4gosJPH/JD7eypcJRC1IL6Qb1e6mdFrsl0vlPY/nwrJQZ4U6lsqe4D67tD9Vl3iPW5tpjlyHWw+87dD2PpufXj2eIrD80ebcbwAOebTkjp1ch9qlaLN97pdJvfR241YHlmvsZEMbG9iu3jajxRcRYIgo/xN9Tbt/GHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ptIeRnVi+ENBS4mMgEZUTePjgGUvE+Mpt5i7xEigS4=; b=CsdBZLIfYzdLF23PwuQ/g5FKKBcFv3M3/3TyzycdQucIXaixJFhYDfgw/8XKYlryZ01Pr+E/y2EPZ+q4r3y+BxJnfRHTl719GIvS5vpFhwO9tCroB3O2AWqFATszMSP2ISWhq5uIaFGMaxUEL4tk5Z3moB+6U64SP+H/B6c97ps78sTKIFfcowJvtHzARv5wjRvuJWfDiZuNpt7yxAHDvLP7vxGWHzDfLh1NbSqr4TPhClkOxqevbdA4XOc2z+VPgM84D1KrQm3bzgl97PV1evB63rJtoN51vjSKyqW+lRHJKEeoYQDNbnyEIlqevW7tlOyVkEB+UFdpJDTXkwT4Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ptIeRnVi+ENBS4mMgEZUTePjgGUvE+Mpt5i7xEigS4=; b=cXEoCe1xBahTVPJ9x8G2IhJfwANBr4uLBNNi0wqQ//UCLJ5jEnz/oPXyFwUqw6rhYC1PVNbY5PqDllsR8xTF243cw90xKa0PqEy4GshMBs61TlNVmBw8OK8n9X/JayafaYgAfvBND4LnuM/vzom0IjkgH9BHZxqtfDN7DpppRN4UqlEcQyGTr5DtkPzJEqHRlZr7JoOADV2olhEOcQZgBYB4DEq9HvxX7jVi3wvOvyy0OJcmuxwTuyekdVW7gjyG8qpeqoQqbY+FcWaFMPeni69iU0FRc7K73lm8SeVK5Y5FtmE1JUDbIax2WbjmhTo+rQJGtpvDVoDrNMdzG37M/g== Received: from VI1EUR04FT007.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::4a) by VI1EUR04HT151.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::357) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Wed, 6 Jan 2021 11:32:12 +0000 Received: from AM0PR06MB6577.eurprd06.prod.outlook.com (2a01:111:e400:7e0e::50) by VI1EUR04FT007.mail.protection.outlook.com (2a01:111:e400:7e0e::229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Wed, 6 Jan 2021 11:32:12 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C760927F6ACD00173DC6649DC935F0FFD30BD6F4F61A77DB848D3FD98B290692; UpperCasedChecksum:58C429EAD7D1CC9EBED66B9D1B1310A69486D03B7464B53805B1B746B31B81BA; SizeAsReceived:7609; Count:46 Received: from AM0PR06MB6577.eurprd06.prod.outlook.com ([fe80::9487:8c7d:da00:4993]) by AM0PR06MB6577.eurprd06.prod.outlook.com ([fe80::9487:8c7d:da00:4993%7]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 11:32:12 +0000 From: Arthur Miller To: martin rudalics Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> <37736abb-082f-cc3b-8eae-5fb34ee9fcfd@gmx.at> Date: Wed, 06 Jan 2021 12:32:09 +0100 In-Reply-To: <37736abb-082f-cc3b-8eae-5fb34ee9fcfd@gmx.at> (martin rudalics's message of "Tue, 5 Jan 2021 16:34:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-TMN: [dA1zCwVvB85eVcWHzqzuzh1OXqdI0/bz] X-ClientProxiedBy: BE0P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::22) To AM0PR06MB6577.eurprd06.prod.outlook.com (2603:10a6:208:19a::23) X-Microsoft-Original-Message-ID: <87ft3e1eti.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (90.230.29.56) by BE0P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.4 via Frontend Transport; Wed, 6 Jan 2021 11:32:11 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: d36a4d43-8e7e-4826-0364-08d8b236b608 X-MS-TrafficTypeDiagnostic: VI1EUR04HT151: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4pN7kfW/pmYNsA+mGMYFo6eM8ZWNs2hDbQk/GlibcFJANf1FCuQfY+7bPDekBBvOoZIeVEjoTPl6qozbWnlenmzKH8TzLXm5gMJfmqEWkQx0O1x8Alva0zWULuoYi7silFScahZfGS0aIyTEgMs5HW8XQtipm/Ot30Yke2LIcKDRFEQTqXChH4IVzFucACDnxLsXDCvpG79QHhBc1BuyPDjm9oEWkRbagiVK5qAAbesO7UOA1vFqsBXWW9c831uS X-MS-Exchange-AntiSpam-MessageData: fUDJB29wUxi/dIdtfgtvDg3PK5UaEI3hJlsFj5yeA4HE6MPjIB6Lbqg2LEJqGFDgasfBd2FNndrMFZ8MmSkM3S4mM/Z4ZXVXx37SVt/P1gkjZ6rWlcoui+aZxjhQctSeSvr5UpCdPmpSOWIdc/TnCw== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2021 11:32:12.4344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: d36a4d43-8e7e-4826-0364-08d8b236b608 X-MS-Exchange-CrossTenant-AuthSource: VI1EUR04FT007.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT151 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, Alexander Miller , tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: >> Eli, can you send Arthur the forms please? > ^^^^^ > > Alexander, obviously ... > > martin Arthur already signed and prefer borderless stuff ... :-) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 06 08:36:38 2021 Received: (at 45620) by debbugs.gnu.org; 6 Jan 2021 13:36:38 +0000 Received: from localhost ([127.0.0.1]:43811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kx8zN-0004K1-QP for submit@debbugs.gnu.org; Wed, 06 Jan 2021 08:36:38 -0500 Received: from mout.gmx.net ([212.227.17.21]:36029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kx8zL-0004Jn-Os for 45620@debbugs.gnu.org; Wed, 06 Jan 2021 08:36:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609940174; bh=zheQO3y18mqzl8Ijn72L5xCNT5asJRbT2k1xMtfCyAA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=baB90L7M1CCrAPos/OoeLnCQIm0DlIfJCGPJayzPEciyZ+pIbIe9N/MKyfTS5mQBG u+KUjCrP7amCCe9SBE5TErb6cnyeJ0sjfzro739oiMxHzsTUJv5BmZv/ViQoswLtYq ZFc/qWyqpEHugstttFQ00KtfK0vnHUAXnED6oL+Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.112]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHEJ-1kLrQT0N9H-00grWz; Wed, 06 Jan 2021 14:36:14 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Arthur Miller References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> <37736abb-082f-cc3b-8eae-5fb34ee9fcfd@gmx.at> From: martin rudalics Message-ID: <1e064e27-2987-8c99-813f-5a55848ac178@gmx.at> Date: Wed, 6 Jan 2021 14:36:12 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:RGuYyM3ruyxxx1qgCzFCjwKEMQ9F3VsYpnfDZl4dy+I/OmN/Vdf rZEia0iPJUFto8UK9Jm7v9Y6qkuZrav8J8d8h4SDEDKSnkHDpRu4xPKeiKl8jlNc5Vbkb79 jOa358NvXqvUIbkzZRCftObphtku/BpIE/CgqRwUzrXQiiZiOKiVGUvYMbQe8WoikfTuHYN 0H3HrhNUe9aOau4/t8pcQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:YR8dfHXdcqA=:4Yj8uQ3I+iXIVDvF2rF4ER S7K+OnOSptGgraikvU1kTBDzuLf/j4RiJ6Vl2uQqQdKnBFRsFivYQSj4I1SM7ZtC9ojhlF9Ds AiNZ8bgxeVkxUa5vr6Z9rUTBqLahKC4FVMaUupXZLRxYr3GsgUcOGJFWStTFVV2dZuSvJWF3n DaEXr4XgpccBINQfLjU/BKh62RHpwAaCe9cBzXCC2JbxpZTfga08mEkFjseR4giuZg92GSdaY sOM1eeGkzwrvzzhoOiWxTQq/XgBaxhvp4YYnM7qijqq46T5FBB+3epXJBd/VvLGlwLNyaroRT fOgl4wcfEWE6XFKuJL7+d8TUmx7YAdnrTb7Gif3Mrylj33S1Tc7hpd52URmdkgoU+SossS1xi IcU87XvdIauL6QsYOUaB5WG4nW+bu+8WuadAA8ZFL7CKah51EgcgPdx5WMtdbRq90DZ+QggFP gIHccciAdV926l/wnySxVI2kEH35gKI7/XbK7a+YemiJ3X3/lbgc15Ovpu/WU6wlV5VmYM31r 0sSoV9tCULi05a03KKFaTCf3A38cSU/Q9EKkdwh2zL5F/0cZx6yLOtAYlbrhe7QBRSwM2lUcB L5BEUFoJzOsS7yP0ZxhZiPHvYTNXLTsAaZ8byMNgyOPBeBJHo1iRiAVEz2L9hk3VOmIavUSjN b4oZHNij6HOOWXUgh6VZeUOixpvEnh9j16sLI6/raaztXwXef9xjkYesRW7CxoLBXaQmankhm Vy8NNKCvmgfSnfrAZZZaAvheglqmLIMJLak4EM5jPjtwGobAbTCt5/0sWCmPVc4Zk7rmP3jbf RMF+9rupFtL3DhYERLoGkX/4plxaumhb2FSfF4MaeaLOmeb6kKFCtBVbWpdSEQMIFpJ1r4yMa WbdY/vX+/7nubq7Kq6ag== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, Alexander Miller , tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Arthur already signed and prefer borderless stuff ... :-) Waiting for Henry to show up ... martin From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 06 10:01:27 2021 Received: (at 45620) by debbugs.gnu.org; 6 Jan 2021 15:01:27 +0000 Received: from localhost ([127.0.0.1]:45251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxAJT-00073O-BK for submit@debbugs.gnu.org; Wed, 06 Jan 2021 10:01:27 -0500 Received: from mail-db8eur06olkn2069.outbound.protection.outlook.com ([40.92.51.69]:2709 helo=EUR06-DB8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxAJR-000739-3Z for 45620@debbugs.gnu.org; Wed, 06 Jan 2021 10:01:25 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KT6c0O+BwgBuwG8Qrvfg6sTh0ox7wDZ3wOuB/1NlH8fCedRTAg7EVempyot72tCWyTaGPr7fzdWybX0rYEv8F/ivmhBtJjORLvirzFWxc0m+PVcp7OZPRMI+boxlEr4wrJceBinTgIxvQNr96LLnKR/MP1dKJY2DlgTlN/sCrMb7ux8hXnr1l/IxEBUqeunhejlOITx1W6QOz32owkzgm2wvo3Wepwbc3Dez/KGP0qQgAbH7AzsqJevZAgtGdhgZsmkCwQhEKTF1sA1X7TxYv48vnm8Mw27nUeg5oRQHNo/54qRHWNlDRtJAK4iz8BXjTHob+U/DTLfUPOyHajTiJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OclB9+rYZ6gRm00kfJ0oVnjARD9TR++dvG7AaRCS3e8=; b=WBB5zxEJcRTFNMJgIh5REkD5ZebfAOxfO7l6sDBajyIX2TWjKiC6xUAb941FUOoCy6slWecpt6l9kwpkh0J/uUnXslSdj4r826E4zZkjHAEBsWBf7rCX0ub8do8StUEhXLKFW0ydOSQEEoe7vTWzV5iAXH+QYI29DJNb4gvC67S97hIo+5MIjZrIkLlG7pp3mr65e4y9svfPBvhjXHpLOyAHzdr/Yk5lnOrcTYVVVBaQfS0+B4Nvujxf7BLAb/NP/oFUjooKQpCv52DgW2aDsO+cVpNK+t2/lMMGoQwIkkdIG22fljK4qxLSZSUTL576Cpdhk99RBI3MuiXV6ERj8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OclB9+rYZ6gRm00kfJ0oVnjARD9TR++dvG7AaRCS3e8=; b=szO7egTt1rE7G1s8F++Ua1jJXKy4Xz7Rr6sGu0gQiF/SrRM0iFarLqYuXHJQiYiFnpfJI38a2SYyYfySjlra/JrmViQ8xp6RUWuBZiz4qOlJ10ihMm8RLgRQO7h0amU3oSvAlHR5ALjQzoeGJ2SMJc+TR0xIfAgxrP1/BVVrgYKc3XARm15C2ETOO28cuyQpsXl3u5ArEOr7d23edX+2dJBn+Hf7JYTNAFt55ESNcF7kZ4DDMk5JUVXE1i7fv7fNpSJyAZSMg72BO114p3TLrgY4Qx9PiXQMVFcUYA8g4jOV6ucmtAm6e+3qkQMZV2HpLLYJKCNunPBgDw0X7WoHJA== Received: from DB8EUR06FT061.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc35::48) by DB8EUR06HT210.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc35::126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Wed, 6 Jan 2021 15:01:18 +0000 Received: from AM0PR06MB6577.eurprd06.prod.outlook.com (2a01:111:e400:fc35::50) by DB8EUR06FT061.mail.protection.outlook.com (2a01:111:e400:fc35::465) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Wed, 6 Jan 2021 15:01:18 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:08516158235CB4C5C26418CAE0D66E4F39ED317D825CCF673CE283AA12B2ABC0; UpperCasedChecksum:FE877E5FBB0B581FC1A268C88EAB5BF1B9E4CCCE6F611DBA514723A19EA90673; SizeAsReceived:7737; Count:46 Received: from AM0PR06MB6577.eurprd06.prod.outlook.com ([fe80::9487:8c7d:da00:4993]) by AM0PR06MB6577.eurprd06.prod.outlook.com ([fe80::9487:8c7d:da00:4993%7]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 15:01:18 +0000 From: Arthur Miller To: martin rudalics Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> <37736abb-082f-cc3b-8eae-5fb34ee9fcfd@gmx.at> <1e064e27-2987-8c99-813f-5a55848ac178@gmx.at> Date: Wed, 06 Jan 2021 16:01:17 +0100 In-Reply-To: <1e064e27-2987-8c99-813f-5a55848ac178@gmx.at> (martin rudalics's message of "Wed, 6 Jan 2021 14:36:12 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-TMN: [+Qy/lKjFV9Nqd1u86q416mE5PVnOE06e] X-ClientProxiedBy: AM5PR0701CA0009.eurprd07.prod.outlook.com (2603:10a6:203:51::19) To AM0PR06MB6577.eurprd06.prod.outlook.com (2603:10a6:208:19a::23) X-Microsoft-Original-Message-ID: <87im8axg76.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (90.230.29.56) by AM5PR0701CA0009.eurprd07.prod.outlook.com (2603:10a6:203:51::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.4 via Frontend Transport; Wed, 6 Jan 2021 15:01:17 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 6fe7da53-ca7b-4a07-1c0b-08d8b253ebc4 X-MS-TrafficTypeDiagnostic: DB8EUR06HT210: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y8s7ZYEV8zUP64H7SG89vtVxlY6FP38st16lDoQRKUa8giUT4HtOuXSMSa3Z+ey85jNqS2tJlPE49eIzt74IAJtWttYGUuRepD09mccwjbs9Ok2K5XubHJwc00Vgy6PGfN2Yn+EbGMvFOh/ejlAFJzP7uoNnO4Fm7KafKbqsNrSpGJ6pC3efqqrTOK559ZXZR1uX9q3i50d7xvoTia2GxDpheOpY3MD4bOZ45FPfrR1OOIHxCZbfTWnS297tJU9h X-MS-Exchange-AntiSpam-MessageData: EEm+PuyN8xsKY20emyxzHJjLJQil8TkC1wS4iWWnWk28ADB+nxjT/rwGLcGzBh6+UXpXVTznK1RQUWv6njAP+MGBbxa0KxWVP8orlu5ZGD0yCsRQ3rG1XLFPs9XxQ7WLtZ/5X6feCf05PMO6+MmL6w== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2021 15:01:18.0283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 6fe7da53-ca7b-4a07-1c0b-08d8b253ebc4 X-MS-Exchange-CrossTenant-AuthSource: DB8EUR06FT061.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR06HT210 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, Alexander Miller , tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: >> Arthur already signed and prefer borderless stuff ... :-) > > Waiting for Henry to show up ... > > martin And if Glenn appears we could have a jazz quartet! From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 06 11:26:34 2021 Received: (at 45620) by debbugs.gnu.org; 6 Jan 2021 16:26:34 +0000 Received: from localhost ([127.0.0.1]:45339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxBdp-0002q9-4g for submit@debbugs.gnu.org; Wed, 06 Jan 2021 11:26:33 -0500 Received: from mout.web.de ([212.227.15.14]:49355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxBdm-0002pu-Uz for 45620@debbugs.gnu.org; Wed, 06 Jan 2021 11:26:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609950376; bh=bBK3FH4ExoThJushxjYH98zng+bINsrtqatMir1NKKM=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=jtNb9qbMHc98R2JAQTASC1GE0e9uvOeO0Y9oebhz531lb+h9D32QVs3c9Q4CKy8dk OBpkkqA3cULGu5ubqQwJpPawg2eRo70ZjtLOIFYlCF66vTXij20Cd6HXx7pm1m8BMV EKWavalJxjE9l8vaknsFXLe+8xNaGegyWsn4r7ZA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mhnvw-1kJT6d27Qu-00dzKH; Wed, 06 Jan 2021 17:26:15 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: Date: Wed, 6 Jan 2021 17:32:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------31762D970CBB97B741E09817" Content-Language: en-US X-Provags-ID: V03:K1:zJvcZHTxE0bwV1v4EL/HIUM0pgSJAj7D9TFoe3PEEeE9uBVNIeb 5eCTihEsF2cX1oxJ+iAKb9k1aKt1kvP7X6VYVaxzFKZYL/p2iyabfbqMaOxc8+LAGUEwWw1 dCYpeDxdtTe9kGft+PNtab2vWaFVONsf5f3/32yIV++UePz4ief6tiEiSNmf/nSZToDKgZw ypRvxiM2bc5IgH5LzAUJw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:VWmurb+T4As=:pJVjunhgu7cGHSk5eySsT7 ciU2GbLsvhPlI8DR4BG1R4gpou8lMgBD1ktjZFOO7YdVZC5pMAJ+1IwFxLYFFTHRNp0EP2ZY+ VtBpL/9G92LyThv2azf9sz/D/Jlv0ufFb3VSt/KqXaDe0w2Y6chcRHN2ZiL+/rFyihm8KoF2E xBkn4dxNdKUsMDhuk+qG/kUYsUL94V1DPFVixDGlyWvYkoHupQnniFpmeKeOggmvPlzPXM7jq OHVEutMLsePAURVUpQrIyGxHgJhNPGHvVggzWnvvq9kN9JBN/K2NtNJ4w25oB1dF25Lyl0/A1 AYDOpKQH0wxpXjD/nms02KpnoE86sJyQjjiv01LjdoO+FMKMEYnftP1EFAdPnU3p05dzSl1o5 OmQ3OFrjDU1QVMsGC5M3BWwYeCQ2lkT0MFA0W8cLwJkzEScYboGFcS/xVbKWoYg5+v34Ll33T GW1cloSn0CUXao5PeD+00abbJ2bF/+rxfwRGqGSGM7z9iVDnKYNHUyopeB/hAu0gmiGHh5fYx C+h8ZaydIqC/tDJV0ONgP4BDe8MfrYQiv0OpibHW9mg2FZsjo1DtODoV2AioedlJu4bKa/Obt MwDZYskNzkD1CcI91K9TkwPLhTxLnZsIP1r4Tln97HL3DBpJqGYu5Og/lgEWqky6VDqrRNXe8 AcpOYz8xeLWCP6cC3CkcMHspk8QPMUvyJ1wjJdWoAIzScUEHvmzadbEMrnkXd0VmBI+jhc/+B wQYTnVgID0zXlT4uIDP8iYyrdMCGxLlMhIcz84uZ8PMBeHqTs0q6mVaXU3TKfsI3Qc3vgpeGg M3Rh6QRQf9ejWzjxenLj/xzLC0GBeN7VNkb6LZX4hXM0quNnPFWayUtua/8XDsPVwdtJwy48r jnJeKojhnUjYTspghaGA== X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> >> - Currently the actual width of the border is still controlled by the >> >> `internal-border-width` parameter for both frame types. Should I try to >> >> do something about that as well? If yes [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] 2.8 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> >> - Currently the actual width of the border is still controlled by the >> >> `internal-border-width` parameter for both frame types. Should I try to >> >> do something about that as well? If yes [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.8 FAKE_REPLY_A1 No description available. This is a multi-part message in MIME format. --------------31762D970CBB97B741E09817 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable >> >> - Currently the actual width of the border is still controlled by the >> >> `internal-border-width` parameter for both frame types. Should I try to >> >> do something about that as well? If yes, what's my entry point? >> > >> > Add a 'child-frame-border-width' parameter. But in this case I would >> > propose to proceed as follows: >> > >> > - If for a frame the 'child-frame-border-width' was explicitly set, use >> > it. >> > >> > - If it was not set, use the 'internal-border-width' parameter. >> >> That's done now too, at least for X. I'll attach patches of my first >> working drafts for both changes. Let me know if I'm on the right path so >> far. > > You're already at the end of it. Please document the changes in the > Elisp manual and announce them as (probably incompatible) changes in > NEWS. > Ok, all done now, see attached patch. For the copyright I have asked my employer to make sure that the copyright parts from my contract don't apply to the work I do on my own time like this, but most of the company will still be on holidays or on sick leave, so it could be a few days before I get an answer. --------------31762D970CBB97B741E09817 Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-distinct-controls-for-the-appearance-of-child-fr.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Add-distinct-controls-for-the-appearance-of-child-fr.pa"; filename*1="tch" =46rom 623b6ab24b93ca21e7fa32dd344955d1138c157f Mon Sep 17 00:00:00 2001 From: Alexander Miller Date: Wed, 6 Jan 2021 17:02:35 +0100 Subject: [PATCH] Add distinct controls for the appearance of child frames' borders. The background of the `child-frame-border` face instead of the `internal-border` face now controls the color of child frames' borders. The `child-frame-border-width` frame parameter is now used for the width of child frames' borders instead of `internal-border-width`, though we still fall back on using the latter if the former is not set. =2D-- doc/lispref/frames.texi | 19 +++++++++++--- etc/NEWS | 7 +++++ lisp/faces.el | 11 +++++++- src/dispextern.h | 1 + src/frame.c | 12 +++++++++ src/frame.h | 25 ++++++++++++++++-- src/nsfns.m | 18 +++++++++++++ src/nsterm.m | 10 ++++--- src/w32fns.c | 58 ++++++++++++++++++++++++++++++++++++++--- src/xfaces.c | 3 +++ src/xfns.c | 46 ++++++++++++++++++++++++++++++++ src/xterm.c | 20 +++++++++----- 12 files changed, 212 insertions(+), 18 deletions(-) diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi index 7f2a6f7542..ef1b661b2a 100644 =2D-- a/doc/lispref/frames.texi +++ b/doc/lispref/frames.texi @@ -694,9 +694,17 @@ Frame Layout @item Internal Border The internal border is a border drawn by Emacs around the inner frame -(see below). Its width is specified by the @code{internal-border-width} -frame parameter (@pxref{Layout Parameters}). Its color is specified by -the background of the @code{internal-border} face. +(see below). The specification of its appearance depends on whether +the given frame is a child frame (@pxref{Child Frames}) or not. + +For normal frames its width is specified by the @code{internal-border-wid= th} +frame parameter (@pxref{Layout Parameters}) and its color is specified by= the +background of the @code{internal-border} face. + +For child frames its width is specified by the @code{child-frame-border-w= idth} +frame parameter (but will use the the @code{internal-border-width} parame= ter as +a fallback) and its color is specified by the background of the +@code{child-frame-border} face. @item Inner Frame @cindex inner frame @@ -1790,6 +1798,11 @@ Layout Parameters The width in pixels of the frame's internal border (@pxref{Frame Geometry}). +@vindex child-frame-border-width@r{, a frame parameter} +@item child-frame-border-width +The width in pixels of the frame's internal border (@pxref{Frame +Geometry}) if the given frame is a child frame (@pxref{Child Frames}). + @vindex vertical-scroll-bars@r{, a frame parameter} @item vertical-scroll-bars Whether the frame has scroll bars (@pxref{Scroll Bars}) for vertical diff --git a/etc/NEWS b/etc/NEWS index d8f25ab362..f1e8443080 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -218,6 +218,13 @@ and other "slow scrolling" situations. It is hoped i= t behaves better than 'fast-but-imprecise-scrolling' and 'jit-lock-defer-time'. It is not enabled by default. +** New face 'child-frame-border' and new frame parameter child-frame-bord= er-width +The face and width of child frames can no be determined separately from n= ormal +frames. To minimize backwards incompatibility child-frames without a +'child-frame-border-width' parameter will fallback to using 'internal-bor= der-width'. +However the new 'child-frame-border' face does constitute a breaking chan= ge since +child frames' borders no longer use the 'internal-border' face. + =0C * Editing Changes in Emacs 28.1 diff --git a/lisp/faces.el b/lisp/faces.el index 4e98338432..639dbeb09a 100644 =2D-- a/lisp/faces.el +++ b/lisp/faces.el @@ -2683,11 +2683,20 @@ window-divider-last-pixel (defface internal-border '((t nil)) - "Basic face for the internal border." + "Basic face for the internal border. +For the internal border of child frames see `child-frame-border'." :version "26.1" :group 'frames :group 'basic-faces) +(defface child-frame-border + '((t nil)) + "Basic face for the internal border of child frames. +For the internal border of non-child frames see `internal-border'." + :version "28.1" + :group 'frames + :group 'basic-faces) + (defface minibuffer-prompt '((((background dark)) :foreground "cyan") ;; Don't use blue because many users of the MS-DOS port customize diff --git a/src/dispextern.h b/src/dispextern.h index 3ad98b8344..f4e872644d 100644 =2D-- a/src/dispextern.h +++ b/src/dispextern.h @@ -1826,6 +1826,7 @@ #define FACE_UNIBYTE_P(FACE) ((FACE)->charset < 0) WINDOW_DIVIDER_FIRST_PIXEL_FACE_ID, WINDOW_DIVIDER_LAST_PIXEL_FACE_ID, INTERNAL_BORDER_FACE_ID, + CHILD_FRAME_BORDER_FACE_ID, TAB_BAR_FACE_ID, TAB_LINE_FACE_ID, BASIC_FACE_ID_SENTINEL diff --git a/src/frame.c b/src/frame.c index 45ee96e962..4a4ad99395 100644 =2D-- a/src/frame.c +++ b/src/frame.c @@ -3528,6 +3528,13 @@ DEFUN ("frame-fringe-width", Ffringe_width, Sfringe= _width, 0, 1, 0, return make_fixnum (FRAME_TOTAL_FRINGE_WIDTH (decode_any_frame (frame))= ); } +DEFUN ("frame-child-frame-border-width", Fframe_child_frame_border_width,= Sframe_child_frame_border_width, 0, 1, 0, + doc: /* Return width of FRAME's child-frame border in pixels. */) + (Lisp_Object frame) +{ + return make_fixnum (FRAME_CHILD_FRAME_BORDER_WIDTH (decode_any_frame (f= rame))); +} + DEFUN ("frame-internal-border-width", Fframe_internal_border_width, Sfram= e_internal_border_width, 0, 1, 0, doc: /* Return width of FRAME's internal border in pixels. */) (Lisp_Object frame) @@ -3744,6 +3751,7 @@ DEFUN ("set-frame-window-state-change", Fset_frame_w= indow_state_change, {"foreground-color", -1}, {"icon-name", SYMBOL_INDEX (Qicon_name)}, {"icon-type", SYMBOL_INDEX (Qicon_type)}, + {"child-frame-border-width", SYMBOL_INDEX (Qchild_frame_border_width)}, {"internal-border-width", SYMBOL_INDEX (Qinternal_border_width)}, {"right-divider-width", SYMBOL_INDEX (Qright_divider_width)}, {"bottom-divider-width", SYMBOL_INDEX (Qbottom_divider_width)}, @@ -4287,6 +4295,8 @@ gui_report_frame_params (struct frame *f, Lisp_Objec= t *alistptr) store_in_alist (alistptr, Qborder_width, make_fixnum (f->border_width)); + store_in_alist (alistptr, Qchild_frame_border_width, + make_fixnum (FRAME_CHILD_FRAME_BORDER_WIDTH (f))); store_in_alist (alistptr, Qinternal_border_width, make_fixnum (FRAME_INTERNAL_BORDER_WIDTH (f))); store_in_alist (alistptr, Qright_divider_width, @@ -5984,6 +5994,7 @@ syms_of_frame (void) DEFSYM (Qhorizontal_scroll_bars, "horizontal-scroll-bars"); DEFSYM (Qicon_name, "icon-name"); DEFSYM (Qicon_type, "icon-type"); + DEFSYM (Qchild_frame_border_width, "child-frame-border-width"); DEFSYM (Qinternal_border_width, "internal-border-width"); DEFSYM (Qleft_fringe, "left-fringe"); DEFSYM (Qline_spacing, "line-spacing"); @@ -6408,6 +6419,7 @@ focus (where a frame immediately loses focus when it= 's left by the mouse defsubr (&Sscroll_bar_width); defsubr (&Sscroll_bar_height); defsubr (&Sfringe_width); + defsubr (&Sframe_child_frame_border_width); defsubr (&Sframe_internal_border_width); defsubr (&Sright_divider_width); defsubr (&Sbottom_divider_width); diff --git a/src/frame.h b/src/frame.h index 8cf41dc004..6a94cee727 100644 =2D-- a/src/frame.h +++ b/src/frame.h @@ -534,6 +534,10 @@ #define EMACS_FRAME_H /* Border width of the frame window as known by the (X) window system. = */ int border_width; + /* Width of child frames' internal border. Acts as the + interal_border_width foy child frames. */ + int child_frame_border_width; + /* Width of the internal border. This is a line of background color just inside the window's border. When the frame is selected, a highlighting is displayed inside the internal border. */ @@ -1432,11 +1436,28 @@ FRAME_TOTAL_FRINGE_WIDTH (struct frame *f) return FRAME_LEFT_FRINGE_WIDTH (f) + FRAME_RIGHT_FRINGE_WIDTH (f); } -/* Pixel-width of internal border lines. */ +INLINE int +FRAME_CHILD_FRAME_BORDER_WIDTH (struct frame *f) +{ + return frame_dimension (f->child_frame_border_width); +} + +/* Pixel-width of internal border lines. + Will use child_frame_border_width for child frames if + possible, and fall back on internal_border_width + otherwise. */ INLINE int FRAME_INTERNAL_BORDER_WIDTH (struct frame *f) { - return frame_dimension (f->internal_border_width); +#ifdef HAVE_WINDOW_SYSTEM + return FRAME_PARENT_FRAME(f) + ? (f->child_frame_border_width + ? FRAME_CHILD_FRAME_BORDER_WIDTH(f) + : frame_dimension (f->internal_border_width)) + : frame_dimension (f->internal_border_width); +#else + return frame_dimension (f->internal_border_width) +#endif } /* Pixel-size of window divider lines. */ diff --git a/src/nsfns.m b/src/nsfns.m index ae114f83e4..1a81b07aae 100644 =2D-- a/src/nsfns.m +++ b/src/nsfns.m @@ -687,6 +687,21 @@ Turn the input menu (an NSMenu) into a lisp list for = tracking on lisp side. } } +static void +ns_set_child_frame_border_width (struct frame *f, Lisp_Object arg, Lisp_O= bject oldval) +{ + int old_width =3D FRAME_CHILD_FRAME_BORDER_WIDTH (f); + int new_width =3D check_int_nonnegative (arg); + + if (new_width =3D=3D old_width) + return; + f->child_frame_border_width =3D new_width; + + if (FRAME_NATIVE_WINDOW (f) !=3D 0) + adjust_frame_size (f, -1, -1, 3, 0, Qchild_frame_border_width); + + SET_FRAME_GARBAGED (f); +} static void ns_set_internal_border_width (struct frame *f, Lisp_Object arg, Lisp_Obje= ct oldval) @@ -1197,6 +1212,9 @@ Turn the input menu (an NSMenu) into a lisp list for= tracking on lisp side. gui_default_parameter (f, parms, Qinternal_border_width, make_fixnum (2= ), "internalBorderWidth", "InternalBorderWidth", RES_TYPE_NUMBER); + gui_default_parameter (f, parms, Qchild_frame_border_width, make_fixnum= (2), + "childFrameBorderWidth", "childFrameBorderWidth", + RES_TYPE_NUMBER); gui_default_parameter (f, parms, Qright_divider_width, make_fixnum (0), NULL, NULL, RES_TYPE_NUMBER); gui_default_parameter (f, parms, Qbottom_divider_width, make_fixnum (0)= , diff --git a/src/nsterm.m b/src/nsterm.m index 2defb9e2ee..76f67d2531 100644 =2D-- a/src/nsterm.m +++ b/src/nsterm.m @@ -3029,9 +3029,13 @@ so some key presses (TAB) are swallowed by the syst= em. */ NSRectEdge edge[] =3D {NSMinXEdge, NSMinYEdge, NSMaxXEdge, NSMaxYEd= ge}; int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); if (!face) diff --git a/src/w32fns.c b/src/w32fns.c index c1e18ff7fa..1d3fb5d761 100644 =2D-- a/src/w32fns.c +++ b/src/w32fns.c @@ -1519,9 +1519,13 @@ w32_clear_under_internal_border (struct frame *f) int width =3D FRAME_PIXEL_WIDTH (f); int height =3D FRAME_PIXEL_HEIGHT (f); int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); block_input (); @@ -1548,6 +1552,32 @@ w32_clear_under_internal_border (struct frame *f) } } +/** + * w32_set_child_frame_border_width: + * + * Set width of child frame F's internal border to ARG pixels. + * ARG < 0 is * treated like ARG =3D 0. + */ +static void +w32_set_internal_border_width (struct frame *f, Lisp_Object arg, Lisp_Obj= ect oldval) +{ + int argval =3D check_integer_range (arg, INT_MIN, INT_MAX); + int border =3D max (argval, 0); + + if (border !=3D FRAME_CHILD_FRAME_BORDER_WIDTH (f)) + { + f->child_frame_border_width =3D border; + + if (FRAME_NATIVE_WINDOW (f) !=3D 0) + { + adjust_frame_size (f, -1, -1, 3, false, Qchild_frame_border_width); + + if (FRAME_VISIBLE_P (f)) + w32_clear_under_internal_border (f); + } + } +} + /** * w32_set_internal_border_width: @@ -5873,6 +5903,28 @@ DEFUN ("x-create-frame", Fx_create_frame, Sx_create= _frame, parameters); } + /* Same for child frames. */ + if (NILP (Fassq (Qchild_frame_border_width, parameters))) + { + Lisp_Object value; + + value =3D gui_display_get_arg (dpyinfo, parameters, Qchild_frame_bo= rder_width, + "childFrameBorderWidth", "childFrameBo= rderWidth", + RES_TYPE_NUMBER); + if (! EQ (value, Qunbound)) + parameters =3D Fcons (Fcons (Qchild_frame_border_width, value), + parameters); + + } + + gui_default_parameter (f, parameters, Qchild_frame_border_width, +#ifdef USE_GTK /* We used to impose 0 in xg_create_frame_widgets. */ + make_fixnum (0), +#else + make_fixnum (1), +#endif + "childFrameBorderWidth", "childFrameBorderWidth", + RES_TYPE_NUMBER); gui_default_parameter (f, parameters, Qinternal_border_width, make_fixn= um (0), "internalBorderWidth", "InternalBorder", RES_TYP= E_NUMBER); gui_default_parameter (f, parameters, Qright_divider_width, make_fixnum= (0), diff --git a/src/xfaces.c b/src/xfaces.c index b3b19a9cb2..5080120957 100644 =2D-- a/src/xfaces.c +++ b/src/xfaces.c @@ -4913,6 +4913,7 @@ lookup_basic_face (struct window *w, struct frame *f= , int face_id) case WINDOW_DIVIDER_FIRST_PIXEL_FACE_ID: name =3D Qwindow_divider_fir= st_pixel; break; case WINDOW_DIVIDER_LAST_PIXEL_FACE_ID: name =3D Qwindow_divider_last= _pixel; break; case INTERNAL_BORDER_FACE_ID: name =3D Qinternal_border; break; + case CHILD_FRAME_BORDER_FACE_ID: name =3D Qchild_frame_border; break= ; default: emacs_abort (); /* the caller is supposed to pass us a basic face i= d */ @@ -5619,6 +5620,7 @@ realize_basic_faces (struct frame *f) realize_named_face (f, Qwindow_divider_last_pixel, WINDOW_DIVIDER_LAST_PIXEL_FACE_ID); realize_named_face (f, Qinternal_border, INTERNAL_BORDER_FACE_ID); + realize_named_face (f, Qchild_frame_border, CHILD_FRAME_BORDER_FACE= _ID); realize_named_face (f, Qtab_bar, TAB_BAR_FACE_ID); realize_named_face (f, Qtab_line, TAB_LINE_FACE_ID); @@ -6967,6 +6969,7 @@ syms_of_xfaces (void) DEFSYM (Qwindow_divider_first_pixel, "window-divider-first-pixel"); DEFSYM (Qwindow_divider_last_pixel, "window-divider-last-pixel"); DEFSYM (Qinternal_border, "internal-border"); + DEFSYM (Qchild_frame_border, "child-frame-border"); /* TTY color-related functions (defined in tty-colors.el). */ DEFSYM (Qtty_color_desc, "tty-color-desc"); diff --git a/src/xfns.c b/src/xfns.c index 9ab537ca8d..cac41ee485 100644 =2D-- a/src/xfns.c +++ b/src/xfns.c @@ -1800,6 +1800,28 @@ x_change_tool_bar_height (struct frame *f, int heig= ht) #endif /* USE_GTK */ } +static void +x_set_child_frame_border_width (struct frame *f, Lisp_Object arg, Lisp_Ob= ject oldval) +{ + int border =3D check_int_nonnegative (arg); + + if (border !=3D FRAME_CHILD_FRAME_BORDER_WIDTH (f)) + { + f->child_frame_border_width =3D border; + +#ifdef USE_X_TOOLKIT + if (FRAME_X_OUTPUT (f)->edit_widget) + widget_store_internal_border (FRAME_X_OUTPUT (f)->edit_widget); +#endif + + if (FRAME_X_WINDOW (f)) + { + adjust_frame_size (f, -1, -1, 3, false, Qchild_frame_border_width); + x_clear_under_internal_border (f); + } + } + +} static void x_set_internal_border_width (struct frame *f, Lisp_Object arg, Lisp_Objec= t oldval) @@ -3897,6 +3919,29 @@ DEFUN ("x-create-frame", Fx_create_frame, Sx_create= _frame, parms =3D Fcons (Fcons (Qinternal_border_width, value), parms); } + + /* Same for child frames. */ + if (NILP (Fassq (Qchild_frame_border_width, parms))) + { + Lisp_Object value; + + value =3D gui_display_get_arg (dpyinfo, parms, Qchild_frame_border_= width, + "childFrameBorderWidth", "childFrameBo= rderWidth", + RES_TYPE_NUMBER); + if (! EQ (value, Qunbound)) + parms =3D Fcons (Fcons (Qchild_frame_border_width, value), + parms); + + } + + gui_default_parameter (f, parms, Qchild_frame_border_width, +#ifdef USE_GTK /* We used to impose 0 in xg_create_frame_widgets. */ + make_fixnum (0), +#else + make_fixnum (1), +#endif + "childFrameBorderWidth", "childFrameBorderWidth", + RES_TYPE_NUMBER); gui_default_parameter (f, parms, Qinternal_border_width, #ifdef USE_GTK /* We used to impose 0 in xg_create_frame_widgets. */ make_fixnum (0), @@ -7762,6 +7807,7 @@ DEFUN ("x-gtk-debug", Fx_gtk_debug, Sx_gtk_debug, 1,= 1, 0, x_set_foreground_color, x_set_icon_name, x_set_icon_type, + x_set_child_frame_border_width, x_set_internal_border_width, gui_set_right_divider_width, gui_set_bottom_divider_width, diff --git a/src/xterm.c b/src/xterm.c index 0a86738cc2..92dcd95043 100644 =2D-- a/src/xterm.c +++ b/src/xterm.c @@ -1293,9 +1293,13 @@ x_clear_under_internal_border (struct frame *f) int height =3D FRAME_PIXEL_HEIGHT (f); int margin =3D FRAME_TOP_MARGIN_HEIGHT (f); int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); block_input (); @@ -1360,9 +1364,13 @@ x_after_update_window_line (struct window *w, struc= t glyph_row *desired_row) { int y =3D WINDOW_TO_FRAME_PIXEL_Y (w, max (0, desired_row->y)); int face_id =3D - !NILP (Vface_remapping_alist) - ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) - : INTERNAL_BORDER_FACE_ID; + (FRAME_PARENT_FRAME (f) + ? (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, CHILD_FRAME_BORDER_FACE_ID) + : CHILD_FRAME_BORDER_FACE_ID) + : (!NILP (Vface_remapping_alist) + ? lookup_basic_face (NULL, f, INTERNAL_BORDER_FACE_ID) + : INTERNAL_BORDER_FACE_ID)); struct face *face =3D FACE_FROM_ID_OR_NULL (f, face_id); block_input (); =2D- 2.29.2 --------------31762D970CBB97B741E09817-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 06 13:48:20 2021 Received: (at 45620) by debbugs.gnu.org; 6 Jan 2021 18:48:21 +0000 Received: from localhost ([127.0.0.1]:45548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxDr2-0008QY-Ld for submit@debbugs.gnu.org; Wed, 06 Jan 2021 13:48:20 -0500 Received: from mout.gmx.net ([212.227.17.21]:56463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxDqx-0008Q9-CW for 45620@debbugs.gnu.org; Wed, 06 Jan 2021 13:48:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609958885; bh=KdrvLkn7SrrXGtYizo2DiS4TcvlTKlbHvkqoyZS8srk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=kB9Q81lgYhfCc9iGlSagSiWxEDeJQLJKBKLR+gxFO6eEBpKiQqfQN+0x2CizQ5Y47 XyUh6TGzJgeNk+bBdQXSkODm1jWTrKvEE0Bp973OIcupulvCsAD0eEC2Z/Z5PGzRdX V3Wy/H6hteaopiUWTZgLAtllvLNYigx4Uerq6Ws0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.112]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MVN6t-1kVY4w2Ub9-00SRLY; Wed, 06 Jan 2021 19:48:05 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: From: martin rudalics Message-ID: <62156308-5e77-8678-aea4-c49f0f6eca46@gmx.at> Date: Wed, 6 Jan 2021 19:48:03 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:C+1TiLEBsxtAQa+V4k5aA1lhherJGybBIaJhRvbYWLlrFweidfy sI0x53TuzuwUQFVARLa7lAVGtrJsp8CpTR6BzY47cqpEv8lNiuo126gDbmMDrjlRXbV91N+ ayiNFHpNCv8MBDioIwTGG7YPdamjRmiRDBxPy9kt+yeWRFk974MT1YYDRFJd/+Vvg5u89o7 YV3CF5XL4sd+hTbuiyMbQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:9H8X7EsbURo=:2TIGfOreneGWQFReT+OmvL Xk2h1A6xBw3oj6sPWquJbMiiBaSfZNLW0mw4B89prCBk2vSuy/ALEcM5CkE9PPxuNQIKqhn17 CNQPQv0ZjKNoX/q9shZwXDGUDSHu9vx5KWklnTQnxCew4+IPuXynAhasYp8UgOAouHUE9u6Lf ajG+BL24YcLbsr31xq/DA1BD6TAdFzl5Yg2VYNTtiods8WZ3NJDMKl3irDyqVu+lnb/B3Lwdi whnTFZ1Bsk6dK4v960DKxckUVdsLx5czYDrz4OjkkwQSHeKKC6JF4xZ7hdcuqQcdItyH6SiJb p5e9u+YNZ0fCxyPgOifpkzoASyQfcx4eFZeJpIJWpYI00D+fSovube4TNbub+OxMMSLsqWqRN eoDGv+KKAKjUg0xrzismljQgpEHZ6n154tnyj5A2KlZZt3ynPzD4/q14QR17FpZWaxZj71qLg CUBwYlGoOWhgwlX2vj+Zy4GiXDtqlFysApbuh4agCBc0uTgDppeu6X7czL6IIWUxU3JeyjvQ0 VbGnGTy4I82JNKYYPVqpKszFDE6T0k9xaHV/4X16LtPDHp3bfzoAPAANRJLRdomen2A/X80eg +9oN99mfkU70TP9f+su2Y3h3g1jrRKdaRfOTqy5/1QbJzCwVZBoYaUJSD7d6wJJGAlvhQJ/rO I+YtZ4THPn7mC1BoF/FSkRhjBq/hxZNSbROrnNxL++ovB/ByZJUrGo5WNtbA0LwKFOPoa/oOg jlypJYLXNgiVuim47X4bqwwk6I/SrAOEa2zU6ykHLf/NiF50Jq+XHRKPIYerfrW/kMQg8V2aI ckLnHTYIT569riuInnHOV0tW/yJqTil6GmE34gGHQVc6Ib5Xyh3oCAC5PGD1sPfHW1yBa1VyJ Hs/PZH4IRwM4q7zqPBWg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Ok, all done now, see attached patch. Looks good. > For the copyright I have asked my employer to make sure that the > copyright parts from my contract don't apply to the work I do on my own > time like this, but most of the company will still be on holidays or on > sick > leave, so it could be a few days before I get an answer. Let's hope for the best. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 04:17:43 2021 Received: (at 45620) by debbugs.gnu.org; 13 Jan 2021 09:17:43 +0000 Received: from localhost ([127.0.0.1]:34254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzcHf-0006UB-0O for submit@debbugs.gnu.org; Wed, 13 Jan 2021 04:17:43 -0500 Received: from mout.web.de ([212.227.17.12]:41869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzcHc-0006Ts-3g for 45620@debbugs.gnu.org; Wed, 13 Jan 2021 04:17:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1610529448; bh=Tu29n4P+x8+ThuYCfm2GprEVxuUiYKKESogpssrIGW8=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=SvIbQoXiYVRgIq9bf1hzbybBiql6J7fc1sNYwARvFPYgzH+75ddDommUp32WsHps/ xDWN20IE2dD2l1kZRu6/aUSQo2aGkN8nMgvjbGCfDdP5ADNCdEGF+h81oYo4R82AAz Obe1u/2S07FYes+zl//KhzAVvzTeBLZbSIR0qqOc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.105] ([217.241.231.57]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MFLB2-1klGns2lts-00EM9x; Wed, 13 Jan 2021 10:17:28 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: <36fcce05-27da-b555-34e6-e80c42d4813e@web.de> Date: Wed, 13 Jan 2021 10:17:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:YIKR3ncMe9OugVaEWl1vBP+dOTHYg8QM2yEm3SR5cxMpNbI3laj 8IU4yOMCeXH1ioPGzyVwftUQABaXjQHqG9uE49SeGpXr9JcIhL5+6NSBlDRI6Rfd1p+l/Yw k6ebso1/l/npeddWscmq6R0pbosiJkHRfaPao/V0Vdl+7wJk4v1icYbNrGvaRRpuCjCKmL5 QvhWcoDfGeMLsxfWO7Llw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0Vel8/P0Pfg=:jMWc3QhM66dByvxugD0s/e o9CstJzpCFPNsEEapAGJdcFpmiPCfWcdvNHTAS0G68FwMQHe+9AgOxBIc4MHf9zHjuxb3QLi9 Ti6mjTtnXjYoL8msNybG2qNp3ODYCDg2+RZFJnN0toYLFwxGOjTIeTfloaULZPSNgWV8Hwvn7 twe2SHEOhVK2o1Rwc32/Kk0+VBgB8pThsKhG/TgIp8I7awWGjDG/dXLRVB0H05enzM3IZWYmk /y95C7/fnhoNdX+dQR1RBFdTvQZG/NwAQptSP82uWttb4zXh5V8ThOZ7he5d9S95iDNm30/L/ V3HRZHkhG6Kbp4DNEdylZeMm2qsmvuvTKefIjIj9JLHJbWuGFSadqHavlTBQmWx6DMEgC6dWk B8SdHC7zVfa1fGHvGlMffqMCrXqi+vJ0TwItkPLeSJXKdUDZZKv2wm9BFI935PpXRXRkLC4tw 3EsbvVrua6um6QyK+o9S0X0i718wJ1TKwoigCAXVGR8xGjPXk8NiE/CX+sXcC6kLcm9G5r2N5 7pT07/h+U7pkOLTwoMlHboytbIkafr7uGvy6mllZdWoaCNaRi0HU2EQWdCIrjsuRHEPtDcFjJ 9VIV9UnQvy31OF4wrSqdN+zXjrV3dnk1WQViDRuJXrRGDOskVarJhDAtsKbdroeE/hcvkhytP 5+OYIW5gxkXr1C6eQoafBd+p+VljGWc6Ec78jppjBCOO4M8Jj5uFOrnGcytAgCgtnFGB0TPGz h0bxeeuBJc2XtI5mTN2zUzOv0LKA9WZLbZx8K2L/RB10gpygb4HyXXCuc26PI8MLC2z57KeoQ vDJVprGeYR0YEwvnSZo4ey89LahfjG04ymBmkt3PdJK2UK7+1NJ/MEFmrCtEaq899ZNJQ6Pun egTEVQhlWGTX/vO7ipBQ== X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> For the copyright I have asked my employer to make sure that the >> copyright parts from my contract don't apply to the work I do on my own >> time like this, but most of the company will still be [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.12 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.9 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, alexanderm@web.de, eliz@gnu.org, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> For the copyright I have asked my employer to make sure that the >> copyright parts from my contract don't apply to the work I do on my own >> time like this, but most of the company will still be [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.12 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.9 FAKE_REPLY_A1 No description available. >> For the copyright I have asked my employer to make sure that the >> copyright parts from my contract don't apply to the work I do on my own >> time like this, but most of the company will still be on holidays or on >> sick >> leave, so it could be a few days before I get an answer. > > Let's hope for the best. > > Thanks, martin I got green light from my employer and sent the signed papers today - we're good to go for whatever comes next. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 13:07:33 2021 Received: (at 45620) by debbugs.gnu.org; 13 Jan 2021 18:07:33 +0000 Received: from localhost ([127.0.0.1]:36540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzkYP-0000V2-Dg for submit@debbugs.gnu.org; Wed, 13 Jan 2021 13:07:33 -0500 Received: from mout.gmx.net ([212.227.17.20]:46851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzkYN-0000UY-KS for 45620@debbugs.gnu.org; Wed, 13 Jan 2021 13:07:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1610561241; bh=MMh/NwrTLnGr9goFrtmOOaDeYEIGvdvzWCR22XNy+HQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=bpvwg5c5VGflyQIFWzNnDD0+ZgDDLSTh+lHrAfNQhJPT0ML3hcxp+CThBHASpnOCA knyrPeDsqjYPWDnJQ/g9TN6W1pljOWUMNy/sUehWBE/xMpAgcWv0w8YiUUw3/JsbOo vDcG+7VnmrwjCbkcz9hxFiKtMSheiSIMRZ90eJV0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.103] ([212.95.5.65]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Ygt-1kwjTe0ZlT-0038g6; Wed, 13 Jan 2021 19:07:21 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: <36fcce05-27da-b555-34e6-e80c42d4813e@web.de> From: martin rudalics Message-ID: <80d5753f-7be7-7a1d-4193-dc622c065127@gmx.at> Date: Wed, 13 Jan 2021 19:07:17 +0100 MIME-Version: 1.0 In-Reply-To: <36fcce05-27da-b555-34e6-e80c42d4813e@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Fzk0OfYavZR7KlCRNN8WW5vGQBFkbvvIKV1QjXaShQgbnk/3kW5 zXMzXhQa7iS3bTcJuJZZxJo9oIVhFPQy9HjRyBEddrK0VF5rE2UY+/eLFd7FFLfSBpdV1OB H8JuXz+rDaEW3DNJV+H8BxCeJVHjIqEj7IbL9fjLvLZB7YHgMS+Fv8XDeLZcyIb/67rczre vu27ZDRt859t8xwhWCGGA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Th6g7T52J94=:yeg0sagK0mzaOJGn16BSo5 zR//1XTbV5KA1COitd2cWNH3aac70d1LEdm+3alygf4pcNrl6eMbbQcPpEvPOct1wJNAD+pPP lT+xlxdqtn+dAY5t8k6KaNYK/hMG9OxM+d1dPmuBg/08Jx75Km6g2z1fYz9c8mGyATqSUf+Yq yGJqSFN/HLecRdeaOOXqNVF6nScHQcCxyRhfcmjnJu/8ZGL+r1hWc0zYA/TZGfLat59khcrJl Ny4dr/034V+iBq2JEqY7ugwufgbd/Csr1IW4vKYTyCMbsIarsK6UOeiXJOvG5Z1t6B7Q0rHv6 cB9hv69oRJkib4V31xBsVLVpoRaXs+4HXg4eVV5bIw6qxjBzaAUEU0rFmqPjDlbrbPTh8hNi1 RRqVWYyCzvB2Vdvrs6ImBhdV+n1EU0s3J7Vgl4AKm9r4N/tuXiiwtrAtTfTE0qbCkxS00pl6A +8ZRG8s49tZQT4w+3rizzLwlKeKgs9wVL7HUGBg99Nw1BtptwLxh0DIqxSK/4DrkL982MhDHa Qy+2zOzr2w8QEg47Mfr3gv85hrBEBJNmeIhLeN5qKh5I2GMwdrFZtLLPh2MmrVhLYFKSOU3O1 GKru39/bc63SRc49ezz5JXp7d57oB2zLbC0y5jBNeaASmSP9nQ6idhQq2zsJPjRXxzQKv0vL7 2bjGXFJsp5/rR5AEbEQP96ZYQpFALYyvw3pjMIXY0umSh5sZVOYyAGcCxGzr5i747zKiKLeg8 FnAERrr6XL/FLF1+u677o3/OiBfry8VI7Exe2ALwQt7PswXP26Gs5YD+dV1m7RMZ5mWdGXAHl DtSQ6HaY41KUtdyGy10vre9AfXfxciYRpTs4T4rOPeofIm1DG4myBn7oLhIqyskUgwJlr6lqp pRBkJtjp04EXnKUF8yVw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I got green light from my employer and sent the signed papers today - > we're good to go for whatever comes next. Fine. When the FSF gets back to you please tell us. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 07:09:18 2021 Received: (at 45620) by debbugs.gnu.org; 25 Jan 2021 12:09:18 +0000 Received: from localhost ([127.0.0.1]:38190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l40gI-0005o2-Ch for submit@debbugs.gnu.org; Mon, 25 Jan 2021 07:09:18 -0500 Received: from mout.web.de ([212.227.15.4]:44875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l40gG-0005nn-Et for 45620@debbugs.gnu.org; Mon, 25 Jan 2021 07:09:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1611576544; bh=zpJomNg1qBbe6moPL4nJLyxAS1PMoE3XvRog2gLeTrQ=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=qwy85LWXT3M8SGLKIHukBULP2RcUHTD4NNgvjtrI70soOHDPccg2Zq9CAZ+PCvkYR jxBuopPELIpTB6GG4tSTQtRbmvItAGemQZtQY3BGcQg3jtFeg3FzdWxCHgKoJWocOt q8heFKhEuZMFeS55HyZJ8BtT4RBecBPl+p01thpQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.105] ([217.241.231.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1McIga-1lZm3w14lY-00clQ1; Mon, 25 Jan 2021 13:09:04 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> Date: Mon, 25 Jan 2021 13:08:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:d+auYvFl3hFM/xHPFKvnQIuEjNKRlvYU6auU+xn8LVx7aVXCfCg bQLpxf4DuBOifykKjELCB+naKY9z4JdzKfH7uDBOrCmkD5m9Xw64ZG4NEUZCuK3mhn3enEi LWGIWs8sekh2gV3LjoM/5mAO0qh1VAbFJtdGlgqUL9lQfE1rXoMi4hRWEJXskqBq1uw4nl+ ynOtL/ns8vqS/XP8sWEoQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5jivOKHDRJM=:TkMPWfCVGalpx1tezkrycC 110CsvHw8SRgwSs1m/ybwhjg9juLBW5SQ28VHfMLoHEW1qc5Bl7Mqxo0Io9HR8b+I08KqNYA5 W7TD/rezZUaIOXSDSVeruT1iEwlAT1UOL946CXJYrVjtjBmTbO/86lII5XRVisYzoaaTtPwKm yU61sz/HyTb5BhiceoZUMdYkfRSA/tcPmo2M802nI9miof55wlSMNP74WWnB4IWHddmZWbCYs BLBLxyPfE15AACBxxGYXVwBTK9U+rF5wkOdvl6cYEqlaoVPecwqrYYgVnwPWLef1XiuU5mn+U IZBQjjiOBFQkdvH+TOAObZfFmUa1QQzSwmt9tC7U+NQTiR3TUkW5dxK+XC4Wfvhf2Mg0pXS6F J1WwSpvel9368kzfC3Hf0scpmGo64wdDR1r++zPGvbTaFdI3G2Mma6PptKoPEEsLlLfaaaX94 Uu73MWB8FIqtbNT96j4TOK0x1Nh0VY6J33SEQik6SAzSrmT1Kbkdi6TbKnaAVzqSvVC7KZnhk iLmaTK2oliXWfSqu/yUiLc1TEuIMwfSAgSwdKisIPeiVFa6OL53xe7Iu4gF2IaxIPOOu6g9aR c3RMBAmVLeCcwwMp6zzNLcPPkUvmSk1TRX1+BjHOIa0YJvPLfrBW824Gq1XYC12jpq7v2G5e9 4jTx3AMGw5/OzTa0Ddyjk2K70UkHBX0NeKPONJDk6kIqHlsgO+mNb4bwRJedxPGpEBl9fXG2o Y2W6SgTIbPlmN2cqHjeUn6g848mbPgqgYAzY5yfAop8pkW4s3j8CSqDUAuYTXXOjonFdL3PlE OeHkagl1SrxiedrDygCQInwyxOnFER3F2Itq25PvM6RSLqJDslWzx1w7QxIUnfPuCZqYIw2I6 NIv38FiV3+rUYjdrTYDg== X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> I got green light from my employer and sent the signed papers today - >> we're good to go for whatever comes next. > > Fine. When the FSF gets back to you please tell us. > > Thanks, martin They got back to me, I have received my signed copy of the documents now. Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, alexanderm@web.de, eliz@gnu.org, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> I got green light from my employer and sent the signed papers today - >> we're good to go for whatever comes next. > > Fine. When the FSF gets back to you please tell us. > > Thanks, martin They got back to me, I have received my signed copy of the documents now. Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. >> I got green light from my employer and sent the signed papers today - >> we're good to go for whatever comes next. > > Fine. When the FSF gets back to you please tell us. > > Thanks, martin They got back to me, I have received my signed copy of the documents now. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 14:05:15 2021 Received: (at 45620) by debbugs.gnu.org; 25 Jan 2021 19:05:15 +0000 Received: from localhost ([127.0.0.1]:39936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l47Ap-0006ND-3h for submit@debbugs.gnu.org; Mon, 25 Jan 2021 14:05:15 -0500 Received: from mout.gmx.net ([212.227.15.15]:51481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l47An-0006Mx-Fk for 45620@debbugs.gnu.org; Mon, 25 Jan 2021 14:05:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611601505; bh=iHj5m6X3Jb9Av7DqOyFrw2cMtKFXVQQcI4K9mhjCOsk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=I1PYjVKeN3xafCJSWGCUJiJrssqGgyf84Yx8xmuOOrNZX8hPEOq/8QBPjn10prKLH uUv1/ax2VVjekfPsQiYAjI91HAJi94KKQjLyyfjDGSlU8wvVeBshoDdSx7NIWFnlYY JHlxoeG3ShD/NnFLCHKY2o8+6c0mkZSJIQkiNt2w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.156]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MV63g-1lSxXi3VCQ-00S9By; Mon, 25 Jan 2021 20:05:04 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alexander Miller References: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> From: martin rudalics Message-ID: Date: Mon, 25 Jan 2021 20:05:03 +0100 MIME-Version: 1.0 In-Reply-To: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:uQ4Gf47ORk9lwQgazEMn2BvYKNe5oyXAT2fej+V8Loqxyex7Cy+ sRYOXKa4/Uwap/WuXHrWPngRPPspU+IjkcddxuuRNN1bb3pfA0DaLmzYtPkb5bXbl8wB8OC 41NC6n8XfxKVajZoOnGeJku8iQzvlCB7H1QUxYffPQeAyIIfBwwGKQ10pS44yPrux2mBsi6 CQttESWsHHYDoqoBWcu6g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:PfFfUDGNw4w=:KShmlrRhRX50ni8ADxXjao MqPxR64615OUFlF74WkAesdlysOQaJjsa80o91MlF6yw1LW12ToZOnEuy30+pZaFjlVSO/gRR ZZ1r3+OCv/PwHUXpKleYzgf/ZcLVuhiML/OaGEMUe/8qTfQ2A05U/QhOulCyvZixNKRqCVQqy SxGuZvYZElkfq/uGNSojCD6CbQg6RqYVs7syisd7EjfYacKICaUtadnlnWgVxYS1ReTf5ak68 ptS0zMpaJBHG5N/BVFjTn8oSf77QCaUU91B8b+/mDPLwTjE/paGW9PSXNxcIgkertElMKelQL JZxURR9jCUsPflxEETL+plFggLzvy9bCWhPF4uMjRhjAGOwOJzZJ21FVG8C3+JYUpQ7vkj/M2 gpNZTr7ubX4bg9GK2/vtzewiJdQgyheSdOs7QehSLC6zePVyggNOlL8A2VrSKLf7NSQ3TWPFG 5019DfY7ToP5YLqOORcwTwg80ZpNzDoW3yFa4Te96vtn7UbcJavVbahCHe6X3gs+QHrlOV9DO wVaWq6EvBwcb+bMM9vwaExEh+Ay6hcTQbSuftnLlgDL7xr/T669E49i/Z5rRmHDeMfcNXJnJA vUkZ7+aTtdZ6EnzwBIg0SSlEGUv8oJlQOlGjuKikTc5ypHR2XJZvC51KVKg+hAb5WNiiH0efn 5mxvsZAfInMG2rKyfDU9yvGyW9EcGjcOk24QPapDdEdqbf/CTX6sR13gLtpvqgAX9ex2olCkW 20P3OvXEBzBm1LGwgWS58xLG3ImWkBYnAQsRkylJlscZ7ztR0mYXCHEBW0WEhZlIzxDxZp/nf 6Yu8UjWMcU9m0ct5S0qavHRcxBhcNpI4KOPwvqfF6AG78joVJIPnAsyU4szXciXfqTV/2N8tZ Urnn7lOgWg8SkHammiPTJHgOsII95Z2veUgI6JgQI= X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > They got back to me, I have received my signed copy of the documents now. I hope to install your patch tomorrow. If you want to ensure a precise position for the NEWS entry, you'd have to update it though. Otherwise, I'll try to find a suitable position myself. Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.15 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.227.15.15 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.156 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > They got back to me, I have received my signed copy of the documents now. I hope to install your patch tomorrow. If you want to ensure a precise position for the NEWS entry, you'd have to update it though. Otherwise, I'll try to find a suitable position myself. Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.15 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.227.15.15 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.156 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders > They got back to me, I have received my signed copy of the documents now. I hope to install your patch tomorrow. If you want to ensure a precise position for the NEWS entry, you'd have to update it though. Otherwise, I'll try to find a suitable position myself. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 10:59:35 2021 Received: (at 45620) by debbugs.gnu.org; 26 Jan 2021 15:59:35 +0000 Received: from localhost ([127.0.0.1]:42488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Qkh-0001sN-Jp for submit@debbugs.gnu.org; Tue, 26 Jan 2021 10:59:35 -0500 Received: from mout.gmx.net ([212.227.17.21]:34193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Qkg-0001sA-1p for 45620@debbugs.gnu.org; Tue, 26 Jan 2021 10:59:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611676755; bh=QKTVV7igJRq9evYnFWNmT6m4dwAA5Aq6cTAU1zHDPS8=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=CTGyUnZEL0ADEeCpdz2F6ubyfm1HRXNVJGz0TEXEiJNB0/rEE9zFGiOsm2pr32Mjt k4jXq63x1pTll7nbVK2PGcDm55H2O5NbgR5w3UmlGrldYjO9Y/7snJVeQKiptpKB0U DpNTjU5j/ZOtCsEtxHAWFdrnHpnLI5tMLno1CTDw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.16]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5G9t-1m5ZQd2ok9-011BmC; Tue, 26 Jan 2021 16:59:14 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: martin rudalics To: Alexander Miller References: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> Message-ID: Date: Tue, 26 Jan 2021 16:59:13 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:x1xDtP76Ep+qYNQDwRcbtj7uUTd9oxfKLK1v9/7xNwDz146f0tJ rubxAZR4A1OyCgGRu3jhvvBg6xdn5VAz/ztKOK7ZePYZkCX+9SQya11a6QelS79EerBIm0S XZ3X9XZrQFNymC/jnjO5oRGzf/p4KnErNNWQgQcWy/lc8xyDxiHaZ9TJoDMdOqj+dNvZFw3 2H4CbsyVUpkbk3gO4/5bA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jmKsj6i1EYA=:KCS1xdoDH39gghEnIAyUhx wXi7G/87CrWiWFNIEns0SjymTcnfFA/26Kr3yKYN99qM/ZMbS4ebM/mLmELlG7cJBPyE7KEUp TPge2euaWvcdKxZQbjJ4f24epoADG2XJnEeCj/aADTuGw3RAygpwnDNsONF5+FLtO730gq8Np 624Tp8iUaZc47uYU2RczjyAjVT6bhdC5hTbj0JVgYcc4bHvO9oGDDVgsX5e1naJqETtWcsV7L kTSbzXcIjdsVlW++nCaq51SOyLxCt1s+XIgoNeuJ5pGkgZ2y9z6vb9vCrUbAJ1Su4GvwaP41f 6+QHdDUiyryawCuYEMn8+34niT4T9taypkfxW2Kw0RVLlKYW6CgJfmO+YQOPptfSCIcvugxBR CKesVjfcrzpZru/leyr64eRAh9onTcfKfhMjZLwPgGRdOA/Rv+f2MhXmg6P/hVgDDnMBtponl 2VDUP/NYhL+rCiiglmBOUPMbd7IaLVBFAsvRjAAic2M9DOdXFpx0CTQA190YeUk85kc9shW4d 6kugiIslZJshUAL8CPBst1eA9/qF//u40QCBceOR50cNx+NrCJipTddzclI2dEWzsLhbcJ9YW 2bqSO0N29O8AUoTh1K+UpwebJX4EDbDL+VAtHbrQp9VtCDS+zE9OXjRFwSJ0RqFljdCtYUB2d aa3Ma+27cBCB47mVBkucat9TOa/u1wYI82FciZZVn+9x7DKymYR9weVkS/yOGnmqMytAFR8jr DCGmFxz4Ni9WrVomIsA9UMkEoMR5p2M2cOm754k1MydmMs/uT+ST24wzd1USFfwmJeFw+xdyq h+edaXJ++wdeR9RdJmt6DO3rarg9H83x2h6C1gpG9Rc2l6lgyB4KVelWvm8DLhQvJlU1y2LxS qOG48DpGKhNeilnSO7bg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I hope to install your patch tomorrow. If you want to ensure a precise > position for the NEWS entry, you'd have to update it though. Otherwise, > I'll try to find a suitable position myself. I pushed the changes now with a few tweaks. Please have a look and consider closing the bug if you feel that nothing else should be done. I couldn't test the changes with GNUstep here, those builds still fail to behave reasonably on my machine. So if you know people who regularly build Emacs with NS, please ask them to check the changes. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 15:37:34 2021 Received: (at 45620) by debbugs.gnu.org; 27 Jan 2021 20:37:34 +0000 Received: from localhost ([127.0.0.1]:46238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rZG-0002b2-0a for submit@debbugs.gnu.org; Wed, 27 Jan 2021 15:37:34 -0500 Received: from mout.web.de ([217.72.192.78]:59155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rZE-0002am-5Y for 45620@debbugs.gnu.org; Wed, 27 Jan 2021 15:37:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1611779842; bh=BC6nTxNpSuEyY50UWnJELCop/2pfNjzh85ELjXZqOBc=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=WNVjLrKjDVU1OAWFkOu+zw8MNKqQBVoNAqCF7Ia3XCR7beVyqhP6CLOnLrK1algI2 3wLnYVFV/WJ2mq13GRADeBFeStomB/FDEv/7lET+JDC6Bceczl1tWWh7YZMSJZNEOP TOZT3UzRzfN5hNKEGX4gdHN8MH0PXNO2tMx4W3wc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M2PdU-1l8hJs10wA-003xKq; Wed, 27 Jan 2021 21:37:22 +0100 To: rudalics@gmx.at Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: <6b45b6bf-d52f-e4b2-aeeb-46acabadb0ab@web.de> Date: Wed, 27 Jan 2021 21:44:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:Bgz7CqFUyEZe64b/oyyLDDEc7lETtsuEb5Kg3UU9fT9yOw9J/9P NuqofyIjdm2De+LTYsN5OqFSEa38XBMYztGidOd+BuF74RfP6Ew9p+lnzkOSRbc/utk1jCc 8yFZWgIpkDuvRfZHGrv01hk+b3kCQc/Pco199zbkcG/3P1RIrnaI0MO7s6MWrUfxkA+9hmF XfbqHDmm+0GGZMoIXHvYw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:9sY5KPkcUSE=:1ZIPXxcKJVYP0eqIac5iPb 8WcLqxH+P4xJ/2RycR/bbZI+XPOzL7VZcA6bLM/82nJ1bMJutW1z4yVgzgUKE/+tLWBhoDeCR 1DOZLn7h4YqVZPUDZsw7a48u5O/8Pbvm/m7VdG9IpTkCHoo6vKgKm38OOSo5HuSpff/yiaIIU TpDBTErn9zdhZTohrOY8vZQm/cjsfgf692v073J8Uac0YBhKRgCdB4c/ffJbUvZkd5/8AB3yN WU6b8wd+x9zy/Kl9GJ5BjsSenB3rus7SBM16VqmbyBQv5NkCXz5IcE5ASOQp1rTENHAeq19/h ZwCiycH5IaRy2yR2eJLsui6Nu26ajr/tU9tKtdBVRLVloftxjbw+F/ti4wgKPC0EafhHrMbmU va7Y805j8ZsZ5qeB0Vdsop2Sn0Q77h3wxsgLsqlBLglX62TkUAi8DMFC7SADMGbEaTK7Bz6un ayZh1aP2rw/SL/WRSj9amkG7/FvccmKlHJaRj1lk91UqEV7iPS2g3bZp4iQTz4TsHI9dijQeV jw6c6k3GH2hUN+1UZAWxrYCNdQc7YfjkAzjfyNBgOHicZFSGo+G6T41Gka3hiGn7JQrX+cuTI D9Jwh4p4EM5ec3KgP2sl2vUHv3aqxawtsQ2e1zLen9vCEJUuOlbqGVTp5Xt6KX93y7M9DSJlU lVYHZyR0O0cy6hVbuFVwwIuOLnu8zzP2GN4WDq3Uz1SqUXfJkJ5ZWTQH0O838zgVBgmHKTJwc 8j7ZxqEGq1wha/zgThLvleMsUOIYrV9Bh8vec2sYu21BRka4tcTtAhhtTXbbp2+1gCUkf0pZt 19fNB+7BaJei+R220IXk6MeiRptY/CtikvVwhh5zuR7jBruGBDbGuorx2e2+w4I6gl+pyzZ6i OzU1nk4R+W+D0G4mnMFA== X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> I hope to install your patch tomorrow. If you want to ensure a precise >> position for the NEWS entry, you'd have to update it though. Otherwise, >> I'll try to find a suitable position myself. > [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.72.192.78 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.72.192.78 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> I hope to install your patch tomorrow. If you want to ensure a precise >> position for the NEWS entry, you'd have to update it though. Otherwise, >> I'll try to find a suitable position myself. > [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.72.192.78 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.72.192.78 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. >> I hope to install your patch tomorrow. If you want to ensure a precise >> position for the NEWS entry, you'd have to update it though. Otherwise, >> I'll try to find a suitable position myself. > > I pushed the changes now with a few tweaks. Please have a look and > consider closing the bug if you feel that nothing else should be done. I have tested the changes locally now, and everything is working as expected. I'd close the bug, but I don't know how. I have found some 12 year old documentation that says to send my mail to nnn-done@debbugs.gnu.org. Is that still correct, or will my mail just get lost? > I couldn't test the changes with GNUstep here, those builds still fail > to behave reasonably on my machine. So if you know people who regularly > build Emacs with NS, please ask them to check the changes. I have gotten one or two people into Emacs to some degree over the years, but I am the most hardcore user I know by far, so I'm afraid I can't help with that. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 15:50:12 2021 Received: (at 45620) by debbugs.gnu.org; 27 Jan 2021 20:50:12 +0000 Received: from localhost ([127.0.0.1]:46255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rlU-0002uE-6G for submit@debbugs.gnu.org; Wed, 27 Jan 2021 15:50:12 -0500 Received: from outbound.soverin.net ([116.202.65.218]:57839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rlS-0002tv-8Q for 45620@debbugs.gnu.org; Wed, 27 Jan 2021 15:50:10 -0500 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id C1414600E9; Wed, 27 Jan 2021 20:50:02 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1611780601; bh=meo212WN8Chjz7IwSODmItUusPCCBLpfjLvQ852g3bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fDY4sMItNIF7dCDaI7ymayHcbLR+XoQ+6+EQPWr+wIyN64CMx17ko1RbWoPP4d9db qwM7dlT5AAwL+VlCUB9O6K13vtHYoQI01cijnF+/7SYw7AZGa0o5k+8eb4M81bUEdk 0xN6ubuwGMQ4RSamN8NfyeMJGRu7SVr/TAJhGhcpgjLkntPh5e2bTMehdaQorMWRjA tYxlj6ZO1q7F87U1fCd0bo+rUa0WkgE5U21CBe5oG8x61Mb2Ejzi/pU02Dx/qDCvA2 G6cDS3DkpxYjMYIB+msjHDRjaDbeOMIHI6tNSZ/+NxLMmfq0Ez9Pvljl8IoL7Il9C2 Ba5EfocoPLadg== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 5CDB8202A0419B; Wed, 27 Jan 2021 20:49:58 +0000 (GMT) Date: Wed, 27 Jan 2021 20:49:58 +0000 From: Alan Third To: martin rudalics Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour Message-ID: Mail-Followup-To: Alan Third , martin rudalics , Alexander Miller , 45620@debbugs.gnu.org, tumashu@163.com References: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, Alexander Miller , tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Jan 26, 2021 at 04:59:13PM +0100, martin rudalics wrote: > > I hope to install your patch tomorrow. If you want to ensure a precise > > position for the NEWS entry, you'd have to update it though. Otherwise, > > I'll try to find a suitable position myself. > > I pushed the changes now with a few tweaks. Please have a look and > consider closing the bug if you feel that nothing else should be done. > > I couldn't test the changes with GNUstep here, those builds still fail > to behave reasonably on my machine. So if you know people who regularly > build Emacs with NS, please ask them to check the changes. Is there some simple test I can try? I had a quick look through the thread but didn't see anything. (GNUstep builds work for me as long as I start with a .emacs that turns off the menus. I can't work out what it is that's causing the problem, and even the large rewrite of some of the menu code we did on the master branch makes no difference. It's quite annoying.) -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 27 22:33:40 2021 Received: (at 45620) by debbugs.gnu.org; 28 Jan 2021 03:33:40 +0000 Received: from localhost ([127.0.0.1]:46715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4y3w-0006XG-4u for submit@debbugs.gnu.org; Wed, 27 Jan 2021 22:33:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4y3v-0006X4-4W for 45620@debbugs.gnu.org; Wed, 27 Jan 2021 22:33:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33468) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4y3m-0000Yo-L3; Wed, 27 Jan 2021 22:33:30 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l4y3m-0003I5-3S; Wed, 27 Jan 2021 22:33:30 -0500 Date: Thu, 28 Jan 2021 05:33:45 +0200 Message-Id: <83ft2lzqee.fsf@gnu.org> From: Eli Zaretskii To: Alexander Miller In-Reply-To: <6b45b6bf-d52f-e4b2-aeeb-46acabadb0ab@web.de> (message from Alexander Miller on Wed, 27 Jan 2021 21:44:21 +0100) Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour References: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de> <6b45b6bf-d52f-e4b2-aeeb-46acabadb0ab@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, rudalics@gmx.at, tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alexander Miller > Date: Wed, 27 Jan 2021 21:44:21 +0100 > Cc: 45620@debbugs.gnu.org, tumashu@163.com > > I'd close the bug, but I don't know how. I have found some 12 > year old documentation that says to send my mail to > nnn-done@debbugs.gnu.org. Is that still correct, or will my mail just > get lost? This is still correct. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 02:06:56 2021 Received: (at 45620-done) by debbugs.gnu.org; 28 Jan 2021 07:06:56 +0000 Received: from localhost ([127.0.0.1]:46968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l51OK-0007kh-K0 for submit@debbugs.gnu.org; Thu, 28 Jan 2021 02:06:56 -0500 Received: from mout.web.de ([212.227.15.4]:55097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l51OJ-0007kU-Ly for 45620-done@debbugs.gnu.org; Thu, 28 Jan 2021 02:06:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1611817601; bh=X9tYheigKeL7WNfOI0Kv2o3V+5XTl/aGiOylmSJNhiQ=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=OqxQyVeS1nYOSvNZ6ds7OdhaNSGr5CXgiZSNVZ3j2hWJg3S3T5EMPjRc+3vPWHVwN 08lWcxGfW9e6lBGRC+j4R6d5j0Wzxg276WmY181hmzI8UDwZFtvHqi/lS5VOpDofz2 GnPsYrMCFrayVs0CCymf8HGGw42gFAccvRXrl620= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.2.105] ([217.241.231.57]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LxNyU-1m1vRr31Cc-016vQb; Thu, 28 Jan 2021 08:06:41 +0100 To: eliz@gnu.org Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour From: Alexander Miller Message-ID: Date: Thu, 28 Jan 2021 08:06:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:cbwCbt3KkHFp+ecQ2mVMEqlALbjtAKWquJ8na5Q32IMUbeNV3CC gKfO5YmqaYu37qImLQVv12kox2vU/hInoi5pAGKiTtMeNQBxV3RqUMYOcPvAsx7jCQ2PKGH zan0PJyjj76pLiYdBCUq081/dGdWWHwQpnBKBIfVZ+0NLgsYJjoBR2CRPKjCGohhanXhIlz Aj7/g3KGXr8FMslklYuvQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:LOOZXr7sduI=:1OaNNJjL9zbOAf1LlY3tPX RhIatDre9WfB4OBt6IIyacIHNehNr5OJZU0DZYinLpUdFcZEa8kRyeIKNfGWJqsNib896MTTI 2V9TJILHMfKnWEvqe+SeERDg1JPM6GeolB72jYkHW8HdgGbmDoCIZ4xnbz9dLDoLSD55Pscj3 WcNdXCgInzTqKzPMm/PoE9h0jw34/++9krEHPlim3xebEj3RIdlBtmMQHjXL8dsRFQny3szfu f3VMYApYG+YnyPi0Ge96S7Wmn08/jVNCiN4tDIvlG1eAy+wa6lB5sYl36nOhbLV1X6EPshy0/ yD0ThJ68+JAVEXe5OoA5XNMS2ODfxcHhkRTVju3DtBpere9OP0QnjOx/PBpcx7Ykd8bHXiu4t DKKx42HCggbvg4pSiWvKUPAXrOKVIUp51HQoqKDm78FSbMREwxH3DGO1fjQ/c0DHgFZQ46GBC zlRxc/gNx6P8slqsIs/21aK1Gxri41Ia7cgsjoi+12qHePslaeKBeL9nqspFyFlUpCTwn5xV+ KdFZTldU+kwztnY2iBxtm62G22h2sQbWS/EsK/+2cIE51fgrDGK26IiJIJIig36nchwtVXQkG Pkaq3YZqoQrKNajGt9DFIhKrBbmL001AUNO34goY4Xa3l6HGeVfDvDXDmOHaIecQWvSGW0WgS BWVk4Vk7qxS5I/NMljaTjJANJOOqDyVtCf5ZmwgKCvfq+ckSp84c9oPyHRNNKA9eGnvTS4Qzb T4GohYeHKO1Xbnz5QOvkC+J6RgiNVIIc1Lzw1MzrFeiySqobRpK0Fo/d8F61k207O8rRirvO6 yQ5+a137RaCTxaxOw0RUYzhlpf7yp/EuCZEIwIAowGUGPd48xW1l8V1G/V+dRIikQ4gFLKlx8 PDQjKlj/eb3SZD5X/YRg== X-Spam-Score: 3.1 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> From: Alexander Miller >> Date: Wed, 27 Jan 2021 21:44:21 +0100 >> Cc: 45620@debbugs.gnu.org, tumashu@163.com >> >> I'd close the bug, but I don't know how. I have found some 12 >> year old docu [...] Content analysis details: (3.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 45620-done Cc: 45620-done@debbugs.gnu.org, alexanderm@web.de, tumashu@163.com, rudalics@gmx.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> From: Alexander Miller >> Date: Wed, 27 Jan 2021 21:44:21 +0100 >> Cc: 45620@debbugs.gnu.org, tumashu@163.com >> >> I'd close the bug, but I don't know how. I have found some 12 >> year old docu [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alexanderm[at]web.de) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.8 FAKE_REPLY_A1 No description available. >> From: Alexander Miller >> Date: Wed, 27 Jan 2021 21:44:21 +0100 >> Cc: 45620@debbugs.gnu.org, tumashu@163.com >> >> I'd close the bug, but I don't know how. I have found some 12 >> year old documentation that says to send my mail to >> nnn-done@debbugs.gnu.org. Is that still correct, or will my mail just >> get lost? > > This is still correct. All right, let's close this bug then. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 04:42:31 2021 Received: (at 45620) by debbugs.gnu.org; 28 Jan 2021 09:42:31 +0000 Received: from localhost ([127.0.0.1]:47295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l53os-0005MP-QI for submit@debbugs.gnu.org; Thu, 28 Jan 2021 04:42:31 -0500 Received: from mout.gmx.net ([212.227.15.18]:33331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l53or-0005MB-5j for 45620@debbugs.gnu.org; Thu, 28 Jan 2021 04:42:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611826939; bh=VcFx53EczWo8ApzTKfBY1XLijssQZpPM/8cxz0t66rE=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=aQMROs1baaD8aw962JYarkY/xp3ivE9L+v4XK/W7AgATX6+FY8wPkvQ9QxZIvqclm ui0Sx28FZrXhsdQtZ0b9GP6wh363Ra5GJyVYPQuuJ9GcZH+Wx0PtSzCY26dahSSiek biS/w47DGb9gIstBWXpy2TnNvfOrKc0Mnc7lya/8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.125]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MEFvj-1lFGYB3cdp-00AIi2; Thu, 28 Jan 2021 10:42:18 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alan Third , Alexander Miller , 45620@debbugs.gnu.org, tumashu@163.com References: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> From: martin rudalics Message-ID: <1108564e-1387-36bd-a5fa-614920509b01@gmx.at> Date: Thu, 28 Jan 2021 10:42:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:wfdHbibHEtrsgMtjm0LGLD9NCRzX0uxtLwWtKAX/bMHowaO6fI9 JVC/Mk9fVH/FeEDWkCGKF5eDxtHiVMhr7Cw38QrMZKuFUXAGj4mIemd7Mi7QKA6ohljwxsy pq0ypXo9xZHvEgg9aJJbCwLeCdqHfaqa++eEkMU1tOYUPYfau4Rsd7zVcWJzTrLtAYYbz7l g4GIYOvquU/NQ3OP8hERw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:WHK02fB2OxQ=:/dclU74L4MViVu44o7Np6s 63OrhpRj42xTk7ZhGOhx9bMsCrjGixmDuM6k3TFJr2VsM8D8LLyNoJSWFIsvRDC7kDad+E2aY CFOXH6tdwawTvX5PpdFixBzLpsQp+5zyOq4qo9l13CJD7qxD/tM2ytGXNuUb4fMFdZxjundsp l16Bz9cQ7GQlRqwAAxMLXequhH7jl2VWR/VxhvAuIkRr/Tw/Slig6nZdUKfhatTkDb5TpuP0R j9MGZOgO45C6DAOZlnNEMQl/Sx87rr7Gcj7gprT1wAe7HHLuyWnT5MdfokmxQ3fD/xWGQhoVg 2RKLfLTj/NySh08tFATssF9cZWj9JFi/LvL+S+VSTYJ8tdP8t+z+wOP2Tl8sckD9X0Xi03BlF dXj3mnnYBzZ2YGQnK0F104JbFm/oZytekR9rux3nRwbMlRKxDsKHTzfO0p2d1V0zJwU2GiIq6 gpGEaNHx4rQs/idIVK+owgXdlk3XWGAt6NQZlugQPMuTy43scmIScsmWB/XOKIUmRkM0pvpoI awVlIxtR6gcbswUd5yp+5ow6r0Wx4TwA/RCPbwATV+L5M9Ixwz1H3rlcbfToX8YaWs3qjb4Cd 1tKgXfLOKqXAxJokHsUYDYch/Iy1h8IG9qIAENZFYrCI5youShZUWLe3PpRmbo03njDKFEnqv WRd98EO3kc6hsAqikpKSuKTmtDrbUzHBAMNaFCuOX0xRVks+6YCm9KVGaptdc9NmR+alYpd37 J/yEHletcmFfEjoHexDd0UzTOKPoLjj8+ygTebVTyBAHQq6IGM0HHBa2AWu2q4nQMjnJ43s1G z6WW9X+bLtDCwQTN4v2dlGDhG+mJoYYFK0ZKwXGz2JWvTnNF4f9qtA9qY9Dh4cAo6F3+Iapu5 4FQZWYco8UcwzygLwq2Q== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45620 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Is there some simple test I can try? I had a quick look through the > thread but didn't see anything. Please with emacs -Q define (defun my-make-child-frame () (interactive) (make-frame `((parent-frame . ,(selected-frame)) (undecorated . t) (left . 0.5) (top . 0.5) (width . 0.3) (height . 0.3) (internal-border-width . 3)))) then do (setq frame (my-make-child-frame)) and finally perform the following two experiments: (1) Customize the background of the faces 'internal-border' and 'child-frame-border'. Only customizing the latter should affect the child frame. (2) Do (set-frame-parameter frame 'internal-border-width 7) (set-frame-parameter frame 'child-frame-border-width 1) Either of them should change the border width of the child frame as indicated. If you now do (set-frame-parameter nil 'internal-border-width 5) with your normal frame selected, that frame's internal border width should change but the child frame's border width should remain unaltered. > (GNUstep builds work for me as long as I start with a .emacs that > turns off the menus. I can't work out what it is that's causing the > problem, and even the large rewrite of some of the menu code we did on > the master branch makes no difference. It's quite annoying.) I'll try turning menus off the next time. But the number of warnings when building has by now exceeded any reasonable limit. I can no more see the wood for the trees Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 11:36:08 2021 Received: (at 45620) by debbugs.gnu.org; 28 Jan 2021 16:36:08 +0000 Received: from localhost ([127.0.0.1]:49720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5AHA-0003vO-3v for submit@debbugs.gnu.org; Thu, 28 Jan 2021 11:36:08 -0500 Received: from outbound.soverin.net ([116.202.65.218]:55479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5AH7-0003us-R9 for 45620@debbugs.gnu.org; Thu, 28 Jan 2021 11:36:06 -0500 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 7FF65601E9; Thu, 28 Jan 2021 16:35:59 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1611851758; bh=BVBOw1AVSscEUAOarD/4UCAbkKADEYpJADhdgLwCg+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V2xSXcwH0IZon+IJPfJj9MiHojlAUXu49abXM6QHIOh7X6d3USQz4HSudHPEA8glC MYaqhOEVezyqxFjCixxgp2dG43lqdbu8XezOKWeCRB+o2kwmOJq254lV30A8l6gluS 6JnnGu18QLh5lTOtfY6OQ0o1OC5MOwi/b/J2yo5BO020YW1Zg5sx9MP9z7BK9x1YNm Y2OESsLIY1S6bxazsPiFHUz75yiRR6YZ0Pktm/wX98orIUGg8V+jP01D+9LTRSLgRQ JiqERSIlf2sbeByZ1tPYThJQmvKMsHcxLSYRhzIKf5IeNbFli84hhs1ft22Tfs1hnG Lz8Sx9lKZxLfA== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id CFDBB202A04DEB; Thu, 28 Jan 2021 16:35:55 +0000 (GMT) Date: Thu, 28 Jan 2021 16:35:55 +0000 From: Alan Third To: martin rudalics Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour Message-ID: Mail-Followup-To: Alan Third , martin rudalics , Alexander Miller , 45620@debbugs.gnu.org, tumashu@163.com References: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> <1108564e-1387-36bd-a5fa-614920509b01@gmx.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1108564e-1387-36bd-a5fa-614920509b01@gmx.at> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45620 Cc: 45620@debbugs.gnu.org, Alexander Miller , tumashu@163.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Jan 28, 2021 at 10:42:18AM +0100, martin rudalics wrote: > > Is there some simple test I can try? I had a quick look through the > > thread but didn't see anything. > > Please with emacs -Q define > > (defun my-make-child-frame () > (interactive) > (make-frame > `((parent-frame . ,(selected-frame)) > (undecorated . t) > (left . 0.5) > (top . 0.5) > (width . 0.3) > (height . 0.3) > (internal-border-width . 3)))) > > then do > > (setq frame (my-make-child-frame)) > > and finally perform the following two experiments: > > (1) Customize the background of the faces 'internal-border' and > 'child-frame-border'. Only customizing the latter should affect the > child frame. > > (2) Do > > (set-frame-parameter frame 'internal-border-width 7) > (set-frame-parameter frame 'child-frame-border-width 1) > > Either of them should change the border width of the child frame as > indicated. If you now do > > (set-frame-parameter nil 'internal-border-width 5) > > with your normal frame selected, that frame's internal border width > should change but the child frame's border width should remain > unaltered. That all works as I expect on macOS, so I guess we can say it's fine? > > (GNUstep builds work for me as long as I start with a .emacs that > > turns off the menus. I can't work out what it is that's causing the > > problem, and even the large rewrite of some of the menu code we did on > > the master branch makes no difference. It's quite annoying.) > > I'll try turning menus off the next time. But the number of warnings > when building has by now exceeded any reasonable limit. I can no more > see the wood for the trees Ah yes, I'd forgotten about that. As I recall the errors are mostly from the GNUstep headers, so I don't know if they're caused by some incompatibility between recent versions of GCC and GNUstep, or if we're setting some compiler flag that GNUstep dislikes. I don't get these warnings on my old Debian Jessie build environment, just on the newer Buster one, but Jessie's really old by now. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 29 02:51:56 2021 Received: (at 45620) by debbugs.gnu.org; 29 Jan 2021 07:51:56 +0000 Received: from localhost ([127.0.0.1]:51078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5OZQ-0005an-Iq for submit@debbugs.gnu.org; Fri, 29 Jan 2021 02:51:56 -0500 Received: from mout.gmx.net ([212.227.17.20]:39391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5OZN-0005aY-Ft for 45620@debbugs.gnu.org; Fri, 29 Jan 2021 02:51:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611906675; bh=aT+EOWYkgMzdaEHGwRxCpxUAlofogtAxmqsEyl/EpIA=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=e2Q7KjIyAxFzUZD1iuv6ur/1tGFrrcEF2BXFlz03jwE5gD5OSfzGVD97ws/u2BLBk YVfWfDWm7kjg655ZnQWvvm/70nWvS76lXg8XGvL3VIpvb2jWUv0cEUqgrQ19qXNQUc cazyYk44z2290WWo2mDHHijglMOaLmndo1p0kLZ4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.98]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZkpb-1lRgE02SL1-00Wp39; Fri, 29 Jan 2021 08:51:15 +0100 Subject: Re: bug#45620: 28.0.50; Child frames should have their own border width and colour To: Alan Third , Alexander Miller , 45620@debbugs.gnu.org, tumashu@163.com References: <33f42dc2-5f51-4bbd-9b0d-d8c691ab745f@web.de> <1108564e-1387-36bd-a5fa-614920509b01@gmx.at> From: martin rudalics Message-ID: <254e45e6-7afb-a871-f7e0-be65ec3c1dd1@gmx.at> Date: Fri, 29 Jan 2021 08:51:13 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:UnKJxc/BLevOsinNfyQpPJsgSOpyyBKj+jsHHwcIiZvcAW9W2uK Bn9y/KUZlmdmvNOR7DLq8I4+RSEe5Ae6qu0ly89OKPb4aaNuWFUWx15qjvZfRUCoCHdOJJt uzwlnocfZTBWZglBvgKhlmsCEvSWN505VTV/qZkW9e/YexnFKg7U61Bu879rjEAr6BIdv66 NCXodQ9RyL3uZ37jVcsZw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ODn4V1l7vOs=:6oXOMUrh3AtYH2BtS16Smm kVqYL9cwC2F8G2jmYdHzTFJSseoWO/Iwdf/nuj/QSd7KJx9AV2b9nyy0d9VgIIXKRwlWtSx3Z EkE2uPMVIcdEQT9vHRA7yMFnWpCrCdYktiJn6I3fPQsowJ/uY92YWMVBgi0LFw/J9m0yYAPQU /LIslRttV3G5keum6VDBUGam+MZqrj10bunQBtSM7LAcK7j5osb5wwduv3B5pbX5xewPrMIew erWf9DQVSkYTb57CEV0qFHzlZvUTuF9HIro6KzI3VtpxauqMbVyDfZY4i+SG4Uvdjb5YP7zNL FWz7VWdApm3MYh96PHoFCdV/nHpHAkZGrjrj3cBdOH/CtznZUaaq0FnpNXk3lquBCyXvoew+W dyvzwzrYOzPEUvzoUOoK1+reNXxws1V2UxYxO+58WF5bAeNNAJ/PWpicz6HaM//WUCkL0YNOn S33XmJhgtOcizd56BnGTVkKkGq3IKW3ox9S4sA+5MWBewQtR3+jW5DXvPeUQ33V35g/FtdcI5 eAdXTK4yioj0NAOJBOWso23mnjJldXO/Q2NyNobiqKytAy4Nhv/vstTJ+9VMLsUXP69usbxMJ OoehuKPtRMkEt/cgfPkjgYSmImS+sX+fq60WW1eq+i8iX3cbPrrx8zYis6ojbuxDqiqHqXkY5 gAG9wlz0GkPjQaZL9g5hU66jytUDisIsvr8zQUl/HRL1roVkA3nwKSVUi0ykKHRTH3KGIltAC i6Q+mZUMGQCRtdl8NHbobwv6T6JQa7YF9g/eDWqBbLGzGXG6el2rJBSltOQgjoTjXHGcnK+0j e+yz41yVxNVlBnj5vw1sEaZ09jadHtikmkwjL8iUMUz5k5xkmzYz694QCXGdlls4uyrjeWTzC b8Ne5r9QxRjt4FFk1mzA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45620 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > That all works as I expect on macOS, so I guess we can say it's fine? I guess so too. Many thanks for checking. > I don't get these warnings on my old Debian Jessie build environment, > just on the newer Buster one, but Jessie's really old by now. Here (with Buster) I especially get some 2000 lines of 2021-01-29 08:45:54.042 temacs[3778:3778] autorelease called without pool for object (0xd6f990) of class GSCInlineString in thread {name = (null), num = 3778} I've never seen before. martin From unknown Wed Aug 20 03:36:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 Feb 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator