From unknown Wed Jun 18 00:24:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45606 <45606@debbugs.gnu.org> To: bug#45606 <45606@debbugs.gnu.org> Subject: Status: [PATCH] Modify comint-read-input-ring to skip uninteresting text Reply-To: bug#45606 <45606@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:24:02 +0000 retitle 45606 [PATCH] Modify comint-read-input-ring to skip uninteresting t= ext reassign 45606 emacs submitter 45606 Brian Leung severity 45606 normal tag 45606 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 01 22:57:07 2021 Received: (at submit) by debbugs.gnu.org; 2 Jan 2021 03:57:07 +0000 Received: from localhost ([127.0.0.1]:35155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvY2M-0002Wo-M2 for submit@debbugs.gnu.org; Fri, 01 Jan 2021 22:57:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:45466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvY2L-0002Wg-AK for submit@debbugs.gnu.org; Fri, 01 Jan 2021 22:57:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvY2K-0001Pp-Vj for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2021 22:57:04 -0500 Received: from wilbur.contactoffice.com ([212.3.242.68]:43964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvY2I-0001Zk-5u for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2021 22:57:04 -0500 Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id 903567B4; Sat, 2 Jan 2021 04:56:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com; s=20160819-nLV10XS2; t=1609559817; bh=y2Zp1/aPVRmChCqEaUjHMW91Ccj6wiUcAI8S9U3DaKc=; h=Date:Subject:Reply-To:From:To:Cc:From; b=bscIbCuKwbJUQd/2gkU9sqJnlNilxhsTXDSA3HHUV2BC6+P9958SORcylGyXFKjaG PGA6i/E3F2UsEdPFInqBjeIceLMwVEMHMNY8lNzwKhTAAF4Wm3g/FVmJlTIBsyGBGV 9ejbofyrTG8QFVrURD5g6woWlBMUfFqLja/D7BTP968osZOEOAdKTK8izf/mSdKhzo lYU4B0Ry/4JifxNfFm23psexUA0RLhQ6tpdmQf0T/IQb8l/qIBxoQyhNt/EB+8+yht 29VzXbIWL0fk0QYc2/DkoBoBgc2XZ+H2jrxrbFsq9mnRqTXwraIVHsKxnorYqYcEe0 V8gP1sj1letMA== Date: Sat, 2 Jan 2021 04:56:54 +0100 (CET) Message-ID: <172138729.342110.1609559814855@ichabod.co-bxl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_341911_1541531884.1609559446264" Subject: [PATCH] Modify comint-read-input-ring to skip uninteresting text X-Priority: 3 From: Brian Leung To: Bug Gnu Emacs X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 Received-SPF: pass client-ip=212.3.242.68; envelope-from=leungbk@mailfence.com; helo=wilbur.contactoffice.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: mjbauer95@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Brian Leung Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ------=_Part_341911_1541531884.1609559446264 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I made the attached changes to handle zsh's history on Emacs' master branch= . This is a follow-up to Matthew Bauer's commit f7421039fb15123dbbda047e23504= dd1771183b5 which sought to support zsh's extended_history. Matthew, would = you confirm that these patches are OK? Thanks, Brian --=C2=A0 Sent with https://mailfence.com Secure and private email ------=_Part_341911_1541531884.1609559446264 Content-Type: text/x-diff; charset=us-ascii; name=0001-shell-mode-use-.zsh_history-as-a-history-file.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0001-shell-mode-use-.zsh_history-as-a-history-file.patch Content-Disposition: attachment; filename=0001-shell-mode-use-.zsh_history-as-a-history-file.patch >From 258a325eb90cc516231714fb329a0ad876ea537f Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Fri, 1 Jan 2021 18:56:41 -0800 Subject: [PATCH 1/4] shell-mode: use "~/.zsh_history" as a history file * lisp/shell.el (shell-mode): Add "~/.zsh_history". --- lisp/shell.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/shell.el b/lisp/shell.el index c179dd24d3..0f866158fe 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -603,6 +603,7 @@ shell-mode (or hfile (cond ((string-equal shell "bash") "~/.bash_history") ((string-equal shell "ksh") "~/.sh_history") + ((string-equal shell "zsh") "~/.zsh_history") (t "~/.history"))))) (if (or (equal comint-input-ring-file-name "") (equal (file-truename comint-input-ring-file-name) -- 2.29.2 ------=_Part_341911_1541531884.1609559446264 Content-Type: text/x-diff; charset=us-ascii; name=0002-comint-read-input-ring-Use-comint-buffer-s-ring-file.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0002-comint-read-input-ring-Use-comint-buffer-s-ring-file.patch Content-Disposition: attachment; filename=0002-comint-read-input-ring-Use-comint-buffer-s-ring-file.patch >From 5a6418f693bd71c3dc0cb398209b769c45e59f30 Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Fri, 1 Jan 2021 18:58:26 -0800 Subject: [PATCH 2/4] comint-read-input-ring: Use comint buffer's ring-file-prefix * lisp/comint.el (comint-read-input-ring): Bind `comint-input-ring-file-prefix' in anticipation of a buffer switch. --- lisp/comint.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 2e683a7572..f92b7b4a7b 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -979,6 +979,7 @@ comint-read-input-ring (ring (make-ring ring-size)) ;; Use possibly buffer-local values of these variables. (ring-separator comint-input-ring-separator) + (ring-file-prefix comint-input-ring-file-prefix) (history-ignore comint-input-history-ignore) (ignoredups comint-input-ignoredups)) (with-temp-buffer @@ -993,17 +994,17 @@ comint-read-input-ring (setq start (if (re-search-backward ring-separator nil t) (progn - (when (and comint-input-ring-file-prefix + (when (and ring-file-prefix (looking-at - comint-input-ring-file-prefix)) + ring-file-prefix)) ;; Skip zsh extended_history stamps (goto-char (match-end 0))) (match-end 0)) (progn (goto-char (point-min)) - (when (and comint-input-ring-file-prefix + (when (and ring-file-prefix (looking-at - comint-input-ring-file-prefix)) + ring-file-prefix)) (goto-char (match-end 0))) (point)))) (setq history (buffer-substring start end)) -- 2.29.2 ------=_Part_341911_1541531884.1609559446264 Content-Type: text/x-diff; charset=us-ascii; name=0003-comint-read-input-ring-skip-over-the-comint-input-ri.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0003-comint-read-input-ring-skip-over-the-comint-input-ri.patch Content-Disposition: attachment; filename=0003-comint-read-input-ring-skip-over-the-comint-input-ri.patch >From 601431c612b1585cbf32f18d4de6287b83cfbdf2 Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Fri, 1 Jan 2021 19:04:27 -0800 Subject: [PATCH 3/4] comint-read-input-ring: skip over the comint-input-ring-separator * lisp/comint.el (comint-read-input-ring): Skip the separator. Because re-search-backward moves point to the beginning of the match, and since we don't want the separator appearing in the output, we skip over it. This is required to properly detect instances of the value that zsh uses for `comint-input-ring-file-prefix'; if the `comint-input-ring-file-prefix' is ':potato', the subsequent invocation `looking-at' sees '\n:potato' for all entries after the one at the very beginning of the history file. --- lisp/comint.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/comint.el b/lisp/comint.el index f92b7b4a7b..36fcbb9465 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -994,6 +994,7 @@ comint-read-input-ring (setq start (if (re-search-backward ring-separator nil t) (progn + (goto-char (match-end 0)) (when (and ring-file-prefix (looking-at ring-file-prefix)) -- 2.29.2 ------=_Part_341911_1541531884.1609559446264 Content-Type: text/x-diff; charset=us-ascii; name=0004-comint-read-input-ring-Tidy.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0004-comint-read-input-ring-Tidy.patch Content-Disposition: attachment; filename=0004-comint-read-input-ring-Tidy.patch >From 125025c407e6995dd9239a51997082cb898acf3b Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Fri, 1 Jan 2021 19:41:26 -0800 Subject: [PATCH 4/4] comint-read-input-ring: Tidy * lisp/comint.el (comint-read-input-ring): Simplify. --- lisp/comint.el | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 36fcbb9465..3476fd146c 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -991,23 +991,14 @@ comint-read-input-ring (while (and (< count comint-input-ring-size) (re-search-backward ring-separator nil t) (setq end (match-beginning 0))) - (setq start - (if (re-search-backward ring-separator nil t) - (progn - (goto-char (match-end 0)) - (when (and ring-file-prefix - (looking-at - ring-file-prefix)) - ;; Skip zsh extended_history stamps - (goto-char (match-end 0))) - (match-end 0)) - (progn - (goto-char (point-min)) - (when (and ring-file-prefix - (looking-at - ring-file-prefix)) - (goto-char (match-end 0))) - (point)))) + (goto-char (if (re-search-backward ring-separator nil t) + (match-end 0) + (point-min))) + (when (and ring-file-prefix + (looking-at ring-file-prefix)) + ;; Skip zsh extended_history stamps + (goto-char (match-end 0))) + (setq start (point)) (setq history (buffer-substring start end)) (goto-char start) (when (and (not (string-match history-ignore history)) -- 2.29.2 ------=_Part_341911_1541531884.1609559446264-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 10:43:35 2021 Received: (at 45606) by debbugs.gnu.org; 11 Jan 2021 15:43:35 +0000 Received: from localhost ([127.0.0.1]:57890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyzLz-0007rv-6C for submit@debbugs.gnu.org; Mon, 11 Jan 2021 10:43:35 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyzLx-0007rh-I3 for 45606@debbugs.gnu.org; Mon, 11 Jan 2021 10:43:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wgjgfphdt97uUUCKdwVWvJZ6cCkmUuD4LV4FoLsyTuk=; b=bu4R/nkHVmKcxETxyiC24H38Bx /7AK4DrgU6AVsk5xdsIr6Dl/lWet7/SBNLBGF1eonV8peU3wNWq9Cf1/OLwocGzptAu+PNcFyMMVN qdmB01EqdIpYSrhznbAE4FA+LKE0IDJ+JlzPmq2PQdN0fHzqY3lSWnTYu6TTk9Wfs6G8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyzLm-0008WH-66; Mon, 11 Jan 2021 16:43:27 +0100 From: Lars Ingebrigtsen To: Brian Leung Subject: Re: bug#45606: [PATCH] Modify comint-read-input-ring to skip uninteresting text References: <172138729.342110.1609559814855@ichabod.co-bxl> X-Now-Playing: R.M. Project's _Fabric Presents: Octo Octa & Eris Drew_: "Rock 2 The Beat (The Greenery Mix)" Date: Mon, 11 Jan 2021 16:43:20 +0100 In-Reply-To: <172138729.342110.1609559814855@ichabod.co-bxl> (Brian Leung's message of "Sat, 2 Jan 2021 04:56:54 +0100 (CET)") Message-ID: <87mtxffpif.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Brian Leung writes: > I made the attached changes to handle zsh's history on Emacs' master branch. > > This is a follow-up to Matthew Bauer's commit > f7421039fb15123dbbda047e23504dd1771183b5 which sought to support zsh' [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45606 Cc: mjbauer95@gmail.com, 45606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brian Leung writes: > I made the attached changes to handle zsh's history on Emacs' master branch. > > This is a follow-up to Matthew Bauer's commit > f7421039fb15123dbbda047e23504dd1771183b5 which sought to support zsh's > extended_history. Matthew, would you confirm that these patches are > OK? I'm not Matthew, but it looks OK to me (and didn't seem to break anything when testing the patch), so I've pushed it to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 10:43:40 2021 Received: (at control) by debbugs.gnu.org; 11 Jan 2021 15:43:40 +0000 Received: from localhost ([127.0.0.1]:57893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyzM4-0007sE-Hi for submit@debbugs.gnu.org; Mon, 11 Jan 2021 10:43:40 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyzM3-0007rt-9r for control@debbugs.gnu.org; Mon, 11 Jan 2021 10:43:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gxm7sj+d4rZTF78I0RFodtGJSNVuzrm7jsNulpDoFEk=; b=ccpMMt9VNdIuim5nO9ZYY1Jemm haF4UzgzObao3qIB022bHImNHFq8DNDc7tTQKiOGKrUf4BWym8V+SKih5RDqYA98G/og3l9UVceZQ dRDqDHqa1xPxapUWkW4zx80MY/g6EG7GaY4TWN3oVHsSZ7Yrwzby5vi6lInUy20CJiMw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyzLv-0008WT-KM for control@debbugs.gnu.org; Mon, 11 Jan 2021 16:43:33 +0100 Date: Mon, 11 Jan 2021 16:43:30 +0100 Message-Id: <87lfczfpi5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45606 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45606 fixed close 45606 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45606 fixed close 45606 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 11 22:45:18 2021 Received: (at 45606) by debbugs.gnu.org; 12 Jan 2021 03:45:18 +0000 Received: from localhost ([127.0.0.1]:58872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzAcP-0001Ot-Ov for submit@debbugs.gnu.org; Mon, 11 Jan 2021 22:45:18 -0500 Received: from mail-ed1-f47.google.com ([209.85.208.47]:41825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzAcO-0001Of-ID for 45606@debbugs.gnu.org; Mon, 11 Jan 2021 22:45:17 -0500 Received: by mail-ed1-f47.google.com with SMTP id i24so743823edj.8 for <45606@debbugs.gnu.org>; Mon, 11 Jan 2021 19:45:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=cDvainxIq4MDIemg8Elw9eo9HkkzqLyVI3AVX7Y5eeo=; b=onErEVUAc+CZUW9xrKiQUZscQ/KMhHoMUgYmej0v5SPbplM8sRdaZUqY10sma65Kch blZ3ZIgCLIit/CKNEIFAVL6LCPgYBnsg8zDn2KLRahhwAkEjPXFkhjkJrBByKOsJ2AQy MwFzGSdJBcJLqFOtayUqC411lqd8sOTx/NHAvnuIBmwtuwiIG+xzYj2XML8mZNO/nsUO aHHBudEYZAsvVfX2DeuOlxC9H0HfRz9wdkY7v6pjrQhA4Lm3IjC7nHPa5PlbxFt4fBmr F1x0DOmZ9nAYmy5vCLkWpR7kwc5JvHPEPRJxAcYbt5bCZWo7Qe/nC0QDpfAOpbG4LGRh MSOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=cDvainxIq4MDIemg8Elw9eo9HkkzqLyVI3AVX7Y5eeo=; b=cd6mEpo4ssmLk7awqxwYWM3t4JvaWLRF+Rhw3lHR9iuEyNueh3bMBcznatim1WVXvT ju4oZN1Mq28G3QwTAskxfTCs6jXT3h3NhdEJRZPRxt0p2Jw0jJ3HN2ijVvzwVjhcjxbx E6jxY0N6fD+Q9ceKcmjZ8X5bFq5+uyQI0N3dan6I8nhzcuuIe5gDvsZL/HLLcwLQv5me OWlYqqbWsu014wXMmlTDqjgS+DDet3V3tobySn4fCa+B5/uw95xy+erMmiVCm9YQEUNv aDaX5hgErE2CIytRmiJKOiyAFtGVSE7EszxQ/s47DZhVZN45J/xhQzJs9NeEbJ8+qSVK KzAQ== X-Gm-Message-State: AOAM531gexdWiSQYs5s1XsXFDG9NIouIBzM8GkHvgaV0ICv+M54cmhzK LyZq/ID9wjy9pzVr7LK4bf/JVgN7L4Xv1u0xykE= X-Google-Smtp-Source: ABdhPJylKlxDpY83rqG2nweyQL0BY91ip1HvWrgD+DnVqX/kuHy2JHI2PaOS89khlLyIV8IrklpjIdhHWo6qQ/rg2to= X-Received: by 2002:a05:6402:1714:: with SMTP id y20mr1795803edu.2.1610423110505; Mon, 11 Jan 2021 19:45:10 -0800 (PST) MIME-Version: 1.0 References: <172138729.342110.1609559814855@ichabod.co-bxl> <87mtxffpif.fsf@gnus.org> In-Reply-To: <87mtxffpif.fsf@gnus.org> From: Matthew Bauer Date: Mon, 11 Jan 2021 21:44:59 -0600 Message-ID: Subject: Re: bug#45606: [PATCH] Modify comint-read-input-ring to skip uninteresting text To: Lars Ingebrigtsen , 45606@debbugs.gnu.org, Brian Leung Content-Type: multipart/alternative; boundary="000000000000709aa105b8abd94e" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 45606 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000709aa105b8abd94e Content-Type: text/plain; charset="UTF-8" Sorry for the delay. Looks good to me too! On Mon, Jan 11, 2021 at 9:43 AM Lars Ingebrigtsen wrote: > Brian Leung writes: > > > I made the attached changes to handle zsh's history on Emacs' master > branch. > > > > This is a follow-up to Matthew Bauer's commit > > f7421039fb15123dbbda047e23504dd1771183b5 which sought to support zsh's > > extended_history. Matthew, would you confirm that these patches are > > OK? > > I'm not Matthew, but it looks OK to me (and didn't seem to break > anything when testing the patch), so I've pushed it to Emacs 28. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --000000000000709aa105b8abd94e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry for the delay. Looks good to me too!

--000000000000709aa105b8abd94e-- From unknown Wed Jun 18 00:24:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Feb 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator