From unknown Thu Sep 11 00:46:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45594] [PATCH] environment: remove unused modules. Resent-From: gfleury Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Jan 2021 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45594 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45594@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160950783722896 (code B ref -1); Fri, 01 Jan 2021 13:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jan 2021 13:30:37 +0000 Received: from localhost ([127.0.0.1]:55804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvKVo-0005xE-Tn for submit@debbugs.gnu.org; Fri, 01 Jan 2021 08:30:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:36962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvKVn-0005x6-5k for submit@debbugs.gnu.org; Fri, 01 Jan 2021 08:30:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvKVe-0000Ka-Nl for guix-patches@gnu.org; Fri, 01 Jan 2021 08:30:31 -0500 Received: from knopi.disroot.org ([178.21.23.139]:54710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvKVb-0006Hi-U3 for guix-patches@gnu.org; Fri, 01 Jan 2021 08:30:26 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9DCAF52990 for ; Fri, 1 Jan 2021 14:30:21 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id FEz3Mhd-BJsc for ; Fri, 1 Jan 2021 14:30:19 +0100 (CET) From: gfleury DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1609507800; bh=y0491O5BpngqvOX+nIo8chbi/2eJdxJ9MqUvuMU5fx0=; h=From:To:Subject:Date; b=IP7M9KQay1Xv1k0/jgQaa2Pzms4cgvePxF3pE9/lNF5N4vqDO2O07Sxst1HMR/RWy lhUGnNbIJTE/EBj6kugC+z04indWfoHazOf9DxyXU5J9CjizFd+wDA25Gr8FXHwcVf EnP+mPXR3o0hmi2+1uitCTR81fn9vxXaVxsUJ2Ut6b+HbkUCXpeonbWZxUPU4nFHbI EdCed3C6USkE6dXsyFBuH9Ug4jFMuVXodDC+f+MUdkXraN5hJ8hk8YC0+F9o/8zdxg 2beWETTwvcTxQuzzFl8DPzExIlRSSIn5AHybd6JBkNIHL5D1eM8MUz7UFqeXjvAbUc fgKFv2aAQ4bcQ== Date: Fri, 01 Jan 2021 15:29:55 +0200 Message-ID: <87r1n4yecs.fsf@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gfleury@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain hi, This patch removed two modules that seems not used. All these relative tests pass: -tests/guix-environment.sh -tests/guix-environment-container.sh --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-environment-remove-unused-modules.patch >From df693d037d57b4b151c99324043486f2ff7fd0c4 Mon Sep 17 00:00:00 2001 From: guy fleury iteriteka Date: Fri, 1 Jan 2021 14:35:11 +0200 Subject: [PATCH] environment: remove unused modules. * guix/scripts/environment.scm(format): remove it. (rdelim): Likewise. --- guix/scripts/environment.scm | 2 -- 1 file changed, 2 deletions(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 40af012..4310dcc 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -42,9 +42,7 @@ #:use-module (gnu packages bash) #:use-module ((gnu packages bootstrap) #:select (bootstrap-executable %bootstrap-guile)) - #:use-module (ice-9 format) #:use-module (ice-9 match) - #:use-module (ice-9 rdelim) #:use-module (srfi srfi-1) #:use-module (srfi srfi-11) #:use-module (srfi srfi-26) -- 2.20.1 --=-=-=-- From unknown Thu Sep 11 00:46:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: gfleury Subject: bug#45594: closed (Re: [bug#45594] [PATCH] environment: remove unused modules.) Message-ID: References: <874kjxxa95.fsf@gnu.org> <87r1n4yecs.fsf@disroot.org> X-Gnu-PR-Message: they-closed 45594 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 45594@debbugs.gnu.org Date: Mon, 04 Jan 2021 10:34:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1609756442-9234-1" This is a multi-part message in MIME format... ------------=_1609756442-9234-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #45594: [PATCH] environment: remove unused modules.=20 which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 45594@debbugs.gnu.org. --=20 45594: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45594 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1609756442-9234-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 45594-done) by debbugs.gnu.org; 4 Jan 2021 10:33:05 +0000 Received: from localhost ([127.0.0.1]:56011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwNAe-0002Nm-V0 for submit@debbugs.gnu.org; Mon, 04 Jan 2021 05:33:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwNAd-0002NJ-90 for 45594-done@debbugs.gnu.org; Mon, 04 Jan 2021 05:33:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60266) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwNAX-0003Cy-KB; Mon, 04 Jan 2021 05:32:57 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35564 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwNAV-0008U0-NN; Mon, 04 Jan 2021 05:32:56 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: gfleury Subject: Re: [bug#45594] [PATCH] environment: remove unused modules. References: <87r1n4yecs.fsf@disroot.org> Date: Mon, 04 Jan 2021 11:32:54 +0100 In-Reply-To: <87r1n4yecs.fsf@disroot.org> (gfleury@disroot.org's message of "Fri, 01 Jan 2021 15:29:55 +0200") Message-ID: <874kjxxa95.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 45594-done Cc: 45594-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Hi, gfleury skribis: >>>From df693d037d57b4b151c99324043486f2ff7fd0c4 Mon Sep 17 00:00:00 2001 > From: guy fleury iteriteka > Date: Fri, 1 Jan 2021 14:35:11 +0200 > Subject: [PATCH] environment: remove unused modules. > > * guix/scripts/environment.scm(format): remove it. > (rdelim): Likewise. Good catch. I tweaked the commit log and applied it, thanks! Ludo=E2=80=99. ------------=_1609756442-9234-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Jan 2021 13:30:37 +0000 Received: from localhost ([127.0.0.1]:55804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvKVo-0005xE-Tn for submit@debbugs.gnu.org; Fri, 01 Jan 2021 08:30:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:36962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvKVn-0005x6-5k for submit@debbugs.gnu.org; Fri, 01 Jan 2021 08:30:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvKVe-0000Ka-Nl for guix-patches@gnu.org; Fri, 01 Jan 2021 08:30:31 -0500 Received: from knopi.disroot.org ([178.21.23.139]:54710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvKVb-0006Hi-U3 for guix-patches@gnu.org; Fri, 01 Jan 2021 08:30:26 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9DCAF52990 for ; Fri, 1 Jan 2021 14:30:21 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id FEz3Mhd-BJsc for ; Fri, 1 Jan 2021 14:30:19 +0100 (CET) From: gfleury DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1609507800; bh=y0491O5BpngqvOX+nIo8chbi/2eJdxJ9MqUvuMU5fx0=; h=From:To:Subject:Date; b=IP7M9KQay1Xv1k0/jgQaa2Pzms4cgvePxF3pE9/lNF5N4vqDO2O07Sxst1HMR/RWy lhUGnNbIJTE/EBj6kugC+z04indWfoHazOf9DxyXU5J9CjizFd+wDA25Gr8FXHwcVf EnP+mPXR3o0hmi2+1uitCTR81fn9vxXaVxsUJ2Ut6b+HbkUCXpeonbWZxUPU4nFHbI EdCed3C6USkE6dXsyFBuH9Ug4jFMuVXodDC+f+MUdkXraN5hJ8hk8YC0+F9o/8zdxg 2beWETTwvcTxQuzzFl8DPzExIlRSSIn5AHybd6JBkNIHL5D1eM8MUz7UFqeXjvAbUc fgKFv2aAQ4bcQ== To: guix-patches@gnu.org Subject: [PATCH] environment: remove unused modules. Date: Fri, 01 Jan 2021 15:29:55 +0200 Message-ID: <87r1n4yecs.fsf@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.21.23.139; envelope-from=gfleury@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain hi, This patch removed two modules that seems not used. All these relative tests pass: -tests/guix-environment.sh -tests/guix-environment-container.sh --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-environment-remove-unused-modules.patch >From df693d037d57b4b151c99324043486f2ff7fd0c4 Mon Sep 17 00:00:00 2001 From: guy fleury iteriteka Date: Fri, 1 Jan 2021 14:35:11 +0200 Subject: [PATCH] environment: remove unused modules. * guix/scripts/environment.scm(format): remove it. (rdelim): Likewise. --- guix/scripts/environment.scm | 2 -- 1 file changed, 2 deletions(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 40af012..4310dcc 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -42,9 +42,7 @@ #:use-module (gnu packages bash) #:use-module ((gnu packages bootstrap) #:select (bootstrap-executable %bootstrap-guile)) - #:use-module (ice-9 format) #:use-module (ice-9 match) - #:use-module (ice-9 rdelim) #:use-module (srfi srfi-1) #:use-module (srfi srfi-11) #:use-module (srfi srfi-26) -- 2.20.1 --=-=-=-- ------------=_1609756442-9234-1--