GNU bug report logs - #45573
[PATCH] Correct freecad runtime errors

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45573: closed ([PATCH] Correct freecad runtime errors)
Date: Mon, 04 Jan 2021 20:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 4 Jan 2021 15:12:29 -0500
with message-id <X/N2rXWaseriuIAj <at> jasmine.lan>
and subject line Re: [bug#45573] [PATCH] Correct freecad runtime errors
has caused the debbugs.gnu.org bug report #45573,
regarding [PATCH] Correct freecad runtime errors
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45573: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45573
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Correct freecad runtime errors
Date: Thu, 31 Dec 2020 18:47:59 +0000

[Message part 3 (text/plain, inline)]

Hi,

I attach 4 patches that correct the runtime issues freecad has and also supply some packages needed as a dependency.

Freecad is a very complex package that is hard to build because many of its dependencies' buildsystem is broken. The approach followed here is the same that Nix follows and appears to work correctly.

The changes correct the Draft module, which wasn't available because pivy was not added as a dependency.

For context, see this message:
https://lists.gnu.org/archive/html/guix-devel/2020-12/msg00123.html

Thanks

[0001-gnu-Add-coin3D-4.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-pivy.patch (text/x-patch, attachment)]

[0004-gnu-freecad-correct-runtime-errors.patch (text/x-patch, attachment)]

[0002-gnu-Add-soqt.patch (text/x-patch, attachment)]

[Message part 8 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "45573 <at> debbugs.gnu.org" <45573-done <at> debbugs.gnu.org>
Subject: Re: [bug#45573] [PATCH] Correct freecad runtime errors
Date: Mon, 4 Jan 2021 15:12:29 -0500

On Mon, Jan 04, 2021 at 12:15:26PM +0000, Ekaitz Zarraga wrote:
> I think they are broken upstream.
> 
> When they are run during the guix compilation they report a circular
> dependency issue when loading but once the lib is installed i'm able to
> import it without issues.

Thanks for the info. I added it to a comment. It helps reviewers (and
later readers of the package definition) to include bits of info to help
understand why the package definition does something non-standard.

> I tried that and I was unable to solve it that way.
> I'm not a CMake expert but I think the problem is that even if CMake finds
> Coin3D, it's not taking it in account during the compilation, so it needs
> that patch to use it.

Okay.

> The only part that is affected by qtwebkit is the first screen of the
> program that shows some examples, links and news. So it's safe to remove
> but I'm not sure if the substitutes were unavailable because of this or
> because the compilation was failing (it have been broken for a long time).
> 
> I'm not sure about how to proceed here. I'm ok with a FreeCad that
> is open in a blank screen and shows a couple of warnings on load. I'll
> leave the decision of including this patch or not on you guys if you don't
> mind.

Now that I understand that the absence of QtWebKit breaks part of the
FreeCAD interface, I agree that it should be included.

I squashed the patches in a way that seemed appropriate, wrote the
commit messages, and pushed as ed2e0b1b50587a38ad26574585f73979874e56f0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.