GNU bug report logs - #45570
operating-system definitions allow duplicate passwd and group entries

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45570: closed (operating-system definitions allow duplicate
 passwd and group entries)
Date: Mon, 11 Jan 2021 15:07:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 11 Jan 2021 16:06:45 +0100
with message-id <1ef9ad81776e110cb538968f2a124df74bec06ac.camel <at> student.tugraz.at>
and subject line Re: [PATCH v3] system: Assert, that user and group names are unique.
has caused the debbugs.gnu.org bug report #45570,
regarding operating-system definitions allow duplicate passwd and group entries
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45570: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45570
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jason Conroy <conjaroy <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: operating-system definitions allow duplicate passwd and group entries
Date: Thu, 31 Dec 2020 13:14:19 -0500

[Message part 3 (text/plain, inline)]

When an operating-system contains multiple users or groups with the same
name, instantiating it with `guix system` does not cause a validation
failure, nor are the duplicate entries filtered from the resulting /etc
files.

This duplication can happen in a few different ways:

- both entries are manually included in the "users" or "groups" fields of
the operating-system
- a manually-specified entry collides with an entry defined by a service
(via an account-service-type extension)
- multiple services define entries that collide with each other

Steps to reproduce: call "guix system container" with the attached
operating-system definition.

[Message part 4 (text/html, inline)]

[duplicate-users-and-groups.scm (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45570-done <at> debbugs.gnu.org, conjaroy <at> gmail.com
Subject: Re: [PATCH v3] system: Assert, that user and group names are unique.
Date: Mon, 11 Jan 2021 16:06:45 +0100

Am Montag, den 11.01.2021, 14:09 +0100 schrieb Ludovic Courtès:
> Hi,
> 
> Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:
> 
> > *gnu/system/shadow.scm (find-duplicates): New variable.
> > (assert-unique-account-names, assert-unique-group-names): New
> > variables.
> > (account-activation): Use them here.
> 
> LGTM, thanks! :-)
> 
> Ludo’.
Aaaand it's pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.