GNU bug report logs - #45565
[PATCH 0/2] Add more r-mlr3 add-ons

Previous Next

Package: guix-patches;

Reported by: Wiktor Żelazny <wz <at> freeshell.de>

Date: Thu, 31 Dec 2020 12:51:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45565: closed ([PATCH 0/2] Add more r-mlr3 add-ons)
Date: Fri, 31 Dec 2021 19:24:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 31 Dec 2021 20:20:53 +0100
with message-id <87lf00fujz.fsf <at> elephly.net>
and subject line Re: [bug#45565] [PATCH 0/2] Add more r-mlr3 add-ons
has caused the debbugs.gnu.org bug report #45565,
regarding [PATCH 0/2] Add more r-mlr3 add-ons
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45565: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45565
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Wiktor Żelazny <wz <at> freeshell.de>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Add more r-mlr3 add-ons
Date: Thu, 31 Dec 2020 13:46:08 +0100
A false alarm yesterday regarding the r-mlr3pipelines determinism. I
confused the derivation hash with the build hash. As for r-mlr3ordinal,
the linter reported

./gnu/packages/cran.scm:25616:15: r-mlr3ordinal <at> 0.1.0-9000-0.9febac9: the source file name should contain the package name

I don’t know what “source file name” is referenced here, so I’m
submitting the definition as it is.

Wiktor Żelazny (2):
  gnu: Add r-mlr3pipelines.
  gnu: Add r-mlr3ordinal.

 gnu/packages/cran.scm | 62 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)


base-commit: 67497e20890348ebbd41612e2582b1745a80fec5
-- 
2.29.2



[Message part 3 (message/rfc822, inline)]
From: Ricardo Wurmus <rekado <at> elephly.net>
To: Wiktor Żelazny <wz <at> freeshell.de>
Cc: 45565-done <at> debbugs.gnu.org
Subject: Re: [bug#45565] [PATCH 0/2] Add more r-mlr3 add-ons
Date: Fri, 31 Dec 2021 20:20:53 +0100
Hi Wiktor,

I’m terribly sorry for the delay.  These two patches are fine and
slipped through the cracks.  I updated the packages to the new input
style and pushed them to the “master” branch.

> As for r-mlr3ordinal, the linter reported
>
> ./gnu/packages/cran.scm:25616:15: r-mlr3ordinal <at> 0.1.0-9000-0.9febac9: the source file name should contain the package name
>
> I don’t know what “source file name” is referenced here, so I’m
> submitting the definition as it is.

This is due to the use of git-reference; you need to provide “file-name”
to give a name to the source checkout.  I did this when I applied your
patches.

Thanks for these patches!

-- 
Ricardo


This bug report was last modified 3 years and 203 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.