From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Dec 2020 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 45562@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160940359629573 (code B ref -1); Thu, 31 Dec 2020 08:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Dec 2020 08:33:16 +0000 Received: from localhost ([127.0.0.1]:52677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kutOV-0007gv-Kv for submit@debbugs.gnu.org; Thu, 31 Dec 2020 03:33:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:55834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kutOT-0007gn-Ag for submit@debbugs.gnu.org; Thu, 31 Dec 2020 03:33:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kutOR-0003Rc-Hk for bug-gnu-emacs@gnu.org; Thu, 31 Dec 2020 03:33:13 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:47028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kutOP-0006he-3F for bug-gnu-emacs@gnu.org; Thu, 31 Dec 2020 03:33:10 -0500 Received: by mail-pf1-f170.google.com with SMTP id s21so10928836pfu.13 for ; Thu, 31 Dec 2020 00:33:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=WNzVrvvKRYce0xBmJirVUkTTYRWT5/p1HqMtPmZ5WlI=; b=IxI4yVNCdSXxb8Or6sVE+8BmdOPUoW/EDf5I4wXliROEnUYaHk5CROyaBCF5anlcvO Aqg7ti8Ek6LItL0Ee6sCkI+DRqI/BqvDG61PMdBMX1c80HS8Rmrlt2Q3of3xvToRDb0k KbIhEbvt0xMXRg6wRWcrroo+jgX3vORkw1WOHMs+IXp+XwAhk6mlOswaFiu8kmc8Kbxp 66MC3Fv2jTr3C+q8+MqlRDexQ1v5ccesbzUzTN7MTT5m1Caz6d3+284AKBNxaBn+HRD5 lR4fOOw1wb+PZAF6s8dLs4sBRrMgbrGC3dom8QwAAGrL6ur2I9cBb36OkocrpUskURKB BH6A== X-Gm-Message-State: AOAM532DX3PZmcHsLxFar1i3eeG2VY0lr6NNDmV7Ub6IcjZxxqNkrq6L N+MDqZ0p4OFXA7I2+K+rkjUbK2N4DdWffH5DFSoNkQG/im8= X-Google-Smtp-Source: ABdhPJzcywRG2J5Pjv0MF9CSvaXAtvXX0fj0MDl9LcWJ4M4jXf/hGykR154mJYuwM99ibgE/rXXhoPGwVSDW6yDlVM0= X-Received: by 2002:a62:e212:0:b029:19d:8cff:f179 with SMTP id a18-20020a62e2120000b029019d8cfff179mr51452449pfi.44.1609403587346; Thu, 31 Dec 2020 00:33:07 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 31 Dec 2020 00:33:06 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 31 Dec 2020 00:33:06 -0800 Message-ID: Content-Type: multipart/mixed; boundary="0000000000001ff11905b7be79de" Received-SPF: pass client-ip=209.85.210.170; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f170.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --0000000000001ff11905b7be79de Content-Type: text/plain; charset="UTF-8" Severity: wishlist The attached patch fixes some warnings found by lgtm.com. Does it look okay? Ref: https://lgtm.com/projects/g/emacs-mirror/emacs/ --0000000000001ff11905b7be79de Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Fix-comparison-always-the-same-warnings-found-by-lgt.patch" Content-Disposition: attachment; filename="0001-Fix-comparison-always-the-same-warnings-found-by-lgt.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 2de1db0659ca70fc_0.1 RnJvbSAzNDAyMDY4NjUzODNiMDc2NGE3ZDA3Y2M3NzcxZjRmYjg3NzNiMzAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVGh1LCAzMSBEZWMgMjAyMCAwODoxOTo0MSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCAi Y29tcGFyaXNvbiBhbHdheXMgdGhlIHNhbWUiIHdhcm5pbmdzIGZvdW5kIGJ5IGxndG0KCiogc3Jj L2FsbG9jLmMgKG1lbW9yeV9mdWxsKToKKiBzcmMvYnVmZmVyLmMgKGluaXRfYnVmZmVyX29uY2Up OgoqIHNyYy9mbnMuYyAoYmFzZTY0X2RlY29kZV8xKToKKiBzcmMvd2luZG93LmMgKHdpbmRvd19z Y3JvbGxfcGl4ZWxfYmFzZWQpOgoqIHNyYy94ZmFjZXMuYyAobWVyZ2VfZmFjZV92ZWN0b3JzKTog Rml4IHdhcm5pbmcgIkNvbXBhcmlzb24gcmVzdWx0IGlzCmFsd2F5cyB0aGUgc2FtZSIgZm91bmQg YnkgbGd0bSBkb3QgY29tLgotLS0KIHNyYy9hbGxvYy5jICB8IDIgKy0KIHNyYy9idWZmZXIuYyB8 IDMgKy0tCiBzcmMvZm5zLmMgICAgfCAyIC0tCiBzcmMvd2luZG93LmMgfCAyICstCiBzcmMveGZh Y2VzLmMgfCAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYWxsb2MuYyBiL3NyYy9hbGxvYy5jCmluZGV4IDBiMzg3 ZGQ4YzEuLjUzODZhMTQyZGUgMTAwNjQ0Ci0tLSBhL3NyYy9hbGxvYy5jCisrKyBiL3NyYy9hbGxv Yy5jCkBAIC00MDAxLDcgKzQwMDEsNyBAQCBtZW1vcnlfZnVsbCAoc2l6ZV90IG5ieXRlcykKIAkg IHsKIAkgICAgaWYgKGkgPT0gMCkKIAkgICAgICBmcmVlIChzcGFyZV9tZW1vcnlbaV0pOwotCSAg ICBlbHNlIGlmIChpID49IDEgJiYgaSA8PSA0KQorCSAgICBlbHNlIGlmIChpIDw9IDQpCiAJICAg ICAgbGlzcF9hbGlnbl9mcmVlIChzcGFyZV9tZW1vcnlbaV0pOwogCSAgICBlbHNlCiAJICAgICAg bGlzcF9mcmVlIChzcGFyZV9tZW1vcnlbaV0pOwpkaWZmIC0tZ2l0IGEvc3JjL2J1ZmZlci5jIGIv c3JjL2J1ZmZlci5jCmluZGV4IDllNDQzNDU2MTYuLjhiY2E0OTc3Y2EgMTAwNjQ0Ci0tLSBhL3Ny Yy9idWZmZXIuYworKysgYi9zcmMvYnVmZmVyLmMKQEAgLTUyMzgsOCArNTIzOCw3IEBAIGluaXRf YnVmZmVyX29uY2UgKHZvaWQpCiAgIFBEVU1QRVJfUkVNRU1CRVJfU0NBTEFSIChidWZmZXJfbG9j YWxfZmxhZ3MpOwogCiAgIC8qIE5lZWQgbW9yZSByb29tPyAqLwotICBpZiAoaWR4ID49IE1BWF9Q RVJfQlVGRkVSX1ZBUlMpCi0gICAgZW1hY3NfYWJvcnQgKCk7CisgIGVhc3NlcnQgKGlkeCA8IE1B WF9QRVJfQlVGRkVSX1ZBUlMpOwogICBsYXN0X3Blcl9idWZmZXJfaWR4ID0gaWR4OwogICBQRFVN UEVSX1JFTUVNQkVSX1NDQUxBUiAobGFzdF9wZXJfYnVmZmVyX2lkeCk7CiAKZGlmZiAtLWdpdCBh L3NyYy9mbnMuYyBiL3NyYy9mbnMuYwppbmRleCAyZGUxZDI2ZGQzLi5mMGNjMTY0YmM3IDEwMDY0 NAotLS0gYS9zcmMvZm5zLmMKKysrIGIvc3JjL2Zucy5jCkBAIC0zODQ3LDggKzM4NDcsNiBAQCBi YXNlNjRfZGVjb2RlXzEgKGNvbnN0IGNoYXIgKmZyb20sIGNoYXIgKnRvLCBwdHJkaWZmX3QgbGVu Z3RoLAogICAgICAgaWYgKGMgPT0gJz0nKQogCWNvbnRpbnVlOwogCi0gICAgICBpZiAodjEgPCAw KQotCXJldHVybiAtMTsKICAgICAgIHZhbHVlICs9IHYxIC0gMTsKIAogICAgICAgYyA9IHZhbHVl ICYgMHhmZjsKZGlmZiAtLWdpdCBhL3NyYy93aW5kb3cuYyBiL3NyYy93aW5kb3cuYwppbmRleCA1 ZGIxNjZlMzQ1Li5iZmRiZDQyNmE2IDEwMDY0NAotLS0gYS9zcmMvd2luZG93LmMKKysrIGIvc3Jj L3dpbmRvdy5jCkBAIC01NzA4LDcgKzU3MDgsNyBAQCB3aW5kb3dfc2Nyb2xsX3BpeGVsX2Jhc2Vk IChMaXNwX09iamVjdCB3aW5kb3csIGludCBuLCBib29sIHdob2xlLCBib29sIG5vZXJyb3IpCiAJ CSAmJiBzdGFydF9wb3MgPiBCRUdWKQogCSAgICBtb3ZlX2l0X2J5X2xpbmVzICgmaXQsIC0xKTsK IAl9Ci0gICAgICBlbHNlIGlmIChkeSA+IDApCisgICAgICBlbHNlIC8qIGlmIChkeSA+IDApICov CiAJewogCSAgZ29hbF95ID0gaXQuY3VycmVudF95ICsgZHk7CiAJICBtb3ZlX2l0X3RvICgmaXQs IFpWLCAtMSwgZ29hbF95LCAtMSwgTU9WRV9UT19QT1MgfCBNT1ZFX1RPX1kpOwpkaWZmIC0tZ2l0 IGEvc3JjL3hmYWNlcy5jIGIvc3JjL3hmYWNlcy5jCmluZGV4IDczYTUzNmIxOWMuLmVhMGU5ZDZh MjggMTAwNjQ0Ci0tLSBhL3NyYy94ZmFjZXMuYworKysgYi9zcmMveGZhY2VzLmMKQEAgLTIyMjgs NyArMjIyOCw3IEBAIG1lcmdlX2ZhY2VfdmVjdG9ycyAoc3RydWN0IHdpbmRvdyAqdywKIAllbHNl IGlmIChpICE9IExGQUNFX0ZPTlRfSU5ERVggJiYgISBFUSAodG9baV0sIGZyb21baV0pKQogCSAg ewogCSAgICB0b1tpXSA9IGZyb21baV07Ci0JICAgIGlmIChpID49IExGQUNFX0ZBTUlMWV9JTkRF WCAmJiBpIDw9IExGQUNFX1NMQU5UX0lOREVYKQorCSAgICBpZiAoaSA8PSBMRkFDRV9TTEFOVF9J TkRFWCkKIAkgICAgICBmb250X2NsZWFyX3Byb3AgKHRvLAogCSAgICAgICAgICAgICAgICAgICAg ICAgKGkgPT0gTEZBQ0VfRkFNSUxZX0lOREVYID8gRk9OVF9GQU1JTFlfSU5ERVgKIAkJCSAgICAg ICAgOiBpID09IExGQUNFX0ZPVU5EUllfSU5ERVggPyBGT05UX0ZPVU5EUllfSU5ERVgKLS0gCjIu MjkuMgoK --0000000000001ff11905b7be79de-- From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Dec 2020 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 45562@debbugs.gnu.org Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.160942400024795 (code B ref 45562); Thu, 31 Dec 2020 14:14:02 +0000 Received: (at 45562) by debbugs.gnu.org; 31 Dec 2020 14:13:20 +0000 Received: from localhost ([127.0.0.1]:39702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuyhc-0006Rq-9u for submit@debbugs.gnu.org; Thu, 31 Dec 2020 09:13:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuyha-0006Rc-Ly for 45562@debbugs.gnu.org; Thu, 31 Dec 2020 09:13:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50621) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuyhV-0008Nd-8O; Thu, 31 Dec 2020 09:13:13 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1338 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuyhU-0001DO-67; Thu, 31 Dec 2020 09:13:12 -0500 Date: Thu, 31 Dec 2020 16:12:51 +0200 Message-Id: <83zh1ugj30.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Thu, 31 Dec 2020 00:33:06 -0800) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 31 Dec 2020 00:33:06 -0800 > > The attached patch fixes some warnings found by lgtm.com. Thanks. IME, these tools have quite a low signal-to-noise ratio. In this case: > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes) > { > if (i == 0) > free (spare_memory[i]); > - else if (i >= 1 && i <= 4) > + else if (i <= 4) > lisp_align_free (spare_memory[i]); > else > lisp_free (spare_memory[i]); This is an optimization better left to the compiler, IMO. > --- a/src/buffer.c > +++ b/src/buffer.c > @@ -5238,8 +5238,7 @@ init_buffer_once (void) > PDUMPER_REMEMBER_SCALAR (buffer_local_flags); > > /* Need more room? */ > - if (idx >= MAX_PER_BUFFER_VARS) > - emacs_abort (); > + eassert (idx < MAX_PER_BUFFER_VARS); This is wrong, because eassert compiles to nothing in the production build, so it is only good for situations where continuing without aborting will do something reasonable, or if it will crash anyway in the very next source line. In this case, there's no way we can continue, and the programmer evidently wanted us to abort rather than continue and let us crash later. > --- a/src/fns.c > +++ b/src/fns.c > @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, > if (c == '=') > continue; > > - if (v1 < 0) > - return -1; > value += v1 - 1; > > c = value & 0xff; I don't think I see why removing the test and the failure return would be TRT. What did I miss? > --- a/src/window.c > +++ b/src/window.c > @@ -5708,7 +5708,7 @@ window_scroll_pixel_based (Lisp_Object window, int n, bool whole, bool noerror) > && start_pos > BEGV) > move_it_by_lines (&it, -1); > } > - else if (dy > 0) > + else /* if (dy > 0) */ I don't necessarily object, but this is again an optimization that compilers are better at than people. > --- a/src/xfaces.c > +++ b/src/xfaces.c > @@ -2228,7 +2228,7 @@ merge_face_vectors (struct window *w, > else if (i != LFACE_FONT_INDEX && ! EQ (to[i], from[i])) > { > to[i] = from[i]; > - if (i >= LFACE_FAMILY_INDEX && i <= LFACE_SLANT_INDEX) > + if (i <= LFACE_SLANT_INDEX) This change hard-codes the assumption about the numerical value of LFACE_FAMILY_INDEX, so it'd be a time bomb waiting to blow up. For example, imagine that the enumeration is modified such that the value of LFACE_FAMILY_INDEX changes, or we are using a compiler with a different scheme of assigning numerical values to enumeration constants. From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 11:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 45562@debbugs.gnu.org, Stefan Kangas Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.160949934125115 (code B ref 45562); Fri, 01 Jan 2021 11:09:01 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 11:09:01 +0000 Received: from localhost ([127.0.0.1]:55482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvIIm-0006Wy-Rw for submit@debbugs.gnu.org; Fri, 01 Jan 2021 06:09:01 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvIIl-0006Wl-Bq for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 06:08:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yDCKio6Jx/DrMbzPSRORPBf8U/aA+hn1NoABf9LSPO4=; b=nzZm4dFr8xh/R+I82Qg/r1wUZo vh7EIF8GkctOdWffBNj+hk9asZsdQZ+Jx9wfuZzAeNLYdz+MaxSQydFDtruWAvYazhsswHj64xO+N /bvG4pCqck+Wkv4mjSk4YqmE5UQQfXuyxm0gYVSS+xHJ/BK1ILmQTJkRl9o1WGKSCleE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvIIa-0000KK-5u; Fri, 01 Jan 2021 12:08:52 +0100 From: Lars Ingebrigtsen References: <83zh1ugj30.fsf@gnu.org> X-Now-Playing: Eurythmics's _Touch_: "Here Comes The Rain Again" Date: Fri, 01 Jan 2021 12:08:46 +0100 In-Reply-To: <83zh1ugj30.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Dec 2020 16:12:51 +0200") Message-ID: <87h7o0c3sx.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> --- a/src/alloc.c >> +++ b/src/alloc.c >> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes) >> { >> if (i == 0) >> free (spare_memory[i]); >> - else if (i >= 1 && i <= 4) >> + else if (i <= 4) >> l [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> --- a/src/alloc.c >> +++ b/src/alloc.c >> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes) >> { >> if (i == 0) >> free (spare_memory[i]); >> - else if (i >= 1 && i <= 4) >> + else if (i <= 4) >> lisp_align_free (spare_memory[i]); >> else >> lisp_free (spare_memory[i]); > > This is an optimization better left to the compiler, IMO. I think the change made the code slightly clearer, though? You don't have to think about whether there's anything in the range between 0 and >= 1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 45562@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.16095010754183 (code B ref 45562); Fri, 01 Jan 2021 11:38:02 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 11:37:55 +0000 Received: from localhost ([127.0.0.1]:55533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvIkl-00015P-C1 for submit@debbugs.gnu.org; Fri, 01 Jan 2021 06:37:55 -0500 Received: from sonic305-19.consmr.mail.ir2.yahoo.com ([77.238.177.81]:38227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvIkj-00015C-GI for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 06:37:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1609501067; bh=dyA/cZnl8nSrqhQUIEz49mksWi5G9bxT04aZnUqoDeE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=nBhzOV7uP78kf1aUwfXeodpJGLInXKnjM5ShcvqNQIYN9Avnw+ktfrxjMjB6d8rN+49isIrLt/dKuVQ8J2oXBnjdFbI4Ylew5eKkmGXHnuEjACg1AAULBmz9oehfzhaRktIgAr6TohdGAP6krT3JQJN1Y9SK6KBDNCRu1Jcig7OVGZTpw6T/Y/YqlVKnNx8yWxD7DLDDLrrJMJEKWhcqn+sAb3IGPeeOJfhslpc6DO7iGHOPfR7RSzyacEOWK2hLgoXhZQEb6iKUc5WHWQTuu+AHZUsN72VIiVLRmeTPaTFaGsH1wK/9WWwUoMKvC0s71Xdqaxjy8kFwPT3zHzB+SA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609501067; bh=IsrLj1YKcaZGR37QMsUoHvGKMOJbuDsM2PSIpRC1fUV=; h=From:To:Subject:Date:From:Subject; b=fw+HCsWd9rL6hhYUEnLFNaQ0zx0xoOpcS8ASsBT5G6tF8gpxe/xau/Xz0hWgsyfdmPpeUHf18lWw7CAUYnFtypghuTU/cxJA4BTuYzzosYNrYKLXCWTDrsHHbn4jAH5MPcT4Awcuae8l3F6MAQeUzlA+XV5OhjwnjTwGI0oAhHYnX1XG4bFpKYsLuiyaDTdW9Czh7F8PRH94iXglTtjZipcS6UgeEfPY7ABDZTKcSWObInpePWxJdDXCMBQZoEn7nJNZsG2TNCNemkHQEhHJ2URIJaiaWsrPAu5a9jcNAvG6dPOu1QlGnjRNY7M4yhjnyjPqZqYpd5rAZl2zjmC3qg== X-YMail-OSG: VbjpuoYVM1nJxxnpHs5spJH7dKwqpUMM43D2YpqIEPHqZ.ZlDKfOfJFU31npKCp .hLUVcLsNimN.JTuwK.pxII8E2BAnvIr3o5.fV.ZHr2GoUT71DsdAT8lTIhybday6wXsw4SEhaa_ rMaGwroqVEJ62sBTd4wo9zYXGzb1XNhb7.3PFFUTahTVJEEmTcxraAh65SnjUgxwpPD2JchoRoZR cliDdG8phx2KSQKLg7xgjvwW9QicfUkaWCr79NcWI4dKsAjWdeSYUSBuIDbkBzWVW8xRKToEX0Yq si0otH.xK5tGlEqD6B43RlNK9EFaI2hCy84YyJYeTiaxpcIHPZddVvxK0FMO0mFHIbDeisZfYGxU m_SsEbleW1QWfcJsCRNo3KldUtMtrk_tK3tRmo0W31UYy4hAsIhudEXGH3kw1i23p9_2ymf9XYs5 zCHXX09VStPmNuLMD46n_2pkBLDDAzflekwPN3fA5Y74mPCprzegtMs42CT7wlR7CIfY_R1qKY7f .1pygA.JeMXJZBFKJd00rrfdBVxTGQlkln70oYY9EACN..qd8L_OQWPn7z0GwkpP1ZS5Qkbbsl4. Uk09plWZWphohfR0pBeYM2OeCP9KLOExmCKWnmLp4k875mvc7qhDco2jVJ5P_DJoblroeZVzIs3i uZK1v4ZgsMeHLo3Pqdvxvwn_H0khJI12Fy83jU9_Q0CWbtOKXxEVRhvVOuBHcNrpPrqbHVW7Knrj OaGdHdWSorqOyOVglMzaAWADMVbZXEb3ZF3BDznIk9KdWgMR9jote.qK2duZsGhH3H9i8jn07l7X s8wGhL12B_QQzgF8L1FFwskN.5jwpcKuuBMKOiOEpHdYDOyj.yCx0PlLhsa1BIR6siQSwP2t4n0N ZF8kA7PUE3IIO2ha5qXH07mWNJ0GLvnx6xEoLexqE_g.Sy7Q51gREo4szvWBJS4ZJVXFLkT1kZkB P.LuOW3VJA5ztU_h_OyyIob3RcHvd1E5FtpIPE7RSjtqxnOKbsu1UbdYcrF2T9GkFH112Hf.D7ez 4Nwb2RDWZ_St1kQGx6myJLedKK8xb8dkDmDdXi63Ba1Exg8PExrIddN7wbLJ_jAdhCOi6_sr9KH2 cbminW2vrV.kWIjSM.k2qHhVo54vfpQIFMYjisn5EQDmBly8iWjgC2dYs_gPd.vvS7EAUtIr7bag fyLGUTPNwLPsFzvGeNwVgwqUQff0wR6aGRzhSk2RjMApXU_O4E1howwlH0EECknxCnin3TgACbi9 88MfomBw8hKamq13e0zeRtKgj5_hGCqNbZE.iXG39rA7GGtEKK3IEuHeuU7EI8O1aKczkF.oTwkI 2RM3DFusO2JWjF74B3fz4OJCTTgitdgR5WN1UHVl7L8SDT1IlXsz5Kdeq.J5owVAiXXNnbFbbUt9 EsJfKSI31QXb0XB2KejAhACpPu7XAifZa8iSWuEUXTKrlhvtvAKEytBXJodgT.OmOO4M6grF_ZoS W7UXp3N0o5UA20adsm9eEOVxedHwtnUboKkU2RvTRUv75haYiaUQYoEtc2IgLlIRDDI8ElGvdSDu N6_Ni8tDffCh6hnsnVEpr3iR4OAhOSSMltvTCaaa6r4d2G4VAsQHfRQq7hFcdiS0gFSMMjL3wxe_ GAmEz6zyHtpuKU5EKBwyw9ELgEeDw0e6QhKGSODTfcPioAfmi.7p6avFsDY39iUD5l3wpA0WpsB4 AO9YlCMlVwBS4z.sXaO10hNE.Elxo1mvu7jmEwMl5B46DzLqowbqMdpOMrbvuQH7HdQCYYpx7L2V CKRxAqrmPlyNvMdFfvMR8rqZpUY6mf_vF5VGl6kpkYKrdyoq6VL8YOBuE0LthWf.oMIK2lisykDz FKK6kPhSEV3v6QwfsplQZUcXOPYjUfikOXrUjeHVOvqtxLntXcWFqZilgHGdUNXHCI1hx_VGx69X PVHgJOdxmiWaUWEMZY1YuGlYrhWvHwpqt043h3rqjMXTInZCO5lYMjo39DgE6KB0G4kgZgAKHr65 8PYA_YpLHj2zbchgkbxQrHSIL1QiKnRXPUQ7r6m9dQaqsguZKTGC2eEIXUuHGq1nR8ukAs9Rw1Z4 18.1LDhBT2rV3xDDYCByXEYvG6fVsH3kDLG7rx8NkEIlYO1Qpa5zj.K.JYP0zqBK0b5I8Mgj.bY9 PSgaQ2ExbFxbyI.JdBy8ZYGkilU6UDQ_R1_Gectwly6FczCIO2c_E7hkBKiNF2O1xKtkCZkCsCIy XGXRqgB5SpyW7GVM26WkLwrAm5SZnatDmVQ3EOxMl_CkHRS5U1jfZrsvTq1EvMl1d9ydZ0NWCoPn XtrZcB1Iv9v1b2UcK1kMCtMfbACf87w.cp38HOCZYiSmI0RU4wLi4gXlhkfmDqxRV96u_sc0DIV7 sxCP.sDGXX3h.YLxmAhNASMiZRTuIGxt.HnHqnqLiZAghTgiTOR2wnEBBmCG_WlMqS7G_iE3iV7t S2JWPRUJhFi3sqiC_DIi_o7juw_PG70GRuD.aw5SFvnqsvu5MNIwFUw4m2RJz06GKnPqAtpm6cD9 F0jrDnaHRCPJAUlTadzQLNqut_9lFUJDBYxHJxhxeOcNbURpd3HfTEckIlDAR0qKN.zL1mQz3oju YUS_4aKUfjLTtCh2T7IvJU.E7.H_b0kNpOpE- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Fri, 1 Jan 2021 11:37:47 +0000 Received: by smtp417.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID c9e694c2f062fee3945c766506d3bd40; Fri, 01 Jan 2021 11:37:44 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= References: <83zh1ugj30.fsf@gnu.org> <87h7o0c3sx.fsf@gnus.org> Date: Fri, 01 Jan 2021 12:37:43 +0100 In-Reply-To: <87h7o0c3sx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 01 Jan 2021 12:08:46 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.17278 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Content-Length: 796 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >>> --- a/src/alloc.c >>> +++ b/src/alloc.c >>> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes) >>> { >>> if (i == 0) >>> free (spare_memory[i]); >>> - else if (i >= 1 && i <= 4) >>> + else if (i <= 4) >>> lisp_align_free (spare_memory[i]); >>> else >>> lisp_free (spare_memory[i]); >> >> This is an optimization better left to the compiler, IMO. > > I think the change made the code slightly clearer, though? You don't > have to think about whether there's anything in the range between 0 and >>= 1. I think it depends on the programmer. To me, the original code makes more clear that the branch runs when i is in the [1..4] range, in a mathematical sense. From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 45562@debbugs.gnu.org, stefan@marxist.se Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.16095027396967 (code B ref 45562); Fri, 01 Jan 2021 12:06:02 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 12:05:39 +0000 Received: from localhost ([127.0.0.1]:55659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvJBa-0001oJ-KI for submit@debbugs.gnu.org; Fri, 01 Jan 2021 07:05:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvJBa-0001o8-1B for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 07:05:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50916) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvJBU-0003E3-Ac; Fri, 01 Jan 2021 07:05:32 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2666 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kvJBP-0008QD-3l; Fri, 01 Jan 2021 07:05:30 -0500 Date: Fri, 01 Jan 2021 14:05:09 +0200 Message-Id: <83y2hcg8wa.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h7o0c3sx.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 01 Jan 2021 12:08:46 +0100) References: <83zh1ugj30.fsf@gnu.org> <87h7o0c3sx.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Stefan Kangas , 45562@debbugs.gnu.org > Date: Fri, 01 Jan 2021 12:08:46 +0100 > > >> --- a/src/alloc.c > >> +++ b/src/alloc.c > >> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes) > >> { > >> if (i == 0) > >> free (spare_memory[i]); > >> - else if (i >= 1 && i <= 4) > >> + else if (i <= 4) > >> lisp_align_free (spare_memory[i]); > >> else > >> lisp_free (spare_memory[i]); > > > > This is an optimization better left to the compiler, IMO. > > I think the change made the code slightly clearer, though? You don't > have to think about whether there's anything in the range between 0 and > >= 1. If you like the modified code better, I won't object. From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel =?UTF-8?Q?Mart=C3=ADn?= , Lars Ingebrigtsen Cc: 45562@debbugs.gnu.org, Eli Zaretskii Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.160951744624715 (code B ref 45562); Fri, 01 Jan 2021 16:11:02 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 16:10:46 +0000 Received: from localhost ([127.0.0.1]:34581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvN0o-0006QX-2L for submit@debbugs.gnu.org; Fri, 01 Jan 2021 11:10:46 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:32868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvN0m-0006QB-9c for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 11:10:44 -0500 Received: by mail-pl1-f176.google.com with SMTP id b8so11243231plx.0 for <45562@debbugs.gnu.org>; Fri, 01 Jan 2021 08:10:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=pGeq6hoKrtRI9pZ+OPHWxFtiQAUtdlGgBzS/GFuqz5g=; b=fs20eycwC4daerXbfDkhrI8jgu4nP3SLYvW2D8i0XqVhKOAdT+zTEyRTAqcZYAFgyA 7ft9zMc/bnwHWYpALffrEJxv4eor7CcgwLAbrVG1QkA6xBco3lVoOjzGjydCtw9gR3lp 0Z8h23ElM1KjXCBh4hMep9zl/NO8e8aL8XxujsrKkIM8RjlhV0X5UNoxOLDQCWgDbeiw ZA/ep+FgH10Uj4lcVMM+ZU1k+xb5UIMLNKkpr4GX5k9h47fYB2K6Qcuisc1DWbE0mAe1 xP2h6Q5JzPMoHJ+oZlI5GcgsiCQN6eRtHdCTe9prf1n3NxH39Opv3PA69DCzSkA2Hbfx ZoNw== X-Gm-Message-State: AOAM530XhNAYB0HQe8Oiike3esase/ZbFKvWVtwPjgbWZ/EK/XMN/4Tk 4vMM5c7nssxhVcMzmL4pOmNulwO7LnfBP8a18S8= X-Google-Smtp-Source: ABdhPJwHheK0aQYpzQBj5vB6v70rwAfEganFB3OYb/nONO4DIGcVKtmNijibpM8aulbcf22MMuVtfPeEtKKl9SAF/3Q= X-Received: by 2002:a17:902:d351:b029:db:e003:3b88 with SMTP id l17-20020a170902d351b02900dbe0033b88mr61169942plk.70.1609517438667; Fri, 01 Jan 2021 08:10:38 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 1 Jan 2021 10:10:38 -0600 From: Stefan Kangas In-Reply-To: References: <83zh1ugj30.fsf@gnu.org> <87h7o0c3sx.fsf@gnus.org> MIME-Version: 1.0 Date: Fri, 1 Jan 2021 10:10:38 -0600 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Daniel Mart=C3=ADn writes: > Lars Ingebrigtsen writes: > >> Eli Zaretskii writes: >> >>>> --- a/src/alloc.c >>>> +++ b/src/alloc.c >>>> @@ -4001,7 +4001,7 @@ memory_full (size_t nbytes) >>>> { >>>> if (i =3D=3D 0) >>>> free (spare_memory[i]); >>>> - else if (i >=3D 1 && i <=3D 4) >>>> + else if (i <=3D 4) >>>> lisp_align_free (spare_memory[i]); >>>> else >>>> lisp_free (spare_memory[i]); >>> >>> This is an optimization better left to the compiler, IMO. >> >> I think the change made the code slightly clearer, though? You don't >> have to think about whether there's anything in the range between 0 and >>>=3D 1. > > I think it depends on the programmer. To me, the original code makes > more clear that the branch runs when i is in the [1..4] range, in a > mathematical sense. I liked the new one better myself, but we should probably just leave it alone if we can't agree. The difference is minor, in any case. From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 45562@debbugs.gnu.org Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.160951809325755 (code B ref 45562); Fri, 01 Jan 2021 16:22:01 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 16:21:33 +0000 Received: from localhost ([127.0.0.1]:34601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvNBF-0006hL-BZ for submit@debbugs.gnu.org; Fri, 01 Jan 2021 11:21:33 -0500 Received: from mail-pf1-f181.google.com ([209.85.210.181]:44337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvNBD-0006h6-Bf for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 11:21:32 -0500 Received: by mail-pf1-f181.google.com with SMTP id f9so12620572pfc.11 for <45562@debbugs.gnu.org>; Fri, 01 Jan 2021 08:21:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=HZkxsJ82rtwlEqegZQyTiB6ixIWoXpcacH+wl0HC2zA=; b=uDOq09y59G1Z0s9e+gxiz3Z8EZjDIyGT0xhks4pPhv7e6a2GeIHF9QPCB+sCOe+KmE M4KgNQiMgviNmdB4P0wgeyI5zgpGKeFep4E829DGgDxIk5EFsKa13JBM6C+6A4KZlYOx 6Rhr4o9VXiQNjWxXbKCS5j6SnE9mHSxkGkiabS7SSW3E2v3DYEuPScEmeLA5EX9y+s/q cSSAgcJZEOUD8ubkgCS8JkjbXlkBEh+aSpqn8Wrpy1XS/4pq3pescSaVNC1sYOjYTaB8 lCi20Q/5DSyrcVBL67NOnWKuSa+IuP/S8NQcjCayVrOF9G8lkXs1jLQF30jznoadZ/ly W+Pw== X-Gm-Message-State: AOAM531YNG29U9LIHYICCVUvftfBEX0bDIZFJl6ZWYLzWrpUmBll/00a ubtzOvcW3d+dZ7dryg42HF3WFFMHzrN1yNLx9xiuv/7c4So= X-Google-Smtp-Source: ABdhPJx+6nA4xff51fi96vD/27+n74aBS2A7HxLMYpWtCNYQBBPrxgZ7/V35CJc55QJ73AyOWawhRA2hfpt1RqGpMXI= X-Received: by 2002:a63:e108:: with SMTP id z8mr57546140pgh.363.1609518085519; Fri, 01 Jan 2021 08:21:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 1 Jan 2021 10:21:24 -0600 From: Stefan Kangas In-Reply-To: <83zh1ugj30.fsf@gnu.org> References: <83zh1ugj30.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 1 Jan 2021 10:21:24 -0600 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> The attached patch fixes some warnings found by lgtm.com. > > Thanks. IME, these tools have quite a low signal-to-noise ratio. In > this case: Thanks for the review! Indeed, this is why I asked for some comments. >> --- a/src/buffer.c >> +++ b/src/buffer.c >> @@ -5238,8 +5238,7 @@ init_buffer_once (void) >> PDUMPER_REMEMBER_SCALAR (buffer_local_flags); >> >> /* Need more room? */ >> - if (idx >= MAX_PER_BUFFER_VARS) >> - emacs_abort (); >> + eassert (idx < MAX_PER_BUFFER_VARS); > > This is wrong, because eassert compiles to nothing in the production > build, so it is only good for situations where continuing without > aborting will do something reasonable, or if it will crash anyway in > the very next source line. In this case, there's no way we can > continue, and the programmer evidently wanted us to abort rather than > continue and let us crash later. Right. But we know the value of both idx and MAX_PER_BUFFER_VARS at compile time. So while I understand your argument, it is arguably a judgment call whether or not it is worth making this check also in production builds. IMHO, the eassert has the (minor) benefit of making the intention clearer. That said, AFAICT we call this function only once per lifetime. So I'm happy to leave this out if you prefer. >> --- a/src/fns.c >> +++ b/src/fns.c >> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, >> if (c == '=') >> continue; >> >> - if (v1 < 0) >> - return -1; >> value += v1 - 1; >> >> c = value & 0xff; > > I don't think I see why removing the test and the failure return would > be TRT. What did I miss? Because we have above: do { ... } while (v1 < 0); So unless I am missing something the test is always false and we will never reach the return. From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 45562@debbugs.gnu.org, Eli Zaretskii Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.160951911427337 (code B ref 45562); Fri, 01 Jan 2021 16:39:02 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 16:38:34 +0000 Received: from localhost ([127.0.0.1]:34613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvNRi-00076r-9K for submit@debbugs.gnu.org; Fri, 01 Jan 2021 11:38:34 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:35574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvNRf-00076h-GT for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 11:38:32 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4D6rLY5Ww8z1rwb1; Fri, 1 Jan 2021 17:38:29 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4D6rLY2zx2z1qr51; Fri, 1 Jan 2021 17:38:29 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id d_bdLfTbIS7W; Fri, 1 Jan 2021 17:38:28 +0100 (CET) X-Auth-Info: dGVmT0IrSdjuNQYqrb9mMHNv9Qlx2YmL3INgfqE02fuY2ZjPuQs5PgxV7OhOHERh Received: from igel.home (ppp-46-244-163-100.dynamic.mnet-online.de [46.244.163.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 1 Jan 2021 17:38:28 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 426422C3621; Fri, 1 Jan 2021 17:38:28 +0100 (CET) From: Andreas Schwab References: <83zh1ugj30.fsf@gnu.org> X-Yow: I just heard the SEVENTIES were over!! And I was just getting in touch with my LEISURE SUIT!! Date: Fri, 01 Jan 2021 17:38:28 +0100 In-Reply-To: (Stefan Kangas's message of "Fri, 1 Jan 2021 10:21:24 -0600") Message-ID: <87o8i87gu3.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 01 2021, Stefan Kangas wrote: >>> --- a/src/fns.c >>> +++ b/src/fns.c >>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, >>> if (c == '=') >>> continue; >>> >>> - if (v1 < 0) >>> - return -1; Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jan 2021 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 45562@debbugs.gnu.org Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.16095250814479 (code B ref 45562); Fri, 01 Jan 2021 18:18:02 +0000 Received: (at 45562) by debbugs.gnu.org; 1 Jan 2021 18:18:01 +0000 Received: from localhost ([127.0.0.1]:34793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvOzx-0001AA-BL for submit@debbugs.gnu.org; Fri, 01 Jan 2021 13:18:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvOzv-00019y-VD for 45562@debbugs.gnu.org; Fri, 01 Jan 2021 13:18:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34181) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvOzq-0007eD-Cr; Fri, 01 Jan 2021 13:17:54 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kvOzp-0006xB-1R; Fri, 01 Jan 2021 13:17:54 -0500 Date: Fri, 01 Jan 2021 20:17:35 +0200 Message-Id: <83lfdcfrnk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Fri, 1 Jan 2021 10:21:24 -0600) References: <83zh1ugj30.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Fri, 1 Jan 2021 10:21:24 -0600 > Cc: 45562@debbugs.gnu.org > > >> - if (idx >= MAX_PER_BUFFER_VARS) > >> - emacs_abort (); > >> + eassert (idx < MAX_PER_BUFFER_VARS); > > > > This is wrong, because eassert compiles to nothing in the production > > build, so it is only good for situations where continuing without > > aborting will do something reasonable, or if it will crash anyway in > > the very next source line. In this case, there's no way we can > > continue, and the programmer evidently wanted us to abort rather than > > continue and let us crash later. > > Right. But we know the value of both idx and MAX_PER_BUFFER_VARS at > compile time. So while I understand your argument, it is arguably a > judgment call whether or not it is worth making this check also in > production builds. A user who builds his/her own Emacs could modify the source to add some buffer-local variable and overflow MAX_PER_BUFFER_VARS. If they build with optimizations, we still want to abort, right? > >> --- a/src/fns.c > >> +++ b/src/fns.c > >> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, > >> if (c == '=') > >> continue; > >> > >> - if (v1 < 0) > >> - return -1; > >> value += v1 - 1; > >> > >> c = value & 0xff; > > > > I don't think I see why removing the test and the failure return would > > be TRT. What did I miss? > > Because we have above: > > do { ... } while (v1 < 0); > > So unless I am missing something the test is always false and we will > never reach the return. Or maybe the test is in error, and it should say if (v1 == 0) From unknown Tue Aug 19 05:09:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: 45562@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.162686702222181 (code B ref 45562); Wed, 21 Jul 2021 11:31:02 +0000 Received: (at 45562) by debbugs.gnu.org; 21 Jul 2021 11:30:22 +0000 Received: from localhost ([127.0.0.1]:36268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6AQg-0005lL-6u for submit@debbugs.gnu.org; Wed, 21 Jul 2021 07:30:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6AQe-0005dh-4n for 45562@debbugs.gnu.org; Wed, 21 Jul 2021 07:30:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8O7AyMRDU0MoA6T02Bb7FEHQLeXuV48BRbQ9n7wct7s=; b=M1Q5DU6DTJogvl7tWEJh1mwWd8 lXN81soIElNDDQXrDUec33gYnvYrhMoFbAPLkCFJLtwVmeKY2b3FQMB4yKyorPGmne5Nmd7EvHxX/ ZC7AhHpgJ4vkSQqjOkuALr7nr8kFEXjtEwK1EeEW+B6UNL4BaYxu9JAeNbwUBMhsjTHI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6AQU-0005wy-Sp; Wed, 21 Jul 2021 13:30:13 +0200 From: Lars Ingebrigtsen References: <83zh1ugj30.fsf@gnu.org> <87o8i87gu3.fsf@igel.home> X-Now-Playing: Orchestral Manoeuvres in the Dark's _Souvenir (1): The Singles 1979-1987_: "La Femme Accident" Date: Wed, 21 Jul 2021 13:30:10 +0200 In-Reply-To: <87o8i87gu3.fsf@igel.home> (Andreas Schwab's message of "Fri, 01 Jan 2021 17:38:28 +0100") Message-ID: <87im13lxa5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andreas Schwab writes: >>>> --- a/src/fns.c >>>> +++ b/src/fns.c >>>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, >>>> if (c == '=') >>>> continue; >>>> >>>> - if (v1 < 0) >>>> - ret [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Andreas Schwab writes: >>>> --- a/src/fns.c >>>> +++ b/src/fns.c >>>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, >>>> if (c == '=') >>>> continue; >>>> >>>> - if (v1 < 0) >>>> - return -1; > > Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead. Seems like so to me, too. So I've now made that change on the trunk -- so the lgtm checks found a real bug there. As for the others, skimming this thread there didn't seem to be any consensus that the proposed changes makes the code any better (or clearer), so applying those doesn't seem to be a net win, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 07:30:24 2021 Received: (at control) by debbugs.gnu.org; 21 Jul 2021 11:30:24 +0000 Received: from localhost ([127.0.0.1]:36271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6AQi-0005o1-JD for submit@debbugs.gnu.org; Wed, 21 Jul 2021 07:30:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6AQh-0005hJ-DN for control@debbugs.gnu.org; Wed, 21 Jul 2021 07:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rEDxSPb289LMHGUVjWRWqy248CROmqqbRhO0D9ZaLwU=; b=K55HNm5tTzJ9V48TsStTPd6e+H BV2/gz4PU61bcBgfyBHuheFy4jADF2hc6V1qX8VnTy0ly+YNcZ2cPe9rbQ9PptzZQ8PBycAeg6IUJ NpYl1JZPOZUAi3YkEXE1MGD6AUBkelu/0iNkBngZthDQIsUQxWRZ9jJgeJZj63CApkmA=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6AQZ-0005x4-QB for control@debbugs.gnu.org; Wed, 21 Jul 2021 13:30:17 +0200 Date: Wed, 21 Jul 2021 13:30:15 +0200 Message-Id: <87h7gnlxa0.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45562 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 45562 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 45562 28.1 quit