Subject: Re: bug#45550: [PATCH] Factor out new function for readability in chartab.c

From: Eli Zaretskii <[email-masked]>
Date: Thu, 31 Dec 2020 05:29:08 +0200

> From: Stefan Kangas <[email-masked]>
> Date: Wed, 30 Dec 2020 15:16:05 -0600
> Cc: [email-masked]
> 
> Eli Zaretskii <[email-masked]> writes:
> 
> > Please make this a macro, not a function.  The code you are factoring
> > out is called in the innermost loops of the display engine, in bidi.c,
> > so it must be as fast as possible, even in an unoptimized build, where
> > static functions aren't inlined.
> 
> Would it be acceptable to use our INLINE macro here instead?

I'd prefer a simple macro.  I can never remember the exact semantics
of INLINE this week.

Thanks.