Subject: bug#4554 closed by Chong Yidong <[email-masked]> (Re: bug#4554: local variable for updating the time stamp on save)

From: [email-masked] (Emacs bug Tracking System)
Date: Fri, 25 Sep 2009 22:15:05 +0000

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#4554: local variable for updating the time stamp on save

It has been closed by Chong Yidong <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <[email-masked]> by
replying to this email.

-- 
4554: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4554
Emacs Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#4554: local variable for updating the time stamp on save
From: Chong Yidong <[email-masked]>
To: Stefan Monnier <[email-masked]>
Cc: Juri Linkov <[email-masked]>, [email-masked]
Date: Fri, 25 Sep 2009 18:05:04 -0400

> > The defcustom `safe-local-eval-forms' contains
> >     '((add-hook 'write-file-hooks 'time-stamp))
> > but the documentation suggests using
> >     (add-hook 'before-save-hook 'time-stamp)
> > This patch adds the recommended form to `safe-local-eval-forms' as well:
>
> Feel free to install this patch, thanks,

I went ahead and installed.

Subject: local variable for updating the time stamp on save
From: Juri Linkov <[email-masked]>
To: [email-masked]
Date: Thu, 24 Sep 2009 23:51:23 +0300

The defcustom `safe-local-eval-forms' contains

    '((add-hook 'write-file-hooks 'time-stamp))

but the documentation suggests using

    (add-hook 'before-save-hook 'time-stamp)

This patch adds the recommended form to `safe-local-eval-forms' as well:

Index: lisp/files.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/files.el,v
retrieving revision 1.1083
diff -c -r1.1083 files.el
*** lisp/files.el	21 Sep 2009 22:12:30 -0000	1.1083
--- lisp/files.el	24 Sep 2009 20:47:28 -0000
***************
*** 2687,2693 ****
    :group 'find-file
    :type 'alist)
  
! (defcustom safe-local-eval-forms '((add-hook 'write-file-hooks 'time-stamp))
    "Expressions that are considered safe in an `eval:' local variable.
  Add expressions to this list if you want Emacs to evaluate them, when
  they appear in an `eval' local variable specification, without first
--- 2687,2695 ----
    :group 'find-file
    :type 'alist)
  
! (defcustom safe-local-eval-forms
!   '((add-hook 'before-save-hook 'time-stamp)
!     (add-hook 'write-file-hooks 'time-stamp))
    "Expressions that are considered safe in an `eval:' local variable.
  Add expressions to this list if you want Emacs to evaluate them, when
  they appear in an `eval' local variable specification, without first

-- 
Juri Linkov
http://www.jurta.org/emacs/