From juri@jurta.org Thu Sep 24 14:04:57 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Sep 2009 21:04:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OL4uGg024598 for ; Thu, 24 Sep 2009 14:04:57 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqvUl-0006Hm-Ru for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 17:04:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqvUg-0006Fp-TH for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 17:04:55 -0400 Received: from [199.232.76.173] (port=55825 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqvUg-0006Fh-O8 for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 17:04:50 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4]:41012 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqvUg-0003hg-6g for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 17:04:50 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.70.149.cable.starman.ee [82.131.70.149]) by mx2.starman.ee (Postfix) with ESMTP id 7A1373F40B9 for ; Fri, 25 Sep 2009 00:04:40 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: local variable for updating the time stamp on save Organization: JURTA Date: Thu, 24 Sep 2009 23:51:23 +0300 Message-ID: <87hbut1vpi.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) The defcustom `safe-local-eval-forms' contains '((add-hook 'write-file-hooks 'time-stamp)) but the documentation suggests using (add-hook 'before-save-hook 'time-stamp) This patch adds the recommended form to `safe-local-eval-forms' as well: Index: lisp/files.el =================================================================== RCS file: /sources/emacs/emacs/lisp/files.el,v retrieving revision 1.1083 diff -c -r1.1083 files.el *** lisp/files.el 21 Sep 2009 22:12:30 -0000 1.1083 --- lisp/files.el 24 Sep 2009 20:47:28 -0000 *************** *** 2687,2693 **** :group 'find-file :type 'alist) ! (defcustom safe-local-eval-forms '((add-hook 'write-file-hooks 'time-stamp)) "Expressions that are considered safe in an `eval:' local variable. Add expressions to this list if you want Emacs to evaluate them, when they appear in an `eval' local variable specification, without first --- 2687,2695 ---- :group 'find-file :type 'alist) ! (defcustom safe-local-eval-forms ! '((add-hook 'before-save-hook 'time-stamp) ! (add-hook 'write-file-hooks 'time-stamp)) "Expressions that are considered safe in an `eval:' local variable. Add expressions to this list if you want Emacs to evaluate them, when they appear in an `eval' local variable specification, without first -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Thu Sep 24 17:44:57 2009 Received: (at 4554) by emacsbugs.donarmstrong.com; 25 Sep 2009 00:44:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.183]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8P0itjh026766 for <4554@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 17:44:57 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvQEAGqvu0pFpZBo/2dsb2JhbACBUtUQhBwFgkuFMw X-IronPort-AV: E=Sophos;i="4.44,448,1249272000"; d="scan'208";a="46562214" Received: from 69-165-144-104.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.104]) by ironport2-out.pppoe.ca with ESMTP; 24 Sep 2009 20:44:50 -0400 Received: by pastel.home (Postfix, from userid 20848) id DAE6980B1; Thu, 24 Sep 2009 20:44:49 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4554@debbugs.gnu.org Subject: Re: bug#4554: local variable for updating the time stamp on save Message-ID: References: <87hbut1vpi.fsf@mail.jurta.org> Date: Thu, 24 Sep 2009 20:44:49 -0400 In-Reply-To: <87hbut1vpi.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 24 Sep 2009 23:51:23 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > The defcustom `safe-local-eval-forms' contains > '((add-hook 'write-file-hooks 'time-stamp)) > but the documentation suggests using > (add-hook 'before-save-hook 'time-stamp) > This patch adds the recommended form to `safe-local-eval-forms' as well: Feel free to install this patch, thanks, Stefan From cyd@stupidchicken.com Fri Sep 25 15:05:11 2009 Received: (at 4554-done) by emacsbugs.donarmstrong.com; 25 Sep 2009 22:05:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po37.its.yale.edu (pantheon-po37.its.yale.edu [130.132.50.95]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PM5Apb023297 for <4554-done@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 15:05:11 -0700 Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po37.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n8PM548I030053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 25 Sep 2009 18:05:04 -0400 Received: by furry (Postfix, from userid 1000) id 97191C070; Fri, 25 Sep 2009 18:05:04 -0400 (EDT) From: Chong Yidong To: Stefan Monnier Cc: Juri Linkov , 4554-done@debbugs.gnu.org Subject: Re: bug#4554: local variable for updating the time stamp on save Date: Fri, 25 Sep 2009 18:05:04 -0400 Message-ID: <87eipuistr.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) > > The defcustom `safe-local-eval-forms' contains > > '((add-hook 'write-file-hooks 'time-stamp)) > > but the documentation suggests using > > (add-hook 'before-save-hook 'time-stamp) > > This patch adds the recommended form to `safe-local-eval-forms' as well: > > Feel free to install this patch, thanks, I went ahead and installed. From juri@jurta.org Tue Sep 29 16:28:33 2009 Received: (at 4554-done) by emacsbugs.donarmstrong.com; 29 Sep 2009 23:28:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8TNSSGj020145 for <4554-done@emacsbugs.donarmstrong.com>; Tue, 29 Sep 2009 16:28:32 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (62.65.211.102.cable.starman.ee [62.65.211.102]) by mx2.starman.ee (Postfix) with ESMTP id A685B3F40F4; Wed, 30 Sep 2009 02:28:21 +0300 (EEST) From: Juri Linkov To: Chong Yidong Cc: 4554-done@debbugs.gnu.org Subject: Re: bug#4554: local variable for updating the time stamp on save Organization: JURTA References: <87eipuistr.fsf@stupidchicken.com> Date: Wed, 30 Sep 2009 02:20:16 +0300 In-Reply-To: <87eipuistr.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 25 Sep 2009 18:05:04 -0400") Message-ID: <877hvhpc67.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> > The defcustom `safe-local-eval-forms' contains >> > '((add-hook 'write-file-hooks 'time-stamp)) >> > but the documentation suggests using >> > (add-hook 'before-save-hook 'time-stamp) >> > This patch adds the recommended form to `safe-local-eval-forms' as well: >> >> Feel free to install this patch, thanks, > > I went ahead and installed. Thanks, but I see something strange in CVS now, `safe-local-eval-forms' contains by default: 1. `write-file-functions'. Yes, I know that it replaces the obsolete `write-file-hooks'. But users might have already `write-file-hooks' in local variables of their files, so I think we should check for both. 2. `before-save-hooks'. Is this a typo? I think it should be `before-save-hook'. So I propose the following default: '((add-hook 'write-file-functions 'time-stamp) (add-hook 'write-file-hooks 'time-stamp) (add-hook 'before-save-hook 'time-stamp)) -- Juri Linkov http://www.jurta.org/emacs/ From cyd@stupidchicken.com Tue Sep 29 16:57:21 2009 Received: (at 4554-done) by emacsbugs.donarmstrong.com; 29 Sep 2009 23:57:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8TNvJY8024216 for <4554-done@emacsbugs.donarmstrong.com>; Tue, 29 Sep 2009 16:57:21 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 9137857E2C7; Tue, 29 Sep 2009 19:59:01 -0400 (EDT) From: Chong Yidong To: Juri Linkov Cc: 4554-done@debbugs.gnu.org Subject: Re: bug#4554: local variable for updating the time stamp on save References: <87eipuistr.fsf@stupidchicken.com> <877hvhpc67.fsf@mail.jurta.org> Date: Tue, 29 Sep 2009 19:59:01 -0400 In-Reply-To: <877hvhpc67.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 30 Sep 2009 02:20:16 +0300") Message-ID: <87pr99e20q.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Juri Linkov writes: > 1. `write-file-functions'. Yes, I know that it replaces the obsolete > `write-file-hooks'. But users might have already `write-file-hooks' > in local variables of their files, so I think we should check for both. This will be an incentive for users to switch to write-file-functions. > 2. `before-save-hooks'. Is this a typo? I think it should be > `before-save-hook'. Whoops, yes this was a typo. Fixed. From unknown Sun Aug 17 04:15:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 28 Oct 2009 14:24:11 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator