GNU bug report logs - #45502
[PATCH] Prettier key bindings in NS menu entries

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattiase <at> acm.org>

Date: Mon, 28 Dec 2020 14:24:02 UTC

Severity: normal

Tags: patch

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45502: closed ([PATCH] Prettier key bindings in NS menu entries)
Date: Wed, 30 Dec 2020 15:54:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 30 Dec 2020 16:53:04 +0100
with message-id <0C5CEE19-1D6C-4AAD-868E-D249579BCF29 <at> acm.org>
and subject line Re: bug#45502: [PATCH] Prettier key bindings in NS menu entries
has caused the debbugs.gnu.org bug report #45502,
regarding [PATCH] Prettier key bindings in NS menu entries
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45502: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45502
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mattias Engdegård <mattiase <at> acm.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Prettier key bindings in NS menu entries
Date: Mon, 28 Dec 2020 15:23:25 +0100
[Message part 3 (text/plain, inline)]
The NS port shows key bindings in a rather cluttered way, with the key in brackets directly after the menu entry. The Mac port of Emacs is much neater with the bindings all aligned at a common tab position. We could do the same, but having done some experiments I actually prefer a right-alignment of the keys. Proof-of-concept patch attached.

The alignment is made by padding with spaces, and then with hair spaces for extra precision; the result is not perfect but probably better than what we have now. If I get some time, I might do an experiment with more precise formatting.

[right-justify-keys.diff (application/octet-stream, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Mattias Engdegård <mattiase <at> acm.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 45502-done <at> debbugs.gnu.org,
 Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#45502: [PATCH] Prettier key bindings in NS menu entries
Date: Wed, 30 Dec 2020 16:53:04 +0100
30 dec. 2020 kl. 14.09 skrev Alan Third <alan <at> idiocy.org>:

> Ah, got it!

Good catch! I think we've squeezed this bug dry by now; closing.



This bug report was last modified 4 years and 202 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.