From unknown Sat Aug 16 11:41:31 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook Reply-To: David Engster , 4548@debbugs.gnu.org Resent-From: David Engster Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 24 Sep 2009 13:40:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4548 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125379932420127 (code B ref -1); Thu, 24 Sep 2009 13:40:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Sep 2009 13:35:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8ODZL0E020124 for ; Thu, 24 Sep 2009 06:35:23 -0700 Received: from mx10.gnu.org ([199.232.76.166]:44823) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MqoTh-0001tj-4T for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:21 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MqoTf-0004Bq-C5 for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:20 -0400 Received: from m61s02.vlinux.de ([83.151.21.164]:38453) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqoTf-0004BK-2A for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:19 -0400 Received: from kafka.physik3.gwdg.de ([134.76.92.48] helo=kafka) by m61s02.vlinux.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1MqoTb-0001cW-K6 for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 15:35:15 +0200 From: David Engster To: emacs-pretest-bug@gnu.org Date: Thu, 24 Sep 2009 15:35:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) --=-=-= In hideshow.el, there is a hook 'hs-show-hook' which should be run whenever some text is shown again (i.e., unfolded). However, the command hs-show-block does not run this hook; a (trivial) patch which will fix this is attached. Regards, David --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=hideshow-patch.diff Index: hideshow.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v retrieving revision 1.80 diff -u -r1.80 hideshow.el --- hideshow.el 14 Aug 2009 23:02:41 -0000 1.80 +++ hideshow.el 24 Sep 2009 13:28:55 -0000 @@ -869,8 +869,8 @@ q (progn (hs-forward-sexp (match-data t) 1) (point))))) (when (and p q) (hs-discard-overlays p q) - (goto-char (if end q (1+ p))))) - (run-hooks 'hs-show-hook)))) + (goto-char (if end q (1+ p)))))) + (run-hooks 'hs-show-hook))) (defun hs-hide-level (arg) "Hide all blocks ARG levels below this block. --=-=-=-- From unknown Sat Aug 16 11:41:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: David Engster Subject: bug#4548 closed by Juanma Barranquero (Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook) Message-ID: References: X-Emacs-PR-Message: they-closed 4548 X-Emacs-PR-Package: emacs Reply-To: 4548@debbugs.gnu.org Date: Fri, 25 Sep 2009 00:40:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1253839206-26072-1" This is a multi-part message in MIME format... ------------=_1253839206-26072-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook It has been closed by Juanma Barranquero . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juanma Barranquero by replying to this email. --=20 4548: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4548 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1253839206-26072-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4548-done) by emacsbugs.donarmstrong.com; 25 Sep 2009 00:33:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8P0Xak8025170 for <4548-done@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 17:33:37 -0700 Received: by fxm3 with SMTP id 3so1860575fxm.44 for <4548-done@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 17:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=PStBvzLp9vkMSPOrjRsXUOl8fmS2Q3Lr8u7Ru4Lbphw=; b=Rc0dZqB1Bf7osqowwf1JWNyN3GuITg6834c2h62xLfnJoQWas6X/ln+sQt3s84x2iK RHpCpCd4vcNme3YRSg1CZcwuRWOYUtDfB+RHtJSqA683Bu4DYXf+W5h/JfboH/RONlKh t8WsZUYn3myaVf6oLpukXH18HhrA3cYF+5qks= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=gmC/HnBYjJuJsrkpLJylzS5Dlao9KhWAyct91nS3uRrjMe20nDJvyEX0T95mCDSq3P f4RRRWz6X3P5+4EAUX3q/D0/DTpevy2oTGvA3dUJy3SevmhHIJBe0SNBPoeWliKI9AGx usMTq659fWrjEZ8ID6tUkTRFIUUSsK60ocp7c= MIME-Version: 1.0 Received: by 10.239.139.104 with SMTP id s40mr354913hbs.76.1253838810137; Thu, 24 Sep 2009 17:33:30 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Fri, 25 Sep 2009 02:33:10 +0200 Message-ID: Subject: Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook To: David Engster Cc: 4548-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Thu, Sep 24, 2009 at 15:35, David Engster wrote: > However, the command hs-show-block does not run this hook; a (trivial) > patch which will fix this is attached. Committed, thanks. Juanma ------------=_1253839206-26072-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 24 Sep 2009 13:35:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8ODZL0E020124 for ; Thu, 24 Sep 2009 06:35:23 -0700 Received: from mx10.gnu.org ([199.232.76.166]:44823) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MqoTh-0001tj-4T for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:21 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MqoTf-0004Bq-C5 for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:20 -0400 Received: from m61s02.vlinux.de ([83.151.21.164]:38453) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqoTf-0004BK-2A for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:19 -0400 Received: from kafka.physik3.gwdg.de ([134.76.92.48] helo=kafka) by m61s02.vlinux.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1MqoTb-0001cW-K6 for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 15:35:15 +0200 From: David Engster To: emacs-pretest-bug@gnu.org Subject: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook Date: Thu, 24 Sep 2009 15:35:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) --=-=-= In hideshow.el, there is a hook 'hs-show-hook' which should be run whenever some text is shown again (i.e., unfolded). However, the command hs-show-block does not run this hook; a (trivial) patch which will fix this is attached. Regards, David --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=hideshow-patch.diff Index: hideshow.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v retrieving revision 1.80 diff -u -r1.80 hideshow.el --- hideshow.el 14 Aug 2009 23:02:41 -0000 1.80 +++ hideshow.el 24 Sep 2009 13:28:55 -0000 @@ -869,8 +869,8 @@ q (progn (hs-forward-sexp (match-data t) 1) (point))))) (when (and p q) (hs-discard-overlays p q) - (goto-char (if end q (1+ p))))) - (run-hooks 'hs-show-hook)))) + (goto-char (if end q (1+ p)))))) + (run-hooks 'hs-show-hook))) (defun hs-hide-level (arg) "Hide all blocks ARG levels below this block. --=-=-=-- ------------=_1253839206-26072-1--