GNU bug report logs - #45478
[PATCH] gnu: u-boot: Fix freeze on boot with u-boot-rockpro64-rk3399

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45478: closed ([PATCH] gnu: u-boot: Fix freeze on boot with
 u-boot-rockpro64-rk3399)
Date: Mon, 28 Dec 2020 18:41:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 28 Dec 2020 19:40:47 +0100
with message-id <20201228194047.4b752e0d <at> scratchpost.org>
and subject line Re: [bug#45478] [PATCH] gnu: u-boot: Fix freeze on boot with u-boot-rockpro64-rk3399
has caused the debbugs.gnu.org bug report #45478,
regarding [PATCH] gnu: u-boot: Fix freeze on boot with u-boot-rockpro64-rk3399
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45478: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45478
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Caliph Nomble <calnomble <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Caliph Nomble <calnomble <at> protonmail.com>
Subject: [PATCH] gnu: u-boot: Fix freeze on boot with u-boot-rockpro64-rk3399
Date: Mon, 28 Dec 2020 06:00:28 +0000

* gnu/packages/bootloaders.scm (u-boot-rockpro64-rk3399): Build with modified
config to prevent freeze on boot due to usb being enabled.
---
 gnu/packages/bootloaders.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 7034085d67..078bc3156e 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -868,7 +868,14 @@ to Novena upstream, does not load u-boot.img from the first partition.")
         (substitute-keyword-arguments (package-arguments base)
           ((#:phases phases)
            `(modify-phases ,phases
-              (add-after 'unpack 'set-environment
+              (add-after 'unpack 'patch-rockpro64-config
+                ;; Fix regression in 2020.10 causing freezes on boot with USB boot enabled.
+                ;; See https://gitlab.manjaro.org/manjaro-arm/packages/core/uboot-rockpro64/-/issues/4
+                (lambda _
+                  (substitute* "configs/rockpro64-rk3399_defconfig"
+                    (("CONFIG_USE_PREBOOT=y") "CONFIG_USE_PREBOOT=n"))
+                  #t))
+              (add-after 'patch-rockpro64-config 'set-environment
                 (lambda* (#:key inputs #:allow-other-keys)
                   (setenv "BL31" (string-append (assoc-ref inputs "firmware")
                                                 "/bl31.elf"))
-- 
2.26.2

[Message part 3 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Caliph Nomble via Guix-patches via <guix-patches <at> gnu.org>
Cc: Caliph Nomble <calnomble <at> protonmail.com>, 45478-done <at> debbugs.gnu.org
Subject: Re: [bug#45478] [PATCH] gnu: u-boot: Fix freeze on boot with
 u-boot-rockpro64-rk3399
Date: Mon, 28 Dec 2020 19:40:47 +0100

[Message part 4 (text/plain, inline)]

Hi,

thanks for the patch!

Pushed to guix master as commit d980e6e275aed80e65ad3b7e17c5a5118661e2c2.

[Message part 5 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.