GNU bug report logs -
#45412
File ... is large (... MiB), really open? (y)es or (n)o or (l)iterally
Previous Next
Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Date: Thu, 24 Dec 2020 23:27:01 UTC
Severity: wishlist
Tags: fixed
Merged with 45647,
47556
Fixed in version 28.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Daniel Martín <mardani29 <at> yahoo.es> writes:
>
>> I've given `read-multiple-choice' a try and the help text doesn't look
>> very good if any of the descriptions is a bit long. Another problem I
>> saw is that if the help text contains a reference to a variable, the
>> rendered hyperlink doesn't work.
>>
>> It's a pity because I think this function is a good way to simplify and
>> homogenize this use case in Emacs.
>
> Well, neither problem seem insurmountable to fix.
OK, I've refactored the feature on top of a patched version of
`read-multiple-choice' that adds support for overriding the help text.
I've also handled the `edit' action, so that a user can enter a
recursive edit to select the help link. This API change is
backwards-compatible. As one change depends on the previous one, but
they are otherwise orthogonal, I've made two separate commits.
These new patches address the following review comments:
- Simplify the call site by avoiding the character loop.
- The help description now appears on `help-char', ?, or F1.
- Improves and fixes the help text and NEWS description, per Eli's
suggestions.
The idea to show the help text also for graphical prompts is a good
idea, but as there's no command already in Emacs that supports it,
AFAIK, it could be a separate feature request. What do you think?
Thanks.
[0001-Extend-read-multiple-choice-to-support-free-form-hel.patch (text/x-patch, attachment)]
[0002-Add-a-help-option-to-the-open-large-files-prompt.patch (text/x-patch, attachment)]
This bug report was last modified 4 years and 49 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.